From 28e1822ad1606804c3e43af3833367ef76771dfe Mon Sep 17 00:00:00 2001
From: Rick Lan <ricklan@gmail.com>
Date: Mon, 31 Mar 2025 10:05:07 +0800
Subject: [PATCH] Core - allow disable logging

---
 common/params_keys.h                |  2 +-
 selfdrive/ui/qt/offroad/settings.cc | 10 ++++++++--
 system/manager/manager.py           |  1 +
 system/manager/process_config.py    |  2 +-
 4 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/common/params_keys.h b/common/params_keys.h
index 2b540b744..c83c173d5 100644
--- a/common/params_keys.h
+++ b/common/params_keys.h
@@ -26,7 +26,7 @@ inline static std::unordered_map<std::string, uint32_t> keys = {
     {"ControlsReady", CLEAR_ON_MANAGER_START | CLEAR_ON_ONROAD_TRANSITION},
     {"CurrentBootlog", PERSISTENT},
     {"CurrentRoute", CLEAR_ON_MANAGER_START | CLEAR_ON_ONROAD_TRANSITION},
-    {"DisableLogging", CLEAR_ON_MANAGER_START | CLEAR_ON_ONROAD_TRANSITION},
+    {"DisableLogging", PERSISTENT},
     {"DisablePowerDown", PERSISTENT},
     {"DisableUpdates", PERSISTENT},
     {"DisengageOnAccelerator", PERSISTENT},
diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc
index 4d0516bda..67b314a56 100644
--- a/selfdrive/ui/qt/offroad/settings.cc
+++ b/selfdrive/ui/qt/offroad/settings.cc
@@ -61,6 +61,12 @@ TogglesPanel::TogglesPanel(SettingsWindow *parent) : ListWidget(parent) {
       tr("Display speed in km/h instead of mph."),
       "../assets/offroad/icon_metric.png",
     },
+    {
+      "DisableLogging",
+      tr("Disable Logging"),
+      "",
+      "../assets/offroad/icon_empty.svg",
+    },
   };
 
 
@@ -326,7 +332,7 @@ void SettingsWindow::setCurrentPanel(int index, const QString &param) {
     if (param.endsWith("Panel")) {
       QString panelName = param;
       panelName.chop(5); // Remove "Panel" suffix
-      
+
       // Find the panel by name
       for (int i = 0; i < nav_btns->buttons().size(); i++) {
         if (nav_btns->buttons()[i]->text() == tr(panelName.toStdString().c_str())) {
@@ -338,7 +344,7 @@ void SettingsWindow::setCurrentPanel(int index, const QString &param) {
       emit expandToggleDescription(param);
     }
   }
-  
+
   panel_widget->setCurrentIndex(index);
   nav_btns->buttons()[index]->setChecked(true);
 }
diff --git a/system/manager/manager.py b/system/manager/manager.py
index 89e5a472f..3513ba79b 100755
--- a/system/manager/manager.py
+++ b/system/manager/manager.py
@@ -40,6 +40,7 @@ def manager_init() -> None:
     ("LanguageSetting", "main_en"),
     ("OpenpilotEnabledToggle", "1"),
     ("LongitudinalPersonality", str(log.LongitudinalPersonality.standard)),
+    ("DisableLogging", "0"),
   ]
 
   if params.get_bool("RecordFrontLock"):
diff --git a/system/manager/process_config.py b/system/manager/process_config.py
index 6e048c339..e462aee76 100644
--- a/system/manager/process_config.py
+++ b/system/manager/process_config.py
@@ -18,7 +18,7 @@ def iscar(started: bool, params: Params, CP: car.CarParams) -> bool:
   return started and not CP.notCar
 
 def logging(started: bool, params: Params, CP: car.CarParams) -> bool:
-  run = (not CP.notCar) or not params.get_bool("DisableLogging")
+  run = not params.get_bool("DisableLogging")
   return started and run
 
 def ublox_available() -> bool: