Shane Smiskol
c258e9d64a
* first draft copy, needs updates * gate behind exp mode * can be one line * this is no longer true * toggle isn't just e2e long now, rename * don't enable/disable * kinda works! * remove old giant qstring * comment clean up * similar breakpoint * more clean up * fixup onroad * preserve planner behavior, and we don't need to look at confirmed param if we're onroad * update translations * vanish translations * use scene for op long * lowercase! * updated copy * need to check longitudinal here now too * clean up! * here is better * used * no nav emoji * don't check param if not valid * revert this revert this * ed * revert experimental mode longitudinal checks (still need to revert toggle change) * revert * logic works * revert test * fix * update translation * fix (reset and update) old-commit-hash: 6bc28fc7698415e41610ddd04bb3ce473870591e
Multilanguage
Contributing
Before getting started, make sure you have set up the openpilot Ubuntu development environment by reading the tools README.md.
Policy
Most of the languages supported by openpilot come from and are maintained by the community via pull requests. A pull request likely to be merged is one that fixes a translation or adds missing translations.
We also generally merge pull requests adding support for a new language if there are community members willing to maintain it. Maintaining a language is ensuring quality and completion of translations before each openpilot release.
comma may remove or hide language support from releases depending on translation quality and completeness.
Adding a New Language
openpilot provides a few tools to help contributors manage their translations and to ensure quality. To get started:
- Add your new language to languages.json with the appropriate language code and the localized language name (Traditional Chinese is
中文（繁體）). - Generate the XML translation file (
*.ts):selfdrive/ui/update_translations.py - Edit the translation file, marking each translation as completed:
linguist selfdrive/ui/translations/your_language_file.ts - View your finished translations by compiling and starting the UI, then find it in the language selector:
scons -j$(nproc) selfdrive/ui && selfdrive/ui/ui - Read Checking the UI to double-check your translations fit in the UI.
Improving an Existing Language
Follow step 3. above, you can review existing translations and add missing ones. Once you're done, just open a pull request to openpilot.
Checking the UI
Different languages use varying space to convey the same message, so it's a good idea to double-check that your translations do not overlap and fit into each widget. Start the UI (step 4. above) and view each page, making adjustments to translations as needed.
To view offroad alerts:
With the UI started, you can view the offroad alerts with:
selfdrive/ui/tests/cycle_offroad_alerts.py
Updating the UI
Any time you edit source code in the UI, you need to update the translations to ensure the line numbers and contexts are up to date (first step above).
Testing
openpilot has a few unit tests to make sure all translations are up-to-date and that all strings are wrapped in a translation marker. They are run in CI, but you can also run them locally.
Tests translation files up to date:
selfdrive/ui/tests/test_translations.py
Tests all static source strings are wrapped:
selfdrive/ui/tests/create_test_translations.sh && selfdrive/ui/tests/test_translations
