from cereal import car import numpy as np from openpilot.common.realtime import DT_CTRL from openpilot.selfdrive.controls.lib.drive_helpers import CONTROL_N from openpilot.common.pid import PIDController from openpilot.selfdrive.modeld.constants import ModelConstants from openpilot.common.filter_simple import FirstOrderFilter from opendbc.car.gm.values import CAR, CarControllerParams, GMFlags from openpilot.starpilot.common.testing_grounds import testing_ground CONTROL_N_T_IDX = ModelConstants.T_IDXS[:CONTROL_N] clip = np.clip interp = np.interp STOPPING_RELEASE_HYSTERESIS = 0.35 STOPPING_RELEASE_MIN_ACCEL = 0.15 MOVING_STOP_FOLLOW_MIN_GAP = 0.25 NEGATIVE_TARGET_CREEP_GUARD_SPEED = 0.35 NEGATIVE_TARGET_CREEP_GUARD_DECEL = 0.40 LongCtrlState = car.CarControl.Actuators.LongControlState def apply_deadzone(error, deadzone): if error > deadzone: error -= deadzone elif error < -deadzone: error += deadzone else: error = 0.0 return error def long_control_state_trans(CP, active, long_control_state, v_ego, should_stop, brake_pressed, cruise_standstill, starpilot_toggles, allow_stopping_release=True): # Ignore cruise standstill if car has a gas interceptor cruise_standstill = cruise_standstill and not CP.enableGasInterceptorDEPRECATED stopping_condition = should_stop release_condition = not should_stop and not brake_pressed starting_condition = release_condition and not cruise_standstill # Some stock ACC platforms keep standstill latched until they see positive drive torque. # Once the planner has sustained a release request, allow LongControl to leave stopping # even if the standstill bit has not dropped yet. stopping_release_condition = release_condition and allow_stopping_release started_condition = v_ego > starpilot_toggles.vEgoStarting if not active: long_control_state = LongCtrlState.off else: if long_control_state == LongCtrlState.off: if not starting_condition: long_control_state = LongCtrlState.stopping else: if starting_condition and CP.startingState: long_control_state = LongCtrlState.starting else: long_control_state = LongCtrlState.pid elif long_control_state == LongCtrlState.stopping: if stopping_release_condition and CP.startingState: long_control_state = LongCtrlState.starting elif stopping_release_condition: long_control_state = LongCtrlState.pid elif long_control_state in [LongCtrlState.starting, LongCtrlState.pid]: if stopping_condition: long_control_state = LongCtrlState.stopping elif started_condition: long_control_state = LongCtrlState.pid return long_control_state def long_control_state_trans_old_long(CP, active, long_control_state, v_ego, v_target, v_target_1sec, brake_pressed, cruise_standstill, starpilot_toggles): accelerating = v_target_1sec > v_target planned_stop = (v_target < starpilot_toggles.vEgoStopping and v_target_1sec < starpilot_toggles.vEgoStopping and not accelerating) stay_stopped = (v_ego < starpilot_toggles.vEgoStopping and (brake_pressed or cruise_standstill)) stopping_condition = planned_stop or stay_stopped starting_condition = (v_target_1sec > starpilot_toggles.vEgoStarting and accelerating and not cruise_standstill and not brake_pressed) started_condition = v_ego > starpilot_toggles.vEgoStarting if not active: long_control_state = LongCtrlState.off else: if long_control_state in (LongCtrlState.off, LongCtrlState.pid): long_control_state = LongCtrlState.pid if stopping_condition: long_control_state = LongCtrlState.stopping elif long_control_state == LongCtrlState.stopping: if starting_condition and CP.startingState: long_control_state = LongCtrlState.starting elif starting_condition: long_control_state = LongCtrlState.pid elif long_control_state == LongCtrlState.starting: if stopping_condition: long_control_state = LongCtrlState.stopping elif started_condition: long_control_state = LongCtrlState.pid return long_control_state class LongControl: def __init__(self, CP): self.CP = CP self.long_control_state = LongCtrlState.off self.experimental_mode = False self.pid = PIDController((CP.longitudinalTuning.kpBP, CP.longitudinalTuning.kpV), (CP.longitudinalTuning.kiBP, CP.longitudinalTuning.kiV), rate=1 / DT_CTRL) # Preserve legacy behaviour when no feedforward gain is provided (default of 0.0) kf = getattr(CP.longitudinalTuning, 'kfDEPRECATED', 0.0) self.feedforward_gain = kf if kf != 0.0 else 1.0 self.v_pid = 0.0 self._mode_setup() self.last_output_accel = 0.0 self.last_a_target = 0.0 self.integrator_hold_frames = 0 self.stop_release_counter = 0 self.is_gm_pedal_long = bool( CP.brand == "gm" and CP.enableGasInterceptorDEPRECATED and (CP.flags & GMFlags.PEDAL_LONG.value) ) self.is_volt = bool( CP.brand == "gm" and str(CP.carFingerprint).startswith("CHEVROLET_VOLT") ) self.is_gm_stock_truck = bool( CP.brand == "gm" and getattr(CP, "carFingerprint", None) in (CAR.CHEVROLET_SILVERADO, CAR.CHEVROLET_SILVERADO_CC) and not CP.enableGasInterceptorDEPRECATED ) def update_mpc_mode(self, experimental_mode): new_mode = 'blended' if experimental_mode else 'acc' if self.transitioning and self.prev_mode == 'blended' and self.current_mode == 'acc': self.mode_transition_timer = 0.0 if new_mode != self.current_mode: self.prev_mode = self.current_mode self.transitioning = True self.mode_transition_timer = 0.0 self.mode_transition_filter.x = self.last_output_accel self.current_mode = new_mode if self.transitioning: self.mode_transition_timer += DT_CTRL if self.mode_transition_timer >= self.mode_transition_duration: self.transitioning = False def _mode_setup(self): self.prev_mode = 'acc' self.current_mode = 'acc' self.mode_transition_filter = FirstOrderFilter(0.0, 0.5, DT_CTRL) self.mode_transition_timer = 0.0 self.mode_transition_duration = 1.0 self.transitioning = False def reset(self, preserve_stop_release=False): self.pid.reset() self.last_a_target = 0.0 self.integrator_hold_frames = 0 if not preserve_stop_release: self.stop_release_counter = 0 def _stop_release_ready(self, CS, a_target, should_stop, starpilot_toggles): if self.long_control_state != LongCtrlState.stopping: self.stop_release_counter = 0 return True if should_stop or CS.brakePressed: self.stop_release_counter = 0 return False if CS.vEgo > starpilot_toggles.vEgoStarting: self.stop_release_counter = int(round(STOPPING_RELEASE_HYSTERESIS / DT_CTRL)) return True if a_target > STOPPING_RELEASE_MIN_ACCEL: max_frames = int(round(STOPPING_RELEASE_HYSTERESIS / DT_CTRL)) self.stop_release_counter = min(self.stop_release_counter + 1, max_frames) else: self.stop_release_counter = 0 return self.stop_release_counter >= int(round(STOPPING_RELEASE_HYSTERESIS / DT_CTRL)) @staticmethod def _apply_moving_stop_target_follow(output_accel, a_target, should_stop, CS, starpilot_toggles): follow_min_speed = max(1.5, starpilot_toggles.vEgoStopping + 1.0) if not should_stop or CS.brakePressed or CS.vEgo <= follow_min_speed: return output_accel if a_target >= output_accel - MOVING_STOP_FOLLOW_MIN_GAP: return output_accel follow_step = interp(CS.vEgo, [follow_min_speed, 3.0, 6.0, 10.0], [0.02, 0.03, 0.05, 0.07]) return max(float(a_target), output_accel - float(follow_step)) def _get_pedal_long_freeze(self, a_target, error, v_ego, accel_limits): volt_test_tune_handoff = self.is_volt and testing_ground.use_2 if not self.is_gm_pedal_long and not volt_test_tune_handoff: self.last_a_target = a_target self.integrator_hold_frames = 0 return False if self.is_gm_pedal_long: handoff_threshold = interp(v_ego, [0.0, 4.0, 12.0, 25.0], [0.35, 0.45, 0.55, 0.70]) hold_frames = int(round(interp(v_ego, [0.0, 4.0, 12.0, 25.0], [25.0, 20.0, 14.0, 10.0]))) else: handoff_threshold = interp(v_ego, [0.0, 4.0, 12.0, 25.0], [0.24, 0.30, 0.38, 0.48]) hold_frames = int(round(interp(v_ego, [0.0, 4.0, 12.0, 25.0], [12.0, 10.0, 8.0, 6.0]))) if abs(a_target - self.last_a_target) > handoff_threshold: self.integrator_hold_frames = max(self.integrator_hold_frames, hold_frames) self.last_a_target = a_target if self.integrator_hold_frames > 0: self.integrator_hold_frames -= 1 sat_buffer = 0.03 at_neg_sat = self.last_output_accel <= (accel_limits[0] + sat_buffer) at_pos_sat = self.last_output_accel >= (accel_limits[1] - sat_buffer) sat_pushing_lower = at_neg_sat and error < -0.05 sat_pushing_upper = at_pos_sat and error > 0.05 return self.integrator_hold_frames > 0 or sat_pushing_lower or sat_pushing_upper def _shape_volt_test_tune_integrator(self, error, v_ego): if not (self.is_volt and testing_ground.use_2): return # Bleed stale I quickly when the target reverses against stored integrator. if self.pid.i * error < 0.0 and abs(error) > 0.05: bleed = interp(v_ego, [0.0, 4.0, 12.0, 25.0], [0.82, 0.86, 0.90, 0.94]) self.pid.i *= bleed def _trim_positive_overshoot_integrator(self, a_target, error, CS): if self.pid.i <= 0.0: return if a_target >= -0.05 or error >= -0.25: return if CS.vEgo <= NEGATIVE_TARGET_CREEP_GUARD_SPEED and a_target > -NEGATIVE_TARGET_CREEP_GUARD_DECEL: return # If the planner has already crossed into decel but the car is still # accelerating, bleed stale positive I aggressively so the command can # cross back through zero instead of carrying throttle for several seconds. bleed = interp(abs(error), [0.25, 0.75, 1.5], [0.55, 0.25, 0.0]) self.pid.i *= bleed def _trim_gm_truck_positive_hold_integrator(self, a_target, error, CS): if not self.is_gm_stock_truck or self.pid.i <= 0.0: return if self.last_output_accel <= 0.10: return if a_target > 0.03: return if CS.vEgo <= NEGATIVE_TARGET_CREEP_GUARD_SPEED and a_target > -NEGATIVE_TARGET_CREEP_GUARD_DECEL: return # Stock-ACC trucks are especially sensitive to hanging onto light positive # torque after the planner has already crossed back to coast or mild decel. # Bleed stale positive I faster in that narrow window so the command can # settle instead of wobbling the converter lock state. authority_mismatch = self.last_output_accel - max(a_target, 0.0) if authority_mismatch <= 0.08 and error > -0.08: return target_factor = float(interp(a_target, [-0.30, -0.10, -0.02, 0.03], [0.20, 0.35, 0.60, 0.85])) if error < -0.20: target_factor *= 0.75 self.pid.i *= target_factor def _apply_pedal_long_brake_bias(self, output_accel, a_target, CS): if not self.is_gm_pedal_long: return output_accel if output_accel >= -0.05 or a_target >= -0.80: return output_accel if CS.vEgo <= 5.0: return output_accel authority_gap = max(0.0, abs(a_target) - abs(output_accel)) if authority_gap <= 0.40: return output_accel speed_factor = interp(CS.vEgo, [5.0, 12.0, 25.0], [0.0, 0.7, 1.0]) max_bias = interp(abs(a_target), [0.8, 2.0, 3.5], [0.0, 0.10, 0.20]) bias = min(authority_gap * 0.12, max_bias) * speed_factor return output_accel - float(bias) @staticmethod def _cap_positive_output_on_negative_target(output_accel, a_target, error, CS): if output_accel <= 0.0: return output_accel if a_target >= -0.10 or error >= -0.35: return output_accel if CS.vEgo <= NEGATIVE_TARGET_CREEP_GUARD_SPEED and a_target > -NEGATIVE_TARGET_CREEP_GUARD_DECEL: return output_accel # Once the planner is asking for real decel, don't keep feeding positive # drive torque while we're still accelerating away from the target. positive_cap = interp(a_target, [-1.5, -0.6, -0.1], [0.0, 0.0, 0.05]) return min(output_accel, float(positive_cap)) def update(self, active, CS, a_target, should_stop, accel_limits, starpilot_toggles): """Update longitudinal control. This updates the state machine and runs a PID loop""" self.pid.neg_limit = accel_limits[0] self.pid.pos_limit = accel_limits[1] allow_stopping_release = self._stop_release_ready(CS, a_target, should_stop, starpilot_toggles) self.long_control_state = long_control_state_trans(self.CP, active, self.long_control_state, CS.vEgo, should_stop, CS.brakePressed, CS.cruiseState.standstill, starpilot_toggles, allow_stopping_release=allow_stopping_release) if self.long_control_state == LongCtrlState.off: self.reset() output_accel = 0. elif self.long_control_state == LongCtrlState.stopping: output_accel = self.last_output_accel if output_accel > starpilot_toggles.stopAccel: output_accel = min(output_accel, 0.0) output_accel -= starpilot_toggles.stoppingDecelRate * DT_CTRL output_accel = self._apply_moving_stop_target_follow(output_accel, a_target, should_stop, CS, starpilot_toggles) self.reset(preserve_stop_release=True) elif self.long_control_state == LongCtrlState.starting: if starpilot_toggles.human_acceleration: output_accel = a_target elif getattr(starpilot_toggles, "custom_accel_profile", False): output_accel = clip(a_target, 0.0, starpilot_toggles.startAccel) else: output_accel = starpilot_toggles.startAccel self.reset() else: # LongCtrlState.pid error = a_target - CS.aEgo self.update_mpc_mode(self.experimental_mode) self._shape_volt_test_tune_integrator(error, CS.vEgo) self._trim_positive_overshoot_integrator(a_target, error, CS) self._trim_gm_truck_positive_hold_integrator(a_target, error, CS) feedforward = a_target * self.feedforward_gain freeze_integrator = self._get_pedal_long_freeze(a_target, error, CS.vEgo, accel_limits) raw_output_accel = self.pid.update(error, speed=CS.vEgo, feedforward=feedforward, freeze_integrator=freeze_integrator) raw_output_accel = self._cap_positive_output_on_negative_target(raw_output_accel, a_target, error, CS) raw_output_accel = self._apply_pedal_long_brake_bias(raw_output_accel, a_target, CS) if self.transitioning and self.prev_mode == 'acc' and self.current_mode == 'blended': if raw_output_accel < 0 and raw_output_accel < self.last_output_accel: progress = min(1.0, self.mode_transition_timer / self.mode_transition_duration) # Soften transition at low urgency, but keep sharp for high decel # 20% smoother for chill decel (lower exponent) urgency = abs(raw_output_accel / CarControllerParams.ACCEL_MIN) urgency_smooth = min(1.0, urgency ** 0.4) # 20% smoother for chill decel blend_factor = 1.0 - (1.0 - progress) * (1.0 - urgency_smooth) output_accel = self.last_output_accel + (raw_output_accel - self.last_output_accel) * blend_factor else: output_accel = raw_output_accel else: output_accel = raw_output_accel self.last_output_accel = clip(output_accel, accel_limits[0], accel_limits[1]) return self.last_output_accel def reset_old_long(self, v_pid): """Reset PID controller and change setpoint""" self.pid.reset() self.v_pid = v_pid self.last_a_target = 0.0 self.integrator_hold_frames = 0 def update_old_long(self, active, CS, long_plan, accel_limits, t_since_plan, starpilot_toggles): """Update longitudinal control. This updates the state machine and runs a PID loop""" # Interp control trajectory speeds = long_plan.speeds if len(speeds) == CONTROL_N: v_target_now = interp(t_since_plan, CONTROL_N_T_IDX, speeds) a_target_now = interp(t_since_plan, CONTROL_N_T_IDX, long_plan.accels) v_target = interp(starpilot_toggles.longitudinalActuatorDelay + t_since_plan, CONTROL_N_T_IDX, speeds) a_target = 2 * (v_target - v_target_now) / starpilot_toggles.longitudinalActuatorDelay - a_target_now v_target_1sec = interp(starpilot_toggles.longitudinalActuatorDelay + t_since_plan + 1.0, CONTROL_N_T_IDX, speeds) else: v_target = 0.0 v_target_now = 0.0 v_target_1sec = 0.0 a_target = 0.0 self.pid.neg_limit = accel_limits[0] self.pid.pos_limit = accel_limits[1] output_accel = self.last_output_accel self.long_control_state = long_control_state_trans_old_long(self.CP, active, self.long_control_state, CS.vEgo, v_target, v_target_1sec, CS.brakePressed, CS.cruiseState.standstill, starpilot_toggles) if self.long_control_state == LongCtrlState.off: self.reset_old_long(CS.vEgo) output_accel = 0. elif self.long_control_state == LongCtrlState.stopping: if output_accel > starpilot_toggles.stopAccel: output_accel = min(output_accel, 0.0) output_accel -= starpilot_toggles.stoppingDecelRate * DT_CTRL self.reset_old_long(CS.vEgo) elif self.long_control_state == LongCtrlState.starting: if getattr(starpilot_toggles, "custom_accel_profile", False): output_accel = clip(a_target, 0.0, starpilot_toggles.startAccel) else: output_accel = starpilot_toggles.startAccel self.reset_old_long(CS.vEgo) elif self.long_control_state == LongCtrlState.pid: self.v_pid = v_target_now # Toyota starts braking more when it thinks you want to stop # Freeze the integrator so we don't accelerate to compensate, and don't allow positive acceleration # TODO too complex, needs to be simplified and tested on toyotas prevent_overshoot = not self.CP.stoppingControl and CS.vEgo < 1.5 and v_target_1sec < 0.7 and v_target_1sec < self.v_pid deadzone = interp(CS.vEgo, self.CP.longitudinalTuning.deadzoneBP, self.CP.longitudinalTuning.deadzoneV) error = self.v_pid - CS.vEgo error_deadzone = apply_deadzone(error, deadzone) freeze_integrator = prevent_overshoot or self._get_pedal_long_freeze(a_target, error_deadzone, CS.vEgo, accel_limits) feedforward = a_target * self.feedforward_gain output_accel = self.pid.update(error_deadzone, speed=CS.vEgo, feedforward=feedforward, freeze_integrator=freeze_integrator) self.last_output_accel = clip(output_accel, accel_limits[0], accel_limits[1]) return self.last_output_accel