Commit Graph

40 Commits

Author SHA1 Message Date
Adeeb Shihadeh 0010c9a986 Revert "params: safe and efficient async writing parameters (#25912)"
This reverts commit 780669c33fea1b2a14a0bd6e2eac82c9b8893aa5.

old-commit-hash: ec479322d3d8d789290bee68919d14b040481d53
2023-09-06 13:44:20 -07:00
Dean Lee 08e70aecb2 params: safe and efficient async writing parameters (#25912)
* Safe and efficient asynchronous writing parameters

* call putNonBlocking in locationd

* remove space

* ->AsyncWriter

* remove semicolon

* use member function

* asyc write multiple times

* add test case for AsyncWriter

* merge master

* add missing include

* public

* cleanup

* create once

* cleanup

* update that

* explicit waiting

* improve test case

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 0d797f4e8b2552192669d0329c14849f0a970066
2023-09-06 08:50:28 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Adeeb Shihadeh 51634f52dc replace custom clock helpers with time module (#29499)
* replace custom clock stuff wtih time module

* fix double

* fix release

* bump cereal

* update type

* fix one more
old-commit-hash: d61f86d3398900ef01423d24cfdf897392a8efbb
2023-08-20 18:50:58 -07:00
MoreTorque f5b4a0df46 Delay Shutdown: delay shutdown for 5 minutes after ignition turned off. (#27860)
Added delay shutdown. Tests updated

Co-authored-by: moretore <wrha@CH-ADS.localdomain>
old-commit-hash: 150a7d52da833876781aa8ec4730ec1d6021b0f2
2023-04-20 14:57:09 -07:00
EdwardApollo 5be01f56c0 Increase Minimum Offroad Battery Voltage (#26661)
* Reduce Min Idle Battery Voltage and Idle Time

Updated minimum offroad battery voltage to reduce wear on car batteries and updated max offroad time to reflect the increased power consumption at idle based on EPHOT hardware power draw (this may have changed).

Most vehicles make use of lead acid batteries which during normal use shouldn't ever decrease below ~12V (sources give a range of 11.8-12V). Increasing this limit will prevent premature battery failure by preventing sulfation of the cells.

* Voltage cutoff to 11.8V, max offroad to 30h

Changed lower voltage limit to 11.8V, removed power usage comment entirely, reverted change to max offroad time to 30 hours

* Added Offroad Shutdown conditional

Added IsOffroad Shutdown conditional statement to prevent shutting down due to voltage floor.

* LPF Gain: Tau = 45s

Tau modified to 45s to result in a LPF gain of ~0.011. 

Assuming a dT of 0.5s: (0.5/45)/((0.5/45)+1)

* Revert IsOffroad check

Removed due to unnecessary redundancy.
old-commit-hash: 30165134e8963e260245c1b6596ca3ae3cc08fea
2022-12-01 14:18:32 -08:00
Harald Schäfer b1e87f4df2 thermald: add minimum offroad time to low voltage shutdown (#26660)
* voltage cleanup thermald

* Fix voltage shutdown test
old-commit-hash: 196caa095b1c028926e580bb9c671338d08d3fa6
2022-12-01 13:57:11 -08:00
Bruce Wayne 3b889f1efd Revert "voltage cleanup thermald (#26658)"
This reverts commit ff0119d67a793f8caf7362ba980dae29e70716b4.

old-commit-hash: 7a9d96759d3a4db277edcce2d5e3ffda9c6823d5
2022-12-01 13:11:31 -08:00
Harald Schäfer 3f7428c731 voltage cleanup thermald (#26658)
old-commit-hash: 92e985c583bfb23c569008157037e77b6080a6f6
2022-12-01 11:56:25 -08:00
Adeeb Shihadeh 7c96e7876a cleanup panda types everywhere (#26574)
* cleanup panda types everywhere

* one more
old-commit-hash: 65fa87a96965000986e76604ac868891e35a86bc
2022-11-21 23:43:24 -08:00
Adeeb Shihadeh caac56b92e USB power mode cleanup (#25619)
* first pass at usb power mode cleanup

* fix build

* a sneaky one

* little more

* fix build

* bump pnada

* remove that

* power monitoring cleanup

* fix tests

* bump submodules
old-commit-hash: 28cb1897cb8be80b35b1ce7573066fb36b01d2d7
2022-08-31 21:13:53 -07:00
Adeeb Shihadeh 3c48bc47b7 Move a bunch of stuff to system/ part 3 (#24829)
* move swaglog.py

* timezoned

* logmessaged

* version.py

* fix linter
old-commit-hash: 0fce5d90459b77bf2cfa70f55f322f0e1fb8d01c
2022-06-11 23:19:27 -07:00
Adeeb Shihadeh 9a45a3b99b Move selfdrive/hardware/ to system/ (#24725)
* move hardware to system/

* fix mypy
old-commit-hash: 1139fe507b01f34de9714c99228f411558b44231
2022-06-11 16:38:24 -07:00
Adeeb Shihadeh 5659b6e6ce more comma two cleanup (#24300)
* more comma two cleanup

* fix up power monitoring
old-commit-hash: 6a48a7acef483907990e34e040deee70c689e700
2022-05-15 17:55:22 -07:00
Robbe Derks f6ebc8993b Add power usage stat (#24055)
old-commit-hash: 68f86d815ecd4573419b027df818a0a3f9442dbd
2022-03-29 11:30:13 +02:00
Robbe Derks 323febbf37 Statsd (#23413)
* device side of statsd

* need to start it

* enable in manager

* add sleep

* cleanup

* remove aggregates for now and standardize on industry terms

* manager needs main

* need to have a try/except

* atomic_write_on_fs_tmp does not work

* cleaner

* use dump

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* one file at a time

* limit amount of files

* move to influx line protocol and cleanup

* needs to be a list

* fix timezone bug

* actually rate limit

* add to release

* normalized origin

* also log deviceType

* more stats

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1b49ce6ec401966b0c56f62ea2b71209e9d4075b
2022-01-10 15:21:48 +01:00
George Hotz 86a39e838b Add More Types for mypy (#23268)
* mypy passes

* a few more

* a few in manager

* more types, will lint

* more

* simple types

* events type

* Update selfdrive/thermald/thermald.py

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dc96d4bee7b898172a6a15de4799af0e2d35605e
2021-12-28 18:07:00 +01:00
Willem Melching 11066c6236 Split pandaState into peripheralState and pandaState (#22385)
* publish peripheralState from boardd

* refactor consumers

* rename thread

* peripheralState has panda type too

* add to process replay

* fix device build

* properly remove hardware unsupported alert

* latest peripheralState

* remove pandaState from thermal_monitor

* put that back

* add back harness check

* fix cloudlog

* needs pandaState

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* dont conflate

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* pigeon is peripheral

* cleanup

* less global

* comment

* move rtc to peripheral_control_thread

* better diff?

* whitespace

* get msg

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f4e2537b124d3d1c0d697a12d8b243b54b76501b
2021-10-04 11:30:11 +02:00
robbederks 5441d1f348 Add harness connection as requirement for powerdown (#21087)
* add harness connection as requirement for powerdown

* fix unittests
old-commit-hash: 4a24d389c47a6dff4f9524490355a852f701aaaf
2021-05-31 13:32:26 +02:00
Willem Melching 76f087e3d6 Also shutdown after one hour after not going onroad (#20949)
old-commit-hash: 147ffb1441fdcda3b605cf3e6744ad6cedfe6993
2021-05-18 15:35:02 +02:00
robbederks 27f3e0f801 add lower limit to prevent triggering on power loss (#20720)
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 13a6e3c68f94d39890602acd6955ac9025e34498
2021-04-21 13:15:44 +02:00
Willem Melching 8f4a445171 add putBool/getBool wrappers to cython params class (#20611)
* add putBool/getBool wrappers to cython class

* use new API

* some more puts

* fix mockparams arguments

* add get_bool to MockParams

* typo
old-commit-hash: ae094042ade44815fdba50196c15ba552bbf33d7
2021-04-07 15:36:37 +02:00
Willem Melching a77f55fad0 Remove oneplus fan support (#20520)
old-commit-hash: 2a5d8b6f74c996e86942b17f2330eb882d2d3c17
2021-03-29 14:37:52 -07:00
Greg Hogan 088a6d1c5b fix pylint errors
old-commit-hash: 7cc0999aebfe63b6bb6dd83c1dff62c3915c4820
2021-02-23 13:58:58 -08:00
robbederks 0f73681f8d Fix tici powerdown and add support for forcing (#20132)
* also shutdown on tici

* force powerdown

* bump panda

* abstract out shutdown and thermal config

* add comment on tici shutdown

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 8ad1c793d1c4fbb37d763b40750561ad3aca137e
2021-02-23 17:04:10 +01:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
Adeeb Shihadeh 966945880b Cereal cleanup (#20003)
* start cleanup

* fan speed

* cleanup dm

* fix cereal

* hwType -> pandaType

* update refs

* update refs

* bump cereal

* freeSpacePercent

* cereal master
old-commit-hash: 000bd226aa9902da01e6010bf26762fca2c20df0
2021-02-03 19:57:30 -08:00
Adeeb Shihadeh b950cab874 HW abstraction layer (#19530)
* start hw refactor

* move that

* pins

* put that back
old-commit-hash: 8674b023bab2b44405139ceec5785a389f837682
2020-12-16 21:30:23 -08:00
robbederks 3209380a23 Move thermald hardware calls into HW abstraction layer (#2630)
* abstracted away hardware calls

* oopsie

* remove bugs

* remove bugs #2

* fix unit test

* removed print

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e64484aecdffbadbcc32c8bd316b579cdd3938ad
2020-12-02 15:20:57 +01:00
Adeeb Shihadeh f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f598639307994392e96f4d9293b295c7
2020-11-03 19:56:25 -08:00
Willem Melching c26ae3dcb5 Get power usage from current sensor (#2192)
old-commit-hash: 73a2067be33ba3a6737a8817c3a3b6ffd0e542d9
2020-09-18 12:25:55 +02:00
robbederks bcaf2a36af Car power integrator + power management refactor (#1994)
* wip, ready to test

* tweaks

* fix

* fix

* fix power monitoring

* fix param writing

* no forced charging on high voltage

* reset capacity on reboot

* don't shutdown unless started seen

* fix unused var warning

* fix linting errors

* time is always valid

* QCOM gate

* Local params

* decimate saving

* fix linting

* rename param

* Log car battery capacity

* fix put_nonblocking

* Added some unit tests

* Add test to docker test list

* fix precommit

* cleanup

* run tests in CI

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 7555379b2b1da2f800e98963ad4436b7fb91cce9
2020-08-17 11:56:27 +02:00
Adeeb Shihadeh 28181e86bf Use a monotonic clock source for power monitoring (#1861)
old-commit-hash: 897ee6bd2b11f313455fd00baff7eee5d45afac5
2020-07-12 01:46:02 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
robbederks a072639865 Added value-error for negative integration (#1390)
old-commit-hash: 15f57c4c22bb8e1f091344891e5b7d88443683d1
2020-04-17 14:05:43 -07:00
Willem Melching 907a97f1ee Don't use battery temperature to determine fan type (#1331)
* Don't use battery temperature to determine fan type

* Add cloudlog

* Init is_uno
old-commit-hash: 017b1f677050b1b9c29ce8173b80cd9a89901e40
2020-04-07 19:18:14 -07:00
Willem Melching bea4addcc2 Boardd should always send health, even with no panda (#1322)
* dont go offroad when health times out

* always send health packet

* Handle disconnect in thermal

* Handle unplug in power monitoring

* Small cleanup

* Remove copied code

* Add mutex

* Can just use infinite timeout. It will still return if not connected
old-commit-hash: b16e11cde5eccf3f3d028cf8ea2190726944a895
2020-04-06 16:01:42 -07:00
robbederks 4b7588e9ab Power monitoring fix (#1269)
* Release lock after exceptions

* No pulsed measurement on uno

* Fix last_measurement_time=None while integrating when going offroad

* Also clear next pulsed measurement time

* Move around locks

* Locks are good now?
old-commit-hash: 905f6b1b777d2032fc9ea510da02f3183e145cbe
2020-03-23 18:02:53 -07:00
Willem Melching 6c6df5486a Small thermald cleanup
old-commit-hash: 65ad31a7e45e79d2147dac6d711be68961f1889b
2020-03-12 11:55:33 -07:00
robbederks b0855ab17c Offroad power monitoring (#1067)
* Untested implementation of offroad power monitoring

* Fixed some syntax errors

* Cast to int

* Fixed pylint

* Wrapped in class

* Put pulsed calc in own thread

* Longer timeout before starting pulse measurement

* Fudge factor + flake8

* Made integration thread-safe and catch charge disable exceptions

* Catch all calculation errors

* Fixed networkstrength removal
old-commit-hash: 992be20d633fbd75ead240a5aeeb86451d42c3c2
2020-03-10 22:18:48 -07:00