Commit Graph

79 Commits

Author SHA1 Message Date
Shane Smiskol 43cac3cf24 PlatformConfig: clean up and print all flags (#32369)
* script to print flags

* don't need

* SAL

* back

* fix
old-commit-hash: f597d63bf6f2b8c8cf9a48934a059ef25ec69cd7
2024-05-07 15:00:02 -07:00
Shane Smiskol 43c72d410d Platforms: less redundant string repr (#32233)
smol
old-commit-hash: 3d0f9fb18f52ce092a2eb00cb92f7c285bc56e89
2024-04-16 23:37:46 -07:00
Adeeb Shihadeh fcbce3d8f6 cleanup pedal crc
old-commit-hash: 23e8ad73979735479131dfb303e249b861829468
2024-03-20 10:35:33 -07:00
thenhnn 77d6d1a8f1 PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 489528dcae3888311f92075ba9e0f68626725121
2024-03-19 11:16:02 -07:00
Adeeb Shihadeh 3bf3f4bf78 remove pedal (#31903)
* remove pedal

* bump panda

* fix

* update refs
old-commit-hash: fa12a6722868d436f15bea31537df1277bcc4027
2024-03-17 22:42:49 -07:00
Justin Newberry 4de27acf3d more car info -> car docs (#31885)
old-commit-hash: 0b92f4e9ee59b9de7ef0895d6d35e06027d3891c
2024-03-17 16:53:57 -07:00
Justin Newberry 5a7de94a13 rename CarInfo to CarDocs (#31879)
car info to car docs
old-commit-hash: 655e5f7c3e0312054da1f3075bf6b20d97d8a15c
2024-03-15 11:45:44 -07:00
Shane Smiskol 60f0948fba docs: don't support multi-type car info (#31875)
don't support multi-type car info
old-commit-hash: bdae188c6f48bc1572f6ca0cc61c4735d11d02fb
2024-03-15 00:11:41 -07:00
Shane Smiskol b286b84044 Revert "common PlatformFlags base class + test for < 32 bits" (#31793)
Revert "common PlatformFlags base class + test for < 32 bits (#31779)"

This reverts commit 7e75a99b03be1289aa515894e81caa1138374a38.
old-commit-hash: 99610c88195301c65c35ba0d4b41ad09d242a269
2024-03-08 00:15:21 -08:00
Justin Newberry fd2a03b1c2 common PlatformFlags base class + test for < 32 bits (#31779)
* add 32 bit check

* space

* this is not required

* jk yes we do
old-commit-hash: 8ba5d660f38c9d74df208aa79d1c6ae85937f4c5
2024-03-07 14:01:28 -08:00
Justin Newberry e6dbf6d614 cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
old-commit-hash: 25ccb2426c0b54dbf823b9e7e6d63607b37d9c5a
2024-03-06 11:22:12 -08:00
Justin Newberry e9ca84c95c platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
old-commit-hash: b0eae8c1b7264b2d0c63ee2957689bc1317616f1
2024-03-01 11:31:51 -08:00
Justin Newberry 9b6963a00d Hyundai: move car specs to platformconfig (#31661)
* specs

* override

* fixes 1

* fix 3

* fixes 4

* fixes

* fixes

* fixc

* fix number 723124

* that too

* fixes

* aa
old-commit-hash: 2e0db7f8d87457d05fef8156eccb94c949623cf3
2024-03-01 10:31:43 -08:00
Shane Smiskol 2ac06e8d7d Toyota: use platform config (#31607)
* part 1. Toyota platform config

* more

* everything works now

* no more DBC

* janky but that saves a lot of car lines

* need to init inside values or else it won't be reliable

* no return

* fixes

* minor update

* common flags, no dbc grouping

* some clean up

* some clean up

* rename

* copied wrong :(

* another

* copied specs for easiest ones first

* second easiest

* fix erroneous commas

* more clean up

* do the rest

* bug

* the refactor is so error prone

* huh?!

* static

* fix stiffness factor

* detect unsupported DSU

* Revert "detect unsupported DSU"

This reverts commit 9b72de6c8ef282ce20f6472970874a960761884b.

* fix DBC diff

* test carparams

* test sets

* scratch

* catches this

* Revert "scratch"

This reverts commit de08daa9fb8cc0368c5847b669e87b1b2e577616.

* Revert "test sets"

This reverts commit 62402f9b021cdf16a27fd9fb0883d81169711cbd.

* Revert "test carparams"

This reverts commit b02971659c2a8268d0ac8fdff02231dc36b5a197.

* Update ref_commit
old-commit-hash: 52ee070fe0a6880b7e3a5db408a0453c8310be86
2024-03-01 02:14:33 -08:00
Justin Newberry 0ffb29accd HKG: move to platform config (#31649)
* fuck me!

* that kinda makes things pretty nice

* move it down

* and move this comment

* Wip

* more flags :/

* add the debug shit

* add

* lets not break this yet

* MORE flags git add .git add .git add .git add .!

* B

* add mando

* update ref

* possibly better?

* we can use flags here

* formatting

* formatting

* move up

* canfd subclass

* this is more clear

* spacing

* static!

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: e341707b0f1b26bc235fb0a3d4a1703723c0e48b
2024-02-29 17:04:54 -08:00
Justin Newberry b3bb450e4a add CAR.print_debug (#31652)
print debug
old-commit-hash: ac16c5518a300df5fa31e088a6e2a03d1a0d1747
2024-02-29 15:01:47 -08:00
Justin Newberry 1a5b057983 Honda: move to platformconfig (#31637)
* first

* Fixes

* not

* not

* Fixes

* fix

* cleanup + use sets for now

* update ref

* update ref
old-commit-hash: 5734d7c2bf13c217e469d37c4900321cba469121
2024-02-29 11:29:40 -08:00
Justin Newberry b17981eced carspecs: add more units (#31646)
more units
old-commit-hash: f775faf26d555a99f43b74f8949aeb463d1d868e
2024-02-29 10:42:11 -08:00
Shane Smiskol d8c7b75973 Platform config small cleanup (#31638)
no field, label mass, correct spacing
old-commit-hash: 85150c0289605c86f6aaeceebfc2376cd6027cf7
2024-02-28 23:54:41 -08:00
Justin Newberry 9ccd7f15f9 Subaru: move to flags within PlatformConfig (#31584)
* flags

* update ref

* use the flags directly

* use post_init (don't freeze)

* we can maintain frozen with custom class

* not preglobal

* move to common

* cleanup
old-commit-hash: 3a6c3315ab181bf7390ae1faa6e87c93b1a97338
2024-02-28 20:12:14 -08:00
Justin Newberry 3321dfe90b Nissan: move to platform config (#31599)
* do nissan

* cleanup + fix
old-commit-hash: d3f0f76a7e33832bb7312597f85b802b50f2d757
2024-02-27 10:16:06 -08:00
Justin Newberry d6f9e2c805 platformconfig: freeze all dataclasses (#31605)
* frozen

* frozen
old-commit-hash: 9ecff49118a053917b462aac9dd20cadcf56dd1a
2024-02-26 21:16:05 -08:00
Eric Brown 0f78a52a22 GM: move to platform config (#31553)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* Move GM to platform config

* Implement CarSpecs

* Simplify centerToFront

* Accidentally had subaru DBC

* Fix typo in DBC name

* done above

* two spaces

* that is moved up

* fix hardcoded fingerprints

* whitespace

* values

* better?

* fix

* bump

* fix

* fix

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 5012e15aa65f4ee82ce19c856a52909b3a879016
2024-02-25 17:53:26 -08:00
Jason Young 5cb007daf3 VW: Move car specs to PlatformConfig (#31567)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* well that sucked

* cleanup and follow refactor

* diff reduction

* oops

* fix

* force fingerprint

* Revert "force fingerprint"

This reverts commit 600fbcd7d559703601a06c8876a640de417e5b6c.

* space

* Fix specs

* this one too

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: da540eac1346d0d28bf7cbb2499d6193af541798
2024-02-25 17:38:17 -08:00
Cameron Clough 9bd90112d0 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
old-commit-hash: 995250ae4967943ee33a3699a1d89a7a770d95e9
2024-02-24 16:41:23 -08:00
Justin Newberry c564806520 Subaru: move carspecs to PlatformConfig (#31550)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* fix
old-commit-hash: 1161d33c1892b32980a222b7c5b2ad9d6b05621e
2024-02-23 13:23:40 -08:00
Justin Newberry 3d5b7dadaf cleanup PlatformConfig (#31551)
cleanup
old-commit-hash: 73a497ded8b4ae7f1e2d3b5a7c4a2f57c748ff1c
2024-02-22 17:49:27 -08:00
Justin Newberry 351b1e1f5f cars: introduce "platformconfig" to be a configuration for all relevant car information (#31542)
* this is decent

* make sure the docs don't change for now

* hackery

* these can live here
old-commit-hash: 1ee8c9aa3317460979dfc2a96eccd101b1b70d41
2024-02-22 15:58:37 -08:00
Adeeb Shihadeh 952ca664fa Update Python packages and pre-commit hooks (#29739)
* Update Python packages and pre-commit hooks

* fix linter

---------

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
old-commit-hash: 9719b227611c880c76a60df223ef6c2f14f1a6ab
2023-08-31 15:00:13 -07:00
Shane Smiskol c5a673b998 car interfaces: handle buttons changing state without going unpressed (#26463)
* rename function first and foremost

* the function

* comment

* move usages over

* probably fine

* comments

* btn

* single line

* not comments

* fix keyword

* is it not clear?

* noEntry while holding cancel

* bumpo

* remove

* better?

* better?

* try this

* try this

* loop

* better

* more clear

* Revert "more clear"

This reverts commit 37e0277e4bfe6f1c553dbbcece6f532a280be62e.

* no optional

* fine

* add comment

* clean up honda

* one line

* can also do this

* but unclear

This reverts commit 1984a72cc8680b23c202695b8aeeb1aa28f7160c.

* bumppanda
old-commit-hash: 24f5a6170dc2e3bea9565115a09a1e20e18572de
2023-08-25 16:47:10 -07:00
Shane Smiskol fca565cad1 car/__init__: missing ending newline
old-commit-hash: ed6e72ae1fbc5605cac693d58b3143dd33c0d6fc
2023-08-25 00:43:29 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Shane Smiskol 183515c04b Rename CivicParams (#29459)
* CivicParams -> ReferenceCarParams

* remove usage in interface

* better name

* revert
old-commit-hash: 8dcd108972b7a434d91dd00686de669236edf148
2023-08-17 21:02:09 -07:00
Justin Newberry 268fb070a8 Subaru: calculate steering angle rate (#29409)
* calculate rate

* added adeeb's comment

* move to selfdrive/car

* that makes way more sense

* much simpler

* fix rate

* preglobal doesn't have a counter

* update ref

* merge

* update ref after merging
old-commit-hash: 7ec52da33ade1b0926b38fb5dc1e2bc52e957bad
2023-08-15 15:28:46 -07:00
Jason Young b4614b3c28 car interfaces: cleanup tire stiffness calculation (#28263)
* cleanup tire stiffness calculation

* bump cereal

* think these todos still apply

* gm: same default

* revert comments

* bump

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 90c4bbe8e4ee11f3c1289a0dbb93262824fa430c
2023-08-15 14:17:08 -07:00
Shane Smiskol 6b7b6034b7 common_fault_avoidance: take a bool (#29328)
old-commit-hash: 2a38f38be12052790804851a179acd159cea7f8b
2023-08-11 00:27:53 -07:00
Shane Smiskol e3b5998998 Clean up common steer fault avoidance code (#29200)
* fix spacing

* more spacing

* better names and comments

* this default doesn't make sense

* or this

* explicitly boolean since latActive is
old-commit-hash: dba4492aa0b7b773f50816c5992fbe6e272d832f
2023-08-01 14:02:15 -07:00
Justin Newberry 6c4a4e5d74 Homogenize Steering Fault Avoidance (#29140)
* fix subaru fault

* try this!

* wip

* try this

* this more or less worked

* this is all under gen2

* that needs to be up there

* comment

* steer_angle

* test

* wip

* wip

* sync

* wip

* cleanup

* remove print

* use sets and fix unittests

* common fault avoidance

* common fault avoidance

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* revert subaru to get this part merged

* revert name change

* revert name change

* revert name change

* same as before

* add test case

* also verify zero tolerance

* keep the current behavior

* split into multiple tests for easier debugging

* added comments and remove tests

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: a19f8dce92bfe7242e64160cb86364d728b01d97
2023-08-01 10:27:06 -07:00
Shane Smiskol 28c64e4856 CanBusBase: fix offset calculation (#28938)
old-commit-hash: f99ac84b5ca8f48d044c4eaf0164b07c7b270fa0
2023-07-14 11:06:22 +01:00
Cameron Clough 5afe1c0ed0 selfdrive/car: reusable CanBus helper (#28489)
old-commit-hash: 28bf7436937a14f16020dd00ee224c1d3fe26705
2023-06-10 22:50:19 -07:00
Shane Smiskol 4cf0ce33d5 steer limits: rename common dist to meas function (#27453)
* rename function

* make a wrapper function (ford uses dynamic up/down limits

* make two functions consistent

* make torque function convert to int
old-commit-hash: 581fd62d2642629b23ac111112245a963202143f
2023-02-26 17:32:52 -08:00
Shane Smiskol a55f8d65cd Angle control: fix limiting bug (#27428)
* fix steer up bug

* Update ref_commit
old-commit-hash: d5688ae49fd8652bf500ec145f2f3aa711c6bbf3
2023-02-23 16:18:32 -08:00
Shane Smiskol ae26b6fb0f Car controls: common angle limiting function (#26732)
* common angle limiting function

* save a line
old-commit-hash: 41667d020ac8eb8d518e9437de32d8d9d09b6b15
2022-12-08 16:26:41 -08:00
Jason Young 914c75d9ea Allow car port to define enable buttons (#25793)
* Allow car port to define enable buttons

* simplify

* oops
old-commit-hash: 135270f65cbde80c06aee1773b9ca802bd32f419
2022-10-12 16:27:23 -07:00
Shane Smiskol cfc3213ac1 ui: support ego speed hysteresis (#25702)
* toyota: match set speed from dash

* Use unit bit

* Use RSA2

* flip this

* Universal unit signal, set vEgoCluster

* remove this and bump opendbc

* detect if car interface sets cluster fields

* revert

* needs to be cp

* UI_SPEED is actually always in kph?

* forgot to actually convert it

* same in onroad

* try conv factor only for imperial

* Seems like UI_SPEED is not the UI speed at all

* the dash might floor it

* same openpilot behavior

* bump

* ego speed factor is dynamic across speeds, handle Lexus exceptions with
diff msg

* remove test, bump opendbc

* secret formula

* secret formula v2

* 1.03 is sufficient

* try short press

* bump opendbc

* surely this can be cleaned up

surely this can be cleaned up

* use filter

* redo factors

* try UI_SPEED again with a factor

try UI_SPEED again with a factor

* dash applies hysteresis to speed. this matches pretty well, but not exactly

* make hysteresis generic

* clean up

* revert this

* try this

* read from fake params

* should be mostly good for imperial now

* revert

* revert

* remove toyota stuff

* common function for everyone

* rm line

* fix

* an example with Toyota

* use CS.out

* one mph

* 1 kph

* cmt

* remove cmt

* abs it

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: ef26abcf658b9fe13f939c43a31f57bd6ae25232
2022-09-13 23:34:51 -07:00
Adeeb Shihadeh 2c85a11a31 expand fingerprint dict size for multipanda setups
old-commit-hash: baef4c1fb2b9dd20bfa172eb49961c4171076b1f
2022-08-17 15:30:20 -07:00
Shane Smiskol 3ba40da00a Honda: fix enabling before PCM (#24715)
* Don't enable for pcmCruise Honda

* make it a no entry as well

* do in another PR
old-commit-hash: 40deea7d7bdd2176f897c203657e45bfd7fd1fcc
2022-06-02 22:06:01 -07:00
Shane Smiskol ddf2d5b63c Button-enable cars: common functions for button events (#24678)
* function for creating button events

* fix

* one line

* alphabetical

alphabetical

* only needed once

* common function for enable events

* add to list

* extend

* fixes

* add type hints

* flip around
old-commit-hash: eed6803ccc55ecbfab4bd52a7ea62c9942243aea
2022-06-01 12:03:34 -07:00
Dylan Herman 2dfba97175 add mypy check for return-any (#24379)
* add mypy check for return-any

* remove unused import

* typing

* remove unnecessary variable typing

* cleanup

* cleanup

* bump submodules

* small fixes

* only a problem on mac

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d2eef1955c777ef6110c7a74d2a9ca9e4e1d958c
2022-05-12 14:59:00 +02:00
Adeeb Shihadeh 5e6608b67e comma pedal: rename create_gas_command -> create_gas_interceptor_command
old-commit-hash: b07ddad6ed62f9b0002ce7aa73db932dd2d7a73e
2021-11-20 20:13:58 -08:00