Commit Graph

35 Commits

Author SHA1 Message Date
Igor Biletskyy f35a445b73 body: add debug ECU for git hash logging + fw version (#24128)
* non-essential ECU for logging

* bump cereal

* debug ECU

* match_fw_to_car_exact

* comment

* version instead of board date

* add old compatible value

* update_refs
old-commit-hash: 7908fb88299c6431e3495a86aafe8b0c092547e4
2022-04-05 18:24:06 -07:00
Igor Biletskyy df806cdbeb car port: comma body (#24019)
* body FPv2

* ..

* ..

* ..

* Temp, REVERT!

* more cleanup

* typo

* ..

* del eyes

* should work?

* fix

* new dbc

* ..

* fixes

* static analysis

* cln balancing code

* no test route

* excluded_interfaces

* THE DOCS!

* comments on steer/speed mixin

* switch to bus 0

* less UDS

* FAKE bus 0 vin and fingerprint

* FAKE locationd

* Keep steady and remove handcoded offset

* Improve startup sequence, get closer to stock openpilot

* Forgot to define angle

* lowercase

* revert that

* little cleanup

* change safety model

* update refs

* body is gold

* handle no llk

* oops

* litte more

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 031f79ba88c58f9fbc087df0a1e2ba5ddc3f80db
2022-03-31 17:16:15 -07:00
Adeeb Shihadeh 309cf89d90 FW query: specify bus in request (#24080)
old-commit-hash: 5550aa6f57698f8cb8dac358ba5f603294be02f5
2022-03-30 13:39:17 -07:00
Dean Lee 98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec18b1313148905172ba54bac9f5fdfd
2022-01-10 16:36:51 +01:00
martinl 0030f11a5e Subaru FPv2 support (#1878)
* Add Subaru FPv2 support

* Add Subaru Ascent and Impreza FPv2 values

* Remove 10 second delay, use UDS for Subaru FPv2

* before VW

* before hyundai

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 6b205347e57eb30a278e1eb9ead6aaba96e30b92
2022-01-04 11:06:29 +01:00
Ewout ter Hoeven f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a8241fba9459cb70c76840b9670e6993a
2021-12-24 11:18:39 -08:00
Ewout ter Hoeven a962365292 Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 55390d273f36f49da3896e687ac5530f40c1d150
2021-12-16 14:58:17 +01:00
Willem Melching ca8e47242d 0.8.11-release FW batch (#23167)
* 0.8.11-release FW batch

* those toyota also dont always return esp

* attempt to clean up 2018 & 2021 accord
old-commit-hash: 0ec68a5a09824e7e372b2e8e47b3b41f586c36a5
2021-12-08 14:44:00 +01:00
robin-reckmann 8c9ab4d333 Fingerprinting v2 support for Nissan vehicles (#22655)
* Add Nissan FPv2

* Update Nissan version response

* Add second Nissan FPv2 query

* Add multiple offsets for Nissan

* Nissan offset fix

* Add Nissan diagnostic request

* Use 21 83 for Nissan version request

* Add partial 2018 Leaf FPv2

* Update 2018 Leaf FPv2

* Nissan FPv2: more RX offsets, add no diagostic request scan for 0x20

* Add FPv2 imports to Nissan values

* Change LEAF to LEAF_IC

It is an instrument cluster leaf. With this minor change it works :).

* fixed ecu addr for nissan eps

* Remove FW not used for fpv2

* Remove unused offsets

* add fw versions for 2018 Nissan Leaf JP

* add standard ecu fw query

* add esp fw

* add nissan xtrail

* Add missing ESP FW for 2018 Nissan Leaf IC

* Add fwdCamera FW for Xtrail 2017

* add missing comma

* Add 0x8 default offset

needed e.g. for xtrail engine ecu

* Apply suggestions from code review

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Fix variable naming

* remove unnecessary part of standard fw query

* add fw versions for CAN-GW ECU

* transmission eco does not reliable answer -> remove

* add Altima FWs (part 1)

* add Altima EPS FW

* Remove NISSAN_KWP_DIAGNOSTIC_REQUEST and cleanup

* Revert "Remove NISSAN_KWP_DIAGNOSTIC_REQUEST and cleanup"

This reverts commit 808d6f1562e9a6cb57ea365d184b74d51f6da017.

* cleanup

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
Co-authored-by: Julian Pieles <julian@pieles.digital>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: e2288371f2bd99cd31d141729a77d676ba28b4df
2021-11-08 10:51:59 +01:00
Willem Melching 03da450865 Improve Hyundai FW query stability (#22344)
* extend timeout on valid response

* extend total timeout in fw query

* redundant query

* cleanup

* add 2 new sonata fw

* add cloudlog

* total timeout always 10x

* update ref

* time.monotonic()

* more logging
old-commit-hash: 2d7d8fba998c3d6c32c9798fd9f7086eb123abff
2021-09-24 17:32:09 -07:00
arfy slowy 63b3d6024b fix: spelling typos (#21861)
* fix: typo spelling grammar

* revert

* Update selfdrive/locationd/calibrationd.py

* more revert

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: d74def61f88937302f7423eea67895d5f4c596b5
2021-08-05 12:05:49 -07:00
ShaneSmiskol 1735252c7d Split Avalon 2016-18 and Avalon 2019+ (#21058)
* start to separate Avalon 2019+

* reverts #20824 (2020)...

and removes fw from a 2020 avalon

* revert 2020 fw from #20241

* revert 2021 fw from #19790

* bump opendbc, add smartDsu

* Add only removed fw from listed PRs above and from jryan's 2020

* bump opendbc to master

* comment out any non-original avalon fw

* new fw

* these 2016 (5 byte EPS_STATUS msg) Avalon fws are correct. comment out any 2019+ fw I haven't seen yet

* Add to release files

* these are good too

* nothing on 7e0 yet

* both have their engines on one address

* validated remaining fws! some from adeeb's, chris's, and kumar's PRs

* Add test route for Avalon 2019

* horrible

* Duplicate

* use nodsu dbc. Only difference is the addition of some signals that don't work, and max of BRAKE_PRESSURE is different

* Enablem 2019 Avalon test route
old-commit-hash: 07e4129edc5ebb870037c1a44d8a33a2faf8a98a
2021-06-01 12:41:24 -07:00
Jafar Al-Gharaibeh f108d93bc0 Mazda FP 2.0 support (#20879)
* Mazda FP 2.0 support

ECU FW for CX-5 2017 and Mazda3 2017

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use standard UDS request/reponse, fix missing arg.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add CX-5 FW test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update/add FW FP

Current suported models:
  CX-5 2017/2021
  CX-9 2019/2020
  Mazda3 2017/2018

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add Cx-9 2019 FW FP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Remove comments, remove TESTER_PRESENT_REQUEST from Mazda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* add transmission ecu to startup test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 824f93303d95695a761d10a00b0e9547274db6a9
2021-05-28 15:50:58 +02:00
Erich Moraga fecadd2169 Add missing Camry FW (#20953)
* Add missing several missing Camry firmwares

@oxigen#0649 2019 Toyota Camry ICE  DongleID/route 04b2f59611cf9e7f|2021-05-18--11-11-17

* Update fw_versions.py
old-commit-hash: cb4ab313623802a7af331a3ebd7cc0322735ba5f
2021-05-18 15:46:04 -07:00
Gabor 9b78f835ce Civic 2019 EU new ECU values added (#20774)
* Update values.py

* non essential

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 7d9aa1352f305312ee1d9c28f3c6316fafae600d
2021-04-30 17:06:12 -07:00
Willem Melching ee0e80a6d4 Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
old-commit-hash: e4f73fbda5c2dd07cbb15816ac1bf30b010408fe
2021-04-20 12:00:36 +02:00
Jason Young 76fc2d5206 VW MQB: UDS fingerprinting support (#20271)
* FPv2 support for MQB

* Comment touch-ups

* Trim extra newlines

* Add Atlas and Tiguan

* Update submodule ref

* Revert "Add Atlas and Tiguan"

This reverts commit a47bc1bca7a5b72df44578051379859eefa5fb39.

* Curb my enthusiasm

* Drop ABS/ESP from UDS fingerprinting for now

* Use multi-query to grab SW build ID and parameterization

* Resolve merge oops

* Resolve merge conflicts

* Make Ecu.fwdCamera optional for VW

* Where'd that come from?

* Propitiate process replay checks until ready for model dump

* FW values for Audi A3 Prestige

* Revert "Make Ecu.fwdCamera optional for VW"

This reverts commit 56852b99

* Don't try to FP fwdCamera for VW

* Remove FW comments

* Simplify RX offset handling

* Corrected scoping for MQB trans detection

* Add default response_offset

* Remove explicit list of MQB vehicles for now

* Deal with pylint warning

* Clarify and simplify comments

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: e7fc11c7fba3433b5f4f2f5d36a882784e426bb7
2021-03-25 16:06:59 -07:00
Adeeb Shihadeh b5efa28b59 Toyota Avalon 2021 (#19790)
old-commit-hash: 876602ba9132b3d4a323129a841be1cfd825fbeb
2021-01-16 14:14:13 -08:00
Adeeb Shihadeh a4f809eca7 fix lexus is fw fingerprinting
old-commit-hash: 27fefb9f608fa43bf6278be2b2bef1c34f1289be
2020-11-20 14:29:54 -08:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Willem Melching 2b60ee9531 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
old-commit-hash: 3d08dcc3b27936cb14c0eae63605be9a6c077380
2020-05-28 15:05:04 -07:00
Willem Melching 3a4e139b83 Fixup comments
old-commit-hash: 68ef23f97b7530e4eab54b79508c1d4a393f65ab
2020-05-20 14:10:55 -07:00
openpilot laptop bd40e9a14b Add single fw requests for hyundai ECUs not supporting multi requests
old-commit-hash: b8cc31f888d4301b7db59ff9419db9215868a3f7
2020-05-20 14:07:04 -07:00
Willem Melching 0bfec1061a Only send FW query requests for the right brand (#1546)
* only send requests for the right brand

* this works on sonata

Co-authored-by: openpilot laptop <laptop@comma.ai>
old-commit-hash: 1162041ea63a7213b9e2b9c11edd521c89f86c99
2020-05-20 13:02:24 -07:00
Willem Melching 88a385e9c9 Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
old-commit-hash: bb8bbdd9ee4d610e2ae6048021407863b3f74683
2020-05-19 13:43:44 -07:00
Willem Melching 8b6263376d add TOYOTA CHR fw versions
old-commit-hash: 10c3494bc9a6a56e0c8dbfa859a0332c38841262
2020-03-13 11:13:55 -07:00
jpancotti eaf9d034c7 classify ecus (#1092)
old-commit-hash: 1dea855708bab89b0bc66d2f9cbfdb7d985cf006
2020-02-20 17:07:21 -08:00
Willem Melching e3bbfa99d6 remove duplicate addresses from firmware query. Fixes #1088 (#1100)
* remove duplicate addresses from firmware query

* Update release notes

old-commit-hash: f719c9a6571f8ce47e305a7ba0fb6b8d05e6f90b
2020-02-14 15:51:56 -08:00
Willem Melching 2bde267e84 Fix fw_versions.py --scan
old-commit-hash: 719e0572e1
2020-02-06 10:58:18 -08:00
Willem Melching bd1db9aa8e Add batch of firmware versions
old-commit-hash: bfa2d030d2
2020-02-01 13:06:05 -08:00
Willem Melching 1dee8638d6 Cache FW query (#1025)
* split fw query and matching

* Read cached firmware versions

* add tests

* this works

old-commit-hash: b7aeb5d64d
2020-01-30 17:57:20 -08:00
Willem Melching 4101b7976c FW fingerprint for Honda & Toyota (#961)
* add script to process logs

* Skip rav4 ESP

* Improve gathering script

* Update firmware versions for honda and toyota

* more firmware versions

* If FW query returns 1 candidate, use it

* Add FW versions

* Fix COROLLA_TSS2 two enigine addresses

* uncomment rav4h tss2

* add progress bar to test script

* Batch with more ecu versions

old-commit-hash: 356f353489
2020-01-30 14:32:26 -08:00
George Hotz 9ef085076b selfdrive/car
old-commit-hash: 71ead9adea
2020-01-17 10:58:43 -08:00
George Hotz 81dd5a50cf root commit
old-commit-hash: 6c33a5c1f3
2020-01-17 10:02:52 -08:00
Vehicle Researcher fa4b6f33d1 openpilot v0.7.1 release
old-commit-hash: 8da8b6135c
2020-01-15 14:05:04 -08:00