Commit Graph

34 Commits

Author SHA1 Message Date
David Peterson a6b0cf3feb docs: add video link for 2019 Subaru Crosstrek (#24251)
* Update values.py

Add video_link :     SubaruCarInfo("Subaru Crosstrek 2018-19", good_torque=True),video_link="https://youtu.be/Agww7oE1k-s"),

* fix syntax

* timestamp to start of openpilot use

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: ce74bd41431e6bcc76ccf3de0c2edb69bcde4d48
2022-04-19 13:25:56 -07:00
Adeeb Shihadeh b4d25060fa Subaru: remove rest of CAN fingerprints (#24195)
old-commit-hash: c8101988150609d79b9d9d9916aedeb95b92ba34
2022-04-13 11:48:14 -07:00
Shane Smiskol 32389d3293 Subaru: add missing Impreza fw versions (#24194)
* add missing impreza fw versions

* these are duplicate

* this fw version flipped on the 5th for michael and never switched back
old-commit-hash: 3ff14adbd67cb003506e735a1608e44b5f6b275d
2022-04-12 17:15:27 -07:00
martinl 808c139479 Subaru: update supported model years and steering torque (#24118)
* Subaru: update carinfo supported model years and good steering torque

* update torque

* model year 2020 was added to IMPREZA_2020, split out

update docs

* order

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5e1095e88131fe7cf4555e9dcb1023f49239443c
2022-04-05 13:04:46 -07:00
Shane Smiskol bf8262394f Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 31a6b141d6c37d7241146a9dc7b3a10313abdc40
2022-03-16 21:27:05 -07:00
martinl 640c381325 Subaru: add FW for 2019 Subaru Impreza Sport (#23945)
old-commit-hash: 30ae47de0558ac909facf85c8d386d4b94242aa4
2022-03-10 13:01:04 -08:00
seven121-ym 156fe4f533 Subaru: add FW for 2019 Subaru Impreza (#23873)
* Update values.py

* Update selfdrive/car/subaru/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9a663214b98345f2da51dec9c03e362bedf10b41
2022-02-27 21:57:42 -08:00
Adeeb Shihadeh 89466907cb Subaru: add Ascent FW values (#23848)
old-commit-hash: 71cf938c519e28f0fd0c160b7ae7e778e52280a3
2022-02-23 17:34:39 -08:00
Adeeb Shihadeh 9bd6dbea43 Subaru: remove Impreza CAN fingerprints (#23841)
* Subaru: remove Impreza CAN fingerprints

* fix process replay

* update refs
old-commit-hash: 04b2545ec013d27e4022604101014f5cf9e6e43b
2022-02-23 15:44:17 -08:00
martinl d4db9082db Subaru: add FW for Impreza Limited UDM 2017 (#23802)
* FPv2: Add Subaru Impreza Limited USM 2017

* test_fw_query_on_routes.py: add subaru support

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 412e43206e819193839eab5525fdb6358349856b
2022-02-22 12:17:48 +01:00
Adeeb Shihadeh 597535c014 linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
old-commit-hash: 2c94f155840b49639b8bf1ec996d99e268fa9a52
2022-01-13 14:19:38 -08:00
Drew Hintz ef70d0689a Subaru: fix missing commas in fingerprints (#23512)
old-commit-hash: 6d5dce2ed5c006ea9da1275df593917e09fa3354
2022-01-13 14:07:00 -08:00
Adeeb Shihadeh 9cbde03c7c Subaru: remove all Pre-Global CAN fingerprints (#23422)
old-commit-hash: a12649564c9b4c3abb0cee8c97631b2698a82019
2022-01-05 14:18:38 -08:00
martinl 6b4865ac8a Subaru: remove Ascent FPv1 (#23407)
* Remove Ascent FPv1

* bump cereal
old-commit-hash: 7faad75a44d05a972d614e78ddb1a1fcc63be735
2022-01-05 14:16:32 -08:00
martinl a81b0d8564 Subaru: initial FPv2 dump (#23389)
* Add FPv2 for Ascent, Forester, Impreza, Legacy, Outback

* remove comments
old-commit-hash: 15be8a8c1f9a15f08b09bd137e661974c77c3616
2022-01-04 13:07:11 -08:00
martinl 0030f11a5e Subaru FPv2 support (#1878)
* Add Subaru FPv2 support

* Add Subaru Ascent and Impreza FPv2 values

* Remove 10 second delay, use UDS for Subaru FPv2

* before VW

* before hyundai

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 6b205347e57eb30a278e1eb9ead6aaba96e30b92
2022-01-04 11:06:29 +01:00
martinl b99c359d61 Subaru: Add Impreza/Crosstrek 2020 (#21011)
* Add Subaru Impreza/Crosstrek 2020

* Update selfdrive/test/test_routes.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 7fd98757b46b384fba00aaa91612f66f3de2f020
2021-12-15 15:13:31 -08:00
seven121-ym fdae7d1f47 Subaru: Add Japanese Impreza fingerprint (#22125)
* Update values.py

* crosstrek is a subset of new fp

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 67ab1193d0b06b74d471e9959fb62a6993e1a6fe
2021-09-06 20:23:32 -07:00
Willem Melching 4daa6f05cf Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
old-commit-hash: e4cf43c6fcc2f442318df815fdc38fb26a74bdb7
2021-01-06 11:20:44 +01:00
jcak ef4eb97860 Add Forester 2020 fingerprint (#2763)
* Add Forester 2020 fingerprint

* Update selfdrive/car/subaru/values.py

* combined Forester 2019 & 2020 fingerprints

2020 model had some additional fingerprints than the 2019 model. Merged rather than adding separately.

* Added Forester 2020 to readme

* Updated to include forester touring as well

added additional messages as per #19499 (updating same fingerprint)

* Delete Forester 2019 sport - duplicate fingerprint

* Update values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d3d57b0744de5ff04c86e91c8a63d92ba681caaa
2020-12-16 11:58:07 +01:00
Adeeb Shihadeh f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f598639307994392e96f4d9293b295c7
2020-11-03 19:56:25 -08:00
martinl 6a000279ad Add preglobal Subaru Forester and Outback (#1993)
* Add preglobal Forester and Outback

* Tests and values cleanup

* Update units in carstate

* Remove ()

* Add OUTBACK_PREGLOBAL_2018 to non_tested_cars

* Add replay route for OUTBACK_PREGLOBAL_2018
old-commit-hash: c9adc4900b2e26d0582cb264da2e547a513de831
2020-08-10 12:31:40 -07:00
martinl 0aeae7d81e Subaru pre-global: add support for Subaru Legacy 2015-18 (#1805)
* Add support for Subaru Legacy 2015-18

* syntax fix

* Add Legacy 2018 FPv1

* Add Subaru Ascent from upstream

* Use GLOBAL_CAR and LEGACY_CAR lists

* Change LEGACY_2015 to LEGACY_PREGLOBAL

* Add LEGACY_CAR to carstate

* Change LEGACY_2015 to LEGACY_PREGLOBAL in test_car_models

* Add missing SafetyModel to Ascent

* Use GLOBAL_CAR and LEGACY_CAR to set safetyModel

* Change LEGACY_CAR to PREGLOBAL_CARS, remove GLOBAL_CAR

* Fix PREGLOBAL_CARS in carstate and subarucan

* Minor cleanups

* Add accelCruise button event

* Change Preglobal Driver Torque limit to match Global

* Match comments to upstream

* Use Steer_Warning and Steer_Error_1 only for Global

* Change mph units to match upstream values

* Increase Preglobal brakePressed  threshold to 2

* Add DashcamOnly to LEGACY_PREGLOBAL

* Fix typo in variable name

* Update README, add create_preglobal_steering_control

* cleanup carcontroller

* cleanup values

* missed that one

* Update STEER_STEP

* Update STEER_MAX

* Add preglobal signal frequency checks

* remove PREGLOBAL_CARS from subarucan

* Remove whitespace

* Use common frequency checks

* cleanup carstate

* cleanup subarucan

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: e37b8e5d5632a7cc48326f7ca162ef87f259e526
2020-08-06 21:55:13 -07:00
martinl 54e4939168 Subaru Global generated dbc and new signals (#1908)
* Change carstate signals to use feature-subaru-long dbc

* Add Conventional_Cruise signal to carstate

* Fix Conventional_Cruise signal source

* Use Cruise_Cancel signal in subarucan

* switch to subaru-global-2020 opendbc branch

* Update release file

* bump opendbc

* switch panda to subaru-global-carstate branch

* bump panda

* bump opendbc

* revert submodules for upstream PR

* switch panda and opendbc to upstream

* bump opendbc
old-commit-hash: a086f52881f4a1f0d20486e7fa089a843d5d8b34
2020-07-23 12:28:23 -07:00
martinl dfee3692f6 Support for 2019 Subaru Ascent (#1801)
* Add support for Subaru Ascent 2019

* remove duplicate safetyModel

* Add Ascent 2019 to README.md
old-commit-hash: b1abf17752f7631014d855466c46f2aef71bc604
2020-07-01 16:54:40 -07:00
martinl 0d04c2cc26 Subaru Forester 2019 (#1768)
* Add initial Forester 2019 support

* Add dgranger15 Forester 2019 FPv1

* fingerprint syntax fix

* FPv1 syntax fix 2

* Add Forester 2019 to CAR

* fix indent

* Add Forester 2019 to test_car_models ignore list

* Update Forester 2019 steering tuning (dgranger15)

* Add Forester 2019 to README.md

* Change lists to single value

* Add test route for Forester 2019

* Remove model year

* Remove Forester model year in test_car_models

* Remove usernames, add Forester ACC speed mph unit value
old-commit-hash: 09e7d4ab3a044fd5279cce43853f69465eac876f
2020-06-23 16:07:46 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Adeeb cf26bb52b5 Clean up ECU redundancy in selfdrive/car/* (#963)
* clean up ecu redundancy in selfdrive/car

* clean up gear parsing

old-commit-hash: dafdb79db2
2020-01-18 23:35:10 -08:00
George Hotz 9ef085076b selfdrive/car
old-commit-hash: 71ead9adea
2020-01-17 10:58:43 -08:00
George Hotz 81dd5a50cf root commit
old-commit-hash: 6c33a5c1f3
2020-01-17 10:02:52 -08:00
Vehicle Researcher b713eae9f8 openpilot v0.6.6 release
old-commit-hash: d7f0b402a8
2019-11-04 15:13:52 -08:00
Vehicle Researcher 89d1d84c70 openpilot v0.6.5 release
old-commit-hash: cf80f7a28b
2019-10-09 18:43:53 +00:00
Vehicle Researcher 0932b367bd openpilot v0.5.12 release
old-commit-hash: 3f9059fea8
2019-05-16 13:20:29 -07:00
Vehicle Researcher 30f7a33535 openpilot v0.5.10 release
old-commit-hash: f74a201edc
2019-03-26 01:09:18 -07:00