Commit Graph

130 Commits

Author SHA1 Message Date
Shane Smiskol 43cac3cf24 PlatformConfig: clean up and print all flags (#32369)
* script to print flags

* don't need

* SAL

* back

* fix
old-commit-hash: f597d63bf6f2b8c8cf9a48934a059ef25ec69cd7
2024-05-07 15:00:02 -07:00
Jack Merrill 38c10a672a Subaru: Increase RPM Limit (#32299)
Increase the Subaru RPM limit in values.py, update panda submodule
old-commit-hash: 5783bdc513bcc9d1606b07c4adacb49236e04fb0
2024-04-26 16:07:17 -07:00
Justin Newberry b899592b18 cars: platform enums -> prepend brand name (#31927)
* with brand name

* migrate

* Fix

* fixes

* more

* passes

* fix

* fix the doc

* collects

* these too

* more stuff

* body exception :/

* more

* hardcode i guess

* update ref

* toyota

* more toyota

* and here

* final!

* fix notebooks and ccs

* move this here
old-commit-hash: b0eb3ba4f477142797624580eb3fdb6448f068d6
2024-03-19 17:29:50 -07:00
thenhnn 77d6d1a8f1 PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 489528dcae3888311f92075ba9e0f68626725121
2024-03-19 11:16:02 -07:00
Justin Newberry 5a7de94a13 rename CarInfo to CarDocs (#31879)
car info to car docs
old-commit-hash: 655e5f7c3e0312054da1f3075bf6b20d97d8a15c
2024-03-15 11:45:44 -07:00
Shane Smiskol 60f0948fba docs: don't support multi-type car info (#31875)
don't support multi-type car info
old-commit-hash: bdae188c6f48bc1572f6ca0cc61c4735d11d02fb
2024-03-15 00:11:41 -07:00
Shane Smiskol 2fc4b2ebd6 Subaru: log alt request (#31812)
* add alt query (same as Hyundai)

* refs
old-commit-hash: 5be3f0b7dbb1209f8e2543bfb6f0003e3fda01b6
2024-03-08 19:36:33 -08:00
Shane Smiskol ae84cb4fc5 Subaru: extra logging request for camera (#31783)
* 7f - service not supported in active session

* update refs

* rm short

* Apply suggestions from code review

* bus 0
old-commit-hash: 66adf8781eb09631687ca4809e92136cbbdc7f56
2024-03-08 17:00:07 -08:00
Shane Smiskol b286b84044 Revert "common PlatformFlags base class + test for < 32 bits" (#31793)
Revert "common PlatformFlags base class + test for < 32 bits (#31779)"

This reverts commit 7e75a99b03be1289aa515894e81caa1138374a38.
old-commit-hash: 99610c88195301c65c35ba0d4b41ad09d242a269
2024-03-08 00:15:21 -08:00
Shane Smiskol 2617b11ab3 Subaru: make OBD query logging (#31785)
* make OBD query logging

* Update selfdrive/car/subaru/values.py

Co-authored-by: Justin Newberry <justin@comma.ai>

* wording

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 90442e35971b273d36832bf90188dd010a32507e
2024-03-07 18:57:15 -08:00
Justin Newberry fd2a03b1c2 common PlatformFlags base class + test for < 32 bits (#31779)
* add 32 bit check

* space

* this is not required

* jk yes we do
old-commit-hash: 8ba5d660f38c9d74df208aa79d1c6ae85937f4c5
2024-03-07 14:01:28 -08:00
Shane Smiskol 3af6ec73ee car values formatting (#31747)
values formatting
old-commit-hash: 78a46ce72499ce627c50ff95aa630602e71b8e39
2024-03-06 15:47:44 -08:00
Justin Newberry e6dbf6d614 cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
old-commit-hash: 25ccb2426c0b54dbf823b9e7e6d63607b37d9c5a
2024-03-06 11:22:12 -08:00
Justin Newberry e9ca84c95c platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
old-commit-hash: b0eae8c1b7264b2d0c63ee2957689bc1317616f1
2024-03-01 11:31:51 -08:00
Shane Smiskol 6addeddd6d Car flags: label static flags (#31639)
* comment, consistent source

* no caps not global

* no field

* label rest
old-commit-hash: 690dc55ea26dadb26ed768103baafba47428cda6
2024-02-29 15:36:40 -08:00
Justin Newberry b3bb450e4a add CAR.print_debug (#31652)
print debug
old-commit-hash: ac16c5518a300df5fa31e088a6e2a03d1a0d1747
2024-02-29 15:01:47 -08:00
Shane Smiskol a254be8fe3 Subaru: group steer rate limited with GEN2 (#31640)
* remove sideways diff

* make a subclass

* fix

* fix
old-commit-hash: 5d291cb64d2ff925a13cbf0f783517642929917f
2024-02-29 14:45:31 -08:00
Justin Newberry 9ccd7f15f9 Subaru: move to flags within PlatformConfig (#31584)
* flags

* update ref

* use the flags directly

* use post_init (don't freeze)

* we can maintain frozen with custom class

* not preglobal

* move to common

* cleanup
old-commit-hash: 3a6c3315ab181bf7390ae1faa6e87c93b1a97338
2024-02-28 20:12:14 -08:00
Justin Newberry d6f9e2c805 platformconfig: freeze all dataclasses (#31605)
* frozen

* frozen
old-commit-hash: 9ecff49118a053917b462aac9dd20cadcf56dd1a
2024-02-26 21:16:05 -08:00
Justin Newberry 53a544b029 Subaru: fix forester weight (#31585)
fix weight
old-commit-hash: cdd4d418aaa1516d110e03199f070b3168cb55c6
2024-02-24 23:15:16 -08:00
Cameron Clough 9bd90112d0 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
old-commit-hash: 995250ae4967943ee33a3699a1d89a7a770d95e9
2024-02-24 16:41:23 -08:00
Justin Newberry c564806520 Subaru: move carspecs to PlatformConfig (#31550)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* fix
old-commit-hash: 1161d33c1892b32980a222b7c5b2ad9d6b05621e
2024-02-23 13:23:40 -08:00
Justin Newberry 3d5b7dadaf cleanup PlatformConfig (#31551)
cleanup
old-commit-hash: 73a497ded8b4ae7f1e2d3b5a7c4a2f57c748ff1c
2024-02-22 17:49:27 -08:00
Justin Newberry 27ac28a55f Subaru: move to PlatformConfig (#31547)
* subaru platform config

* forester wrong dbc

* spacing
old-commit-hash: 015eed5d61c583328d419a7990ffac0eee97edd4
2024-02-22 17:17:00 -08:00
Justin Newberry afe8debb81 Subaru: add 2024 forester (#31520)
* also angle based

* 24 forester
old-commit-hash: 51e3daf244306637bfc4031ac75756eee2360ee4
2024-02-20 15:02:56 -08:00
Justin Newberry 6b7039c6bf Subaru: eps is non-essential for gen2 cars (#31220)
* eps non essential

* comment

* suggestions
old-commit-hash: 54fe19206eb3b25432f8ddaf7f39b996c07dbdce
2024-01-29 16:48:03 -08:00
Justin Newberry c8d5ce1517 Subaru: move non-obd requests out of logging (#31174)
enable
old-commit-hash: aff3d5ae091eba2b2ef09f004c6a2b70ee33db06
2024-01-27 09:07:14 -08:00
Justin Newberry ff12759e80 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
old-commit-hash: 28eed156e0a62ab993de6d534bb102a6ede222f7
2023-12-18 14:04:27 -08:00
Justin Newberry a625ca55e7 Subaru: enable alpha longitudinal for gen1 cars (#30714)
* enable alpha long

* update docs

* added footnote about eyesight

* only for these cars

* add alpha

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5f24078a480c9436ce99bf19358b5737aebf065f
2023-12-13 20:17:33 -08:00
Justin Newberry cc625f1a0c Subaru: non-obd FW queries logging (#30552)
* add subaru logging fw

* whitelist + comma

* whitelist is empty for the other requests

* all whitelisted
old-commit-hash: a2bb41e0ec5fd96763e9a01a7116efda059de6e6
2023-11-29 17:47:09 -08:00
Justin Newberry afaddc9ef5 Subaru: add 2023 forester (#30554)
23
old-commit-hash: 44ef143ae7cc855d6f4ce4b8328b90ab4f125fec
2023-11-29 14:53:43 -08:00
Nickolas Komarnitsky 55b1515b75 Subaru: Add FW for 2022 Legacy (#30434)
Update values.py
old-commit-hash: cf2d4fd7ea85034983bb7ce0d3f56e3d79a8949a
2023-11-09 17:42:36 -08:00
Justin Newberry 83038edcbf Subaru: initial eyesight disable support (#30373)
* initial eyesight disable

* disable_eyesight

* comment
old-commit-hash: 60b21b55d28473046825346845b609a5324d945c
2023-11-06 22:13:39 -08:00
Justin Newberry 605b5e264e Subaru: 2019-2020 forester is also rate limited (#30391)
* forester rate limited

* better comment

* better comment
old-commit-hash: ace14698c42e8a1da084a3f2debce043b569a76b
2023-11-06 13:22:58 -08:00
Justin Newberry 7587e8a44f Subaru: improve longitudinal tuning (#30389)
subaru long tuning
old-commit-hash: df79ec531497cec5c8fd7063790787f3ebd2e3f4
2023-11-05 17:53:42 -08:00
Justin Newberry 61b9a58c0e Subaru: forester 2017 fingerprint (#30388)
forester fw
old-commit-hash: 0fbc36bce19a7fb7a57484488bed16f07a51c888
2023-11-05 01:21:46 -07:00
Justin Newberry 05e1de5c76 Subaru: 2015 outback fingerprint (#30387)
subaru outback fw
old-commit-hash: 1463fd3917a9aa3ba556e82e411935eecb959ab6
2023-11-04 22:31:09 -07:00
Justin Newberry 6a472937da Subaru: 2016 legacy fingerprint (#30386)
legacy fw
old-commit-hash: b791c0296b5a57ab031cbae924446ec732eecb9f
2023-11-04 22:09:43 -07:00
Stephen Marin 9b83190ffb Subaru: Fingerprint for 2021 Outback XT (#30380)
* Fingerprint for 2021 Outback XT

* that one already exists

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 240f43b42166effa179494b5502ca7f5a18981a2
2023-11-04 22:04:54 -07:00
Justin Newberry c8ebd08c62 Subaru: 2021 impreza fingerprint (#30249)
old-commit-hash: 998763b4bced0ef787aac3be9c46307bd287ddbc
2023-10-15 17:15:41 -04:00
Justin Newberry 4d732ad439 Subaru: Outback 2023 fingerprint (#30190)
fingerprint
old-commit-hash: 7f945f10c65b445f630b970ddf4b245d917d5448
2023-10-05 17:15:26 -07:00
Justin Newberry 5eabb35a53 Subaru: crosstrek hybrid is a B harness (#30150)
its a b harness
old-commit-hash: 8cc8952d819740436ef9a53d618437c420819d5b
2023-10-03 13:29:07 -07:00
Justin Newberry 58936aa0cb Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
old-commit-hash: 6ae465e4af76e21c6a31c541f37555f6bd0727fc
2023-09-30 17:15:34 -07:00
Justin Newberry 1b35278d95 Subaru: remove 2020+ temporary steering faults (#29116)
* subaru steer faults

* it takes a bool now

* Update selfdrive/car/subaru/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* that was removed

* should be abs

* bump panda

* bump panda

* subaru faults

* add fixme

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* review suggestions

* still want zero steer when lat not active

* bump submodules

* move it under the non-preglobal section

* better comment for steer limited

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fb06b98667483bbf9d62b16d7f5aa5e50721f597
2023-09-07 15:28:46 -07:00
Justin Newberry 8b7c706ff3 Subaru: impreza 22 fingerprint (#29765)
add fingerprint
old-commit-hash: f4f92f1a2fba9358f7a529b9f5c28d90c9691d08
2023-09-03 13:12:31 -07:00
martinl 5f1528708e Subaru: Ascent 2023 dashcam mode (#27583)
* Subaru: Add support for 2023 Ascent

* Update supported cars list

* Remove tester present from fw query

* merge master

* fix merge issues

* minimize diff

* add comment about 23 ascent

* add comment

* correct spot

* fix name

* nocap

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: a1bf66a0d26574eabf322ce139142a6db92c9098
2023-08-25 20:55:21 -07:00
Shane Smiskol acec4fc22f Subaru: Forester Hybrid 2020 dashcam (#24770)
* Add support for Forester Hybrid 2020

Co-authored-by: martinl <martin@mlp.ee>

* it's a param now

* make it work

* fix

* merge and cleanup

* remove duplicate

* should be forester

* bump submodules

* should be abs

* add missing params

* still need a test route

* still need a test route

* consitent

* here too

* todo

* more

* Update selfdrive/car/tests/routes.py

* clean up

---------

Co-authored-by: martinl <martin@mlp.ee>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 3719be8b76f81068da3aadd5bd0f76e8a4d00396
2023-08-23 21:30:12 -07:00
Adeeb Shihadeh 56facfcc5a Subaru: Crosstrek Hybrid dashcam mode (#25378)
* Subaru: Crosstrek Hybrid support

* hybrid cars in dashcam only

* revert that

* just dashcam

* tah should be abs

* remove unused import

* use the old dbc for now

* hybrid car exceptions in carstate

* need dashstatus until we get a proper cruiseactivated bit

* missing CP

* merge conflicts

* lets be consistent about extend

* cleanup

* fix and comments

* preglobal fix

* and the rest

* and this

* added hybrid to release

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 973d90be779efc0e4a83eeab213c0cc9b4d711ce
2023-08-23 18:50:55 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Justin Newberry 7faefd677b Subaru: Global gen1 experimental longitudinal (#28872)
* Add longitudinal support for Subaru Crosstrek and Impreza

* Update experimentalLongitudinalAvailable check

* Update supported cars list

* bump panda

* Remove/rename es_lkas_msg to es_lkas_state_msg

* Use stockAeb for AEB passthrough

* bump panda

* bump panda

* remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* bump panda

* bump panda

* update poetry deps: shellingham

* bump panda

* bump panda

* Revert "update poetry deps: shellingham"

This reverts commit 6e9b20964890c8a5c416a17b8aaad4cc16fddcfc.

* Merge fixes

* bump panda

* bump panda

* update supported cars list

* dont use counters for long control

* fix unittests

* submodules update

* only soft disable in long control

* use common functions and cleanup

* apply hystersis correctly

* move to comma repo

* use CanBus

* cleanup

* explicit copy

* behind a flag

* remove unrequired rpm checks

* add comment

* fix flag issue

* we still need to check rpm

* update docs

* enable long for a test route

* unit tests

* inactive throttle fix

* Update subarucan.py

* Update carcontroller.py

* Update carcontroller.py

* inactive throttle fix

* Delete settings

* fix rate limit

* bump submodules

* bump panda

* bump panda

* bump panda

* bump panda

* simplify initial implementation, remove AEB

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* fix fwd hook test

* show pcb off warning

* cleanup and setup for tuning

* fix sumobuldes

* revert unrelated changes

* only whats required

* only whats required

* clean that up

* better comments

* behind the flag for now

* comments and minimize diff

* align stuff

* cleanup for PR

* apply review suggestions

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
old-commit-hash: d6c682b40168241e481aa2904198ac29c8d1a73e
2023-08-16 12:58:09 -07:00