Commit Graph

93 Commits

Author SHA1 Message Date
Greg Hogan f646a64cce Honda CRV BSM alert from B-CAN (#1867)
old-commit-hash: 825821f010db63c3498d3730069f3eac08ace789
2020-07-21 17:41:45 +02:00
cfranhonda 0059e653f0 Update civic bosch longitudinal tuning (#1875)
These are the correct values when i was testing visionradar. Things got messed when Civics were coded together and got split up again.
old-commit-hash: 1613abb0b15e24e3d0ddec3efdbd0d61581e6d2b
2020-07-20 17:03:20 +02:00
Adeeb 8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Willem Melching 3df1a2c681 Fix low speed engage on stop and go Hondas (#1613)
* fix low speed engage on stop and go Hondas

* update ref commit
old-commit-hash: f575a9ec12990ac2a764a5f416795d1c618f4609
2020-06-01 10:14:11 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Willem Melching e048a1f054 Add alternate Accord tuning
old-commit-hash: 02c130731c2c041cbe95cef8717a93a0b6d67b48
2020-05-31 13:37:55 -07:00
Adeeb 48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
Shane Smiskol eb99eae1f6 remove redundant ret.steerControlType line, fix indentation in toyota/carcontroller.py (#1442)
old-commit-hash: e7ae7b98501d4061efcf0d9161535d029d3c3c64
2020-04-30 14:11:31 -07:00
cowanhmoore 8fa7d31138 Honda HRV (#1404)
* PR - Honda HRV

values.py - incl. Class, FP, FW_VERSIONS, SPEED_FACTOR 1.025
carstate.py - incl. carFingerprint, doorOpen OVERRIDE (signal unknown)
Safety test concludes that removal of drivers seatbelt IMMEDIATELY disengages OP
interface.py - incl. HR-V vehicle parameters, tuning (tested for 100+ miles)
Longitudinal tuning parameters unchanged from CAR.FIT
test_car_models.py - added per request of review process
*5. honda_hrv_touring_2019_can_generated.dbc will be submitted to commaai/opendbc in next PR

Once *5 is approved, will need to update values.py to matching dbc

Thanks, Cowan Moore 330-701-3922

* Honda HRV Door Signal

BO_ 422 SCM_BUTTONS: 8 SCM
 SG_ DRIVERS_DOOR_OPEN : 63|1@0+ (1,0) [0|1] "" EON

* Update values.py

* Update test_car_models.py
old-commit-hash: 1d6042c5f35dc2e5c2b6b8aeaca51ef8348c69b5
2020-04-20 15:30:46 -07:00
Adeeb 15916d03f4 Abstract pcmEnable and pcmDisable events (#1350)
* don't need individual prev state vars since whole CS is copied

* don't need a whole function since toyota alerts were simplified

* better here

* abstract pcmEnable/pcmDisable events

* the flippening came to NEOS

* delete

* unused

* Revert "the flippening came to NEOS"

This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
old-commit-hash: 8d791d78dd4fbc973eb61ccd9df2ed4cf9bbbcd5
2020-04-10 16:12:58 -07:00
Chris Souers a5927023db Adds 2016 CR-V Executive (Euro version of Touring trim) (#1097)
Co-authored-by: Ted Slesinski <ted_slesinski@epam.com>
old-commit-hash: 035397cd319cb1c08a7fea7735c0b575a1094fc7
2020-03-13 11:48:08 -07:00
rbiasini 5849f719ef abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
old-commit-hash: fe911bcca8ece66cfeec1eda353fa9bd658cd2bf
2020-03-08 23:35:00 -07:00
theantihero 976a4197ad Add 2019 Honda Insight (#1166)
* add 2019 Honda Insight + fw fp

* add actual fp and add to ignored, but still required for ECU detection

* add Insight dirty route for now

* update README.md, was wrong mph for each

* update test_car_models

* remove dbc extension

old-commit-hash: c8c4708f21652218644e981185a808ea911de869
2020-02-27 14:56:36 -08:00
rbiasini 8fc38619c0 Abstract gasPressed for all cars (#1151)
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event

* move lines a bit

* more GM cleanup

* typo

* move espDisabled to carState packet

* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed

* ops, wrong change

* bug

* update cereal

* update ref
old-commit-hash: 9685a5a74318dc168cf4f3da994f983df5db08c0
2020-02-21 18:24:37 -08:00
Chris Souers 53dbe430a8 Add support for 2019 Civic Sedan 1.6L Diesel with CVT (#1091)
add car

Update test_car_models.py

Update test_car_models.py

add firmware

Update README.md

Update test_car_models.py
old-commit-hash: ba6f555ede7cd3f0daf94bf413511b409dd4a9d6
2020-02-21 11:03:10 -08:00
Adeeb 65a2c62114 Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref

old-commit-hash: e8cb6ea06a2470dd89a6ad8fd17bd1d1b62034cc
2020-02-20 16:22:25 -08:00
rbiasini b495a36507 Abstract std params (#1138)
* get_can_parser and get_cam_can_parser are now standard static methods
old-commit-hash: af39d74a5bad29660e244daf0ed000b1183458bc
2020-02-20 14:06:02 -08:00
rbiasini 5375a08920 get_can_parser and get_cam_can_parser are now standard static methods (#1136)
old-commit-hash: dc3ea9b08d831203d31294eb37e88a682ae9d79a
2020-02-20 13:08:43 -08:00
Adeeb 0468c42f22 Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw

old-commit-hash: 13f60eae91764a2cdc7405e323381dcf971b11c3
2020-02-19 20:37:07 -08:00
Greg Hogan c58361fbcb WIP: Honda Steering Improvements (#983)
* move honda steer params to CarParams

* use breakpoints/values from firmware

* remove comment

* civic fw mod max included deadzone

* civic bosch needs to be separate

* script to measure steering accuracy

* civic tuning

* update cr-v values

* cleanup

* averaging over 10 samples was silly

* update stock civic and cr-v tuning

* remove comment

* update replay expected results

old-commit-hash: 57c44e3705a2e442a169ab9da5571aab4ef16ae4
2020-02-19 13:28:01 -08:00
rbiasini 6209ad5120 Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>

old-commit-hash: 0c67143c925f3ead6c3e88675e4fcfa4fa3f9c28
2020-02-18 15:28:15 -08:00
Adeeb cf26bb52b5 Clean up ECU redundancy in selfdrive/car/* (#963)
* clean up ecu redundancy in selfdrive/car

* clean up gear parsing

old-commit-hash: dafdb79db2
2020-01-18 23:35:10 -08:00
George Hotz 9ef085076b selfdrive/car
old-commit-hash: 71ead9adea
2020-01-17 10:58:43 -08:00
George Hotz 81dd5a50cf root commit
old-commit-hash: 6c33a5c1f3
2020-01-17 10:02:52 -08:00
Vehicle Researcher fa4b6f33d1 openpilot v0.7.1 release
old-commit-hash: 8da8b6135c
2020-01-15 14:05:04 -08:00
Vehicle Researcher 99b637c7ce openpilot v0.7 release
old-commit-hash: c025b96e8a
2019-12-13 13:03:08 -08:00
Vehicle Researcher 89d1d84c70 openpilot v0.6.5 release
old-commit-hash: cf80f7a28b
2019-10-09 18:43:53 +00:00
Vehicle Researcher dfe603c178 openpilot v0.6.4 release
old-commit-hash: 61229779e4
2019-09-09 23:03:02 +00:00
Ted Slesinski 24829da756 Adds 2018 Honda Fit support (#266)
* Fit rebased on latest devel

* Added new objects for fit to values.py

* Update readme

* Updated formatting of fingerprint to match others

* Update cargo variable

Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>

* Added tire stiffness, renamed PID kp/ki variables

Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>

* Renamed longitudinal KpBP

Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>

* Renamed longitudinal kpV

Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>

* Renamed longitudinal KiBP variable

Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>

* Renamed longitudinal KiV

Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>

* Set more realistic value for tire stiffness

* CR-V Hybrid doc duplicate

old-commit-hash: c73464f67f
2019-08-27 15:19:25 -07:00
Vehicle Researcher 02cedeadd9 openpilot v0.6.3 release
old-commit-hash: d5f9caa82d
2019-08-13 01:36:45 +00:00
Vehicle Researcher 3835061760 openpilot v0.6.2 release
old-commit-hash: e90c41c576
2019-07-30 02:27:48 +00:00
Vehicle Researcher 07aa8b1bf3 openpilot v0.6.1 release
old-commit-hash: 94053536b4
2019-07-22 19:17:47 +00:00
dekerr ae1fbf70fa Refactor default Civic params (#720)
* move civic params out

* fix variable name

* simplify ford scaling

* cleanup

* remove import dependency

* requested changes

* keep hyundai

old-commit-hash: 4a48ef8dbc
2019-07-08 16:59:32 -07:00
Vehicle Researcher 9abcfabc5f openpilot v0.6 release
old-commit-hash: 8a9ed94f5f
2019-06-28 21:11:30 +00:00
dekerr 442711d597 update vals (#705)
old-commit-hash: 36881b6410
2019-06-20 12:22:30 -07:00
Vehicle Researcher e47a2e6e30 openpilot v0.5.13 release
old-commit-hash: dd34ccfe28
2019-06-06 04:38:45 +00:00
Vehicle Researcher 0932b367bd openpilot v0.5.12 release
old-commit-hash: 3f9059fea8
2019-05-16 13:20:29 -07:00
Vehicle Researcher 83dfc3ca1f openpilot v0.5.11 release
old-commit-hash: 2f92d577f9
2019-04-23 01:41:19 +00:00
eFini 0efda5770b Add port for 2019 Honda CRV Hybrid (China ver) (#596)
* 2019 honda crv hybrid port (china version)

* adjust mass based on spec

* update mass based on spec

* add 2019 Honda CRV Hybrid

old-commit-hash: 7978afabe5
2019-04-09 17:35:57 -07:00
eFini 4d8a08a828 Add Port for 2019 Honda Odyssey Exclusive (China version) (#592)
* Port for 2019 Honda Odyssey China ver

* update as per comments

old-commit-hash: e89fd1236f
2019-04-08 17:58:56 -07:00
Vehicle Researcher 2cc4edde68 openpilot v0.5.9 release
old-commit-hash: 0207a97040
2019-02-20 01:39:02 +00:00
Vehicle Researcher 3bde47d556 openpilot v0.5.8 release
old-commit-hash: b967da5fc1
2019-01-23 15:34:52 -08:00
Chris Souers f1f9cf6b45 Merge new 2019 Civic and existing 2017-18 Civic Hatch (#446)
* fingerprint and new car

* you know the drill

* fix

* mod civic hatch to work for now

* try to merge hatch and other bosch

* fix

* fixed spaces

* comma (heh)

* make mass civic

* Add to readme. Need to confirm speed

* steering dropout at ~3.3 kph

* Remove additional fingerprint

* combined comment. fixed formatting to match

old-commit-hash: 9eb1666a52
2019-01-11 17:13:57 -08:00
Vehicle Researcher f8ce921247 openpilot v0.5.7 release
old-commit-hash: 210db686bb
2018-12-10 14:13:12 -08:00
rbiasini fd79d0150a Honda Nidec: avoid giraffe setting alert when car is turned off (#449)
old-commit-hash: 9d76070ab7
2018-11-29 20:36:34 -08:00
Vehicle Researcher fdbf213be8 openpilot v0.5.6 release
old-commit-hash: 860a48765d
2018-11-17 02:08:34 -08:00
rbiasini 187a86bfcf Revert "Honda Pilot tuning / lane centering fixes (#408)" (#433)
This reverts commit 75ba15021bed3fbb8c1bfd5a27eb0efa354ca965.
old-commit-hash: b4dd562c43
2018-11-13 14:36:29 -08:00
kegman 75a3aeba45 Honda Pilot tuning / lane centering fixes (#408)
Tuned kP and kI and Tire Stiffness Factor settings.
Fixes lane centering issues in the following situations:
1.  Hugging of left lane line during fast left curving roads
2.  Hugging of right lane line during fast right curving roads
3.  Left bias in fast lane on crowned roads (sloping down to the left)
4.  Right bias in slow lane on crowned roads (sloping down to the right)
Works better when lane_width = 2.85 (vs 3.7 default) in pathplanner.py
old-commit-hash: fdbf1c5938
2018-10-31 11:09:48 -07:00