68a3061c9d
enable E261 in flake8: two spaces before inline comment
...
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
5e857427ba
Enable more flake8 checks ( #1602 )
...
* enable some more flake8 checks
* some more quick ones
* bump opendbc
* e401
* e711 e712
* e115 e116
* e222
* e301
* remove that
* e129
* e701 e702
* e125 e131
* e227
* e306
* e262
* W503
* e713
* e704
* e731
* bump opendbc
* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
6fbcde48e5
Using lgtm.com and fixing found alerts ( #1452 )
...
* lgtm in readme, and mac nui fixes
* call super inits in radars
* unused imports, dup lines
* more radars, more unused imports
* pass CP into RadarInterfaceBase
* more fixups
* unused imports
* delete unused lines
* ugh, new unused import
Co-authored-by: George Hotz <geohot@gmail.com >
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00
0468c42f22
Abstract CarInterface init ( #1131 )
...
* abstract CarInterface init
* unused
* subaru
* gm cleanup
* vw
* typo
* carcontroller
* more cleanup
* fix vw
old-commit-hash: 13f60eae91764a2cdc7405e323381dcf971b11c3
2020-02-19 20:37:07 -08:00
9ef085076b
selfdrive/car
...
old-commit-hash: 71ead9adea
2020-01-17 10:58:43 -08:00
81dd5a50cf
root commit
...
old-commit-hash: 6c33a5c1f3
2020-01-17 10:02:52 -08:00
99b637c7ce
openpilot v0.7 release
...
old-commit-hash: c025b96e8a
2019-12-13 13:03:08 -08:00
89d1d84c70
openpilot v0.6.5 release
...
old-commit-hash: cf80f7a28b
2019-10-09 18:43:53 +00:00
dfe603c178
openpilot v0.6.4 release
...
old-commit-hash: 61229779e4
2019-09-09 23:03:02 +00:00
07aa8b1bf3
openpilot v0.6.1 release
...
old-commit-hash: 94053536b4
2019-07-22 19:17:47 +00:00
9abcfabc5f
openpilot v0.6 release
...
old-commit-hash: 8a9ed94f5f
2019-06-28 21:11:30 +00:00
e47a2e6e30
openpilot v0.5.13 release
...
old-commit-hash: dd34ccfe28
2019-06-06 04:38:45 +00:00
3ad68e4378
getting ready for Python 3 ( #619 )
...
* tabs to spaces
python 2 to 3: https://portingguide.readthedocs.io/en/latest/syntax.html#tabs-and-spaces
* use the new except syntax
python 2 to 3: https://portingguide.readthedocs.io/en/latest/exceptions.html#the-new-except-syntax
* make relative imports absolute
python 2 to 3: https://portingguide.readthedocs.io/en/latest/imports.html#absolute-imports
* Queue renamed to queue in python 3
Use the six compatibility library to support both python 2 and 3: https://portingguide.readthedocs.io/en/latest/stdlib-reorg.html#renamed-modules
* replace dict.has_key() with in
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#removed-dict-has-key
* make dict views compatible with python 3
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#dict-views-and-iterators
Where needed, wrapping things that will be a view in python 3 with a list(). For example, if it's accessed with []
Python 3 has no iter*() methods, so just using the values() instead of itervalues() as long as it's not too performance intensive. Note that any minor performance hit of using a list instead of a view will go away when switching to python 3. If it is intensive, we could use the six version.
* Explicitly use truncating division
python 2 to 3: https://portingguide.readthedocs.io/en/latest/numbers.html#division
python 3 treats / as float division. When we want the result to be an integer, use //
* replace map() with list comprehension where a list result is needed.
In python 3, map() returns an iterator.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* replace filter() with list comprehension
In python 3, filter() returns an interatoooooooooooor.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* wrap zip() in list() where we need the result to be a list
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-zip
* clean out some lint
Removes these pylint warnings:
************* Module selfdrive.car.chrysler.chryslercan
W: 15, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 16, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 25, 0: Unnecessary semicolon (unnecessary-semicolon)
************* Module common.dbc
W:101, 0: Anomalous backslash in string: '\?'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
************* Module selfdrive.car.gm.interface
R:102, 6: Redefinition of ret.minEnableSpeed type from float to int (redefined-variable-type)
R:103, 6: Redefinition of ret.mass type from int to float (redefined-variable-type)
************* Module selfdrive.updated
R: 20, 6: Redefinition of r type from int to str (redefined-variable-type)
old-commit-hash: 9dae0bfac4
2019-05-02 11:08:59 -07:00
83dfc3ca1f
openpilot v0.5.11 release
...
old-commit-hash: 2f92d577f9
2019-04-23 01:41:19 +00:00
b406c7fb22
GM: Cadillac ATS Coupe 2018 support ( #445 )
...
* GM: Cadillac ATS Coupe 2018 support
* Missed adding Cadillac ATS
old-commit-hash: 024870d16a
2018-12-06 21:22:21 -08:00
582cc400cf
Adding support for 2018 GMC Acadia Denali ( #453 )
...
* added acadia
* adding acadia
* adding acadia
* Update radar_interface.py
* adding acadia
* refactored
* fixed tuning
* Adding acadia
* Update interface.py
* fixed whitespace
* fixed whitespace
old-commit-hash: 68e56c8017
2018-12-04 08:35:36 -08:00
a7dcbc2e33
Add initial support for Holden/Opel Astra BK ( #431 )
...
old-commit-hash: c9dd7fe0e6
2018-11-20 20:12:50 -08:00
fdbf213be8
openpilot v0.5.6 release
...
old-commit-hash: 860a48765d
2018-11-17 02:08:34 -08:00
aa512e987a
GM: disengage on radar fault ( #396 )
...
* GM: copy cadillac's radar header DBC
* Remove unused interface imports
* Rename num targets message to radar header
* Catch various radar faults
old-commit-hash: 3d05cca678
2018-10-23 18:59:34 -07:00
242328f92c
openpilot v0.4.7 release
...
old-commit-hash: ae5cb7a0da
2018-06-16 20:59:34 -07:00
Adeeb Shihadeh