Commit Graph

134 Commits

Author SHA1 Message Date
Robbe Derks 58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d425e2a5dc61d09571933cffb9536113
2021-10-08 17:54:34 +02:00
Willem Melching 6dea543246 Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
old-commit-hash: 6c29a4c7fb83f9a4935d6003970b6b3442cccfd8
2021-10-07 16:37:02 +02:00
John Belmonte d9aa78a6bb Car Port: Honda Freed 2020 (#22003)
* car port: Honda Freed

Popular 3-row compact minivan in Japan based on Fit platform.

test route: 2c4292a5cd10536c|2021-08-19--21-32-15

* missing DRIVERS_DOOR_OPEN signal on FREED

* remove redundant long parameters

* additional FW; confirm lack of stop-and-go

* restore gateway ECU to fingerprint

* corrected mass and wheelbase

* add another forwardRadar id
old-commit-hash: edabca193d011f2f8bcfd1bb84c67f265df17f09
2021-09-24 17:11:47 -07:00
Willem Melching e082d60ce4 set Honda Bosch long lag to 1s (#22335)
* set Honda Bosch long lag to 1s

* update ref
old-commit-hash: c68fc8ef9c82989d941ed01f6838c420710c8e96
2021-09-24 10:28:00 -07:00
Adeeb Shihadeh 821f1f6cb6 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
old-commit-hash: 649af76fd4ade524df8eb6c56cc8bb09b3772e7c
2021-09-23 17:34:52 -07:00
Willem Melching a8ce1288fd Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
old-commit-hash: c4bac6bd68ce2a91beb15bb4f4472d76525288e0
2021-09-13 22:03:08 -07:00
Willem Melching b079219b93 Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
old-commit-hash: 1e62b09e5dd70cae6721d2da9f7bcef59aa87c10
2021-09-11 17:13:30 -07:00
HaraldSchafer cb1cd01bdf cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
old-commit-hash: 74b6c872545ac64055a914789a89ccc173168d8b
2021-09-10 10:34:18 -07:00
vanillagorillaa 1349e159e7 Honda e Port (#22108)
* Honda e Port

* Test route for Honda e

* remove

* Update README.md

* update values based on logs

* no need for Honda e specific DBC

* fix tests

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: bcb8a11d7fe3868535bb7a66fcb767885c21a5e6
2021-09-07 16:46:44 -07:00
Willem Melching 6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcdc9d651fe7169044fb7f52fd70f94ab
2021-09-06 17:29:32 -07:00
HaraldSchafer 1b98341932 Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
old-commit-hash: ebf2a2279d837feb3ce55a7bc44c7f0053e77f27
2021-09-02 14:16:44 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh b3e3708dbc Revert 2021 Accord (#22063)
* bump panda

* Revert "Car Port: 2021 Accord 2.0 Touring & Hybrid Touring (#22007)"

This reverts commit b305a94049606c7a92aebf0e50dc21eda58aa017.

* revert release notes

* bump panda
old-commit-hash: 4be956f8861ecbb521ef9503a3c87b07c9d36721
2021-08-28 21:28:14 -07:00
Adeeb Shihadeh 3c4005ed10 Car Port: 2021 Accord 2.0 Touring & Hybrid Touring (#22007)
* Add 2021 Accord 2.0 Touring & Hybrid Touring

- Create the HONDA_BOSCH_EXT set for HONDA_BOSCH cars that utilize the new extended IDs for LKAS_HUD

* Remove ids added to the wrong car

* add comment

* fix undefined signal

* fix tests

Co-authored-by: Chris Souers <csouers@gmail.com>
old-commit-hash: 7e53a42984b38eb45cad8628c225ded3f843d4bb
2021-08-22 12:50:58 -07:00
Adeeb Shihadeh 760cdcd896 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
old-commit-hash: 9e03aa0b92fd846bc643040fa8b8d4ab06ee2855
2021-08-22 00:27:48 -07:00
HaraldSchafer 6bed02373e Remove acura (#21946)
* treat acura like nidec

* treat acura like nidec
old-commit-hash: 1c6c56a9dfa7308d31c24ac20a07baa73ac41059
2021-08-17 11:44:22 -07:00
HaraldSchafer 6fa8d389f3 Change long control honda pilot, ridgeline, honda fit, civic, ilx (#21886)
* not used

* just use gas

* allow gas

* try 0

* typo

* set to default

* set default

* makes more sense

* downtune and cleanup

* max accel always

* that is needed to smooth gas to brake

* try downtuning low speed

* try from default

* nidec is not bosch

* air resistance exists

* more smoothing

* wind brake sooner

* Civic experiments2 (#21862)

* control on throttle

* throttle modifier

* get acura in line

* try set speed control again (#21870)

* new acura function

* put back

* put back

* make linter happy

* define wind_brake once

* Civic experiments (#21908)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* Civic experiments (#21910)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* add acura control

* more cleanup

* cleanup

* update ref

* clip

* seems to fault

* always continuous

* new ref
old-commit-hash: a8f3e2b3c26f2b617a1c9c94250b44adce861d04
2021-08-11 18:32:37 -07:00
HaraldSchafer 285d015e5a hard honda max accel in car interface (#21585)
* hard set in car interface, not related to planning

* move to values
old-commit-hash: b8a4adfb2f68e93c63f95935bd2fff2a3a40c20f
2021-07-14 11:06:29 -07:00
HaraldSchafer 91d5b10426 less accel (#21565)
* less accel

* new refs

* Update longitudinal_planner.py

* update refs
old-commit-hash: a42d8f3a14132c3c0826ed106d61a617ce41936e
2021-07-12 18:30:56 -07:00
Adeeb Shihadeh 7c9ce25b05 Honda: keep braking after PCM disables cruise (#21510)
* Honda: keep braking after PCM disables cruise

* update refs
old-commit-hash: 6d9dc9945a9334cb8554fe6e1617f93a2415ae73
2021-07-11 19:31:09 -07:00
Adeeb Shihadeh b7c1b9a6e8 rename enableCruise -> pcmCruise (#21546)
old-commit-hash: cb7e96f99d59cc56ac532d4b5e08e03c013cf946
2021-07-10 13:56:11 -07:00
HaraldSchafer 96d4bfbff3 Refactor long (#21433)
* refactor

* needs casting

* tests pass

* fix that test

* refactor in controls

* lets not go crazy

* change of names

* use constants

* better naming

* renamed

* soft constraints

* compile slack variables

* rm git conflict

* add slack variables

* unused

* new edition

* fcw

* fix tests

* dividing causes problems

* was way too slow

* take a step back

* byeeee

* for another time

* bad idxs

* little more cpu for cruise mpc

* update refs

* these limits seem fine

* rename

* test model timings fails sometimes

* add default

* save some cpu

* Revert "little more cpu for cruise mpc"

This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.

* Revert "test model timings fails sometimes"

This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.

* update refs

* less cpu

* Revert "Revert "test model timings fails sometimes""

This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.

* Revert "less cpu"

This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.

* cleanup

* not too much until we clean up mpc

* more cost on jerk

* change ref

* add todo

* new ref

* indentation
old-commit-hash: be5ddd25cd3f4c8b7e46cdeecf303e2c73301003
2021-07-07 19:42:26 -07:00
Adeeb Shihadeh 691ea8553f deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
old-commit-hash: c72d163e142d90edac5086892c0cd297bdc636fe
2021-07-07 14:59:18 -07:00
Willem Melching 5bc0d28708 Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
old-commit-hash: a8fac002ae8e7c6ab37e9b1a5deb8cfcea2a71ac
2021-06-22 16:28:11 +02:00
Greg Hogan d0e5f3fb92 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 8071111f59371c9aee16dee3d6fb87f42464894b
2021-06-15 14:00:57 +02:00
Adeeb Shihadeh ff875ae2df Fix Honda Accord transmission type detection (#21247)
old-commit-hash: af8d4176271c0ecc972d1e8d437aa1707abaf5d1
2021-06-12 20:52:50 -07:00
ShaneSmiskol eca70237fd Merge Accord trims (#21105)
* Merge unique Accord 1.5 fw versions

* remove all instances of ACCORD_15

* bump opendbc and update dbcs

* Switch between gearbox messages by detecting presence of gearbox msg

* both accord (2t) and accord hybrid use the same gearbox, 1.5t is the outlier

* default to GEARBOX

* add old name to migration

* bump opendbc

* update refs

* change msg name, bump cereal

* Update selfdrive/test/test_routes.py

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: e9e197eb3c5f3714134ebfc104c2e4523fe57177
2021-06-03 13:35:23 -07:00
Adeeb Shihadeh d1422c20fc Honda: cleanup enable logic (#20749)
old-commit-hash: a69e1715d4daa1eea41d15764a763d082e249235
2021-06-03 01:49:33 -07:00
ShaneSmiskol 0d45e6885a Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 551091bcfa46e50ef60dac3f3bdff299dba95f35
2021-05-18 17:48:02 -07:00
Willem Melching 41950a9f8a Cleanup HONDA_BOSCH alternate brake signal (#20901)
* Cleanup HONDA_BOSCH alternate brake signal

* always set self.brake_switch

* define in one place

* also defined here

* nesting

* remove CRV Hybrid

* rename brake_switch_ts

* add note about panda safety
old-commit-hash: 245312370f9fd6c36fc197147f6d2037500bc1f3
2021-05-18 14:13:22 +02:00
Willem Melching b8e1d18f8e CRV Hybrid doesn't use alternate brake signal (#20945)
old-commit-hash: 4215f63769fd6f350194cf5b6c9607cce40e18e0
2021-05-18 12:16:08 +02:00
Adeeb Shihadeh 7546f7d084 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
old-commit-hash: 6c7ed8f2e4a3769c12e61be57e802920b84dcc29
2021-04-25 12:52:16 -07:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
Samuel Coles c077c9f9ae Honda Fit Tune (#20094)
This commit lowers the kp and ki values for lateral tuning. This fixes the wheel shake, greatly increases straight line performance, and produces more human like driving on long curves.
old-commit-hash: 4c2efb4e7e658064d6399eb5be484b0d5fdb4431
2021-02-16 16:15:44 -08:00
Chris McCammon 28c24071e5 Honda Odyssey tune (#20058)
old-commit-hash: 012fa35096c3b5d808160e30a245d8379e7f804a
2021-02-10 16:35:18 -08:00
Adeeb Shihadeh 966945880b Cereal cleanup (#20003)
* start cleanup

* fan speed

* cleanup dm

* fix cereal

* hwType -> pandaType

* update refs

* update refs

* bump cereal

* freeSpacePercent

* cereal master
old-commit-hash: 000bd226aa9902da01e6010bf26762fca2c20df0
2021-02-03 19:57:30 -08:00
Igor 95bb79c51c Parametrize MIN_CAN_SPEED in car interfaces (#2684)
* Parametrize MIN_CAN_SPEED in car interfaces

* fixed instance in planner.py

* fix typo

* var name change

* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files

* added default value to get_std_params, removed unneeded instances from car interface files

* Revert PEP8 autoformat corrections

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 093456cc40f2bafac6a36491cac8e57db42ee9e5
2020-12-04 11:09:34 +01:00
Ted Slesinski c3a745eb90 Reduce Kp/Ki by 30% to eliminate steer oscillation (#1985)
old-commit-hash: 36391bf12fb88fc15626c9ba3ed5cb3925a39c1b
2020-11-16 15:25:43 -08:00
Adeeb Shihadeh f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f598639307994392e96f4d9293b295c7
2020-11-03 19:56:25 -08:00
Chris Souers 747de9f80f Add 2020 Acura RDX (#1557)
Update CAN Fingerprint

Update files_common

Update test_car_models.py
old-commit-hash: dc8b5538e858d4435fa636705ca3bb592999dcde
2020-10-18 19:03:04 -07:00
Greg Hogan 659b82c469 pre-reqs for honda bosch longitudinal control (#1458)
* pre-reqs for honda bosch longitudinal control

* openpilot_longitudinal_control -> radar_disabled

* fix chrysler test

* review feedback

* little cleaner

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 0902575e3422da15454224a627650a1096d4c682
2020-09-29 00:04:15 -07:00
Greg Hogan f646a64cce Honda CRV BSM alert from B-CAN (#1867)
old-commit-hash: 825821f010db63c3498d3730069f3eac08ace789
2020-07-21 17:41:45 +02:00
cfranhonda 0059e653f0 Update civic bosch longitudinal tuning (#1875)
These are the correct values when i was testing visionradar. Things got messed when Civics were coded together and got split up again.
old-commit-hash: 1613abb0b15e24e3d0ddec3efdbd0d61581e6d2b
2020-07-20 17:03:20 +02:00
Adeeb 8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Willem Melching 3df1a2c681 Fix low speed engage on stop and go Hondas (#1613)
* fix low speed engage on stop and go Hondas

* update ref commit
old-commit-hash: f575a9ec12990ac2a764a5f416795d1c618f4609
2020-06-01 10:14:11 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Willem Melching e048a1f054 Add alternate Accord tuning
old-commit-hash: 02c130731c2c041cbe95cef8717a93a0b6d67b48
2020-05-31 13:37:55 -07:00
Adeeb 48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00