Commit Graph

97 Commits

Author SHA1 Message Date
Robbe Derks 58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d425e2a5dc61d09571933cffb9536113
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh 821f1f6cb6 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
old-commit-hash: 649af76fd4ade524df8eb6c56cc8bb09b3772e7c
2021-09-23 17:34:52 -07:00
Willem Melching b079219b93 Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
old-commit-hash: 1e62b09e5dd70cae6721d2da9f7bcef59aa87c10
2021-09-11 17:13:30 -07:00
Willem Melching 6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcdc9d651fe7169044fb7f52fd70f94ab
2021-09-06 17:29:32 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
Jason Young 5acd7306e7 GM: Correctly handle EPS warning vs error states (#21641)
old-commit-hash: f5d9216a01dfc5b8cde88ab07bf0cfae6cf7bffd
2021-07-18 12:50:50 -07:00
Adeeb Shihadeh b7c1b9a6e8 rename enableCruise -> pcmCruise (#21546)
old-commit-hash: cb7e96f99d59cc56ac532d4b5e08e03c013cf946
2021-07-10 13:56:11 -07:00
Dave 1ef1b65ca3 Add Acadia Denali 2018 fingerprint (#21545)
old-commit-hash: c0e25a8f295c4129c178229dcf43bb5d2cd1cfae
2021-07-10 13:23:55 -07:00
Adeeb Shihadeh 691ea8553f deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
old-commit-hash: c72d163e142d90edac5086892c0cd297bdc636fe
2021-07-07 14:59:18 -07:00
Greg Hogan d0e5f3fb92 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 8071111f59371c9aee16dee3d6fb87f42464894b
2021-06-15 14:00:57 +02:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Jason Young 51db9216f2 Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
old-commit-hash: 83ca5a0d29a5befa210f60a60e25029cadf30930
2021-06-02 15:51:54 +02:00
Adeeb Shihadeh 7546f7d084 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
old-commit-hash: 6c7ed8f2e4a3769c12e61be57e802920b84dcc29
2021-04-25 12:52:16 -07:00
Adeeb Shihadeh 99b2c0d024 Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
old-commit-hash: 2fa1b2572dfb63e367cfe2868da576090b227ca4
2021-04-07 12:18:58 -07:00
qadmus 1b8d4b1eef int(round()) on apply_steer for correct comparison after rate limiting (#20425)
old-commit-hash: 0d61d8a4b61287289632ec143f328efdf0c900b0
2021-03-22 13:01:33 +01:00
qadmus 56bc319a29 Add GM steering rate and EPS torque to CarState (#20319)
* Add GM steering rate and EPS torque to CarState

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: ad123714ba8a7f4b41eacf141efd957401b0f601
2021-03-12 14:51:20 -08:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
Willem Melching 4daa6f05cf Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
old-commit-hash: e4cf43c6fcc2f442318df815fdc38fb26a74bdb7
2021-01-06 11:20:44 +01:00
andrewcopenpilot 3f2ade1312 Fix to allow brakes to release on resume press (#2709)
old-commit-hash: 4fcf8678f64be681abde5f1bb146f873e1b005da
2020-12-16 18:29:52 +01:00
Adeeb Shihadeh f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f598639307994392e96f4d9293b295c7
2020-11-03 19:56:25 -08:00
Adeeb Shihadeh 39d98d3d2d Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
old-commit-hash: 892e1162c0bfa0970cbe262452a70745eccb8ba6
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh dbdcaef1a1 Test Car Models 2.0 (#1903)
* start with radar interface

* car interface

* panda safety rx check

* check panda safety inits

* check NO_RADAR_SLEEP in all radar interfaces

* sonata 2019 and kia optima should use hyundai legacy safety

* check radar errors

* check radar can errors

* real fingerprint

* run in CI

* it shoud pass now

* ignore old openpilot msgs

* ensure safety mode is set

* sort can msgs

* filter out openpilot msgs
old-commit-hash: 99106fd9c465b366c7c61b8a0452b73455a9b96d
2020-07-25 02:27:56 -07:00
Adeeb Shihadeh 304d893af6 GM cleanup + ignition fix (#1729)
* small cleanup

* alertmanager handles that

* improve tuning

* below steer speed

* Revert "improve tuning"

This reverts commit 5d2de147d2c9979af09b7964ad59e4b95ddb2f2a.

* bump panda

* update refs

* bump panda
old-commit-hash: 472fe6696278b4137466e401496d1561a799a0da
2020-06-18 12:24:47 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Adeeb 8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Kishan Karunaratne 433cd9843a [GM] Show FCW from OP on dashboard UI / LED (#1596)
old-commit-hash: 9256530a1d41a4ad65616815f8e9ab047c63f61e
2020-05-30 10:17:04 -07:00
Adeeb 48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
George Hotz 6fbcde48e5 Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00
Adeeb 614adb569e Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
old-commit-hash: 337529d5cb7c8f35ed776c96bc2c2f394f766305
2020-05-01 13:13:12 -07:00
Willem Melching 8d4658790e Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
old-commit-hash: f7f0a81d13c9134f6e43aa67005c99b169d532a4
2020-04-27 14:10:07 -07:00
Adeeb 7f2008aa0b Remove Cadillac CT6 port (#1359)
* remove CT6 port

* dont need this route

* extra char

* fix carcontroller params
old-commit-hash: e22482eb31f0dd7851fec6ecf448cf99a14b7f5c
2020-04-13 15:53:24 -07:00
Adeeb 15916d03f4 Abstract pcmEnable and pcmDisable events (#1350)
* don't need individual prev state vars since whole CS is copied

* don't need a whole function since toyota alerts were simplified

* better here

* abstract pcmEnable/pcmDisable events

* the flippening came to NEOS

* delete

* unused

* Revert "the flippening came to NEOS"

This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
old-commit-hash: 8d791d78dd4fbc973eb61ccd9df2ed4cf9bbbcd5
2020-04-10 16:12:58 -07:00
rbiasini 5849f719ef abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
old-commit-hash: fe911bcca8ece66cfeec1eda353fa9bd658cd2bf
2020-03-08 23:35:00 -07:00
rbiasini 27c9381aa5 Test interfaces also in enabled state and fix a bug (#1213)
old-commit-hash: 6582d632ec58336158147afdcba1172d7455f11e
2020-03-06 23:48:47 -08:00
rbiasini 8fc38619c0 Abstract gasPressed for all cars (#1151)
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event

* move lines a bit

* more GM cleanup

* typo

* move espDisabled to carState packet

* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed

* ops, wrong change

* bug

* update cereal

* update ref
old-commit-hash: 9685a5a74318dc168cf4f3da994f983df5db08c0
2020-02-21 18:24:37 -08:00
Adeeb 65a2c62114 Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref

old-commit-hash: e8cb6ea06a2470dd89a6ad8fd17bd1d1b62034cc
2020-02-20 16:22:25 -08:00
rbiasini b495a36507 Abstract std params (#1138)
* get_can_parser and get_cam_can_parser are now standard static methods
old-commit-hash: af39d74a5bad29660e244daf0ed000b1183458bc
2020-02-20 14:06:02 -08:00
rbiasini 5375a08920 get_can_parser and get_cam_can_parser are now standard static methods (#1136)
old-commit-hash: dc3ea9b08d831203d31294eb37e88a682ae9d79a
2020-02-20 13:08:43 -08:00
Adeeb 0468c42f22 Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw

old-commit-hash: 13f60eae91764a2cdc7405e323381dcf971b11c3
2020-02-19 20:37:07 -08:00
rbiasini 6209ad5120 Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>

old-commit-hash: 0c67143c925f3ead6c3e88675e4fcfa4fa3f9c28
2020-02-18 15:28:15 -08:00
rbiasini 4277ff5355 abstract kf and gear parser as static methods (#1103)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* Abstract gear parser static method (#1107)

* abstract common instance vars in carstate init and a generic gear parser static method

* update opendbc (#1105)

* abstract gear parser for chrysler

* update opendbc (#1106)

* abstract gm gear parser too

* remove unnecessary random vars

old-commit-hash: 5c52be27ca8ecef959b1bb7eabcedc0c970d0a8f
2020-02-17 11:53:53 -08:00
Kishan Karunaratne 0a2620d069 Generalize GM lateral PID tuning values, so each model can override (#1094)
old-commit-hash: 89eebd79fbb864839816df0320b52618e549b19a
2020-02-14 10:49:08 -08:00
andrewcopenpilot 15a9b3b96c GM: Resume Required Alert should be triggered off of ECM state (#1045)
* Resume Required Alert should be triggered off of ECM state

On GM cars the ECM goes into cruise state 4 (standstill) and in order
for the ECM to accept cruise inputs, the resume button must be pressed
to drive it to state 1 (active).

Previously rather than testing for if the ECM was in state 4, the wheel
speed sensors were checked that the vehicle was going less than 0.5 m/s.

In some cases this could cause the resume required alert to be displayed
before the car actually came to a stop as far as the ECM was concerned.
If the alert is triggered before state 4 and OP demands acceleration,
its possible for OP to acelerate while the Resume Required Alert is
displayed created a very confusing UX.

* After more review, the problem was actually with the 'if at_full_stop' check was inside an else statement preventing entering the stopped mode if braking is 0

old-commit-hash: 4b12aca9411d2edd178b5972cd0f10c0c02303e8
2020-02-08 13:32:01 -08:00
Adeeb cf26bb52b5 Clean up ECU redundancy in selfdrive/car/* (#963)
* clean up ecu redundancy in selfdrive/car

* clean up gear parsing

old-commit-hash: dafdb79db2
2020-01-18 23:35:10 -08:00
George Hotz 9ef085076b selfdrive/car
old-commit-hash: 71ead9adea
2020-01-17 10:58:43 -08:00