Commit Graph

304 Commits

Author SHA1 Message Date
ZwX1616 dae628002f Clean up and test camerad refactor (#2310)
* refactor

add function get_camerabuf_by_type

remove cl_free

use camera_id

move front stuff into frontview_thread

bigger refactor

more

typo

rename camerabuf *c to *b

cleanup header files

remove wideview_thread

camera_qcom.c to c++

fix SConscript

camera_process_buf

space

sendrgb same with before

do autoexposure in processing_thread

correct sendrgb

add camera_common.cc

move yuv_transform to CameraBuf

* use C to keep consitent

* rebase master

* rebase master

* continue refactor

* refactor all camera related data&function out of main

 done

* cleanup

* -use buf.rgb_width&height

* remoe ,

* rebase master

* remove unused std::vector

* add func common_camera_process_front

* fix max

* fix sendrgb

* less crap being logged

* fix indents

* add back thumbnails

* thumbnail fixed on tici

* junk junk junk

* unify api

* fix ptr ref

* lol!

* cleanup

* more simplified

* typos

* remove terminate

* use standard polling

* ops_thread refactor, too much code!

* fix build

* ok

* assert

* listen

* incl more

* wq!

* fix more build

* macos

* fix exp targets

* front is different

* const

* bye

* remath

* remove irrelevant

* do ops in a thread

* fix init

* return null

* QCOM2 ops

* qcom2 build

* missing comma

Co-authored-by: deanlee <deanlee3@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 6b020241c986f614e9a1f08b5b870ff225cf7b19
2020-10-16 21:58:05 -07:00
Adeeb Shihadeh 8531345bf9 HKG fixups (#2342)
* fix hyundai blinker state

* consistency with update_speed

* update refs

* make hyundai resume reliable

* update refs

* 20 works

* don't need that

Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
old-commit-hash: 725e3b78ea1baaefa6795116c582a63c7a61686b
2020-10-14 18:27:27 -07:00
Adeeb Shihadeh aea2faaa98 Alert cleanup (#2274)
* no more focus recover active

* consistency

* more permanent

* dm alerts

* sanity check test

* no please

* clean that up

* update refs

* one more

* bump cereal
old-commit-hash: ae4b4bd1256c11153035e4236cd801738f135c51
2020-10-14 15:56:18 -07:00
Adeeb Shihadeh 5dc58abbbe clear irrelevant alerts on state transition (#2318)
* cleanup

* clear warnings

* more types

* needs refactor

* update refs

* update refs
old-commit-hash: 1c6905cac1c5b4528e60dac3279357959c2e2bc3
2020-10-14 14:08:15 -07:00
Willem Melching 498ecbdf3c Params refactor, simplified (#2300)
* always c++

* Create C++ params class

* get works

* tests hang now

* passes tests

* cleanup string formatting

* handle interrupt in blocking read

* fix memory leak

* remove unused constructor

* Use delete_db_value directly

* Rename put -> write_db_value

* filename cleanup

* no semicolons in cython

* Update common/SConscript

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* add std::string version of delete_db_value

* This is handled

* cleanup encoding

* Add clear method to clear all

* add persistent params

* fix android build

* Should be called clear_all

* only import params when needed

* set params path on manager import

* recusrively create directories

* Fix function order

* cleanup mkdirp

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2e182e5c574ea1468678b5fd8d0597e34ed5898d
2020-10-13 16:23:23 +02:00
grekiki 469a7ee7ef add caching to CI tests (#2269)
* first caching attempt

* caching attempt

* caching attempt

* caching attempt

* caching attempt

* caching attempt

* dump logs

* does this work?

* Create cache folder

* Print folder contents

* Fix volume mount

* Update test.yaml

* add removed tests

* reduce diff

* reduce diff

* reduce diff

* reduce diff

* reduce diff

* readd coverage upload

* Update test.yaml

* add more caching

* Use hash of test file to compute cache key

* add cache to valgrind tests

* Update .github/workflows/test.yaml

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update .github/workflows/test.yaml

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Also hash workflow yaml

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: fc1d01be81d4e0716d10f8bed9ea3feb6a22be5b
2020-10-13 15:38:13 +02:00
grekiki 83b7ec3ce1 Process replay for C++ daemons (#2288)
* more like a stash

* mem

* comment cpp

* remove some tests

* WORKSpython test_processes.py python test_processes.py

* all tests work, time to clean up

* initialize cleanup

* fix spaces

* refactor

* Update selfdrive/test/process_replay/process_replay.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* revert debug change

* mini refactor

* remove submaster

* update README

* add delay

* check for missaligned start

* Update compare_logs.py

* should finally work now, I hope...

* update comment

* real fix

* real fix now

* fix styling

* fix styling

* Update process_replay.py

* fix code review

* speed up tests

* Update selfdrive/test/process_replay/process_replay.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/test/process_replay/process_replay.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* fix reviews

* nicer code

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 870644b59eb61953b3355a3938cc272927708dfa
2020-10-12 11:18:53 +02:00
Adeeb Shihadeh 17d4fbfa7c more accurate profiling (#2287)
old-commit-hash: d5796e07e2a08141bae97de2d76bfd20ce199aad
2020-10-10 15:17:02 -07:00
Adeeb Shihadeh 6bb8f56f8d add timeout to modeld replay
old-commit-hash: cb85a193509c21597986f3f9abaf1a29e061b26d
2020-10-09 16:25:21 -07:00
Adeeb Shihadeh b864a2e9dd add acura rdx test route
old-commit-hash: 024c33e7246418e921fab1e9616814a79d33b2c3
2020-10-09 13:57:58 -07:00
Adeeb Shihadeh baae562f8f report git branch to testing closet
old-commit-hash: f1c3662311ae3d4b69ddb2ddb268622d9a9c3339
2020-10-06 21:00:19 -07:00
Willem Melching 13769c0287 Update radard cpu usage
old-commit-hash: 079c878adf24f1374a687138d70f6802ed030a93
2020-10-06 12:16:12 +02:00
Adeeb Shihadeh daad4ce4d6 write car params before profiling
old-commit-hash: 176c06499de585cc2c96484d442ee79fd0df844e
2020-10-05 21:34:57 -07:00
Adeeb Shihadeh 2f754f6df4 don't want to profile that
old-commit-hash: 67091060253a94d921460ad2bb4d8c5f2685dc07
2020-10-05 20:48:23 -07:00
Adeeb Shihadeh 413d7a4243 paramsd profiling
old-commit-hash: 0d11acf34ea7cf23d00d206fcd284bdf8b9f5d54
2020-10-05 20:41:24 -07:00
Willem Melching 416bc987f5 Fix calibration invalid alert on startup (#2270)
* change controlsd calibration initial value

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 3f88df62c76ee91deda15063bb2803f391c3912e
2020-10-05 19:16:52 -07:00
ZwX1616 a9d6c98aa4 Reduced wheel touch time (#2259)
* decrease wheel touch time

* update refs

* fix unittest

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 21d4ac1eebba06769f03edf7220ce84bd6ae154d
2020-10-05 14:39:24 -07:00
grekiki 67b02775da CI: Add valgrind (#2245)
* prepare a test for valgrind by fixing linter issues

* something went wrong

* Try update cereal

* Not working, fixing replay_learning.py

* Testing

* Testing

* Working now

* More logs, a bit of cleaning, still no idea how this works

* Ok got 10% cleaning done

* trying some stackOverflow code

* Lots of cleaning

* wip

* Delete valgrind_testing.py

* Delete replay_learning.py

* Add to CI, cannot fail though

* Add to CI, cannot fail though

* Now the unit test should fail

* Dump valgrind output in case of a failure

* fix subrepos

* fix subs

* hopefully fixes every issue that we have

* wait for message confirmation

* Revert "wait for message confirmation"

This reverts commit ad7ba280ec6536015ac1a442c9732bfe42fd5664.

* fix local issues

* Revert "fix local issues"

This reverts commit 4498df21df471fa6e9360d50407eaefdf24ae69f.

* attempt 3 to fix things

* untested function extraction

* refactor

* add valgrind task

* add delay and BASEDIR

* Make test not fail, it is not designed for that

* fix subrepositories

* fix tests

* Real fix now :)

* scons

* ... stupid CI

* fix valgrind CI

* Update test.yaml

* Update test.yaml

* Update test.yaml

* add valgrind logs as file

* remove delays

* kill process more reliably

* rename action

* small cleanup

* fix casting to int in case of large leaks

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a09fd7c860555c308e516bbcfbf4fff850a694e1
2020-10-05 16:09:32 +02:00
Adeeb Shihadeh af2ec63bea radard cleanup (#2266)
* some cleanup

* more realistic profiling

* Update selfdrive/controls/radard.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a77548bff606a20537ed7ff526d605bed1b7a721
2020-10-05 11:37:39 +02:00
Adeeb Shihadeh 349b5814bb radard profiling (#2265)
old-commit-hash: df6a66c785acaba43ba2699a35e3937c818aae8a
2020-10-04 15:55:25 -07:00
Adeeb Shihadeh 0184a43999 run loggerd tests in CI (#2241)
* run loggerd tests in jenkins

* fast

* check segs on the fly

* missing import

* wait for dir

* no thread

* relax FILE_SIZE_TOLERANCE

* cleanup

* unused

* set ci flag

* wait longer for first seg

* fix race condition with setting RecordFront

Co-authored-by: ZwX1616 <zwx1616@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 427d4a5a9eaf3a593db43ee78315dd38664dbb47
2020-10-01 18:42:43 -07:00
Adeeb Shihadeh 6c39de6c92 Increase HKG torque limit (#2249)
* increase hkg torque limit

* update refs

* bump panda
old-commit-hash: 67aec50b88cf1a65ae44940a4594d893a384bbc6
2020-10-01 13:16:51 -07:00
Willem Melching d34b18069c simplify testing closet client
old-commit-hash: 1c6fb567699714fa2aa39a147114fb277544c59f
2020-10-01 16:01:34 +02:00
Comma Device 493c95e363 update testing closet client
old-commit-hash: 3f0491b7e58d4d3a7fe6e2bd483d6fd267a9bdd4
2020-10-01 06:52:59 -07:00
qadmus 94b0fd629e Fix grade force in test_long plant (#2225)
Co-authored-by: user <email@web.com>
old-commit-hash: cba53957bd33379ff6ad9fc53dd5edc73cfdff4a
2020-09-28 11:54:48 +02:00
Adeeb Shihadeh 58f07d754c add type hints to selfdrive/version.py
old-commit-hash: 0040ac987aa4e836744abc5f541c1aeeda17edf5
2020-09-19 14:55:27 -07:00
Adeeb Shihadeh bdf52941c8 Improve realtime performance on NEOS (#2166)
* fix setting core affinity

* dmonitoringd doesn't need rt priority

* android only gets two cores

* model and planner get core 2

* log missed cycle count

* neos update

* prod image

* revert NEOS changes

* still need this
old-commit-hash: ef21b83937d25b824018ac1d07fa7759ae6f8128
2020-09-16 15:33:12 -07:00
ZwX1616 6f3c2fba6e Cut down unnecessary DM uncertain alerts (#2157)
* cut down high std alerts

* clean comments

* uncertain curve tune

* update test gt

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a2adfdb155f2293d9a2e7be11e81af8c020f011b
2020-09-14 10:43:19 -07:00
Adeeb Shihadeh 64a9728f2e Reduce paramsd and calibrationd CPU usage (#2119)
* reduce paramsd cpu

* reduce calibrationd cpu usage

* calibration_helpers was mostly unused

* more calibration cleanup

* update refs

* fix thresholds in CPU test
old-commit-hash: e0004d09810d9c3bcb8681bca110bf5bbd09445a
2020-09-10 12:16:29 -07:00
Jafar Al-Gharaibeh b3b48372d8 Split car identities to CX5, CX9, and Mazda3 (#2097)
Add test routes for CX9 and Mazda3

CX9: "10b5a4b380434151|2020-08-26--17-11-45"

Mazda3: "74f1038827005090|2020-08-26--20-05-50"

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 6c292c3f0c3f399b5e6f77a54ff9d2ffae379325
2020-09-09 16:02:26 -07:00
Adeeb Shihadeh 5b9466a76e hide camera view when in reverse (#2144)
* partially hide camera view when in reverse

* lowest priority

* update ref commit

* fix type

* update refs
old-commit-hash: 9cd88526b513250aae592761a4d554a0eae4acc0
2020-09-09 00:11:12 -07:00
Adeeb Shihadeh 4706f05fe9 update refs after new alert
old-commit-hash: 5838a88a3f3a22a7afac1058e3c2f2f28b73fdf5
2020-09-04 14:09:26 -07:00
HaraldSchafer 5b1dc76a96 remove vp everywhere (#2122)
* remove vp everywhere

* wrong dimension

* useful disclaimer

* switcheroo

* imcomplete switcheroo

* did it wrong again

* difference look small enough

* fix comment
old-commit-hash: 01111b3f28c748769db8f27646d9086f00a417ef
2020-09-04 03:05:20 -07:00
Adeeb Shihadeh c3f623e432 UI vision refactor (#2115)
* refactor vision

* don't show slow frame message when in preview mode

* change draws to uint32_t

* set vision_seen=false after destroy

* remove vision_connect_thread

* refactor ui_update

* seelp 30ms when vision is not connected

* remove should_swap

* call ui_update_sizes before ui_draw

* rebase

* start bigger UI refactor

* don't need the touch fd

* fix qt build

* more cleanup

* more responsive

* more refactor

* fix for pc

* poll for frames

* lower CPU usage

* cleanup

* no more zmq

* undo that

* cleanup speed limit

* fix sidebar severity for athena status

* not aarch64

Co-authored-by: deanlee <deanlee3@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 848301b091af11e129ba6873f7d297d4890c562b
2020-09-03 16:32:55 -07:00
Adeeb Shihadeh a58dc92f20 paramsd process replay test (#2118)
* paramsd process replay test

* cleanup
old-commit-hash: 1e5a935ff00916efe65046f50d46a77d091c2e29
2020-09-01 18:31:26 -07:00
Adeeb Shihadeh 6eddfac1a6 Reduce plannerd and dmonitoringd CPU usage (#2108)
* fix wasted cycles in locationd and dmonitoringd

* bump cereal

* calibrationd

* Revert "calibrationd"

This reverts commit 580051a33bc96e1e83300629e9c04817928d0851.

* this is cleaner

* calibrationd

* paramsd is driven by liveLocationKalman

* only log params once a minute

* stricter CPU usage test

* revert locationd for now

* revert calibrationd too

* revert thresholds
old-commit-hash: 21fbe26980ccbc6893af4dfe64f58e2c875f2be6
2020-09-01 16:41:09 -07:00
Adeeb Shihadeh 91ac4efab2 driver monitoring cleanup (#2101)
* read rhd from param

* don't need that anymore

* fix build

* bump cereal

* read param from camerad too

* add read_db_bool helper

* bump model replay ref commit, IsRHD wasn't set
old-commit-hash: 349040d9580bf7c9b98273dd2745fc4b147d3254
2020-08-29 17:16:00 -07:00
Adeeb Shihadeh a3461065b9 fix CI cache auto-deletion
old-commit-hash: 33fd13cc8c6af7dddea64dbc239bfe872c433adb
2020-08-28 11:19:20 -07:00
Willem Melching 16fe1bb2ad Hardware abstraction class (#2080)
* hardware abstraction class

* De Morgan

* Rename pc hardware class

* Fix sound card in controlsd

* Pc get sim info

* fix hardware in test

* two more

* No more random imei on android

* no randomness on android

* Need to return something that looks like imei for registration to work

* Return proper network strength

* Unused import

* Bug fixes + gpsd is only android
old-commit-hash: c7152d54192605c833912b69cf85514ac2e1b1fc
2020-08-26 14:57:17 +02:00
ZwX1616 275123e6d4 Loggerd rotation test (#2077)
* loggerd test

* delete afterwards

* add ccc

* fix pylint

* cleanup rotation test

* this works

* bump tolerance

* clear the data after test

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 87473fbc41055f8e768089475616d642f3d45ffe
2020-08-25 18:31:49 -07:00
Willem Melching 6fbb4e18ec Revert "more init time in cpu test"
This reverts commit 76dcc65b31a7b03c8f48b92e5bc537397f847f3e.

old-commit-hash: b29d9da875271c719ef6edd6d33a51a11c66d227
2020-08-20 17:18:03 +02:00
Willem Melching 4fd9d6467b more init time in cpu test
old-commit-hash: 03ec6af300d1d051436514b194e430fb54d16c6c
2020-08-20 15:20:59 +02:00
Adeeb Shihadeh 41a6c716d5 remove old tests (#2040)
old-commit-hash: 744fe7180187507f9dc8d455b961f882992d0684
2020-08-18 15:21:47 +02:00
Adeeb Shihadeh 2f3942bb11 increase CPU test timeout to allow for installing new APKs
old-commit-hash: 5641aeee7ae896e2ee4e24f68e24d47e497031ea
2020-08-13 15:10:00 -07:00
Adeeb Shihadeh c2b1d97b20 NEOS background updater (#1892)
old-commit-hash: cb5a2996e75658ac61f057fb729c229a554c551e
2020-08-12 11:39:21 -07:00
Adeeb Shihadeh dbd9d952e9 increase controlsd CPU test threshold
old-commit-hash: f3adedacb29bc4784e474d89a960364c7a4c24cd
2020-08-11 13:43:19 -07:00
xps-genesis 1b330d06ce Car Port: 2020 Hyundai Kona (#2010)
* update KONA car port

* update Kona  Car Port

* ignore kona EV

* add Kona route

* update readme for Hyundia Kona

* remove electric for regular Kona
old-commit-hash: a3d754a8d88404ec7f8ef1f0c1d04dd65c1fa90a
2020-08-11 13:42:19 -07:00
martinl 6a000279ad Add preglobal Subaru Forester and Outback (#1993)
* Add preglobal Forester and Outback

* Tests and values cleanup

* Update units in carstate

* Remove ()

* Add OUTBACK_PREGLOBAL_2018 to non_tested_cars

* Add replay route for OUTBACK_PREGLOBAL_2018
old-commit-hash: c9adc4900b2e26d0582cb264da2e547a513de831
2020-08-10 12:31:40 -07:00
xps-genesis 83ae9ef377 Car Port: Hyundai Genesis G70 2018 (#2000)
* Car port Genesis G70

* Car port G70

* rebase

* update G70 car port

* Update README.md

* no space

* rebase mistake

* Update values.py

* Update values.py

* Update values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a16a948f9ee434c69a72f8aac39405a14ba62073
2020-08-08 22:20:25 -07:00
Adeeb Shihadeh 37f8ca00aa Improve CPU usage test reliability (#2002)
* run phone tests in parallel

* better cpu test

* re-enable test

* no root

* terms version

* not one

* yes

* debug

* that's coverd by min cpu percent
old-commit-hash: ecf0a8c8d49dddb18767d929d381f5bbf946c5d8
2020-08-08 20:59:32 -07:00