Commit Graph

251 Commits

Author SHA1 Message Date
Adeeb Shihadeh aea2faaa98 Alert cleanup (#2274)
* no more focus recover active

* consistency

* more permanent

* dm alerts

* sanity check test

* no please

* clean that up

* update refs

* one more

* bump cereal
old-commit-hash: ae4b4bd1256c11153035e4236cd801738f135c51
2020-10-14 15:56:18 -07:00
Adeeb Shihadeh 5dc58abbbe clear irrelevant alerts on state transition (#2318)
* cleanup

* clear warnings

* more types

* needs refactor

* update refs

* update refs
old-commit-hash: 1c6905cac1c5b4528e60dac3279357959c2e2bc3
2020-10-14 14:08:15 -07:00
Willem Melching 94a947e59a Fix lane change when blinker is turned off early (#2324)
old-commit-hash: ce85e402f4a7141d8ee739006c20a5492c06a2ea
2020-10-13 17:42:29 +02:00
Shane Smiskol 09aad99228 Use math instead of numpy for calculating TTC, on average 80% faster (#2293)
* Use math instead of numpy, on average 80% faster

* whoops
old-commit-hash: 6133f603f046bb08c8e3493c3092c796156b8930
2020-10-08 14:23:53 +02:00
Logan Lasiter dd0c9d0796 Present alert if fan isn't spinning (#2258)
* Present alert if fan isn't spinning

* allow entry

* Small updates

Moving to fan malfunction event

Only trigger event for uno or dos

* Changed checking fanSpeed > 50%

* Update text for fan malfunction alert.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Alert if fan isn't spinning for 5 sec

* Alert edit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 1a2efdc139868f3588a4a35505e8833eacee735d
2020-10-07 12:15:09 +02:00
Adeeb Shihadeh aff01412d3 cleanup duplicate function
old-commit-hash: bd4a1f291df99e237d73ff0b3743d9ffcd88eb93
2020-10-06 23:59:16 -07:00
Willem Melching 416bc987f5 Fix calibration invalid alert on startup (#2270)
* change controlsd calibration initial value

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 3f88df62c76ee91deda15063bb2803f391c3912e
2020-10-05 19:16:52 -07:00
Adeeb Shihadeh 69946508db bump cereal
old-commit-hash: 70bc935210c8b948ab20f1d72fd2c6a6884d4cfd
2020-10-05 18:43:21 -07:00
Adeeb Shihadeh af2ec63bea radard cleanup (#2266)
* some cleanup

* more realistic profiling

* Update selfdrive/controls/radard.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a77548bff606a20537ed7ff526d605bed1b7a721
2020-10-05 11:37:39 +02:00
Adeeb Shihadeh ff14d71845 Run all driving processes on cores 2-3 (#2257)
old-commit-hash: 059cf6b43e579b8634090a0ecac4fb1c6c7a205e
2020-10-02 17:18:18 -07:00
Greg Hogan 659b82c469 pre-reqs for honda bosch longitudinal control (#1458)
* pre-reqs for honda bosch longitudinal control

* openpilot_longitudinal_control -> radar_disabled

* fix chrysler test

* review feedback

* little cleaner

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 0902575e3422da15454224a627650a1096d4c682
2020-09-29 00:04:15 -07:00
cydia2020 ca29e033e9 add 1 second delay to acc pedal alert (#2221)
So that the screen wouldn't appear to "flicker" when openpilot is engaged while the acc pedal is being released
old-commit-hash: 6d5b2af3f2290d9cf99c4eee3eb9c412a069fbb4
2020-09-28 16:17:21 -07:00
qadmus b48d1823e9 remove unused globals, use self.reset() (#2220)
Co-authored-by: user <email@web.com>
old-commit-hash: 254814cc793dc4668ea9fd25f092b0712fb5b8a0
2020-09-24 11:39:47 +02:00
Adeeb Shihadeh 6f96ed3c59 remove unused alert
old-commit-hash: cdcf2350252059e937b032ea2448584ff3c512a9
2020-09-22 13:47:30 -07:00
qadmus c613f8dfcc cleanup long planner, mpc: unused globals and arguments (#2211)
Co-authored-by: user <email@web.com>
old-commit-hash: 72e0ac2de1087760822b8a552c569ab3a859e2a5
2020-09-21 11:43:28 +02:00
Willem Melching 2b95a9fec2 Revert "tici: take into account frame timestamp (#2199)"
This reverts commit 58dc2982af6593d7a31464342d80190fa365287e.

old-commit-hash: 65e5032a97cba8c294e0763eeaaa430d4803a4d6
2020-09-21 10:31:01 +02:00
Adeeb Shihadeh 69c45af274 alertmanager type hints (#2201)
* alertmanager types

* clean that up

* more cleanup

* little more

* space
old-commit-hash: 15e4048318c2bf2e3e064c3f1e7e288edb9f902c
2020-09-19 10:53:14 -07:00
Willem Melching 5d817c4f46 tici: take into account frame timestamp (#2199)
* compensate for frame processing time

* add rolling shutter time

* Add max frame delay of 250ms

* only delay on tici
old-commit-hash: 3a494e144bd85166fe347cf3c0b8bfbf22d8e462
2020-09-18 17:42:29 +02:00
Adeeb Shihadeh 8221c26fab type hints for alerts and fix community feature alert (#2196)
* fix startup alert for community features

* type hints for alerts

* more type hints

* fix dashcam only alerts

* more type hints
old-commit-hash: a81a18205e85ac576a5cf5e330e3f7b99fcb4152
2020-09-17 22:06:31 -07:00
Adeeb Shihadeh bdf52941c8 Improve realtime performance on NEOS (#2166)
* fix setting core affinity

* dmonitoringd doesn't need rt priority

* android only gets two cores

* model and planner get core 2

* log missed cycle count

* neos update

* prod image

* revert NEOS changes

* still need this
old-commit-hash: ef21b83937d25b824018ac1d07fa7759ae6f8128
2020-09-16 15:33:12 -07:00
ZwX1616 6f3c2fba6e Cut down unnecessary DM uncertain alerts (#2157)
* cut down high std alerts

* clean comments

* uncertain curve tune

* update test gt

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a2adfdb155f2293d9a2e7be11e81af8c020f011b
2020-09-14 10:43:19 -07:00
Adeeb Shihadeh 6dbfe6fb9e prevent reversing alert from showing while changing gears
old-commit-hash: a4a4e28c1a9948297d36f562aad6343294380d47
2020-09-12 17:21:30 -07:00
Adeeb Shihadeh 64a9728f2e Reduce paramsd and calibrationd CPU usage (#2119)
* reduce paramsd cpu

* reduce calibrationd cpu usage

* calibration_helpers was mostly unused

* more calibration cleanup

* update refs

* fix thresholds in CPU test
old-commit-hash: e0004d09810d9c3bcb8681bca110bf5bbd09445a
2020-09-10 12:16:29 -07:00
Willem Melching e64274a37d cleanup controlsd env variable reading
old-commit-hash: d4328365e90636cc0e075c8844823fed5321e8ed
2020-09-10 12:19:14 +02:00
Vivek Aithal db0a4ef2dc dockerize carla + openpilot (#2011)
* dockerize carla + openpilot

* separate dockerfile

* bring back CI dockerfile

* cleanup bridge

* add op docker build and start script

* build container in CI

* fix camerad hack

* remove most magic numbers from bridge.py

* openpilot-sim docker build and run scripts

* fix dmonitoring hacks

* revert controlsd hacks

* clean up build scripts

* singular

* fix path

* fix image name

* modify sim readme

* sim readme and start script changes

* dockerfile with working opengl

* working opengl + passing panda build_st in docker

* fix bug in sim docker file

* bugfix sim docker file

* bugfix all op-sim docker issues

* modify readme + run script

* IT DRIVES

* clean this up

* more cleanup

* cleanup docker stuff

* more cleanup

* start with openpilot-base

* install carla python package

* Script is not in lib

* chmod

* everything should be running in docker now, the code may not be nice though

* works locally...

* rhdChecked is deprecated

* Checkout using git lfs when building sim container

* try to pass the tests

* pull latest docker

* gps should not throw an error on openpilot launch in bridge.py

* fixed a coding style error

* Only start ubloxd in car

* fixed more style problems

* revert typo

* Use enviromental variable to prevent errors in a simulator

* Remove unused import

* Attempt to fix missing enviromental variable

* fix typo

* less work for users, auto tmux engagement

* less work for users, auto tmux engagement

* fix check for nvidia

* clean up nvidia check

* remove typo, shorted dockerfile

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Bruce Wayne <batman@workstation-eu-gregor.eu.local>
Co-authored-by: Gregor Kikelj <gregor1234567890@gmail.com>
old-commit-hash: c5dfbe7a72c6f31a0aa3a32b6df3f81409b40faf
2020-09-10 12:14:49 +02:00
Adeeb Shihadeh 3001e4c3b2 set params for new test
old-commit-hash: fde8b18f733797b1222ea844f3f3fc93217a8dcc
2020-09-09 15:57:06 -07:00
Adeeb Shihadeh 43010d853a fix timing issues with new test
old-commit-hash: fae13bf07e3b336f52911cb23291c6db029922cb
2020-09-09 15:16:05 -07:00
Adeeb Shihadeh c3760c267d simple unit test for startup alert
old-commit-hash: a3c1de1e66e798d5e2c030cbb8d5c66159dc4cbe
2020-09-09 14:40:16 -07:00
Adeeb Shihadeh 5b9466a76e hide camera view when in reverse (#2144)
* partially hide camera view when in reverse

* lowest priority

* update ref commit

* fix type

* update refs
old-commit-hash: 9cd88526b513250aae592761a4d554a0eae4acc0
2020-09-09 00:11:12 -07:00
Adeeb Shihadeh e17575f36d make calibrationInvalid a permanent alert
old-commit-hash: 86f4d86cd7ae704d97efea1638f1a510d950c9bc
2020-09-04 13:20:48 -07:00
Adeeb Shihadeh c3f623e432 UI vision refactor (#2115)
* refactor vision

* don't show slow frame message when in preview mode

* change draws to uint32_t

* set vision_seen=false after destroy

* remove vision_connect_thread

* refactor ui_update

* seelp 30ms when vision is not connected

* remove should_swap

* call ui_update_sizes before ui_draw

* rebase

* start bigger UI refactor

* don't need the touch fd

* fix qt build

* more cleanup

* more responsive

* more refactor

* fix for pc

* poll for frames

* lower CPU usage

* cleanup

* no more zmq

* undo that

* cleanup speed limit

* fix sidebar severity for athena status

* not aarch64

Co-authored-by: deanlee <deanlee3@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 848301b091af11e129ba6873f7d297d4890c562b
2020-09-03 16:32:55 -07:00
Adeeb Shihadeh 6eddfac1a6 Reduce plannerd and dmonitoringd CPU usage (#2108)
* fix wasted cycles in locationd and dmonitoringd

* bump cereal

* calibrationd

* Revert "calibrationd"

This reverts commit 580051a33bc96e1e83300629e9c04817928d0851.

* this is cleaner

* calibrationd

* paramsd is driven by liveLocationKalman

* only log params once a minute

* stricter CPU usage test

* revert locationd for now

* revert calibrationd too

* revert thresholds
old-commit-hash: 21fbe26980ccbc6893af4dfe64f58e2c875f2be6
2020-09-01 16:41:09 -07:00
ZwX1616 fca076b982 not show soft recover alerts
old-commit-hash: 9731e7a0d7af7aec44097e0028c10427681d4e8c
2020-08-27 17:59:26 -07:00
Willem Melching 16fe1bb2ad Hardware abstraction class (#2080)
* hardware abstraction class

* De Morgan

* Rename pc hardware class

* Fix sound card in controlsd

* Pc get sim info

* fix hardware in test

* two more

* No more random imei on android

* no randomness on android

* Need to return something that looks like imei for registration to work

* Return proper network strength

* Unused import

* Bug fixes + gpsd is only android
old-commit-hash: c7152d54192605c833912b69cf85514ac2e1b1fc
2020-08-26 14:57:17 +02:00
Chris 42538fd54b Kilometers per hour now displayed as km/h (#2032)
Fixes #2031

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
old-commit-hash: 1b52930a52828b1423c59c677c9b42a5ff76125c
2020-08-17 11:16:52 +02:00
Adeeb Shihadeh c2b1d97b20 NEOS background updater (#1892)
old-commit-hash: cb5a2996e75658ac61f057fb729c229a554c551e
2020-08-12 11:39:21 -07:00
Adeeb Shihadeh 017b084154 Alert when updated consistently fails (#2013)
* alert when update fails more than 10 times

* bring over offroad alert refactor from other branch

* and we have tests

* use it in snapshot

* bump apk

* don't show exceptions on release branches

* only write when changed

* why does delete use so much cpu

* clean that up

* little more
old-commit-hash: 8e63f065400ea1868f077560ae89b2c17f5523f8
2020-08-11 16:23:57 -07:00
Adeeb Shihadeh 944759717e fix missing negative limit in pid controller (#2001)
old-commit-hash: ee99b59bade8d3b5057a5b3f22ad8b3edd102c78
2020-08-08 11:49:13 -07:00
HaraldSchafer 122118ccd4 add fall filter and less FP on posenet (#1971)
* add fall filter and less FP on posenet

* add alert

* list

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 490ee5268712c38f738161cab939c02573581ebf
2020-08-03 15:51:56 -07:00
HaraldSchafer bc3b340694 Misc locationd improvements (#1714)
* I like this more

* rewind less

* bump rednose

* falling off windshield detectopr

* adjust thresholds

* this is a soft disable now

* move that

* process replay fixes

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8e2d344135b9a1102503432d651e6bf599d9fa42
2020-07-30 15:33:22 -07:00
Adeeb Shihadeh 224b7fd34b Remove get_one_can from messaging (#1946)
* move get_one_can into openpilot

* bump cereal
old-commit-hash: 714f8c3f0bf8fa98a4619763d46ecb3ea29bc9f6
2020-07-28 23:52:18 -07:00
Adeeb Shihadeh 6e7fde5d61 Revert "can't directly access sockets anymore", was supposed to be on branch
This reverts commit 1046c572b4e49608137f687263d443eab6c430f8.

old-commit-hash: acb25751b75059a6e212192064528afe0ebd5e03
2020-07-28 18:41:39 -07:00
Adeeb Shihadeh 59ade6c2f6 can't directly access sockets anymore
old-commit-hash: 6acda96a163ad77f2f0b283712ac79b3d3d90d54
2020-07-28 18:37:16 -07:00
Shane Smiskol 3454f1e033 Fix hard deceleration after user accelerates above set cruise speed (#1880)
* Fix hard deceleration after user accelerates above set cruise speed

* 2nd required change
old-commit-hash: ebadb39e42d8a39eaf3bc969157777d596e42012
2020-07-20 17:04:05 +02:00
Adeeb Shihadeh cd317b0780 Fix most remaining LGTM alerts (#1893)
* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android
old-commit-hash: 5db81f60ca8fbc0ef28924b7e93f25a1d4bb3764
2020-07-19 16:12:22 -07:00
Adeeb Shihadeh c374f03187 Revert modeld vipc conflate behavior and alert on dropped frame percent (#1877)
* Revert "Fix modeld dropping frames if processing takes over 50 ms"

This reverts commit fb908877a50d72e20a047bd4138316b12c8a30cc.

* track frame drop

* fix unused

* alert on frame drop perc

* reduce thresholds

* posenet is invalid on non-consecutive frames

* Refactor filter time constant

* Use vipc_dropped_frames for posenet valid check

* Actually set frame drop percentage

* Add explicit cast just to be sure

* Prevent frames dropped to go up to quickly on startup

* bump cereal

* reduce soft disable threshold to 1%

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 58c3b5ba84f6c3da3c660770148cea98c708fce5
2020-07-14 14:23:27 -07:00
Adeeb Shihadeh a1dbb38a0c Alert when modeld is lagging by more than a frame (#1823)
* alert when modeld is lagging by more than 1 frame

* log frameAge in modelData

* set posenet valid

* compute frame_age once
old-commit-hash: 03e824a4b558daa15191408e88b73fee7ab1792f
2020-07-09 17:02:21 -07:00
Greg Hogan bcf7edf595 k-line 5 init fault type (#1821)
* k-line 5 baud fault type

* update name

* bump cereal

* fix name

* add missing event
old-commit-hash: c458f5a5d3587d0eb87abbebd86c4f399e28c63d
2020-07-06 09:33:16 -07:00
Adeeb Shihadeh 0d79150606 Sound test (#1820)
* WIP sound test

* it does something

* refactor

* phone only

* update release files

* test sound card init

* add to CI

* check writes

* increase time

* unused

* only build cereal

* small tolerance

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f1afb3e3ae4b95a1de0262d1408c49093c5ada6f
2020-07-05 17:56:24 -07:00
George Hotz 70dbce450c Add an SSH param to disable updates (#1807)
* disable updates with optional param

* dont create the alert

* Revert "dont create the alert"

This reverts commit 7179a6c8b4b4656e0b203b5a590b33d3388aa9c9.

* keep alert, but allow engagement

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cb495bb8c9af8b9347bfe3cf4b59baf1f6d10482
2020-07-01 14:26:35 -07:00