Commit Graph

66 Commits

Author SHA1 Message Date
martinl 6a000279ad Add preglobal Subaru Forester and Outback (#1993)
* Add preglobal Forester and Outback

* Tests and values cleanup

* Update units in carstate

* Remove ()

* Add OUTBACK_PREGLOBAL_2018 to non_tested_cars

* Add replay route for OUTBACK_PREGLOBAL_2018
old-commit-hash: c9adc4900b2e26d0582cb264da2e547a513de831
2020-08-10 12:31:40 -07:00
xps-genesis 83ae9ef377 Car Port: Hyundai Genesis G70 2018 (#2000)
* Car port Genesis G70

* Car port G70

* rebase

* update G70 car port

* Update README.md

* no space

* rebase mistake

* Update values.py

* Update values.py

* Update values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a16a948f9ee434c69a72f8aac39405a14ba62073
2020-08-08 22:20:25 -07:00
Adeeb Shihadeh c4ce441026 Remove non-SCC Hyundai Kona port (#1997)
old-commit-hash: 5e82578a1b66a1e13753d2258f32950aece48942
2020-08-08 11:48:16 -07:00
martinl 0aeae7d81e Subaru pre-global: add support for Subaru Legacy 2015-18 (#1805)
* Add support for Subaru Legacy 2015-18

* syntax fix

* Add Legacy 2018 FPv1

* Add Subaru Ascent from upstream

* Use GLOBAL_CAR and LEGACY_CAR lists

* Change LEGACY_2015 to LEGACY_PREGLOBAL

* Add LEGACY_CAR to carstate

* Change LEGACY_2015 to LEGACY_PREGLOBAL in test_car_models

* Add missing SafetyModel to Ascent

* Use GLOBAL_CAR and LEGACY_CAR to set safetyModel

* Change LEGACY_CAR to PREGLOBAL_CARS, remove GLOBAL_CAR

* Fix PREGLOBAL_CARS in carstate and subarucan

* Minor cleanups

* Add accelCruise button event

* Change Preglobal Driver Torque limit to match Global

* Match comments to upstream

* Use Steer_Warning and Steer_Error_1 only for Global

* Change mph units to match upstream values

* Increase Preglobal brakePressed  threshold to 2

* Add DashcamOnly to LEGACY_PREGLOBAL

* Fix typo in variable name

* Update README, add create_preglobal_steering_control

* cleanup carcontroller

* cleanup values

* missed that one

* Update STEER_STEP

* Update STEER_MAX

* Add preglobal signal frequency checks

* remove PREGLOBAL_CARS from subarucan

* Remove whitespace

* Use common frequency checks

* cleanup carstate

* cleanup subarucan

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: e37b8e5d5632a7cc48326f7ca162ef87f259e526
2020-08-06 21:55:13 -07:00
xps-genesis 5cecf53e5f Add Hyundai Veloster 2019 (#1955)
* Add Hyundai Veloster 2019

* Add Hyundai Veloster interface.py

* add route for Hyundia Veloster

* steer ratio fix

* Update interface.py

* new longer route

* space

* ignored fingerprint

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6e1bcdcb34d8361379cb2a21ea043ba331c3dabf
2020-08-02 15:45:41 -07:00
Adeeb Shihadeh 80b450e2a6 we have routes for these now
old-commit-hash: 433c9241f38d1167f0555e75902823b8a1f063be
2020-08-02 15:25:09 -07:00
Adeeb Shihadeh fd97dfbdd2 Test can valid in car unit tests (#1961)
* check can invalid

* remove bad lexus is route

* blacklist routes from before cam forwarding

* fix rav4 route with missing first segment
old-commit-hash: e89b2b84534e76d8965b22d2aa7451984fbf7229
2020-08-01 22:38:19 -07:00
Adeeb Shihadeh fefe79bedb fail new car model unit tests if missing a test route
old-commit-hash: 63e4aeac9f63fac4ab7679766ac2e655c1e98a8c
2020-07-28 23:37:53 -07:00
Adeeb Shihadeh 9ca2bbfc40 kia stinger: use hyundaiLegacy safety mode and add test route
old-commit-hash: 360cd7d8a86460fcc339ead89c0c6a439417eb66
2020-07-26 14:09:49 -07:00
Adeeb Shihadeh 713da21faf add test route for HYUNDAI.KIA_SORENTO
old-commit-hash: 4bc90c578aa1e229c18b62aaec6668dee9b49a84
2020-07-23 15:44:14 -07:00
Adeeb Shihadeh 1618f87f5d add HYUNDAI_GENESIS test route
old-commit-hash: f753ca14ad1ab26eb81d48b50c6672e44c81334f
2020-07-23 13:24:06 -07:00
martinl dfee3692f6 Support for 2019 Subaru Ascent (#1801)
* Add support for Subaru Ascent 2019

* remove duplicate safetyModel

* Add Ascent 2019 to README.md
old-commit-hash: b1abf17752f7631014d855466c46f2aef71bc604
2020-07-01 16:54:40 -07:00
Adeeb Shihadeh 0722b40c04 Hyundai Ioniq SE 2020 (#1786)
* Update values.py

* Update carcontroller.py

* Update values.py

* Update interface.py

* Update carcontroller.py

* add test route

* readme

Co-authored-by: baldwalker <insigniadesign@yahoo.co.uk>
old-commit-hash: 57deb3a8930c3fa9140b48338c599dfda0f59435
2020-06-26 12:25:09 -07:00
martinl 0d04c2cc26 Subaru Forester 2019 (#1768)
* Add initial Forester 2019 support

* Add dgranger15 Forester 2019 FPv1

* fingerprint syntax fix

* FPv1 syntax fix 2

* Add Forester 2019 to CAR

* fix indent

* Add Forester 2019 to test_car_models ignore list

* Update Forester 2019 steering tuning (dgranger15)

* Add Forester 2019 to README.md

* Change lists to single value

* Add test route for Forester 2019

* Remove model year

* Remove Forester model year in test_car_models

* Remove usernames, add Forester ACC speed mph unit value
old-commit-hash: 09e7d4ab3a044fd5279cce43853f69465eac876f
2020-06-23 16:07:46 -07:00
Adeeb Shihadeh e4f549c998 Hyundai Ioniq EV LTD (#1694)
* add ioniq

* bump panda

* test route

* bump pnada
old-commit-hash: 224672705c6bc5e7476275648813d39e17d3e476
2020-06-15 11:45:37 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Andre Volmensky d106ccc0fb Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
old-commit-hash: 9fc826cb5c6fc46ebd0fe5c1ecd322a472da44ef
2020-05-30 20:25:32 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Jafar Al-Gharaibeh a476d51333 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 34b9b5e849fcd192bbd8c3060ce725ef61d725ab
2020-05-28 22:15:19 -07:00
Willem Melching 2b60ee9531 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
old-commit-hash: 3d08dcc3b27936cb14c0eae63605be9a6c077380
2020-05-28 15:05:04 -07:00
Adeeb f4ef9ae00a Remove incomplete Hyundai Ioniq port (#1570)
old-commit-hash: c78602e8ccf242be6f8a1806ba9e2f0e4f79275b
2020-05-26 20:48:41 -07:00
Thaixican 53a18127e6 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
old-commit-hash: dd16990952980bfd5c8eac919309052be084a7ee
2020-05-26 13:49:18 -07:00
Willem Melching 2e0f9fe628 add sonata 2019 to test_car_modelsg
old-commit-hash: ef2ea14ecce0133b5596074712162931cbaebdc3
2020-05-20 17:20:17 -07:00
Alice Knag bf066b2601 add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
old-commit-hash: fde1a5e9af1c1e84ed6f82b642a50bae21f25bbe
2020-05-20 17:12:00 -07:00
Willem Melching fb7e47e2fb This one also needs to be fixed
old-commit-hash: 96605d095162c88b6e97de6262f4972c12c49c68
2020-05-19 16:19:00 -07:00
Adeeb Shihadeh e6af5da522 remove those debug prints
old-commit-hash: 8788ab36e40a413c777dd298817477a2fd7da8f9
2020-05-19 13:54:24 -07:00
Willem Melching 88a385e9c9 Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
old-commit-hash: bb8bbdd9ee4d610e2ae6048021407863b3f74683
2020-05-19 13:43:44 -07:00
Erich Moraga 739d5c7249 Add HIGHLANDERH_TSS2 Support (#1425)
* exclude HIGHLANDERH_TSS2

* add HIGHLANDERH_TSS2 support

* Add HIGHLANDERH_TSS2 Support

* Add HIGHLANDERH_TSS2 Support

* Added to IGNORED_FINGERPRINTS per @pd0wm
old-commit-hash: 009c32d516c0a487a146e1943720041c3e77d1bf
2020-04-27 14:56:30 -07:00
cowanhmoore 8fa7d31138 Honda HRV (#1404)
* PR - Honda HRV

values.py - incl. Class, FP, FW_VERSIONS, SPEED_FACTOR 1.025
carstate.py - incl. carFingerprint, doorOpen OVERRIDE (signal unknown)
Safety test concludes that removal of drivers seatbelt IMMEDIATELY disengages OP
interface.py - incl. HR-V vehicle parameters, tuning (tested for 100+ miles)
Longitudinal tuning parameters unchanged from CAR.FIT
test_car_models.py - added per request of review process
*5. honda_hrv_touring_2019_can_generated.dbc will be submitted to commaai/opendbc in next PR

Once *5 is approved, will need to update values.py to matching dbc

Thanks, Cowan Moore 330-701-3922

* Honda HRV Door Signal

BO_ 422 SCM_BUTTONS: 8 SCM
 SG_ DRIVERS_DOOR_OPEN : 63|1@0+ (1,0) [0|1] "" EON

* Update values.py

* Update test_car_models.py
old-commit-hash: 1d6042c5f35dc2e5c2b6b8aeaca51ef8348c69b5
2020-04-20 15:30:46 -07:00
Willem Melching 1404dabb62 Add Palisade to test_car_models
old-commit-hash: ed527dfd1eb421f871d63c1a01f3feaa0778d609
2020-04-17 11:46:16 -07:00
Willem Melching c9ec2cbec6 Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7d78cef34b0eea35c2e47f4aa91baf671ef39c43
2020-04-15 19:33:24 -07:00
Adeeb 7f2008aa0b Remove Cadillac CT6 port (#1359)
* remove CT6 port

* dont need this route

* extra char

* fix carcontroller params
old-commit-hash: e22482eb31f0dd7851fec6ecf448cf99a14b7f5c
2020-04-13 15:53:24 -07:00
Willem Melching bb5e87efda 2020 Chrysler Pacifica (#1297)
* 2020 pacifica support

* Update readme
old-commit-hash: 746f7ed9b1e5756feb24938ff8287ad075c22b5b
2020-03-31 15:47:49 -07:00
Willem Melching 0d03fad5b6 Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
old-commit-hash: 1df6b67511e0872c134edef0eb8535d71e0b2cfd
2020-03-27 21:44:59 -07:00
Chris Souers a5927023db Adds 2016 CR-V Executive (Euro version of Touring trim) (#1097)
Co-authored-by: Ted Slesinski <ted_slesinski@epam.com>
old-commit-hash: 035397cd319cb1c08a7fea7735c0b575a1094fc7
2020-03-13 11:48:08 -07:00
Willem Melching d2b9f729c8 add honda pilot 2019 to test car models
old-commit-hash: 768f08e1299aa4205f47d59f402371128a47261a
2020-03-11 16:51:45 -07:00
Willem Melching 6a23823752 add accord 1.5L to test_car_models
old-commit-hash: fbac82ea21696cf12bc54c47e17f9a6f58d4fc49
2020-03-07 11:05:46 -08:00
Willem Melching 119f2c2a12 add crv5g and optima to test_car_models
old-commit-hash: 82f77e379b8e398995e000be6eaf3adbdd37d168
2020-03-06 17:33:30 -08:00
Willem Melching 6d4e12c32f Add 2017 Pacifica Hybrid to test_car_models
old-commit-hash: 3d15eb39d5c48d8d1b341216ef3c0301cec807a8
2020-03-06 17:13:09 -08:00
Willem Melching fd3db576af More public routes in test car models (#1208)
* remove non public routes

* Fix linter

* add rav4h

* add odyssey

* add pilot and civic_bosch

* cth and camry

* add regal
old-commit-hash: a25acaae0770a32aa54abd4d41dc0f5ab5077f9a
2020-03-06 13:44:34 -08:00
Willem Melching 0a47a0cb3e Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models

old-commit-hash: 6db044c86cad910235a0cbcaf5f5f91775fe4e26
2020-03-05 15:40:07 -08:00
theantihero 976a4197ad Add 2019 Honda Insight (#1166)
* add 2019 Honda Insight + fw fp

* add actual fp and add to ignored, but still required for ECU detection

* add Insight dirty route for now

* update README.md, was wrong mph for each

* update test_car_models

* remove dbc extension

old-commit-hash: c8c4708f21652218644e981185a808ea911de869
2020-02-27 14:56:36 -08:00
Chris Souers 53dbe430a8 Add support for 2019 Civic Sedan 1.6L Diesel with CVT (#1091)
add car

Update test_car_models.py

Update test_car_models.py

add firmware

Update README.md

Update test_car_models.py
old-commit-hash: ba6f555ede7cd3f0daf94bf413511b409dd4a9d6
2020-02-21 11:03:10 -08:00
Willem Melching c6ec40cbc5 Add HONDA.ACCORDH to test_car_models (#1143)
Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>

old-commit-hash: fdbe289e71758d75e75805f98c36f56848379081
2020-02-20 16:23:29 -08:00
Willem Melching 2d44c22265 Merge 2019 and 2020 Chrysler Pacifica Hybrid (#1142)
* Merge 2019 and 2020 Chrysler Pacifica Hybrid

* fix carcontroller

old-commit-hash: 85e8bb90d4fa657c7adde4ab32023f4844a53775
2020-02-20 16:23:10 -08:00
Willem Melching dcfe0b17c0 Fingerprint rav4 hybrid tss2 only using firmware versions (#1084)
* fingerprint rav4 hybrid tsss only using firmware

* remove print statement

old-commit-hash: 9e6e1cba560fcb8d752b5b9c55c32a56d9aea4d1
2020-02-12 12:59:38 -08:00
Patipat Susumpow 9227e375b7 Add support for Lexus NX 300h 2018 (#1077)
* Add support for Lexus NX 300h 2018

* Add Lexus NX 300h 2018 to README.md

* Fix a misplaced value CAR.LEXUS_NXH in the values.py

old-commit-hash: 576317ad104cba59e2a048886c95a52f07b076c3
2020-02-11 19:27:17 -08:00
che220 79c629adab 2020 Toyota Highlander (TSS2) (#1065)
* added 2020 highlander (TSS2)

* add HIGHLANDER_TSS2 test into routes

* reduce HIGHLANDER_TSS2 weight to 4700 from 4900

* add highlander 2020 limited to the list of supported cars

old-commit-hash: 4ea729460762251686d74c1d0d5af23a93c7493d
2020-02-11 11:06:50 -08:00