39d98d3d2d
Car cleanup ( #1924 )
...
* cleanup car code
* more pruning
* little more
* less pylint disables
* radar stuff
* fix
* udpate refs
* fix honda bosch
* fix test
old-commit-hash: 892e1162c0bfa0970cbe262452a70745eccb8ba6
2020-07-25 15:07:27 -07:00
304d893af6
GM cleanup + ignition fix ( #1729 )
...
* small cleanup
* alertmanager handles that
* improve tuning
* below steer speed
* Revert "improve tuning"
This reverts commit 5d2de147d2c9979af09b7964ad59e4b95ddb2f2a.
* bump panda
* update refs
* bump panda
old-commit-hash: 472fe6696278b4137466e401496d1561a799a0da
2020-06-18 12:24:47 -07:00
8c0971086b
Fix speed too low ( #1627 )
...
* fix speed too low
* bump ref
Co-authored-by: Willem Melching <willem.melching@gmail.com >
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
a56e2b01f8
Make pylint more strict ( #1626 )
...
* make pylint more strict
* cleanup in progress
* done cleaning up
* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
37a67a2a14
enable flake8 E502: backslash is redundant between brackets
...
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
68a3061c9d
enable E261 in flake8: two spaces before inline comment
...
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
5e857427ba
Enable more flake8 checks ( #1602 )
...
* enable some more flake8 checks
* some more quick ones
* bump opendbc
* e401
* e711 e712
* e115 e116
* e222
* e301
* remove that
* e129
* e701 e702
* e125 e131
* e227
* e306
* e262
* W503
* e713
* e704
* e731
* bump opendbc
* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
48340cc8cb
Alerts + Events refactor ( #1466 )
...
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
8d4658790e
Remove fake yaw rate from carstate ( #1426 )
...
* remove fake yaw rate from carstate
* update ref
old-commit-hash: f7f0a81d13c9134f6e43aa67005c99b169d532a4
2020-04-27 14:10:07 -07:00
7f2008aa0b
Remove Cadillac CT6 port ( #1359 )
...
* remove CT6 port
* dont need this route
* extra char
* fix carcontroller params
old-commit-hash: e22482eb31f0dd7851fec6ecf448cf99a14b7f5c
2020-04-13 15:53:24 -07:00
15916d03f4
Abstract pcmEnable and pcmDisable events ( #1350 )
...
* don't need individual prev state vars since whole CS is copied
* don't need a whole function since toyota alerts were simplified
* better here
* abstract pcmEnable/pcmDisable events
* the flippening came to NEOS
* delete
* unused
* Revert "the flippening came to NEOS"
This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
old-commit-hash: 8d791d78dd4fbc973eb61ccd9df2ed4cf9bbbcd5
2020-04-10 16:12:58 -07:00
5849f719ef
abstract pedalPressed event ( #1218 )
...
* abstract pedalPressed event
* Fix bug
* update refs
old-commit-hash: fe911bcca8ece66cfeec1eda353fa9bd658cd2bf
2020-03-08 23:35:00 -07:00
8fc38619c0
Abstract gasPressed for all cars ( #1151 )
...
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event
* move lines a bit
* more GM cleanup
* typo
* move espDisabled to carState packet
* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed
* ops, wrong change
* bug
* update cereal
* update ref
old-commit-hash: 9685a5a74318dc168cf4f3da994f983df5db08c0
2020-02-21 18:24:37 -08:00
65a2c62114
Abstract common events + event cleanup ( #1129 )
...
* too many if
* unused
* whitespace
* key
* sefldrive/car/*
* no more gctx
* lower
* start abstracting common events
* all cars
* start small
* all cars
* reverse gear
* wrongCarMode
* wrongGear
* espDisabled
* steerUnvailable
* make linter happy
* c isn't used
* fix esp_disabled in VW
* update ref
* more red
* more cleanup
* fix subaru
* update ref
old-commit-hash: e8cb6ea06a2470dd89a6ad8fd17bd1d1b62034cc
2020-02-20 16:22:25 -08:00
b495a36507
Abstract std params ( #1138 )
...
* get_can_parser and get_cam_can_parser are now standard static methods
old-commit-hash: af39d74a5bad29660e244daf0ed000b1183458bc
2020-02-20 14:06:02 -08:00
5375a08920
get_can_parser and get_cam_can_parser are now standard static methods ( #1136 )
...
old-commit-hash: dc3ea9b08d831203d31294eb37e88a682ae9d79a
2020-02-20 13:08:43 -08:00
0468c42f22
Abstract CarInterface init ( #1131 )
...
* abstract CarInterface init
* unused
* subaru
* gm cleanup
* vw
* typo
* carcontroller
* more cleanup
* fix vw
old-commit-hash: 13f60eae91764a2cdc7405e323381dcf971b11c3
2020-02-19 20:37:07 -08:00
6209ad5120
Carstate returns capnp struct ( #1115 )
...
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* abstract common instance vars in carstate init and a generic gear parser static method
* abstract gear parser for chrysler
* abstract gm gear parser too
* remove unnecessary random vars
* Chrysler: carstate returns capnp struct directly
* revert ref commit
* test ref
* WIP
* more WIP
* ops, missed this conflict
* ford as well
* not sure why this got deleted
* no need to copy
* remove copy
* remove copy import
* remove unnecessary intermediate variable
* remove obsolete comments
* GM: have carstate returning capnp struct directly
* Honda carstate also outputing capnp struct
* hyundai too now returns capnp from carstate
* ops, not meant this
* Subaru carstate also returning capnp
* Toyota: capnp struct as output of carstate
* fix bool
* minor simplififcation in Honda
* no need to negate
* VW carstate returning capnp struct (#1118 )
* VW carstate also returning capnp struct
* fixed typo
* Remove unused blinker button (#1119 )
* remove unused blinker button
* ops, this wasn't meant
* remove blinker button for VW as well
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com >
old-commit-hash: 0c67143c925f3ead6c3e88675e4fcfa4fa3f9c28
2020-02-18 15:28:15 -08:00
4277ff5355
abstract kf and gear parser as static methods ( #1103 )
...
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* Abstract gear parser static method (#1107 )
* abstract common instance vars in carstate init and a generic gear parser static method
* update opendbc (#1105 )
* abstract gear parser for chrysler
* update opendbc (#1106 )
* abstract gm gear parser too
* remove unnecessary random vars
old-commit-hash: 5c52be27ca8ecef959b1bb7eabcedc0c970d0a8f
2020-02-17 11:53:53 -08:00
0a2620d069
Generalize GM lateral PID tuning values, so each model can override ( #1094 )
...
old-commit-hash: 89eebd79fbb864839816df0320b52618e549b19a
2020-02-14 10:49:08 -08:00
cf26bb52b5
Clean up ECU redundancy in selfdrive/car/* ( #963 )
...
* clean up ecu redundancy in selfdrive/car
* clean up gear parsing
old-commit-hash: dafdb79db2
2020-01-18 23:35:10 -08:00
9ef085076b
selfdrive/car
...
old-commit-hash: 71ead9adea
2020-01-17 10:58:43 -08:00
81dd5a50cf
root commit
...
old-commit-hash: 6c33a5c1f3
2020-01-17 10:02:52 -08:00
fa4b6f33d1
openpilot v0.7.1 release
...
old-commit-hash: 8da8b6135c
2020-01-15 14:05:04 -08:00
99b637c7ce
openpilot v0.7 release
...
old-commit-hash: c025b96e8a
2019-12-13 13:03:08 -08:00
b713eae9f8
openpilot v0.6.6 release
...
old-commit-hash: d7f0b402a8
2019-11-04 15:13:52 -08:00
89d1d84c70
openpilot v0.6.5 release
...
old-commit-hash: cf80f7a28b
2019-10-09 18:43:53 +00:00
dfe603c178
openpilot v0.6.4 release
...
old-commit-hash: 61229779e4
2019-09-09 23:03:02 +00:00
02cedeadd9
openpilot v0.6.3 release
...
old-commit-hash: d5f9caa82d
2019-08-13 01:36:45 +00:00
3835061760
openpilot v0.6.2 release
...
old-commit-hash: e90c41c576
2019-07-30 02:27:48 +00:00
07aa8b1bf3
openpilot v0.6.1 release
...
old-commit-hash: 94053536b4
2019-07-22 19:17:47 +00:00
ae1fbf70fa
Refactor default Civic params ( #720 )
...
* move civic params out
* fix variable name
* simplify ford scaling
* cleanup
* remove import dependency
* requested changes
* keep hyundai
old-commit-hash: 4a48ef8dbc
2019-07-08 16:59:32 -07:00
9abcfabc5f
openpilot v0.6 release
...
old-commit-hash: 8a9ed94f5f
2019-06-28 21:11:30 +00:00
e47a2e6e30
openpilot v0.5.13 release
...
old-commit-hash: dd34ccfe28
2019-06-06 04:38:45 +00:00
0932b367bd
openpilot v0.5.12 release
...
old-commit-hash: 3f9059fea8
2019-05-16 13:20:29 -07:00
7df6dd4ccb
Maintain Python 2-3 compatibility but use six.iteritems().
...
old-commit-hash: 2eebe49940
2019-05-04 19:01:46 -07:00
3ad68e4378
getting ready for Python 3 ( #619 )
...
* tabs to spaces
python 2 to 3: https://portingguide.readthedocs.io/en/latest/syntax.html#tabs-and-spaces
* use the new except syntax
python 2 to 3: https://portingguide.readthedocs.io/en/latest/exceptions.html#the-new-except-syntax
* make relative imports absolute
python 2 to 3: https://portingguide.readthedocs.io/en/latest/imports.html#absolute-imports
* Queue renamed to queue in python 3
Use the six compatibility library to support both python 2 and 3: https://portingguide.readthedocs.io/en/latest/stdlib-reorg.html#renamed-modules
* replace dict.has_key() with in
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#removed-dict-has-key
* make dict views compatible with python 3
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#dict-views-and-iterators
Where needed, wrapping things that will be a view in python 3 with a list(). For example, if it's accessed with []
Python 3 has no iter*() methods, so just using the values() instead of itervalues() as long as it's not too performance intensive. Note that any minor performance hit of using a list instead of a view will go away when switching to python 3. If it is intensive, we could use the six version.
* Explicitly use truncating division
python 2 to 3: https://portingguide.readthedocs.io/en/latest/numbers.html#division
python 3 treats / as float division. When we want the result to be an integer, use //
* replace map() with list comprehension where a list result is needed.
In python 3, map() returns an iterator.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* replace filter() with list comprehension
In python 3, filter() returns an interatoooooooooooor.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* wrap zip() in list() where we need the result to be a list
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-zip
* clean out some lint
Removes these pylint warnings:
************* Module selfdrive.car.chrysler.chryslercan
W: 15, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 16, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 25, 0: Unnecessary semicolon (unnecessary-semicolon)
************* Module common.dbc
W:101, 0: Anomalous backslash in string: '\?'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
************* Module selfdrive.car.gm.interface
R:102, 6: Redefinition of ret.minEnableSpeed type from float to int (redefined-variable-type)
R:103, 6: Redefinition of ret.mass type from int to float (redefined-variable-type)
************* Module selfdrive.updated
R: 20, 6: Redefinition of r type from int to str (redefined-variable-type)
old-commit-hash: 9dae0bfac4
2019-05-02 11:08:59 -07:00
2cc4edde68
openpilot v0.5.9 release
...
old-commit-hash: 0207a97040
2019-02-20 01:39:02 +00:00
3bde47d556
openpilot v0.5.8 release
...
old-commit-hash: b967da5fc1
2019-01-23 15:34:52 -08:00
bed4bd3c37
Adding GM Steering Rate ( #495 )
...
* adding steering rate
* adding steering rate
old-commit-hash: b78ed77f1d
2019-01-08 19:40:09 -08:00
f8ce921247
openpilot v0.5.7 release
...
old-commit-hash: 210db686bb
2018-12-10 14:13:12 -08:00
b406c7fb22
GM: Cadillac ATS Coupe 2018 support ( #445 )
...
* GM: Cadillac ATS Coupe 2018 support
* Missed adding Cadillac ATS
old-commit-hash: 024870d16a
2018-12-06 21:22:21 -08:00
582cc400cf
Adding support for 2018 GMC Acadia Denali ( #453 )
...
* added acadia
* adding acadia
* adding acadia
* Update radar_interface.py
* adding acadia
* refactored
* fixed tuning
* Adding acadia
* Update interface.py
* fixed whitespace
* fixed whitespace
old-commit-hash: 68e56c8017
2018-12-04 08:35:36 -08:00
a7dcbc2e33
Add initial support for Holden/Opel Astra BK ( #431 )
...
old-commit-hash: c9dd7fe0e6
2018-11-20 20:12:50 -08:00
acce43eb0f
GM: remove refactor leftovers ( #440 )
...
old-commit-hash: e4ed48928b
2018-11-18 16:13:44 -08:00
fdbf213be8
openpilot v0.5.6 release
...
old-commit-hash: 860a48765d
2018-11-17 02:08:34 -08:00
4b1b3ae3e1
Revert the changes to GM in 0.5.4 ( #380 )
...
* Revert 0.5.4 changes for GM for 18ers
* Redo the refactor of stock control msgs
* Fixed missing CONTROL_MSGS -> STOCK_CONTROL_MSGS
* Remove spacing
* Need candidate array idx
old-commit-hash: 8cc32df779
2018-10-01 19:13:34 +02:00
7062c6dcc4
openpilot v0.5.4 release
...
old-commit-hash: a422246dc3
2018-09-25 00:13:41 -07:00
f86034846c
GM: go passive if detected ASCM or LKA camera ( #350 )
...
Since fingerprint is powertrain CAN only, camera still present
on object bus is not an issue.
old-commit-hash: faea9a42c4
2018-09-06 20:59:05 +02:00
d63ae5c7d0
Fix pre-enable engagement on GM ( #348 )
...
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas
is commanded while user presses gas pedal. PID winds up,
and when PCM fault clears, car gets a "max gas" jolt.
In 2018 Volts, PCM fault doesn't time out, which means pre-enable
doesn't work at all, and car would slowly decelerate, while openpilot
thinks it's engaged.
old-commit-hash: 9653f9d6a6
2018-09-04 00:16:09 -07:00
Adeeb Shihadeh