Commit Graph

15 Commits

Author SHA1 Message Date
HaraldSchafer 2d945b2fd5 Torque control: higher low speed gains and better steering angle deadzone logic (#24980)
* Try no friction and no deadzone

* Learn fromd ata

* update refs
old-commit-hash: b3226d505b9260ec8565acfda7138601a76039a6
2022-06-27 15:25:47 -07:00
Adeeb Shihadeh 145f3c96ba cleanup torque tuning config (#24951)
old-commit-hash: 062a8bcdbd78826cbb035c1dabc6ebd18a9367dd
2022-06-24 13:01:49 -07:00
HaraldSchafer 5e002bff96 Torque control: low speed boost (#24859)
* Make very low speed more aggressive

* Less extreme low speed boost

* Update ref
old-commit-hash: a6652a539d8d4ba614b216900c472cc9e2e58a05
2022-06-14 22:29:08 -07:00
HaraldSchafer bc679f735d Misc torque control fixes (#24801)
* Fiction compensation should be based on error

* Update refs

* Add deadzone

* update ref
old-commit-hash: 843e59f6f0be33e6c51a35ef8912f5b7c4b58ca5
2022-06-10 22:52:48 -07:00
ClockeNessMnstr 52a28d8938 update DH names + notes for MPC output curvatures (#24701)
* update names + notes for MPC outputs

"current_curvature" is not the correct description of what the MPC is outputting in it's curvature_ego state.
The MPC is integrating it's free variable, curvature_rate, such that curvature[0] is actually the desired_curvature before any delay.
inversely: the curvature_rate_desired is the desired rate of change to the setpoint and not the actual curvature rate. 

If we were to set the initial curvature = measured curvature in the MPC initiation these names would be correct. 
This was possibly how it was initially set up but the nomenclature here is now confusing.

* more notes

* match

* Clarify #1
old-commit-hash: b215d611b1adf5ea2b93e6628936f2e73539f34f
2022-06-07 09:41:03 -07:00
Shane Smiskol 1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c04bec31677170782d5f3e1f404c2a7
2022-06-03 17:41:20 -07:00
HaraldSchafer f5a6a6dc77 Tssp prius torque control (#24669)
* use llk

* use steering sensor at low speed stil

* Try more simple

* rm prius tune

* updated ref
old-commit-hash: d708a134bdff9db5cc65491dd9129a709e30ad34
2022-05-27 10:21:02 -07:00
HaraldSchafer 39886246c9 Rerevert torque control (#24649)
* Revert "Revert torque control (#24565)"

This reverts commit 93f434d047a92366c4ccefeece86fe101ed98d02.

* Move tune out of car specific stuff

* Update ref commit
old-commit-hash: d9289721503976cd99ac90216c502a841988c1a6
2022-05-24 17:52:33 -07:00
HaraldSchafer 51165e5df5 Latcontrol torque: integrator need not be reset (#24606)
slow integrators need not be reset
old-commit-hash: 2181bbca71d9d9c8bfe7a6b2bb26241a84138607
2022-05-20 13:50:47 -07:00
ClockeNessMnstr a7dceb30ae LatControlTorque: clean up class variable (#24526)
* move to super

* no class variable

* there's CP

* whitespace

* drop CI from latcontrol super

* Revert "drop CI from latcontrol super"

This reverts commit 9218273060ade6431c4fc4c310b27e7e210158b9.

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: a693b3a26b2dcbd7910e4fa98318f23c13c3d815
2022-05-13 16:52:20 -07:00
HaraldSchafer 3427eb411b Latcontrol torque: fix integrator induced ping pong (#24458)
* Latcontrol torque: fix integrator induced ping pong

* Reset on disengage since unwind resets anywayh

* Might be overkill

* rm whitespace

* update ref
old-commit-hash: 29afd53d88f5c98efdac8727f3df1e4679790cde
2022-05-06 22:17:21 -07:00
ntegan1 af82274bac LatControlTorque: log desired/actual lateral accel (#24406)
* log torque lateral accel

* bump cereal

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9a44d4c4e0895f88dd5cd716ce3e2d6ebeab3457
2022-05-03 14:18:46 -07:00
Shane Smiskol 12d0a18a05 Clean up controllers (#24340)
* clean up lat controllers

* pass CP once

* sort
old-commit-hash: c9be2f02c3877fe00674ea7fc86912234376a36a
2022-04-28 00:42:52 -07:00
Shane Smiskol 3e9694d3f3 LatControlTorque: fix deadzone and missing steer saturated warning (#24294)
* fix steer saturated alert and deadzone

* fix and formatting

* update refs

* update refs

* not needed

* remove
old-commit-hash: e834b4d9bed65e672c25c6e9ba67d41f2a1c8329
2022-04-27 01:18:05 -07:00
HaraldSchafer 2174005f05 Lateral torque-based control with roll on TSS2 corolla and TSSP rav4 (#24260)
* Initial commit

* Fix bugs

* Need more torque rate

* Cleanup cray cray control

* Write nicely

* Chiiil

* Not relevant for cray cray control

* Do some logging

* Seems like it has more torque than I thought

* Bit more feedforward

* Tune change

* Retune

* Retune

* Little more chill

* Add coroll

* Add corolla

* Give craycray a good name

* Update to proper logging

* D to the PI

* Should be in radians

* Add d

* Start oscillations

* Add D term

* Only change torque rate limits for new tune

* Add d logging

* Should be enough

* Wrong sign in D

* Downtune a little

* Needed to prevent faults

* Add lqr rav4 to tune

* Try derivative again

* Data based retune

* Data based retune

* add friction compensation

* Doesnt need too much P with friction comp

* remove lqr

* Remove kd

* Fix tests

* fix tests

* Too much error

* Get roll induced error under 1cm/deg

* Too much jitter

* Do roll comp

* Add ki

* Final update

* Update refs

* Cleanup latcontrol_torque a little more
old-commit-hash: fe0bcdaef6b1fd3fc9d855aefeba755b35dfc222
2022-04-19 19:34:31 -07:00