Commit Graph

110 Commits

Author SHA1 Message Date
Adeeb Shihadeh 8e8f61ad35 camerad: IFE debayer support (#33720)
* ife is up

* split out cdm, bps needs this too

* straight to vipc buffer

* start reducing the diff

* support both

* disable for now

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-10-12 13:07:30 -07:00
Adeeb Shihadeh 747acaac71 camerad: prep to unify IFE + BPS processing (#33770)
* unify

* fixup

* start porting over ife branch

* setup new bufs

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-10-11 20:49:30 -07:00
Adeeb Shihadeh 50baf37ddd camerad: fix CAM_SYNC requests (#33757)
* camerad: fix CAM_SYNC requests

* cast

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-10-09 11:56:46 -07:00
Adeeb Shihadeh 8cf1b79189 camerad: more ISP prep (#33752) 2024-10-08 14:07:13 -07:00
Adeeb Shihadeh 853febe21d visionipc: remove RGB support (#33739)
* visionipc: remove RGB support

* bump

* msgq master

* fix sim
2024-10-07 13:24:57 -07:00
Dean Lee 2cb526a5a9 camerad: refactor gain index loop for clarity (#33613)
* Refactor Gain Index Loop for Clarity

* Update system/camerad/cameras/camera_qcom2.cc

* Update system/camerad/cameras/camera_qcom2.cc

---------

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-09-29 10:06:34 -07:00
Adeeb Shihadeh 62d044c794 camerad: IFE config definitions (#33624)
* camerad: more definitions for IFE config

* comment
2024-09-22 15:49:12 -07:00
Adeeb Shihadeh d5039bcbbe camerad: reduce internal ISP buffer count (#33619) 2024-09-22 14:24:37 -07:00
Robin Reckmann 312a1b2a65 camerad: fix: Explicitly include necessary headers (#33623)
camerad: Explicitly include necessary headers
2024-09-22 14:15:01 -07:00
Dean Lee 07f3f93bd9 camerad: remove SpectraCamera inheritance from CameraState and simplify initialization (#33611)
remove inherit

Co-authored-by: Comma Device <device@comma.ai>
2024-09-20 11:15:49 -07:00
Adeeb Shihadeh 20c983897b camerad: set patch_offset 2024-09-19 20:57:42 -07:00
Adeeb Shihadeh bdb4b87fa5 rm debug print 2024-09-19 16:39:30 -07:00
Adeeb Shihadeh df9b8f0222 camerad: final debayer prep (#33598)
* prep part 4?

* cleanup

* little less magic

* reorg

* final touches

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-09-19 16:14:29 -07:00
Dean Lee eaebea0968 camerad: cleanup includes (#33600)
cleanup includes

Co-authored-by: Comma Device <device@comma.ai>
2024-09-19 14:16:48 -07:00
Dean Lee 34f5ba46b3 camerad: move handle_camera_event to SpectraCamera class (#33595)
move handle event

Co-authored-by: Comma Device <device@comma.ai>
2024-09-19 11:34:37 -07:00
Adeeb Shihadeh eea06b4c3e camerad: camera_util is spectra (#33597)
* camerad: camera_util is spectra

* lil more

* mv that

* fix build

* runs on device

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-09-19 11:22:46 -07:00
Dean Lee 943aa616b3 camerad: add helper function get_gain_factor (#33594) 2024-09-19 10:58:49 -07:00
Dean Lee b852aba670 camerad: fix POLLPRI event check in poll loop (#33591)
fix event check in poll loop to validate POLLPRI
2024-09-19 10:58:06 -07:00
Dean Lee c95f0f039f camerad: move debugging parameters from camera_common.h to camera_qcom2.cc (#33589)
move debugging parameters

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-09-19 10:45:57 -07:00
Dean Lee 78db136914 camerad: remove libyuv dependency (#33593)
remove libyuv
2024-09-19 10:41:51 -07:00
Dean Lee 467bd74944 camerad: remove CameraType enum from camera_common.h (#33588)
remove CameraType from camera_common.h
2024-09-19 10:33:24 -07:00
Adeeb Shihadeh 80013219fe camerad: abstract out ISP handling (#33583)
* spectra and tici

* master

* move the rest

* rm stupid indirection

* start move

* multi cam state is dead

* rest is moved

* lil more

* mv that

* lil more

* fix pc build

* we haven't done rgb for a while

* bring this stuff back

* fix mac?

* no camera in ui!

* i remember why we always cut mac

* fix mac build

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-09-18 22:24:53 -07:00
Adeeb Shihadeh 718835a825 camerad: prep part 2 (#33584)
* no camerastate in sensors

* bring this over

* and encoder
2024-09-18 21:10:45 -07:00
Adeeb Shihadeh 5378e63812 it's not really rgb 2024-09-18 21:01:38 -07:00
Adeeb Shihadeh b733b875f8 camerad: ci -> sensor rename (#33582)
* camerad: ci -> sensor rename

* no behavior change for now
2024-09-18 15:51:03 -07:00
Dean Lee ad42551437 camerad: encapsulate cl_command_queue in ImgProc (#33178)
move cl queue to imgproc
old-commit-hash: 8f9b165de8be31b8c68dfa31e7f6a036107aa2e4
2024-08-03 14:57:26 -07:00
Dean Lee 7adc4219f0 camerad: update frame msg related variable types to uint64_t for consistency (#33113)
Update frame_msg related variable types to uint64_t for  type safety
old-commit-hash: c40d129f70338674302116cfdde129ba6511a920
2024-08-02 12:57:29 -07:00
Dean Lee 2a16a305b3 camerad: move do_exit to camera_qcom2.cc (#33086)
move do_exit to camera_qcom2.cc
old-commit-hash: 8ab587d30b461cf52844a351b912e3560b9dcbcd
2024-08-02 12:18:10 -07:00
Dean Lee b12b30c328 camerad: encapsulating event management within the ImgProc Class (#33119)
Encapsulating Event Management Within the ImgProc Class
old-commit-hash: 2189164d455aba0c72192881bef43a1cee8f3d3b
2024-08-02 12:16:04 -07:00
ZwX1616 03fa24ee82 camerad: use os binning (#33161)
* all

* right sz

* what is this

* Revert "what is this"

This reverts commit 3ff771926f109452a055dfb61cee06b34e498164.

* ok

* big

* update intrs

* fl

* more specifuc

* fish

* revert

* revert

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 3ccc63deec85f454521d465c4e0e3438e76cb547
2024-07-31 19:10:44 -07:00
Dean Lee 01ac526046 camerad: merge thread functions into one (#33025)
merge multiple thread functions into one
old-commit-hash: ccd369ee9639beae479704615f198902d58135b9
2024-07-25 15:05:14 -07:00
Dean Lee 5b5e3ef053 camerad: add CameraConfig struct for initializing CameraState in constructor (#33065)
* Add CameraConfig struct for initializing CameraState in constructor

* init member variables
old-commit-hash: 75f49f84f3b71c970e7f4a5768016a092175e870
2024-07-25 13:09:03 -07:00
Dean Lee 4d6d229820 camerad: refactor camera_open() into separate functions for clarity (#33056)
split function
old-commit-hash: 0fa6745a67b60a572cfa4060d8155ac50f4e4e06
2024-07-24 10:07:10 -07:00
Adeeb Shihadeh 5025140f37 Revert "camerad: add CameraConfig struct for initializing CameraState in constructor (#33034)"
This reverts commit 8ef650da47eec8b64e2aedcba5114ca1a2428a89.

old-commit-hash: cefe00c964d41f5ac15f13bc83b3e389d8965a5e
2024-07-21 20:36:45 -07:00
Dean Lee 3f327ef4d3 camerad: add CameraConfig struct for initializing CameraState in constructor (#33034)
* Add CameraConfig struct for initializing CameraState in constructor

* Update system/camerad/cameras/camera_qcom2.h

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dc886e195f9815c77b721a8a438bbdffe9067e38
2024-07-21 19:19:34 -07:00
Dean Lee cc3f9090bf cereal: deprecate FrameData.frameType (#33019)
deprecate FrameData.frameType
old-commit-hash: 917ea5699f3af241e60311455af5f20c0c55a8c4
2024-07-19 10:14:04 -07:00
Harald Schäfer f870a968e9 Split cereal into cereal/msgq (#32631)
* squash

* fix doc

* compile device

* compile device

* Update ref

* add msgq to precommit exclusions

* No service ports

* fix compile

* address comments

* More comments

* Delete logger

* Update opendbc

* Linting

* bump msgq
old-commit-hash: e71ec4e8d7e39a56235f590227e7cb361cd8b79d
2024-06-06 14:31:56 -07:00
Andrei Radulescu 1cbb26bcc7 camerad: cast ci->image_sensor to unsigned short (#32317)
fixes 24.04 build
old-commit-hash: 6a52507e3a7479cdb3e4626de164290d839b926c
2024-05-01 15:00:25 -07:00
Dean Lee 2772be8303 camerad: Localizing the variable "ret" (#32294)
Localizing the variable "ret"
old-commit-hash: edb683a62bf0944974d9c781b3fe1ab4daba739b
2024-04-25 11:08:27 -07:00
ZwX1616 cc3550df2a camerad: OS HDR (#32112)
* it's something

* backup

* 16:10

* cleanup

* this is fine

* close

* remove some junk

* no heck

* disos

* real 10

* for some reason this is flipped

* 20hz

* no return

* ae

* tear

* need curve laster

* correct real gains

* fix time

* cleanup

* why the scam

* disable for now

* 0.7

* hdr

* that doesnt work

* what

* hugeoof

* clean up

* cleanup

* fix regs

* welp cant

* is this corrent

* it is sq

* remove

* back

* stg10bit

* back2ten

* Revert "remove"

This reverts commit 18712ab7e103c12621c929cd0f772ecb9b348247.

* 20hz and swb

* correct height

* 10bit

* ui hack for now

* slight

* perfect

* blk64

* ccm

* fix page faults

* template

* set 4x

* is this fine

* try

* this seems to work

* Revert "this seems to work"

This reverts commit d3c9023d3f14bd9394fed2d6276dba777ed0e606.

* needs to be static

* close

* 64 is optimal

* 2

* take

* not 1

* offset

* whats going on

* i have no idea

* less resistence

* box defs

* no

* reduce blur artifacts

* simplify

* fix

* fake short is too much for bright

* can be subzero

* should not use lsvc

* no wasted bit

* cont no slow

* no less than 10bit

* it is based

* wrong

* right

* quart

* shift

* raise noise floor

* 4.5/4.7

* same ballpark

* int is fine

* shane owes me m4a4

* Revert "shane owes me m4a4"

This reverts commit b4283fee18efebedae628a6cfd926ff1416dcfe5.

* back

* Revert "4.5/4.7"

This reverts commit e38f96e90cb5370bd378f6b66def9e7e3ed0ce5d.

* default

* oof

* clean up

* simpilfy

* from sensorinfo

* no div

* better name

* not the wrong one

* not anymore relevant

* too

* not call it debayer

* cl headers

* arg is 2nd

* gone is is_bggr

* define

* no is hdr

* rgb_tmp

* p1

* clean up

* 4

* cant for

* fix somewhre else

* const

* ap

* rects

* just set staruc

* nnew tmp

* hmm

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 03d1c48017b2169dd3d559989e72c4925eafb264
2024-04-19 13:44:03 -07:00
ZwX1616 f466145f34 image processing refactor and test (#32249)
* it's something

* backup

* 16:10

* cleanup

* this is fine

* close

* remove some junk

* no heck

* disos

* real 10

* for some reason this is flipped

* 20hz

* no return

* ae

* tear

* need curve laster

* correct real gains

* fix time

* cleanup

* why the scam

* disable for now

* 0.7

* hdr

* that doesnt work

* what

* hugeoof

* clean up

* cleanup

* fix regs

* welp cant

* is this corrent

* it is sq

* remove

* back

* stg10bit

* back2ten

* Revert "remove"

This reverts commit 18712ab7e103c12621c929cd0f772ecb9b348247.

* 20hz and swb

* correct height

* 10bit

* ui hack for now

* slight

* perfect

* blk64

* ccm

* fix page faults

* template

* set 4x

* is this fine

* try

* this seems to work

* Revert "this seems to work"

This reverts commit d3c9023d3f14bd9394fed2d6276dba777ed0e606.

* needs to be static

* close

* 64 is optimal

* 2

* take

* not 1

* offset

* whats going on

* i have no idea

* less resistence

* box defs

* no

* reduce blur artifacts

* simplify

* fix

* fake short is too much for bright

* can be subzero

* should not use lsvc

* no wasted bit

* cont no slow

* no less than 10bit

* it is based

* wrong

* right

* quart

* shift

* raise noise floor

* 4.5/4.7

* same ballpark

* int is fine

* shane owes me m4a4

* Revert "shane owes me m4a4"

This reverts commit b4283fee18efebedae628a6cfd926ff1416dcfe5.

* back

* Revert "4.5/4.7"

This reverts commit e38f96e90cb5370bd378f6b66def9e7e3ed0ce5d.

* default

* oof

* clean up

* simpilfy

* from sensorinfo

* no div

* better name

* not the wrong one

* not anymore relevant

* too

* not call it debayer

* cl headers

* arg is 2nd

* gone is is_bggr

* define

* no is hdr

* rgb_tmp

* p1

* clean up

* 4

* cant for

* fix somewhre else

* const

* ap

* rects

* just set staruc

* nnew tmp

* pull it for now

* 12

* common rect

* Revert "not anymore relevant"

This reverts commit 1d574673a16cc31b7a255609e07775c3579eef15.

* Revert "too"

This reverts commit c2d4dcc52a859fe799362f9fcc2ffda99b264e50.

* Revert "Revert "too""

This reverts commit 0abbabe1fde51592f1619058638b4ac6a6dee4b3.

* no tol is fine

* rename

* sensor id

* unsgin

* flag

* some linalg

* cast

* should be h ref

* cap

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 331c7b103a7e4349c75be373589fc68161e69500
2024-04-18 21:45:59 -07:00
ZwX1616 ec2d235c69 camerad: OS04C10 operational (#31674)
* it's something

* backup

* 16:10

* cleanup

* this is fine

* close

* remove some junk

* no heck

* disos

* real 10

* for some reason this is flipped

* 20hz

* no return

* ae

* tear

* need curve laster

* correct real gains

* fix time

* cleanup

* why the scam

* disable for now

* 0.7

* hdr

* that doesnt work

* what

* hugeoof

* clean up

* cleanup

* fix regs

* welp cant

* is this corrent

* it is sq

* remove

* back

* add base comment

* clean up

* make orders clear

* not abcd

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7eb1e958848c6fdb0865da95eaba991252ca9fd6
2024-03-08 16:43:18 -08:00
Adeeb Shihadeh 402e8f8b0e encoderd: fix large frames (#31681)
* encoderd: fix large frames

* Update camera_common.cc

* just do this for now

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 84797482e909ce017385fb3510d564ee5b08045d
2024-03-06 16:19:08 -08:00
Justin Newberry de4644aa73 camerad: assert isp started successfully (#31385)
* isp assert

* disable this for testing

* Revert "disable this for testing"

This reverts commit e65cf6d4b457babcc1a980d40079a2d6aa6540b8.

* move below
old-commit-hash: c9951e9d6c14b860d4b13952fca5540a91ff5813
2024-02-10 14:49:45 -08:00
Adeeb Shihadeh 1d1514449c OS04C10 support (#30658)
* getting frames

* ok

* support both output

* cleanup

* fix unused

* undo

* fix release files

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: cd1d7eb4d2e590c56a570e6f45189eb10401401c
2024-01-09 14:19:10 -08:00
Adeeb Shihadeh cef8286550 camerad: log request id (#30935)
* camerad: log request id

* bump cereal

* bump cereal
old-commit-hash: 91c5c5eca765c990ff185a4a0bda7207eb55787d
2024-01-08 09:16:50 -08:00
Dean Lee cbbbaf22b7 camerad: zero memory before returning from MemoryManager::alloc (#30781)
* zero memory

* remove redundant memset

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: b9080d23627849aafc4969d39df50cc615ffecdf
2023-12-18 13:54:11 -08:00
Dean Lee 6ae3e95542 camerad: cleanup includes (#30782)
* cleanup includes

* continue

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: ab0b26d2b8dc8b3957812856917084af2cb3df0a
2023-12-17 22:42:52 -08:00
Dean Lee 9c4376a57f camerad/CameraBuf: remove deprecated rgb_stride (#30758)
old-commit-hash: ea7e701052f8da1fb562746c62bdb5a64410ea76
2023-12-15 19:48:26 -08:00
Dean Lee 89395a7a3f camerad/CameraBuf: rename yuv_type to stream_type (#30695)
old-commit-hash: 62670e66bfb93f2d203abcb675f93ccac39d768a
2023-12-11 21:53:27 -08:00