Commit Graph

9266 Commits

Author SHA1 Message Date
Adeeb Shihadeh 2e6ca5dd05 debug: add summary to check_timings
old-commit-hash: 20a44bb4e9e36e525e0caa6694c6cb863a23b538
2024-06-08 21:01:39 -07:00
Adeeb Shihadeh 8da4e94289 pandad: fix receive buffer size on failed transfer (#32670)
old-commit-hash: 1093a4ac8217030ae4a0c73ba54bc734a6010acc
2024-06-08 20:43:25 -07:00
Adeeb Shihadeh 8472df65ea tools/sim: remove special docker image (#32659)
old-commit-hash: 541b5cbf1387df07e76da55d3e332170d9e756f0
2024-06-08 09:18:28 -07:00
Nelson Chen dfd4374739 Change the term "Non-US" to "South America" for the "Corolla Hybrid (Non-US only) 2020-23" entry (#32658)
The term "Non-US" in cars.md for the "Corolla Hybrid (Non-US only) 2020-23" is not precise enough and should be changed to South America

Users may think "Non-US" includes Europe or Canada, which is not the case for this entry.

It has two issues:

* The 2023 Corolla Hybrid in Europe and Canada include a new Toyota Safety Sense 3.0 that has yet to be supported due to it being a new version and the presence of Toyota Security Key.
* The 2020-2022 Corolla Hybrid in Europe is the same as the 2020-2022 Corolla Hybrid in North America, which is supported by Openpilot and has full-speed ACC due to the presence of an electronic parking brake which is not present in the 2020-2022 Corolla Hybrid in South America and the reason why it is listed as not having full-speed ACC.

The entry should be reverted to at least "Corolla Hybrid (South America) 2020-23" which was proposed but not merged in the pull request:

https://github.com/commaai/openpilot/commit/28454c04cc93dc241da3b004a7154e44313e85c9

Pull request for that change that does not include that commit: https://github.com/commaai/openpilot/pull/26943

Examples of confusion throughout the community:

comma.ai Discord:

https://discord.com/channels/469524606043160576/524327905937850394/1235264758580772996

https://discord.com/channels/469524606043160576/524327905937850394/1228090600272691370

https://discord.com/channels/469524606043160576/954493346250887168/1209952008329633813

https://discord.com/channels/469524606043160576/524327905937850394/1182093384647721140

https://discord.com/channels/469524606043160576/954493346250887168/1147751657543848017

openpilot community Discord:

https://discord.com/channels/771493367246094347/771495215570747403/1247737844727021629

> I think that the supported cars list (https://github.com/commaai/openpilot/blob/master/docs/CARS.md) is incorrect.
>
> I have a UK 2020 Toyota Corolla Hybrid
>
> In the cars list it's listed as "no accel below" 17 mph and no resume from > stop.
>
> This is not my experience. For me it works just fine down to a complete stop and it can resume from a stop too.
>
>

CC: @AlexandreSato
old-commit-hash: 3b6862030a550b92e8ecc5a51de61811ad12d6b9
2024-06-08 09:18:00 -07:00
Adeeb Shihadeh ae8f9da48d pandad: fix loopback test (#32656)
* pandad: fix loopback test

* clear all params

* try this

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 57f21abb4fe3ae81842adc07fb79a1d2c056fee0
2024-06-07 23:58:14 -07:00
Shane Smiskol 945c6b94fa remove old fingerprints test (#32654)
* is this even used?

* remove
old-commit-hash: 90523b3b000e355599a1f2c7d3c90cb6b8498c66
2024-06-07 23:38:51 -07:00
Adeeb Shihadeh 97bfed714c card: remove old canRcvtimeout field (#32650)
* card: remove old canRcvtimeout field

* deprecate
old-commit-hash: b42b156fcd8d98adee9e6b5384558cfabd4f2165
2024-06-07 17:03:17 -07:00
Adeeb Shihadeh ba34590567 controlsd: remove last mention of CAN (#32646)
old-commit-hash: a7ed190df4665a7f972862c992455bfd7daa6eab
2024-06-06 16:46:27 -07:00
Harald Schäfer f870a968e9 Split cereal into cereal/msgq (#32631)
* squash

* fix doc

* compile device

* compile device

* Update ref

* add msgq to precommit exclusions

* No service ports

* fix compile

* address comments

* More comments

* Delete logger

* Update opendbc

* Linting

* bump msgq
old-commit-hash: e71ec4e8d7e39a56235f590227e7cb361cd8b79d
2024-06-06 14:31:56 -07:00
Vivek Aithal dec353a9de [Lag] Increase Optima Lag (#32583)
increase lag in optima to 0.2
old-commit-hash: e8857a6713db6b8b3b8cd67aca1b8c046a4dccd9
2024-06-06 01:14:28 -07:00
Dean Lee eb6e134869 events.py: rename event counters (#32596)
* improve prev event counters

* just rename

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 983063c3e6ce344b8569814fcdc2eafc2830c4e9
2024-06-06 00:13:57 -07:00
Dean Lee 6f9e28d8f2 fuzzy_generation.py: improve performance (#32591)
* improve performance

* remove DEPRECATED

* formatting

* catch kjException

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3a43f5d7844611cd5c770748b7d235974c3eb97d
2024-06-05 23:48:20 -07:00
Shane Smiskol 9778515344 Genesis G70 2020: use common specs (#32641)
use non-2020 specs
old-commit-hash: ae375091dbc86aaca7a1bf2d9e7e3e9281a33495
2024-06-05 23:44:19 -07:00
Dean Lee eb13fda0b4 improve get_torque_params (#32586)
* Loading torque data only once and reusing it across function calls.

* apply review

* still check only one entry

* fix that

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 045b9f20b717e7c5d68f84df4715bb596530b046
2024-06-05 21:21:16 -07:00
Solomon Jones 682c862351 Fingerprint for 2017 Subaru Forester (#32584)
Fingerprint for 2017 Forester
old-commit-hash: a418c9e40a273dc83efefb46a2ef5a034d9c92d3
2024-06-05 21:18:29 -07:00
Dean Lee 9706498c7a car/interfaces.py: optimize parse_gear_shifter() with predefined dictionary (#32592)
Optimize gear shifter parsing for improved performance
old-commit-hash: 91fd918fcbed4f5aa828d0ec59169c42d50cdcd0
2024-06-05 18:04:03 -07:00
Shane Smiskol 70230f5cef Restore lateral limits report (#32640)
* stash

* staaaaash

* clean up

* more clean up

* fix

fix

* fix

* stash

clean up

* more

* this is just simpler to understand

* explicitly check
old-commit-hash: 7cfd91bb69ce1a8ccc9c1f25907d33d14e8181d4
2024-06-05 18:03:23 -07:00
Adeeb Shihadeh bc76ae701b fix linter
old-commit-hash: 260e18f0aedc3bdbf65b357948e6b5067a296439
2024-06-05 17:32:47 -07:00
Adeeb Shihadeh d2948c3fcd pandad: add more context to spi logs (#32639)
* pandad: add more context to spi logs

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e828a7bdcf7744102a321b68076ad7842ec31af4
2024-06-05 17:27:57 -07:00
Adeeb Shihadeh 30c41788dc thermald is hardwared (#32637)
* thermald is deviced

* hardwared

* rename
old-commit-hash: 51fdf2330453fe863597db0eb8daf87c2ec4ff8d
2024-06-05 15:58:00 -07:00
Adeeb Shihadeh ca0bc15d6b pandad: add jungle spam mode to test (#32636)
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: a46f1c6eba712e2814619d37427a3aaaee50fc3a
2024-06-05 15:23:25 -07:00
Adeeb Shihadeh 389daf4018 pandad: move to core 3 (#32402)
* move to core 3

* core is fully offlined now

* move to init

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7b092858172220efd6805d3586355c0f393b2d86
2024-06-05 14:50:25 -07:00
Riley Williams 28eb64e1fd 2024 IONIQ 6 (#32302)
* Tweak carspecs for 2023 (and now also 24) ioniq 6 to reflect public info instead of cloning ioniq 5 specs

* Regenerated car docs

* revert specs *for now*

---------

Co-authored-by: Riley Williams <riley@rileyww.dev>
Co-authored-by: Riley Williams <riley@rileyw.dev>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 7381872a544f48daa3b1f26cf88a61714083801b
2024-06-05 14:34:02 -07:00
Adeeb Shihadeh 22bfc435a9 jenkins: fix unsafe checkout when changing submodules (#32635)
do it twice
old-commit-hash: 95263340493ed516c9a2f84ce770276560007b89
2024-06-05 14:00:55 -07:00
Shane Smiskol da7e6d5b5b [bot] Fingerprints: add missing FW versions from new users (#32605)
Export fingerprints
old-commit-hash: bbc21b9f524a3790bb269ccbf4ff7e784992a82e
2024-06-04 22:09:54 -07:00
Shane Smiskol 1c49e5eb73 Honda: remove programmedFuelInjection ECU (#32626)
* set up for quick test

* remove pgfi

* Revert "set up for quick test"

This reverts commit aa6af2ff838b2cd203a6feaacaa5b4f3b71272ed.

* still query JIC
old-commit-hash: de61d417b92554f1e86bbc9a28e995e9bff650c6
2024-06-04 21:29:05 -07:00
Adeeb Shihadeh 0ace8d0e7f pandad: reset CAN comms on checksum failure (#32629)
old-commit-hash: 877b810ac9e89c62f1cb7632235d4c8f87a4e716
2024-06-04 21:26:16 -07:00
Adeeb Shihadeh 2c6829ed67 boardd is pandad (#32628)
* boardd is pandad

* rename tests
old-commit-hash: 34e329649d7a388d4cd1f25dac9dda9d5409bf4a
2024-06-04 19:16:55 -07:00
Dean Lee 4acd5f4293 LongControl: storing T_IDXS[:CONTROL_N] in a variable for reuse (#32599)
Improve Control Trajectory Interpolation Efficiency
old-commit-hash: 23fcd687071c7825a7d518aec898fcdd536b2855
2024-06-04 17:04:50 -07:00
Shane Smiskol edd2e43239 Honda: helpful non-essential ECU comment
old-commit-hash: e494d989601f295ed1dfbcbfacaf891f26a0408c
2024-06-04 16:37:01 -07:00
Shane Smiskol 65354c789e Hyundai: remove Ioniq EV 2020 CAN fingerprint (#32625)
* add from afc1609bb1584f28

* remove HYUNDAI_IONIQ_EV_2020 CAN fingerprint
old-commit-hash: ba9ea0a25f636d0a425b05e19b5fd1bc4cfee31a
2024-06-04 16:31:16 -07:00
Dean Lee 6e4c3ddb40 modeld: cleanup commonmodel (#32618)
cleanup
old-commit-hash: 2482ed085ebfd2c09394ce59900348334772d58f
2024-06-04 11:20:17 -07:00
Vivek Aithal cf8885b596 [torqued] Reduce friction for some Hyundai cars (#32578)
* reduce friction coeff for ev6 and ioniq6

* Update ref

---------

Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com>
old-commit-hash: 8a4bfcf5b4f4adc5cf9f0c91895d621421e994a2
2024-06-04 11:10:04 -07:00
Dean Lee 2be5c0e970 ui/cameraview: fix deadlock on exit due to Qt::BlockingQueuedConnection (#32620)
fix deadlock
old-commit-hash: 25e15846f1a16407d674f83e1a1125f579181a67
2024-06-04 10:25:46 -07:00
Shane Smiskol 19d9e7ac6b revert marking some files as unexecutable (#32613)
* this is not a test

* these are not tests!
old-commit-hash: c7b3ece37ef4445bcc18403b6a9e0217db4abd96
2024-06-03 17:19:27 -07:00
Adeeb Shihadeh c868694a23 boardd: check CAN in SPI test (#32400)
* test

* little more

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 69f57fb6a890ed17b7ed8e908a870354e5d5d55b
2024-06-03 17:05:06 -07:00
Adeeb Shihadeh 86b6103657 test_*.py files are no longer executable (#32610)
* test_*.py files are no longer executable

* cleanup empty lines

* update precommit

* fixme

* enable

* build
old-commit-hash: c59887c8109dd8d33ea2e7169995184fbe38cc3a
2024-06-03 15:48:56 -07:00
Shane Smiskol 60ed5d6d40 [bot] Fingerprints: add missing FW versions from CAN fingerprinting cars (#32604)
Export fingerprints
old-commit-hash: 7c4b7ce799f7de15384231552c8fef1f9227292a
2024-06-03 14:11:51 -07:00
Dean Lee 375f2a243f LongitudinalPlanner: replace hardcoded length with ModelConstants.IDX_N (#32597)
replace hardcoded length
old-commit-hash: 1e70b23855a50e645325edf6f9548b0de73abe8d
2024-06-02 22:52:45 -07:00
Shane Smiskol b7949ec7ad debug FW fingerprinting: live support (#32585)
* live debug!

* clean up
old-commit-hash: 63f55f4915ebb3763cc6bc9adaba52a77467ff23
2024-05-31 22:28:03 -07:00
Dean Lee c2b13f27b9 api: cache RSA private key (#32566)
old-commit-hash: 9908b729c8af1c608ddd9f2b3d0b1b50a58f39de
2024-05-31 21:40:53 -07:00
cl0cks4fe e77b75d9f0 cache get_torque_params (#32560)
* cache get_torque_params

* switch to cache

* Update selfdrive/car/interfaces.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 8f4b00c263e1942c6a6eed9d24297dff44e7f48f
2024-05-31 13:43:12 -07:00
Shane Smiskol ab16c708e9 add Hyundai CAN FD fingerprinting note
old-commit-hash: f887b8703cfdb764a5f16d624bd4ce8380054a23
2024-05-30 23:08:14 -07:00
Shane Smiskol b41b5cc067 fw_versions debug: match online vin retry
old-commit-hash: 0a43d82428d03662a3a439f7ec5ada7afc39b7a2
2024-05-30 22:20:04 -07:00
William Stairs c0ef111581 Add Chassis for VW Arteon Shooting Brake 2020-2023 (#32579)
* Added Arteon "3H" chassis code for Shooting Brake to VWCarDocs.

* Added new engine and transmission FW to Volkswagen fingerprints.py for Arteon Mk1.

* Apply suggestions from code review

* updates docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 984ad8833aedf20c5cad14996c5e5cafc95fe3fa
2024-05-30 21:35:19 -07:00
Shane Smiskol 2a6e025183 ui: re-generate JWT on valid system time (#32571)
* revert me

* Revert "revert me"

This reverts commit 17d815ddfc9a18f7fb9f39f89ec8b4481389b339.

* duh we have timed!

* clean up

* use clocks

* re-initialize map on SSL handshake failure (time)

* this is fine, takes some time to init

* fix

* log errors like map renderer

* more clean up

full message is "loading style failed: SSL handshake failed"

* MOAR

* we still can't swap the token live

* mbgl has its own retries that never work, don't reinit multiple times at once

* simpler

* more

* whoops

* this works

* fix from merge

* rm

* fix cmt

* only an issue calling the function inside itself
old-commit-hash: 57d64279bdd0a8935586d7f58b68edaf793a73ed
2024-05-30 02:08:31 -07:00
Shane Smiskol 3a1c7c61c6 map window: log style load errors (#32573)
log errors
old-commit-hash: c2f55a2600d6981c1f84360f7c64bbb7a893d25c
2024-05-30 01:52:43 -07:00
ZwX1616 a51790da10 dmonitoringd: set invalid if missing dependence(s) (#32569)
* no step but still send

* no this

* update diff
old-commit-hash: a16fbdae3890b0e547f0113497ff8f713bd2b07b
2024-05-29 15:43:55 -07:00
kacperhq e1ec898b41 KIA SPORTAGE 5th HEV 2022 EUR fingerprint (#32558)
Update fingerprints.py

KIA Sportage 5th GEN EUR ver
old-commit-hash: 325dcec06b5662b6b4c0f8903f0a7ea064fa4b7f
2024-05-28 15:27:08 -07:00
Shane Smiskol 47524c9393 [bot] Fingerprints: add missing FW versions from new users (#32552)
Export fingerprints
old-commit-hash: 521ee46c4704057365a6e08c4571a6eafd5d8dde
2024-05-27 22:01:31 -07:00