Commit Graph

30 Commits

Author SHA1 Message Date
Adeeb Shihadeh 597535c014 linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
old-commit-hash: 2c94f155840b49639b8bf1ec996d99e268fa9a52
2022-01-13 14:19:38 -08:00
Adeeb Shihadeh 88f0be8372 add pre-commit hook for large files (#23505)
old-commit-hash: ee52a61c7d5289d8dbfbd27558177f5757929325
2022-01-12 22:52:58 -08:00
Adeeb Shihadeh 63d9bed046 pre-commit: fix exclude patterns (#23375)
old-commit-hash: a1a9a0f342bc40540d31d1cfbc10c6263a748ef3
2022-01-03 15:24:34 -08:00
Adeeb Shihadeh efa7998d5f update pre-commit hook versions (#22526)
* update pre-commit hook versions

* fix mypy
old-commit-hash: a255449539b690f2bc16fbdf4d3a27297451dcb0
2021-10-14 20:14:00 -07:00
Adeeb Shihadeh 782d7023d2 phonelibs -> third_party (#22477)
* git mv to third_party

* find and replace

* fix release tests

* update pre-commit

* update tici bins

* update eon bins

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 5b641379ae04d3408093381629b9d60dee81da27
2021-10-07 16:32:44 -07:00
Adeeb Shihadeh 760cdcd896 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
old-commit-hash: 9e03aa0b92fd846bc643040fa8b8d4ab06ee2855
2021-08-22 00:27:48 -07:00
Adeeb Shihadeh 03405b81fd acados support (#21319)
* acados support

* add pyextra to python path

* x86 libs
old-commit-hash: 6e4c2aa4d286bb43f091ad13820f564f70e4c0d7
2021-06-17 16:40:00 -07:00
Adeeb Shihadeh d366d2abeb pin pre-commit hook versions
old-commit-hash: 9fbac812e40e1decb4e6f47e70967efe450953bb
2021-01-30 16:55:07 -08:00
Adeeb Shihadeh bc9891b651 external cleanup (#19647)
* remove external

* put back ffmpeg for now
old-commit-hash: 1669e4a5d1444c07c31400a23fc42d8f6cccc837
2021-01-04 14:17:14 -08:00
Willem Melching 9ac982ea34 fix cppcheck on ubuntu 19.10
old-commit-hash: 5f59fd4f40fda2dc07ab140253730058726ea753
2020-07-23 15:24:17 +02:00
Adeeb Shihadeh d8adab2ce5 enable flake8 F error codes
old-commit-hash: d204d87b95114f8aa6e719b4628be2abe8be27dc
2020-06-22 14:00:32 -07:00
Adeeb Shihadeh 0891b1331d Add cppcheck as a pre-commit hook (#1646)
* add cppcheck as a pre-commit hook

* fix Dockerfile

* update precommit config

* exclude panda and opendbc
old-commit-hash: 3c461ca5ccf1b0ae2b9164feced96a5aa4998555
2020-06-19 20:39:34 -07:00
Adeeb Shihadeh 35fe5fa31b remove trailing whitespace pre-commi hook for now
old-commit-hash: c454bff2f842dce9f66bae60e93ad68d0cc392e6
2020-06-05 12:52:55 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Willem Melching dbdbef72d6 vehicle model types (#1631)
old-commit-hash: 240041708450d916bb49ee229ee4cff0e5f5ab59
2020-06-03 13:47:47 -07:00
Adeeb d035394ce7 Add pre-commit hooks (#1629)
old-commit-hash: ab83e48ec4f7c7ddaa742d9797b0d38646fdb268
2020-06-03 12:54:49 -07:00
George Hotz 710710364d fetch image from route script
old-commit-hash: d1d2984f366e6b541b80c5364cd1f17f817ecb02
2020-06-03 11:32:51 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 8b3418b0f9 enable flake8 E251: unexpected spaces around keyword / parameter equals
old-commit-hash: ebed2d1dcc53f092696b61fd1e004045c9bde893
2020-05-31 17:34:47 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Willem Melching 8a32bd3c41 use github url instead of gitlab mirror
old-commit-hash: 266dfe5a9b521d62cfdfdca73ffe622deee82013
2020-05-28 17:45:32 -07:00
Willem Melching 2ac27def5a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
old-commit-hash: ba2ac1207a554d277e01af5b9514de4500d4f66a
2020-05-28 15:40:48 -07:00
Willem Melching 2b60ee9531 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
old-commit-hash: 3d08dcc3b27936cb14c0eae63605be9a6c077380
2020-05-28 15:05:04 -07:00
Willem Melching 12a306021d flake8 in pre-commit(#1583)
old-commit-hash: 29aaa44740b5dae3c1cc0c273c72c7eb53135e5e
2020-05-27 20:33:05 -07:00
Willem Melching c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd0643424357864287ae0485da03f66df85e1fb1
2020-05-27 20:00:14 -07:00