Commit Graph

186 Commits

Author SHA1 Message Date
Shane Smiskol 35a99d7fc6 Common CI._update function (#33289)
* use CP

* no car control, consistent _update function signatures

* eh it's fine to name it whatever

* clean up

* oops

* !!

* now we can delete this!

* nobody does anymore
old-commit-hash: 7248b00086f9b8d5d95c80a2eb7fe89c387f44ea
2024-08-13 22:59:25 -07:00
Shane Smiskol b97ed10ea1 Car interface clean up (#33290)
* remove some defs

* now carstate

* remove carControl from CI update function

* almost merged that

* and that
old-commit-hash: 65fccbf7563ceca5ec84bb75ceb39556371a74de
2024-08-13 21:16:39 -07:00
Shane Smiskol e46d96bb11 Move events out of car interfaces (#33280)
* chrysler down

* honda and ford

* we can pass the class for this

* do the rest

* clean that up

* remove EventName

* fix CI

* move smallest bodies to top

* rm todo

* eps_timer_soft_disable_alert is too ingrained in carcontroller

* re-did everything w/ no diff (except just passing cereal instead of class)
old-commit-hash: cf39cc823ad5aea33af6d51214ffb14bc51ec6c4
2024-08-13 20:40:36 -07:00
Shane Smiskol 6a15aa3f8c interfaces: assume CarState is instantiated (#33284)
test to make sure mock doesn't crash!
old-commit-hash: 3d2fbe9aa3403e635d476fba9c8232b741e54cce
2024-08-13 19:36:21 -07:00
Shane Smiskol 11c9105a60 carState: add invalid sensors field (#33266)
* add to CS

* add vehicleSensorsInvalid to CarState

* fix ord

* clean up
old-commit-hash: 7ec998634097f062afe8fb584e34e4c8a1d9fb54
2024-08-11 23:12:42 -07:00
Shane Smiskol b014b1cc90 Fix some car typing (#33256)
* ??

* fix these

* more typing and some fixes

* fix

* rm this for now

* fix
old-commit-hash: 2dab8b31f20503b2eaf0d11302da31759d9867e2
2024-08-11 19:12:46 -07:00
Shane Smiskol a7db075f08 selfdrive/car: generic CAN send/receive callbacks (#33215)
* start

* hmm API doesn't seem great

* better

* rm line

* sendcan -> can_send callable for best static type coverage, list -> tuple msg

TODO: logcan

* more sendcan -> can_send references

* remove pandad's capnp from selfdrive/car

* fix and remove cereal from test_can_fingerprint

* test_fw_fingerprint: remove pandad, less cereal

* comment done too

* better comment

* fix test_models test

* niceeee it works

* move to can_definitions

* can't come up with a better name :(

* I think we can remove SimpleNamespace soon

* fix test_can_fingerprint.py

* maintain previous behavior

* Revert "maintain previous behavior"

This reverts commit f848fd32132391692c6191a305bb38f74091ec91.

* can test comment

* no need for get_one_can now!

* big clean up: no SimpleNamespace

* now self explanatory!

* not needed

* use empty can again since this is now real

* cmt
old-commit-hash: 9880b1393c7bfc2b71aec01b6b91caffb72f9cc0
2024-08-07 23:49:25 -07:00
Shane Smiskol c1084b3df3 selfdrive/car: rm make_can_msg (#33231)
* rm make_can_msg

* fix
old-commit-hash: bd4f0cec18d7f22f16d906de5c3b0f97ae1450ae
2024-08-07 21:58:16 -07:00
Shane Smiskol 7f4f1d4c5f make_can_msg: returns tuple (#33222)
* bump

* make_man_msg returns tuple

* fix CI.update typing

* bump

* better name

* Revert "better name"

This reverts commit 4deb38d4ed99e43721960f69da1dd46a1069eb42.

* common
old-commit-hash: 51bd3682148ce7a00ac76281d76c278716a1c24a
2024-08-07 16:12:00 -07:00
Shane Smiskol 54d10c2aa3 remove CAN capnp conversion from car interfaces (#33218)
remove pandad from interfaces
old-commit-hash: ba7a60c5a20c5f252bc89ba3e2559edf5ab65c59
2024-08-07 00:05:32 -07:00
Shane Smiskol d8f56b30b5 selfdrive/car: ban common (#33210)
* ban all of common & copy numpy_fast

* add numpy_fast

* these are okay

* and ban controls

* better name

* Conversions

* do utils, kalman

* clean up

* sorting

* don't forget
old-commit-hash: 8d961a12e5b033855f2abf5d8bd9c51374f74c6e
2024-08-06 20:45:11 -07:00
Shane Smiskol 2c49f6b20d selfdrive/car: ban selfdrive/controls (#33211)
ban controls (VM isn't used anymore)
old-commit-hash: 6c837332ea9ae854caf4f7747d3ef84101cd93c6
2024-08-06 16:36:38 -07:00
Shane Smiskol c45e72dd2f remove more car import exceptions (#33193)
* remove another exception (remove mention of events from car stack)

* guess this should've been here all along

* reorganize exceptions

* fix
old-commit-hash: 06216d43bbd0926cfd89c91c43cfc0cf9247c324
2024-08-05 17:27:28 -07:00
Shane Smiskol 799fabd707 Reapply "update to new opendbc API (#32009)" (#33151)
This reverts commit f2f01e3afaeaa267af61c8d7ab918da04d3411f2.
old-commit-hash: 7c112341c358b57ee9d0209cb2b2c53383adcca9
2024-07-31 15:37:39 -07:00
Shane Smiskol 0ea25665bb get_fw_versions: test the full stack (#33156)
* add the test

fix

* bump

* not sure why mypy didn't catch this
old-commit-hash: ebff7cab1ab897526800e229e30b01ec4cf1114c
2024-07-31 14:53:13 -07:00
Shane Smiskol 2c11e7b49a Revert "update to new opendbc API (#32009)"
This reverts commit d21755b2e216c3f547db0b55b7088357c4368801.

old-commit-hash: ac130001cc83734118524f59a83a96a2065dd56e
2024-07-31 02:38:44 -07:00
Dean Lee 2f1ee6e832 update to new opendbc API (#32009)
* use new opendbc api

* export pandad_python

* merge master

* merge master

* bump opendbc

* bump opendbc

* improve func

* keep interface unchanged

* fix test_car_interfaces

* bump opendbc

* bump opendbc

* fix test_models

* the interface now has to convert from can capnp to list, so we should include this time

* goes from ~210 to ~240 mean ms real time

* remoe busTime

* lowercase sendcan

* consistent msgtype

* bump

* bump

* not used in lat_mpc

* space

* bump to master

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 0dddc97dca8bf4e023b29c35cb92fd3dd0a9a3a2
2024-07-31 00:24:46 -07:00
Shane Smiskol b4b3ae5da8 CarController: call to super's init (#33148)
* this should be common

* super!

* bump

* and frame is common

* bump
old-commit-hash: 1b6ac2d876fe3170968944722df67ee815d8cb1b
2024-07-30 23:55:23 -07:00
Shane Smiskol 2cb381997f cars: remove some external imports (#33133)
* ford and gm

* clean that up

* also this

* honda

* temp fix

* move into selfdrive.car

* clean up

* more
old-commit-hash: 0739d79a512965abbe22f0b15c7fddcdd71478d0
2024-07-30 14:27:27 -07:00
Shane Smiskol e8c4fb0177 Reapply "selfdrive/car: ban imports from external modules" (#32993) (#32994)
* Reapply "selfdrive/car: ban imports from external modules" (#32993)

This reverts commit 626d78ec548fe19acfdf3c2c3e063fac3b257dc6.

* controls will just use controls

* also these

* ignore
old-commit-hash: d684d8f0f6900d80a2a1618099b0b8e19e6492a2
2024-07-15 11:59:25 -07:00
Shane Smiskol a878118b00 Revert "selfdrive/car: ban imports from external modules" (#32993)
Revert "selfdrive/car: ban imports from external modules (#32973)"

This reverts commit c1e8ff2dbc47ccb07fb41a4e88bfb66af2669254.
old-commit-hash: 35a4a773f1ff6c7b171b7acdb2fd4a65279edebd
2024-07-15 11:14:04 -07:00
Dean Lee 58df39a2ba selfdrive/car: ban imports from external modules (#32973)
* lint import

* Update selfdrive/car/__init__.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 83d4623590f87dcb7df2b458a8814d5ad6ea711b
2024-07-15 11:12:24 -07:00
Jason Wen ecb9dfecff Hyundai CAN: Log ABS/ESP Activation to espActive (#32743)
* Hyundai CAN: Log active ABS to accFaulted

* Add comments

* `espActive` to CarState and CarEvent.EventName

* re-order

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 36eafc0dc6ea73bcc59df216a3231ae54960a282
2024-06-24 20:14:57 -07:00
Harald Schäfer 47d5601d8a long control: new API (#32706)
* Simplify long control

* Seperate

* Rename

* Try new api for toyota

* rm v_pid everywhere

* No speed in reset

* 0 is better default

* unassigned variable

* Update other cars

* Update gm

* SIMPLIFY

* simplify more

* fix API boundry

* Fix stopping bug

* Small fixes

* Update ref
old-commit-hash: bc303df6a0a4a9d52a2e92e5976b6c7aa5138b95
2024-06-14 00:08:58 -07:00
Harald Schäfer d9fb61da16 Long control: Double delay is super complicated (#32694)
* Double delay is super complicated

* No more upper bound

* DEAD

* Update ref
old-commit-hash: 965415135ac7db4c67ea248ac52535eac537f3bf
2024-06-10 22:29:17 -07:00
Dean Lee eb13fda0b4 improve get_torque_params (#32586)
* Loading torque data only once and reusing it across function calls.

* apply review

* still check only one entry

* fix that

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 045b9f20b717e7c5d68f84df4715bb596530b046
2024-06-05 21:21:16 -07:00
Dean Lee 9706498c7a car/interfaces.py: optimize parse_gear_shifter() with predefined dictionary (#32592)
Optimize gear shifter parsing for improved performance
old-commit-hash: 91fd918fcbed4f5aa828d0ec59169c42d50cdcd0
2024-06-05 18:04:03 -07:00
cl0cks4fe e77b75d9f0 cache get_torque_params (#32560)
* cache get_torque_params

* switch to cache

* Update selfdrive/car/interfaces.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 8f4b00c263e1942c6a6eed9d24297dff44e7f48f
2024-05-31 13:43:12 -07:00
Shane Smiskol 97dc134a42 card: create pedal pressed event (#32417)
* card: create pedal pressed event (#32393)

* move pedalPressed to card

* rm

* needs to be a builder

* move these

* clean up

* reader later

* Update ref_commit

* moved to card
old-commit-hash: d0d44a51a0ff66c1b2da56b3d9864e10ecc2174d
2024-05-13 16:18:55 -07:00
Shane Smiskol 4c7c4272d0 Revert "card: create pedal pressed event" (#32414)
Revert "card: create pedal pressed event (#32393)"

This reverts commit 05be56def1f1fdddb761291e1a40cce459fc7d36.
old-commit-hash: 9287a6962479b63f1628086a73459b4e7e933d59
2024-05-13 14:25:22 -07:00
Shane Smiskol 48bb3caaac card: create pedal pressed event (#32393)
* move pedalPressed to card

* rm

* needs to be a builder

* move these

* clean up

* reader later

* Update ref_commit
old-commit-hash: d18da895d3b70dc62ee3cd8ebeb75de6cf48e7a9
2024-05-13 14:15:26 -07:00
Shane Smiskol 4a0b3c8b64 CarInterface: move stateless, common car events to car interface (#32394)
* move stateless, common car events to car interface

* try to reduce process replay diff a bit

* Revert "try to reduce process replay diff a bit"

This reverts commit b12798deabea67c5a636d6e70e80a3c21c7225ff.

* update refs
old-commit-hash: 3dfb6d7931711c51ecfe0d8c32f0ff928b17a5c9
2024-05-13 12:50:42 -07:00
Adeeb Shihadeh 428f170f59 car: CarController and CarState are always present (#31925)
* always set

* add mock

* little more

* fix

* fix
old-commit-hash: afc96972c80743378ad0e091d9dca8c216b09298
2024-03-19 14:16:33 -07:00
Adeeb Shihadeh cd74ed0489 Abstract out common CarInterface.apply (#31924)
old-commit-hash: 3a7582d9a624ab7b43fd6cf98a19657252b11850
2024-03-19 13:46:31 -07:00
Shane Smiskol 96c2d9358e CarInterface: no platform config fallback (#31873)
* no mock default

* rm
old-commit-hash: d5852ab1b35b42a8d66bd37eee66820ab357a094
2024-03-14 22:27:32 -07:00
Justin Newberry 1f178307f0 move getting platform to get_params (#31871)
* better

* string

* not here
old-commit-hash: ca5a2ed942c7560f11dd85b812c914f944318250
2024-03-14 21:58:25 -07:00
Kacper Rączy 0f8a2c80e0 RadarInterfaceBase: remove no_radar_sleep field (#31715)
Remove no_radar_sleep field from base radar interface
old-commit-hash: ecce4663d3f90d69c4592d3496de650c6714a75f
2024-03-05 16:45:47 -08:00
Justin Newberry e9ca84c95c platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
old-commit-hash: b0eae8c1b7264b2d0c63ee2957689bc1317616f1
2024-03-01 11:31:51 -08:00
Shane Smiskol 2ac06e8d7d Toyota: use platform config (#31607)
* part 1. Toyota platform config

* more

* everything works now

* no more DBC

* janky but that saves a lot of car lines

* need to init inside values or else it won't be reliable

* no return

* fixes

* minor update

* common flags, no dbc grouping

* some clean up

* some clean up

* rename

* copied wrong :(

* another

* copied specs for easiest ones first

* second easiest

* fix erroneous commas

* more clean up

* do the rest

* bug

* the refactor is so error prone

* huh?!

* static

* fix stiffness factor

* detect unsupported DSU

* Revert "detect unsupported DSU"

This reverts commit 9b72de6c8ef282ce20f6472970874a960761884b.

* fix DBC diff

* test carparams

* test sets

* scratch

* catches this

* Revert "scratch"

This reverts commit de08daa9fb8cc0368c5847b669e87b1b2e577616.

* Revert "test sets"

This reverts commit 62402f9b021cdf16a27fd9fb0883d81169711cbd.

* Revert "test carparams"

This reverts commit b02971659c2a8268d0ac8fdff02231dc36b5a197.

* Update ref_commit
old-commit-hash: 52ee070fe0a6880b7e3a5db408a0453c8310be86
2024-03-01 02:14:33 -08:00
Shane Smiskol d35f01464a move CarControllerBase up with other car classes
old-commit-hash: f20bfacb9434d5f9d2a6692352c1f686dec9327f
2024-02-28 20:23:09 -08:00
Justin Newberry 9ccd7f15f9 Subaru: move to flags within PlatformConfig (#31584)
* flags

* update ref

* use the flags directly

* use post_init (don't freeze)

* we can maintain frozen with custom class

* not preglobal

* move to common

* cleanup
old-commit-hash: 3a6c3315ab181bf7390ae1faa6e87c93b1a97338
2024-02-28 20:12:14 -08:00
Justin Newberry c3f35c3fbd add CarControllerBase base class to all CarControllers (#31630)
just base class for now
old-commit-hash: d4c497d82674126103118a4d5bb7a39db2823609
2024-02-28 17:13:44 -08:00
Justin Newberry 36d50a2e45 remove cast for platformconfig (#31604)
* this isnt required

* Cleaner
old-commit-hash: 6d0027342ab00486e9cfbed1ffbd098642f2abd7
2024-02-26 21:01:41 -08:00
Eric Brown 0f78a52a22 GM: move to platform config (#31553)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* Move GM to platform config

* Implement CarSpecs

* Simplify centerToFront

* Accidentally had subaru DBC

* Fix typo in DBC name

* done above

* two spaces

* that is moved up

* fix hardcoded fingerprints

* whitespace

* values

* better?

* fix

* bump

* fix

* fix

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 5012e15aa65f4ee82ce19c856a52909b3a879016
2024-02-25 17:53:26 -08:00
Jason Young 5cb007daf3 VW: Move car specs to PlatformConfig (#31567)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* well that sucked

* cleanup and follow refactor

* diff reduction

* oops

* fix

* force fingerprint

* Revert "force fingerprint"

This reverts commit 600fbcd7d559703601a06c8876a640de417e5b6c.

* space

* Fix specs

* this one too

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: da540eac1346d0d28bf7cbb2499d6193af541798
2024-02-25 17:38:17 -08:00
Justin Newberry d11aac152e cars: introduce "Platform" union type for all car enums (#31558)
* Hmm

* release

* hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm

* unrelated

* forgot

* cleaner

* Platform

* new syntax

* Fix

* clean

* Fix
old-commit-hash: e6009d80e9323f0cbb41f058164b63eef4a9c55c
2024-02-24 22:18:13 -08:00
Cameron Clough 9bd90112d0 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
old-commit-hash: 995250ae4967943ee33a3699a1d89a7a770d95e9
2024-02-24 16:41:23 -08:00
Justin Newberry c564806520 Subaru: move carspecs to PlatformConfig (#31550)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* fix
old-commit-hash: 1161d33c1892b32980a222b7c5b2ad9d6b05621e
2024-02-23 13:23:40 -08:00
Adeeb Shihadeh 66adafe850 radard: remove sleep for cars without radar (#31467)
* radard: remove sleep for cars without radar

* fix

* update refs
old-commit-hash: 6f905ed979cb8e217c182c653528df3a6094015b
2024-02-14 13:12:54 -08:00
Vivek Aithal ac63e9fd51 CHEVROLET BOLT EUV 2022: Add a simple neural feed forward (#31266)
* add simple neural feed forward

* update refs

* do not sample during inference in op

* update refs
old-commit-hash: 619625625ce9dc67835aaaca266ccd66f63545e3
2024-02-01 12:30:43 -08:00