Commit Graph

399 Commits

Author SHA1 Message Date
Shane Smiskol efd1ff1452 Longitudinal planner: make v_desired a FirstOrderFilter (#23341)
* make v_desired a FirstOrderFilter

* forgot one

* one more ref

* Add a new object for the filter

* fix

* fix tests

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9f88ba188a19cd90e8fee48353668dda7b47b2ba
2022-01-04 12:17:33 +01:00
Ewout ter Hoeven f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a8241fba9459cb70c76840b9670e6993a
2021-12-24 11:18:39 -08:00
HaraldSchafer f64c2974b4 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
old-commit-hash: cf466222f623df5fac325b86b71dc4e181b40d55
2021-12-16 17:34:12 -08:00
Adeeb Shihadeh d5a1acd1b6 update model replay ref commit after increased model idx precision
old-commit-hash: e49480185ac315f817a2d4c63089e23d11023cb8
2021-12-16 15:58:56 -08:00
Ewout ter Hoeven a962365292 Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 55390d273f36f49da3896e687ac5530f40c1d150
2021-12-16 14:58:17 +01:00
Willem Melching 7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a83a3abebebef67a081961e27594d90
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh 24c730f083 model replay: more consistent replay (#23237)
* first cleanup

* don't send calib and desire

* should always be valid

* little more
old-commit-hash: 66ee3e9ef98f240f424228953c307be8daaf5597
2021-12-15 16:12:24 -08:00
Harald Schafer 8d8b61e73f Update ref with minSpeedCAN removed
old-commit-hash: c25ed45437b7b216a3df528915c7cab56f09e198
2021-12-14 12:31:30 -08:00
ZwX1616 f464a02782 DM: more adaptive pose policy (#23184)
* rename and add dep

* proto thresholds

* tweak vk

* update natural offset and clip offsets

* 95th looks good

* no punish for being relaxed

* yaw laplace only

* some pay more attention

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: af5a418fa65347fb9215ce28c86c85cd3c4d9b0a
2021-12-14 12:13:59 -08:00
Adeeb Shihadeh 0c76321224 update refs
old-commit-hash: af125f3c5124bd44ceb999a8cabcc7bea20dc7fe
2021-12-12 13:49:14 -08:00
Adeeb Shihadeh 700ad9ec50 alerts: handle min duration properly (#23191)
* alerts: handle min duration properly

* add active

* tests

* cleanup test

* update refs
old-commit-hash: 07b971d4735d891cc59f404095812f5d001b3092
2021-12-10 19:20:07 -08:00
Adeeb Shihadeh 853dc0d016 alert text simplification (#23186)
* alert text simplification

* little more

* user triggered

* little more

* less annoying ldw

* Update selfdrive/controls/lib/events.py

* update refs

* revert
old-commit-hash: 4627d201b68b670c4d4c29f3ce7523daf8ddc732
2021-12-10 15:21:37 -08:00
Mitchell Goff 42591a19a7 New model: 224877e7-dfcf-4b28-9482-371655918fe1/950 (#23170)
* New model: 224877e7-dfcf-4b28-9482-371655918fe1/950

* Updated model replay ref
old-commit-hash: 1d119999c2fad20708eae522503d7656124c5628
2021-12-08 13:55:30 -08:00
HaraldSchafer 0dbf0a0106 Cruise speed: up to 90mph max (#23161)
* Cruise speed: up to 90mph max

* update ref
old-commit-hash: d1b003c5d22fa7db9763886b08a2b8294aba5a30
2021-12-07 15:47:57 -08:00
HaraldSchafer b19b5fdb98 long planner: no reset when starting (#23149)
* long planner: no reset when starting

* let go to 2m/s

* update ref
old-commit-hash: 77a99e7d6dc021a69078f21923ad0fa2fae1a278
2021-12-06 23:10:16 -08:00
grekiki 9e4cc1f7ff Python: Replace more lists with generators (#23116)
* Replace lists with generators v2

* Replace set with {}

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Replace more set() with {}

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6951b3271d1770297cb6bd53878463035ec0bf43
2021-12-03 22:57:19 -08:00
HaraldSchafer 3afc818433 Long policy: strictly squared stopped equivalence function (#23118)
* new ref

* never let lead stopped equivalence go down

* no overbraking

* stricter again

* cleanup

* updated refs
old-commit-hash: 0dcdf9c30fdb14e907015cb2b0195238e6121b05
2021-12-03 16:12:30 -08:00
Willem Melching 23ef06428a add desired angle to log (#23115)
* add desired angle to log

* update ref

* bump cereal
old-commit-hash: bbd0f94d9d72e86fec79269b9decd424d0050872
2021-12-03 21:35:34 +01:00
Willem Melching b8ab21bd64 add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
old-commit-hash: e6180738fdc4c55ba913905e6591de5435966eb1
2021-12-03 14:57:53 +01:00
HaraldSchafer c6964152bb Reaction buffer on follow distance (#23112)
* Reaction time buffer

* new ref
old-commit-hash: 5b0e10ea33e89fb1c8132cf9014a3a927e93bd6f
2021-12-02 23:56:02 -08:00
HaraldSchafer 08ac1b33ba Human inspired follow distance (#22937)
* Add cost for creep

* more reasonable cost

* seems better than before

* science tune

* more chill

* closer follow

* stopping takes some leeway

* better cruise

* needed to be cumsum all along

* jerk not even needed

* matches better

* 6 is too much

* add back

* a little extra buffer is good for badly tuned cars

* new refs

* refs again
old-commit-hash: 46fd5892bf41add3dc15d413bced81693d0f8853
2021-12-02 14:42:13 -08:00
Adeeb Shihadeh 6c2182c026 Newer sounds (#23091)
* new prompt sound

* padding

* prompt distracted

* debug

* fix spelling

* lower min volume

* better volume at low speeds

* revert debug

* revert that

* fix tests

* update refs

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 3b367e68728c29eea057d99f3948d64ed6cbfa92
2021-12-02 00:28:25 -08:00
HaraldSchafer e3f9919b5c Set accel trajectory to a_ego when not engaged (#23100)
* Set accel trajectory to a_ego when not engaged

* update ref
old-commit-hash: 68015f75ed7f60a5901af728d31b6c11b98edbf4
2021-12-01 23:12:11 -08:00
Mitchell Goff 104ad1d833 New model: d2053554-6094-43ce-943a-7bee3f43458d/950 (#23097)
* New model: d2053554-6094-43ce-943a-7bee3f43458d/950

* Updated model replay ref

* Revert "Updated model replay ref"

This reverts commit e83e0a1adc79dd20232b74932de202d858ebb485.

* New refs (again)

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: be89044c51406eccb7ce7ae7678004a8fc774a7a
2021-12-01 22:43:13 -08:00
Adeeb Shihadeh dccb8b4010 New sounds (#22652)
* new engage/disengage + amp config

* first family

* cleanup audible alerts

* tici isn't special

* fix up debug cycle alerts

* these were better

* extend range

* use distracted sound

* log scaling

* getting closer

* slightly louder

* prompt

* update tests

* update refs

* fix c2 test

* resolve todo

* adjust tolerance

* revert for now

* should work

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e679d05d9e98e267047c21c0b6b67fe9d61f8ed6
2021-11-30 19:47:33 -08:00
Adeeb Shihadeh 2a57577b9d process replay: set full env in cpp replay
old-commit-hash: b3b5beb6277ba0889a74ac56178596727519f1b1
2021-11-30 18:18:12 -08:00
HaraldSchafer 4d9d215996 Toyota pedal rewrite (#23067)
* pedal redo

* add offset to compensate for creep and windbrake

* offset in standard units

* wrong size

* better creep values

* update ref
old-commit-hash: eda69930430da564251581814fd3962ca7af0372
2021-11-30 10:50:06 -08:00
Dean Lee 9b0fcaeb84 rename yuv streams (#23071)
* rename yuv streams

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 348d2d2b0d169b0d181a51eb0e23b1f9b8fc6793
2021-11-29 18:14:59 -08:00
HaraldSchafer fb1cf5b1bf Longcontrol : pid error should be 0 when plan is followed (#23066)
* v_pid error should be 0 when plan is followed

* update ref
old-commit-hash: 048cc3ac9f86ed2b3b9fe82cb28ec243cc8e7bac
2021-11-29 15:22:02 -08:00
Willem Melching 28dd415759 Do not run code on version.py import (#23063)
* Do not run code on version.py import

* fix athena
old-commit-hash: f7c46c694985456e569ce2313b29e43607c62a12
2021-11-29 19:38:55 +01:00
ZwX1616 97175e78a1 test: Replay both models on C2/C3 (#23019)
* add dcam stream

* delete model_test

* both in jenkins

* update spinner

* get filename fn

* they are not random names

* update route

* new ref commit

* temporarily resize tmp

* clean up unlog send

* need calib 0

* revert device

* cleanup

* arg

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 1ec8f03ec642fb5117727eaf31df4841625e0d7b
2021-11-24 15:59:19 -08:00
Vivek Aithal d537897e9a locationd: Fix Nav localization reliability (#22959)
* modify reset logic

* remove debug statements

* use ecef pos and vel covariances during reset

* reset orientations initialized to 0,0,GPSbearing

* refactor nav fix

* add fake gps observations to control ecef pos and ecef vel std

* replace fake_P with individual fake cov

* set gps mode flag

* add gps invalid flag names

* update refs

* more accurate gps accuracy check + update refs
old-commit-hash: 8b6a14758329eb977beb5cba73403dd113495aeb
2021-11-24 15:24:25 -08:00
Adeeb Shihadeh ec6eb5b582 process replay: add cx9 route to migration list
old-commit-hash: 5bcb4c03581fac92dd1418ed94b5125d180461e9
2021-11-24 14:08:46 -08:00
Adeeb Shihadeh e9f5b17ed1 update refs for new mazda name
old-commit-hash: eb55226c2bc53b787834eb51997d2df1900cc892
2021-11-24 13:31:02 -08:00
Vivek Aithal 16d9fcbd80 Revert ecef std until real fix (#22982)
* too low

* update refs

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: 94d59314e28c484c8a4a9fb36c8ab659ea79da57
2021-11-19 12:49:32 -08:00
HaraldSchafer 6eb5dce881 Lateral planner: lower max cost (#22960)
* prevent ping pong when tuning is not so great

* update refs
old-commit-hash: 24aadaf1f35d61f26637377bc353539d25989f94
2021-11-17 20:24:10 -08:00
HaraldSchafer 345d52e957 Add cost to long plan change for smoother lag comp (#22923)
* add plan changing cost

* fix compile

* set weights

* try this cost

* horizon problem

* looks pretty good

* update refs

* update refs

* smoother plan changes
old-commit-hash: b3b45c8d29d0afb741c829fea8145fb47ffa7462
2021-11-16 17:57:55 -08:00
Adeeb Shihadeh 5247da772d update refs after alert disable
old-commit-hash: f262725705c8cd5bfb46cf5c6e893432e5743cc0
2021-11-15 21:45:18 -08:00
Adeeb Shihadeh 9f84f9ad97 put cruiseMismatch event in logging only mode
old-commit-hash: 33022390138df73199ac626cb7b5ab7fac1a89a6
2021-11-15 21:16:54 -08:00
Vivek Aithal 27a6dc0c08 locationd : Acceleration Bias in locationd (#22879)
* add accel bias to filter for offline calculation

* bugfix acc bias in live_kf

* add no_accel obsertvation

* increase initial certainty of acc-bias and reduce PN

* increase initial certainty of acc-bias and reduce PN

* increase accel bias PN

* increase obs noise for no_accel observation

* style fixes

* update refs
old-commit-hash: 534bf697eeb3b72643abc713649ce2eef5f75820
2021-11-12 15:55:16 -08:00
HaraldSchafer d17ec32e0b Give car interface roll and pitch (#22891)
* Give car interface roll and pitch

* fixup

* whitespace
old-commit-hash: a04114f68c118caae5d9b3e19e70e885e87544ff
2021-11-12 12:21:22 -08:00
Vivek Aithal d49fbbfbed locationd: Set ECEF_POS valid flag to false if in no-gps mode (#22857)
* set ECEF_POS valid flag to false if in no-gps mode

* modify valid flag for all ecef states before gps

* add calibrated valid when no gps

* update refs

* remove extra whitespace

* add invalid flag to all NED values pre gps

* update refs

* update correct refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: c7be73b826b21947197f24c6a60fc5a7098e42af
2021-11-11 21:34:17 -08:00
sshane 9c994173ed Longcontrol: do not clip vEgo to minSpeedCan (#22832)
* fix tss2 slow reacceleration in sng

(should) preserve stopping behavior

add comments since it's confusing

fix

* Revert "fix tss2 slow reacceleration in sng"

This reverts commit 42abde0eb945d8bc5ad9b502d1d89b3e3dc16f8a.

* don't max(vEgo)

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: bdaea086f8bd5ea079c4ea98abc5a3d48ca08401
2021-11-11 13:24:38 +01:00
Adeeb Shihadeh a142638899 increase engagement alerts duration
old-commit-hash: 327464fb845dd01533f390ac89d9fd78fbfb02d7
2021-11-10 22:11:14 -08:00
Adeeb Shihadeh d6c42f11f4 controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
old-commit-hash: 035bc0c20fd27490cc353a33f3c373201288a10a
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh 448d5f9e93 alerts: use a single duration for sound, text, and HUD (#22856)
* alerts: use a single duration for sound, text, and HUD

* little cleanup

* update refs
old-commit-hash: c5d6b85c9014386b8d1cb2a17f8767abef3afd57
2021-11-10 11:54:12 -08:00
Adeeb Shihadeh 450471058b controlsd: optimize alert management (#22846)
* controlsd: optimize alert management

* little cleanup

* dataclass is nice

* fix tests

* update refs

* sort by start frame

* update refs

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 93ba52c76c20baf36e07c25d28a98bc8e9ea6219
2021-11-10 10:54:18 -08:00
Jason Young a283e88f37 Fix momentary false blind spot alerts when changing lanes (#22819)
* reset LaneChangeDirection after finishing

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 2006fff2b66329e2d11300691301bf7a4531b18a
2021-11-10 17:21:36 +01:00
HaraldSchafer caa01d2f95 ACADOS: partial condensing (#22830)
* partial condense

* new refs

* new ref

* newerest refs
old-commit-hash: 35d6ed10148adbb07c2a4b0c787342b6e101aa05
2021-11-09 19:29:55 -08:00
Jafar Al-Gharaibeh 6c74dc1366 Mazda: disable hud alerts until we find a way to silence audible alerts (#22808)
* Mazda: disable hud alerts for now until we find a way to silence audible warnings

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: add hud alert for steer lockout

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* show when above min steer speed

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2621e5301da0e10a70a68672db5052ea5037db9b
2021-11-09 15:24:18 -08:00