Commit Graph

236 Commits

Author SHA1 Message Date
Dean Lee ea519c31e4 controlsd/publish_logs: follow capnp best practices (#23372)
* follow follow capnp best practices

* cleanup
old-commit-hash: 960e0cf6a70638e5235f569da9391638eb94b513
2022-01-04 12:04:03 +01:00
Adeeb Shihadeh 98c8147ec3 CAN receive error is a comm issue (#23362)
old-commit-hash: 1e41f4723b539c9c76c1ae0c16f7a0a42cfe5deb
2022-01-03 14:13:45 -08:00
Ewout ter Hoeven f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a8241fba9459cb70c76840b9670e6993a
2021-12-24 11:18:39 -08:00
HaraldSchafer f64c2974b4 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
old-commit-hash: cf466222f623df5fac325b86b71dc4e181b40d55
2021-12-16 17:34:12 -08:00
Willem Melching 7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a83a3abebebef67a081961e27594d90
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh 83136e8016 increase cruise mismatch threshold
old-commit-hash: 7f618b16bfa47352143d6edac30fba05f9fdfc28
2021-12-12 13:35:12 -08:00
Adeeb Shihadeh 06a9b3448d alerts: escalate soft disable alert near disengagement (#23198)
* alerts: escalate soft disable alert if resulted in disengagement

* show 0.5s before disengagement
old-commit-hash: 8068df0b2a35eb8fcef809f4ce9a6cb7bfc75fdc
2021-12-11 17:07:37 -08:00
Adeeb Shihadeh 700ad9ec50 alerts: handle min duration properly (#23191)
* alerts: handle min duration properly

* add active

* tests

* cleanup test

* update refs
old-commit-hash: 07b971d4735d891cc59f404095812f5d001b3092
2021-12-10 19:20:07 -08:00
HaraldSchafer 9c03362ba8 Less sensitive torque saturated warning (#23003)
* Less sensetive torque saturated warning

* better comment
old-commit-hash: 8f3bc4872f19b84203608b2561924cd85e0d1788
2021-12-01 13:53:42 -08:00
Adeeb Shihadeh 2bcaee3678 add offroad alerts for car unrecognized (#22934)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
old-commit-hash: 2a72e2a5140a7b02c3a13f167e91b4238a01eba0
2021-11-17 20:29:00 -08:00
Adeeb Shihadeh 8a66c54064 Revert "add offroad alerts for car unrecognized"
This reverts commit 2ffaadb4d2eaabf6e8d86423fbc25328e81dfff0.

old-commit-hash: d8a5c415cd73b50a3424a28f644466fee263e09c
2021-11-16 13:31:10 -08:00
Adeeb Shihadeh 08bfdb151b add offroad alerts for car unrecognized
old-commit-hash: fb1e8ce086ec5e2dc7b2150b62fdd99368eb7e66
2021-11-16 13:30:33 -08:00
Adeeb Shihadeh d1eacc4619 alerts: make soft disables an orange alert (#22925)
old-commit-hash: 833399e9418db26df70169d37c2dff90051d89c7
2021-11-16 13:11:32 -08:00
Adeeb Shihadeh a1ab2f7c36 CI: skip cruise mismatch check for can replays
old-commit-hash: db92006dc0b964871c65ca9be88ebdb3b67137ec
2021-11-12 18:22:39 -08:00
HaraldSchafer d17ec32e0b Give car interface roll and pitch (#22891)
* Give car interface roll and pitch

* fixup

* whitespace
old-commit-hash: a04114f68c118caae5d9b3e19e70e885e87544ff
2021-11-12 12:21:22 -08:00
Adeeb Shihadeh d6c42f11f4 controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
old-commit-hash: 035bc0c20fd27490cc353a33f3c373201288a10a
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh 421a5db493 controls: don't wind up while EPS is faulted or below min steer speed (#22739)
* controlsd: don't wind up while EPS is faulted

* also check if above min steer speed

* car params
old-commit-hash: 385f3c5387cceb8e23c2d57752f81a2e919104aa
2021-10-29 14:13:41 -07:00
Robbe Derks dbe4641e04 Multipanda support (#22402)
* squash all PR commits for easy rebase

* merged all panda rx can into one message

* fix buffers in can_send

* more cleanup and minor fixes

* fix even more stuff

* fix non-allocated send buffer

* make connecting more robust

* fix bus offset

* fix controls_mismatch?

* simplify mismatch check

* C++ style struct

* fix connect loop

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 585c16cd2aba6e2504c2427aaf1855b97035eb41
2021-10-29 13:04:26 +02:00
Adeeb Shihadeh 05aa510c25 always show lane lines on HUD (#22693)
* always show lane lines on HUD

* update refs
old-commit-hash: f2b48a1803eed1512962ee80e0f4c9718f40d44b
2021-10-25 23:47:12 -07:00
Adeeb Shihadeh 300294d0c6 temporarily disable per-core cpu usage check
old-commit-hash: 7394956a9056ef313b3bffb2a1aa93ae9ba97856
2021-10-25 15:03:28 -07:00
Mitchell Goff 3e3b875111 Only trigger model FCW on stock long when not already braking (#22620)
* Only trigger model FCW on stock long when not already braking

* Split model_fcw checks for better readability
old-commit-hash: 38f775edfc12736f590885705c3a92a785d531f8
2021-10-20 16:16:40 +02:00
Adeeb Shihadeh 3802eab361 only check low battery on EON
old-commit-hash: 74a3c92704b1d6597002d6c5da020ba8ff4393a1
2021-10-15 15:04:19 -07:00
Robbe Derks 58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d425e2a5dc61d09571933cffb9536113
2021-10-08 17:54:34 +02:00
Willem Melching 79d5c6107b Set CarControl.active (#22442)
* Set CarControl.active

* update ref
old-commit-hash: e636f03c7a9ad963f728e400cb1bfced4d37a5ac
2021-10-05 14:32:39 -07:00
speedking456 ca46acfd64 accel/decel button metric increments (#22399)
* add metric values

Freedom units have weird multiples compared to metric. Modified so that it increments by 10 km/h on long press and 1 km/h on short press, rather than 8 and 1.6 km/h. This mimics stock hyundai behaviour on metric vehicles.

* use is_metric from controlsd

* use actual mph value instead of rounded

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 23b931660336b7fdd21b8942cedb5f79401aa357
2021-10-04 21:11:17 +02:00
Willem Melching 11066c6236 Split pandaState into peripheralState and pandaState (#22385)
* publish peripheralState from boardd

* refactor consumers

* rename thread

* peripheralState has panda type too

* add to process replay

* fix device build

* properly remove hardware unsupported alert

* latest peripheralState

* remove pandaState from thermal_monitor

* put that back

* add back harness check

* fix cloudlog

* needs pandaState

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* dont conflate

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* pigeon is peripheral

* cleanup

* less global

* comment

* move rtc to peripheral_control_thread

* better diff?

* whitespace

* get msg

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f4e2537b124d3d1c0d697a12d8b243b54b76501b
2021-10-04 11:30:11 +02:00
qadmus 810e859169 Lateral PID: move steer feedforward to CarInterface (#22411)
* move steer feedforward to car interface, in car parameters

* LatControlPID.get_steer_feedforward()
old-commit-hash: 3461e25944ae4f4ba4f55960a9748c0f57236c76
2021-10-04 10:03:53 +02:00
Greg Hogan a131767d0b accel/decel button short/long press 1mph/5mph (#22013)
old-commit-hash: 92895f1e68f76f1092d2fcea8e672eef7309aaf2
2021-10-01 11:09:56 +02:00
HaraldSchafer d91e0604e8 Change radar-based FCW to model-based FCW (#22379)
* just use MPC for fcw checking

* thats already bad

* model FCW is always good

* better fcw

* should be good for now

* comment

* linting

* cleaner

* unused
old-commit-hash: a8b4249ebcf21c2868e298ef86ee37ac96d2715e
2021-09-29 11:55:54 -07:00
Adeeb Shihadeh a4194021bd controls: only send cruise cancel while cruise is enabled (#22359)
* controls: only send cruise cancel while cruise is enabled

* cleanup

* might actually do something

* update refs

* update refs again

* update refs
old-commit-hash: 3b8fa4b7fdc9bdd262faca457c478e9d388eae38
2021-09-28 12:30:50 -07:00
Willem Melching b3601ce43b Remove fuzzy fingerprint startup alert (#22328)
* deprecate fuzzy fingerprint startup alert

* bump cereal
old-commit-hash: 88d248a5af55a5b184b313e3c3223edd77461db9
2021-09-23 17:15:33 -07:00
Willem Melching a8ce1288fd Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
old-commit-hash: c4bac6bd68ce2a91beb15bb4f4472d76525288e0
2021-09-13 22:03:08 -07:00
Willem Melching 523219c678 Parameterize longitudinal control using carParams (#22200)
* use CP.startAccel

* missing values

* order

* update ref

* cereal
old-commit-hash: b7d1aac1972d8317e77d1f48edb22156b2c67bd6
2021-09-11 18:01:54 -07:00
HaraldSchafer cb1cd01bdf cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
old-commit-hash: 74b6c872545ac64055a914789a89ccc173168d8b
2021-09-10 10:34:18 -07:00
Willem Melching 83ce6c65bb actually set longControlState in actuators packet (#22155)
* actually set longControlState in actuators packet

* update ref
old-commit-hash: 4f84e1b2ad689fb43b06d28def2bd58abf722748
2021-09-06 20:14:01 -07:00
Willem Melching ab7d2f1d08 put LongControlState in CarControl.Actuators (#22154)
old-commit-hash: 21ae64868e2ab2d75cf77fa816087847b0496ade
2021-09-06 18:45:59 -07:00
Willem Melching 6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcdc9d651fe7169044fb7f52fd70f94ab
2021-09-06 17:29:32 -07:00
Adeeb Shihadeh 50ea63cb76 no battery (#22124)
* no battery

* little more

* used for power monitoriong
old-commit-hash: 69fd26623846e6b82bfa4cb022bc84a8f2df1771
2021-09-03 22:17:57 -07:00
HaraldSchafer 1b98341932 Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
old-commit-hash: ebf2a2279d837feb3ce55a7bc44c7f0053e77f27
2021-09-02 14:16:44 -07:00
Adeeb Shihadeh 1244074094 add TSS2 replay route (#21953)
* add TSS2 replay route

* skip on sim

* do not set on import time

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 86f68ff22ed184dc40bfe58761a554aea1e3995e
2021-08-31 10:48:21 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh d0dce9a166 don't check cpu usage in simulation mode
old-commit-hash: 9afa0eec6451a37a0dc0c39bf4837edd2ad53531
2021-08-28 14:55:12 -07:00
Adeeb Shihadeh ac8b08fa0c alert for per-core cpu usage (#21983)
* thermald: per-core cpu usage

* add alert

* better alert text

* list

* fix process replay
old-commit-hash: fc8b571a847f1a89abb331eef8f85f310453fd77
2021-08-19 19:14:51 -07:00
Willem Melching f92f51d2b5 controlsd: ensure actuators packet is finite (#21958)
* controlsd: ensure actuators packet is finite

* do not hardcode fields

* cleaner way to get fields

* move line up
old-commit-hash: 4fcd51e0215d5f81a343d2f12108ad1528ab496e
2021-08-19 19:00:03 +02:00
Adeeb Shihadeh 13b3649211 add that back
old-commit-hash: 8aafbc78f65a398b7d354a68453df15c1324eb9d
2021-08-06 15:48:16 -07:00
Adeeb Shihadeh 8e8edfe185 increase controls initializing timeout a bit
old-commit-hash: 03255d83bea80c92d3bd5739ea20f7c510417646
2021-07-28 15:50:40 -07:00
Adeeb Shihadeh 4df47022d5 increase timeout for controls init (#21680)
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7c3b7b53485069e1402f7351d9f032909c581021
2021-07-22 00:04:00 -07:00
Jafar Al-Gharaibeh 26990b19b9 Car Port: Mazda CX-9 2021 (#20864)
* Mazda CX-9 no steer lockout, and newer cars can use more torque

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda CX-9 2021 test route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* cleanup

* more cleanup

* don't show community features alert if dashcam only

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: ff704e18b7797d093191950825e8c76623b9f5a6
2021-07-10 23:50:03 -07:00
Adeeb Shihadeh b7c1b9a6e8 rename enableCruise -> pcmCruise (#21546)
old-commit-hash: cb7e96f99d59cc56ac532d4b5e08e03c013cf946
2021-07-10 13:56:11 -07:00
Adeeb Shihadeh db852728a2 move fuzzy fingerprinting out of community features (#21542)
old-commit-hash: b4fc20816664f76d0b3ba0070f37d4f738021025
2021-07-10 13:23:39 -07:00