Commit Graph

201 Commits

Author SHA1 Message Date
Adeeb Shihadeh e8ced8bee5 Cleanup startup event handling (#1748)
* cleanup startup event

* always show permanent

* lowest

* update refs
old-commit-hash: ccf6b80c7e5aa24b922ed60a519eab91a1d5ec9b
2020-06-19 16:16:48 -07:00
Adeeb Shihadeh 304d893af6 GM cleanup + ignition fix (#1729)
* small cleanup

* alertmanager handles that

* improve tuning

* below steer speed

* Revert "improve tuning"

This reverts commit 5d2de147d2c9979af09b7964ad59e4b95ddb2f2a.

* bump panda

* update refs

* bump panda
old-commit-hash: 472fe6696278b4137466e401496d1561a799a0da
2020-06-18 12:24:47 -07:00
Willem Melching e7a7bf0898 update ref
old-commit-hash: ed7e568b70d1de79cf741d8de4a9a79991c7239c
2020-06-15 17:55:03 -07:00
Adeeb Shihadeh e4f549c998 Hyundai Ioniq EV LTD (#1694)
* add ioniq

* bump panda

* test route

* bump pnada
old-commit-hash: 224672705c6bc5e7476275648813d39e17d3e476
2020-06-15 11:45:37 -07:00
Adeeb f396864fab Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
old-commit-hash: 0bbe870b5f90c25427c4d21cabe4a0f78291eee9
2020-06-12 15:32:50 -07:00
Willem Melching c25d71dd31 update process replay after sonata stiffness change
old-commit-hash: 2a12c653d51fd1a6d1c0e6f08dab624de65f6e2f
2020-06-12 13:20:54 -07:00
Adeeb Shihadeh d231b3a7ec don't clear scons cache in CI
old-commit-hash: cf72a4eb34287218f385e75849902755203d55ec
2020-06-10 17:49:34 -07:00
Willem Melching 76a465e0ec Write orientation & transform in C++ (#1637)
* locationd at 20hz

* update ref

* bump cereal

* dont modify global state

* add scons files

* ecef2geodetic and geodetic2ecef

* Finish local coords class

* Add header file

* Add orientation.cc

* cleanup

* Add functions to header file

* Add cython wrapper

* y u no work?

* This passes the tests

* test rot2quat and quat2rot

* Teste euler2rot and rot2euler

* rot_matrix

* test ecef_euler_from_ned and ned_euler_from_ecef

* add benchmark

* Add test

* Consistent newlines

* no more radians supported in geodetic

* test localcoord single

* test localcoord single

* all tests pass

* Unused import

* Add alternate namings

* Add source for formulas

* no explicit tests needed

* remove benchmark

* Add release files

* Typo

* Remove print statement

* no access to raw transform matrix

* temporarily add tolerance

* handcode quat2euler

* update ref
old-commit-hash: c18e7da3c25c59a19efda8ec3a1b716c2571cc2f
2020-06-09 16:44:26 -07:00
Willem Melching d0f60029cb Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
old-commit-hash: 15dc6044d44e7f85293cb9b0187c7d2a51a84c55
2020-06-05 16:01:53 -07:00
Willem Melching ce6dd8d4e9 Model + camerad test (#1622)
* kind of works

* move that

* hack to get camerad to reliably terminate

* not sure why SIGTERM wasn't working before

* compare bytes

* clean up some hacks

* gitignore

* fix that

* WIP

* no reboot

* comparison works

* pretty print

* fix build

* run in jenkins

* python path

* space

* raise timeout

* new eon

* skip the copy

* spinner

* spin less

* update model ref commit

* reenable that

* clean up

* fix jenkinsfile

* parallel

* wrap it in a stage

* fix linter

* better progress

* lower timeout

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 63c8e8439b6d19020055f922340d8e33d906363a
2020-06-04 18:57:25 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Willem Melching ad66386877 locationd profiling (#1625)
old-commit-hash: 66455b075d918d9f04fae6921d0a692ee3f8afd0
2020-06-02 17:32:55 -07:00
Adeeb 8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Willem Melching e738ab6f04 longitudinal test should broadcast liveLocationKalman
old-commit-hash: d00cdf1e0c7bf7fc8bb7726bafb93e8e6f946574
2020-06-01 14:24:48 -07:00
Willem Melching 3df1a2c681 Fix low speed engage on stop and go Hondas (#1613)
* fix low speed engage on stop and go Hondas

* update ref commit
old-commit-hash: f575a9ec12990ac2a764a5f416795d1c618f4609
2020-06-01 10:14:11 -07:00
Adeeb Shihadeh 8b3418b0f9 enable flake8 E251: unexpected spaces around keyword / parameter equals
old-commit-hash: ebed2d1dcc53f092696b61fd1e004045c9bde893
2020-05-31 17:34:47 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Andre Volmensky d106ccc0fb Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
old-commit-hash: 9fc826cb5c6fc46ebd0fe5c1ecd322a472da44ef
2020-05-30 20:25:32 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Willem Melching e04d6772d8 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community

old-commit-hash: b5a2cec913f44438aa15b8b49e2cfee2b033c5e6
2020-05-30 17:04:38 -07:00
Adeeb Shihadeh 25f83a654e remove file that shouldn't have been committed
old-commit-hash: 18afb979fe5ef00ebb9079991a0fcbfdf3734eb1
2020-05-30 14:40:00 -07:00
Adeeb Shihadeh 974b9317bc update refs
old-commit-hash: 2d898bc0edb2cef132e90c695e77911c2720c026
2020-05-29 12:41:20 -07:00
Jafar Al-Gharaibeh a476d51333 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 34b9b5e849fcd192bbd8c3060ce725ef61d725ab
2020-05-28 22:15:19 -07:00
Willem Melching 2ac27def5a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
old-commit-hash: ba2ac1207a554d277e01af5b9514de4500d4f66a
2020-05-28 15:40:48 -07:00
Willem Melching 2b60ee9531 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
old-commit-hash: 3d08dcc3b27936cb14c0eae63605be9a6c077380
2020-05-28 15:05:04 -07:00
Willem Melching 4022d92155 make pre-commit pass without xx present
old-commit-hash: bee15f8abef98b35d070e931d5b34fd01ca8128e
2020-05-28 13:20:28 -07:00
Willem Melching 12a306021d flake8 in pre-commit(#1583)
old-commit-hash: 29aaa44740b5dae3c1cc0c273c72c7eb53135e5e
2020-05-27 20:33:05 -07:00
Willem Melching c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd0643424357864287ae0485da03f66df85e1fb1
2020-05-27 20:00:14 -07:00
Adeeb f4ef9ae00a Remove incomplete Hyundai Ioniq port (#1570)
old-commit-hash: c78602e8ccf242be6f8a1806ba9e2f0e4f79275b
2020-05-26 20:48:41 -07:00
Adeeb Shihadeh 4221ed5d56 update refs after radarState fields populated
old-commit-hash: a1ffcdd2535b82ff1883879bd53a16f17042419f
2020-05-26 18:12:12 -07:00
Thaixican 53a18127e6 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
old-commit-hash: dd16990952980bfd5c8eac919309052be084a7ee
2020-05-26 13:49:18 -07:00
Adeeb Shihadeh 02cea3e7b4 remove that script
old-commit-hash: b251eff7645035e51f6379209a9c492c2c980a37
2020-05-22 14:50:08 -07:00
Adeeb Shihadeh e5fee88a3d bump panda after hyundai checksum
old-commit-hash: ea1b19256540289732257df35c683730e329cf98
2020-05-22 14:42:22 -07:00
Willem Melching 4061f1d530 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
old-commit-hash: fcf879d783c345ccbf80252de23f649427c35fbd
2020-05-21 16:08:05 -07:00
Willem Melching 2e0f9fe628 add sonata 2019 to test_car_modelsg
old-commit-hash: ef2ea14ecce0133b5596074712162931cbaebdc3
2020-05-20 17:20:17 -07:00
Alice Knag bf066b2601 add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
old-commit-hash: fde1a5e9af1c1e84ed6f82b642a50bae21f25bbe
2020-05-20 17:12:00 -07:00
Willem Melching 6e41973c3c Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
old-commit-hash: d099e09fb77544eb00d13ba9aea34a0a3374a52e
2020-05-19 16:45:20 -07:00
Willem Melching fb7e47e2fb This one also needs to be fixed
old-commit-hash: 96605d095162c88b6e97de6262f4972c12c49c68
2020-05-19 16:19:00 -07:00
Adeeb Shihadeh e6af5da522 remove those debug prints
old-commit-hash: 8788ab36e40a413c777dd298817477a2fd7da8f9
2020-05-19 13:54:24 -07:00
Willem Melching 88a385e9c9 Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
old-commit-hash: bb8bbdd9ee4d610e2ae6048021407863b3f74683
2020-05-19 13:43:44 -07:00
Adeeb 48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
Adeeb fe106e25a3 Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
old-commit-hash: 08832ff29d20348ebffd0ac3bcce29ad3a479cee
2020-05-12 15:06:48 -07:00
Willem Melching c77e9b1f59 Fix counter in HKG clu11 message (#1484)
* fix counter in clu11 message

* update ref
old-commit-hash: 27ffa29f6c24637ce0580dbd9ad96d290de98fec
2020-05-10 20:13:35 -07:00
Willem Melching 587d00d24a fix update ref script
old-commit-hash: 5182da31009e0dd62bd92abb98b1a5bc306ddee1
2020-05-10 18:55:53 -07:00
Adeeb Shihadeh 004c0e277b fake less of PubMaster and SubMaster when profiling
old-commit-hash: ad2c54e9916301d63907d96c3e9dec046bd016b1
2020-05-03 17:41:26 -07:00
Adeeb 614adb569e Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
old-commit-hash: 337529d5cb7c8f35ed776c96bc2c2f394f766305
2020-05-01 13:13:12 -07:00