From dd607aa07dece95dd288cda2e1f89be117710e19 Mon Sep 17 00:00:00 2001 From: firestarsdog <229254897+firestarsdog@users.noreply.github.com> Date: Thu, 10 Sep 2026 03:12:11 -0400 Subject: [PATCH] temp force dev until simple mode --- .../layouts/settings/starpilot/longitudinal.py | 2 +- .../ui/layouts/settings/starpilot/vehicle.py | 2 +- starpilot/common/starpilot_variables.py | 5 +++-- .../common/tests/test_starpilot_variables.py | 16 ++++++++++++++++ 4 files changed, 21 insertions(+), 4 deletions(-) diff --git a/selfdrive/ui/layouts/settings/starpilot/longitudinal.py b/selfdrive/ui/layouts/settings/starpilot/longitudinal.py index 0551b8b3bf..ef96d49ca2 100644 --- a/selfdrive/ui/layouts/settings/starpilot/longitudinal.py +++ b/selfdrive/ui/layouts/settings/starpilot/longitudinal.py @@ -1108,7 +1108,7 @@ class StarPilotLongitudinalLayout(_SettingsPage): def _developer_feature_access(self) -> bool: return ( starpilot_state.car_state.hasOpenpilotLongitudinal and - (self._params.get_bool("DeveloperUI") or self._params.get_bool("GalaxyDeveloperMode")) + (gui_app.big_ui() or self._params.get_bool("DeveloperUI") or self._params.get_bool("GalaxyDeveloperMode")) ) def _speed_unit(self) -> str: diff --git a/selfdrive/ui/layouts/settings/starpilot/vehicle.py b/selfdrive/ui/layouts/settings/starpilot/vehicle.py index ed28301081..10ebde197e 100644 --- a/selfdrive/ui/layouts/settings/starpilot/vehicle.py +++ b/selfdrive/ui/layouts/settings/starpilot/vehicle.py @@ -809,7 +809,7 @@ class StarPilotVehicleSettingsLayout(_SettingsPage): allowed_ids = set(range(9)) | {11, 12, 13, 14} if key == "LKASButtonControl": allowed_ids.add(9) - developer_access = self._params.get_bool("DeveloperUI") or self._params.get_bool("GalaxyDeveloperMode") + developer_access = gui_app.big_ui() or self._params.get_bool("DeveloperUI") or self._params.get_bool("GalaxyDeveloperMode") options = [o for o in ACTION_OPTIONS if o["id"] in allowed_ids and (cs.hasOpenpilotLongitudinal or not o.get("requires_longitudinal", False)) and diff --git a/starpilot/common/starpilot_variables.py b/starpilot/common/starpilot_variables.py index 4810bddcde..9d4cd6633a 100644 --- a/starpilot/common/starpilot_variables.py +++ b/starpilot/common/starpilot_variables.py @@ -989,7 +989,8 @@ class StarPilotVariables: toggle.static_pedals_on_ui = self.get_value("StaticPedalsOnUI", condition=toggle.pedals_on_ui) toggle.rotating_wheel = self.get_value("RotatingWheel", condition=custom_ui) - toggle.developer_ui = self.get_value("DeveloperUI") + big_ui = os.getenv("BIG", "0") == "1" or HARDWARE.get_device_type() in ("tici", "tizi") + toggle.developer_ui = self.get_value("DeveloperUI") or big_ui developer_metrics = self.get_value("DeveloperMetrics", condition=toggle.developer_ui) border_metrics = self.get_value("BorderMetrics", condition=developer_metrics) toggle.blind_spot_metrics = has_bsm and self.get_value("BlindSpotMetrics", condition=border_metrics) @@ -1042,7 +1043,7 @@ class StarPilotVariables: condition=toggle.car_make == "gm" and toggle.has_pedal and "BOLT" in toggle.car_model, ) - developer_feature_access = self.params.get_bool("DeveloperUI") or self.params.get_bool("GalaxyDeveloperMode") + developer_feature_access = toggle.developer_ui or self.params.get_bool("GalaxyDeveloperMode") toggle.pulse_and_glide_available = toggle.openpilot_longitudinal and developer_feature_access toggle.pulse_glide_speed_delta = self.get_value( "PulseGlideSpeedDelta", diff --git a/starpilot/common/tests/test_starpilot_variables.py b/starpilot/common/tests/test_starpilot_variables.py index 3241de5d0c..dd1d71e80b 100644 --- a/starpilot/common/tests/test_starpilot_variables.py +++ b/starpilot/common/tests/test_starpilot_variables.py @@ -293,6 +293,22 @@ def test_disabled_conditional_experimental_toggles_are_off(monkeypatch, tmp_path assert toggles.conditional_signal_lane_detection is False +def test_big_ui_exposes_developer_toggles_without_persisting_developer_ui(monkeypatch, tmp_path): + params_cls = spv.Params + + def isolated_params(_path=None, memory=False, return_defaults=False): + return params_cls(str(tmp_path / ("memory" if memory else "params")), return_defaults=return_defaults) + + monkeypatch.setattr(spv, "Params", isolated_params) + monkeypatch.setattr(spv.HARDWARE, "get_device_type", lambda: "tici") + monkeypatch.delenv("BIG", raising=False) + + variables = spv.StarPilotVariables() + + assert variables.starpilot_toggles.developer_ui is True + assert variables.params_raw.get_bool("DeveloperUI") is False + + def test_device_shutdown_hours_convert_directly_to_seconds(): assert spv.device_shutdown_seconds(6) == 6 * 60 * 60 assert spv.device_shutdown_seconds(0) == 60 * 60