Always On Lateral

Co-Authored-By: Jacob Pfeifer <jacob@pfeifer.dev>

opendbc_repo/opendbc/car/hyundai/values.py

@@ -70,6 +70,7 @@ class HyundaiSafetyFlags(IntFlag):
 
 # FrogPilot variables
 class HyundaiFrogPilotSafetyFlags(IntFlag):
+  HAS_LDA_BUTTON = 1024
 
 
 class HyundaiFlags(IntFlag):

opendbc_repo/opendbc/car/interfaces.py

@@ -199,6 +199,9 @@ class CarInterfaceBase(ABC):
 
           fp_ret.isHDA2 = hda2
 
+        if CP.flags & HyundaiFlags.HAS_LDA_BUTTON:
+          fp_ret.safetyConfigs[-1].safetyParam |= HyundaiFrogPilotSafetyFlags.HAS_LDA_BUTTON.value
+
       elif platform in TOYOTA:
         fp_ret.canUsePedal = not CP.autoResumeSng
         fp_ret.canUseSDSU = candidate not in UNSUPPORTED_DSU_CAR and candidate not in TSS2_CAR

opendbc_repo/opendbc/safety/__init__.py

@@ -10,3 +10,4 @@ class ALTERNATIVE_EXPERIENCE:
   ALLOW_AEB = 16
 
   # FrogPilot variables
+  ALWAYS_ON_LATERAL = 32

opendbc_repo/opendbc/safety/declarations.h

@@ -269,6 +269,10 @@ extern int cruise_button_prev;
 extern bool safety_rx_checks_invalid;
 
 // FrogPilot variables
+extern bool aol_allowed;
+extern bool lkas_button_prev;
+extern bool lkas_on;
+extern bool main_button_prev;
 
 // for safety modes with torque steering control
 extern int desired_torque_last;       // last desired steer torque
@@ -312,6 +316,7 @@ extern bool enable_gas_interceptor;
 #define ALT_EXP_ALLOW_AEB 16
 
 // FrogPilot variables
+#define ALT_EXP_ALWAYS_ON_LATERAL 32
 
 extern int alternative_experience;
 

opendbc_repo/opendbc/safety/lateral.h

@@ -61,7 +61,7 @@ bool steer_torque_cmd_checks(int desired_torque, int steer_req, const TorqueStee
   bool violation = false;
   uint32_t ts = microsecond_timer_get();
 
-  if (controls_allowed) {
+  if (aol_allowed || controls_allowed) {
     // Some safety models support variable torque limit based on vehicle speed
     int max_torque = limits.max_torque;
     if (limits.dynamic_max_torque) {
@@ -96,7 +96,7 @@ bool steer_torque_cmd_checks(int desired_torque, int steer_req, const TorqueStee
   }
 
   // no torque if controls is not allowed
-  if (!controls_allowed && (desired_torque != 0)) {
+  if (!(aol_allowed || controls_allowed) && (desired_torque != 0)) {
     violation = true;
   }
 
@@ -138,7 +138,7 @@ bool steer_torque_cmd_checks(int desired_torque, int steer_req, const TorqueStee
   }
 
   // reset to 0 if either controls is not allowed or there's a violation
-  if (violation || !controls_allowed) {
+  if (violation || !(aol_allowed || controls_allowed)) {
     valid_steer_req_count = 0;
     invalid_steer_req_count = 0;
     desired_torque_last = 0;
@@ -176,7 +176,7 @@ static bool rt_angle_rate_limit_check(AngleSteeringLimits limits) {
 bool steer_angle_cmd_checks(int desired_angle, bool steer_control_enabled, const AngleSteeringLimits limits) {
   bool violation = false;
 
-  if (controls_allowed && steer_control_enabled) {
+  if ((aol_allowed || controls_allowed) && steer_control_enabled) {
     // convert floating point angle rate limits to integers in the scale of the desired angle on CAN,
     // add 1 to not false trigger the violation. also fudge the speed by 1 m/s so rate limits are
     // always slightly above openpilot's in case we read an updated speed in between angle commands
@@ -262,12 +262,12 @@ bool steer_angle_cmd_checks(int desired_angle, bool steer_control_enabled, const
   }
 
   // No angle control allowed when controls are not allowed
-  if (!controls_allowed) {
+  if (!(aol_allowed || controls_allowed)) {
     violation |= steer_control_enabled;
   }
 
   // reset to current angle if either controls is not allowed or there's a violation
-  if (violation || !controls_allowed) {
+  if (violation || !(aol_allowed || controls_allowed)) {
     if (limits.inactive_angle_is_zero) {
       desired_angle_last = 0;
     } else {
@@ -304,7 +304,7 @@ bool steer_angle_cmd_checks_vm(int desired_angle, bool steer_control_enabled, co
 
   bool violation = false;
 
-  if (controls_allowed && steer_control_enabled) {
+  if ((aol_allowed || controls_allowed) && steer_control_enabled) {
     // *** ISO lateral jerk limit ***
     // calculate maximum angle rate per second
     const float max_curvature_rate_sec = MAX_LATERAL_JERK / (fudged_speed * fudged_speed);
@@ -340,12 +340,12 @@ bool steer_angle_cmd_checks_vm(int desired_angle, bool steer_control_enabled, co
   }
 
   // No angle control allowed when controls are not allowed
-  if (!controls_allowed) {
+  if (!(aol_allowed || controls_allowed)) {
     violation |= steer_control_enabled;
   }
 
   // reset to current angle if either controls is not allowed or there's a violation
-  if (violation || !controls_allowed) {
+  if (violation || !(aol_allowed || controls_allowed)) {
     desired_angle_last = SAFETY_CLAMP(angle_meas.values[0], -limits.max_angle, limits.max_angle);
   }
 

opendbc_repo/opendbc/safety/modes/chrysler.h

@@ -80,6 +80,7 @@ static void chrysler_rx_hook(const CANPacket_t *msg) {
     pcm_cruise_check(cruise_engaged);
 
     // FrogPilot variables
+    acc_main_on = GET_BIT(msg, 20U);
   }
 
   // TODO: use the same message for both

opendbc_repo/opendbc/safety/modes/ford.h

@@ -160,6 +160,7 @@ static void ford_rx_hook(const CANPacket_t *msg) {
       pcm_cruise_check(cruise_engaged);
 
       // FrogPilot variables
+      acc_main_on = (cruise_state == 3U) || cruise_engaged;
     }
   }
 }

opendbc_repo/opendbc/safety/modes/gm.h

@@ -125,6 +125,9 @@ static void gm_rx_hook(const CANPacket_t *msg) {
   }
 
   // FrogPilot variables
+  if (msg->addr == 0xC9U) {
+    acc_main_on = GET_BIT(msg, 29U);
+  }
 }
 
 static bool gm_tx_hook(const CANPacket_t *msg) {

opendbc_repo/opendbc/safety/modes/honda.h

@@ -238,7 +238,7 @@ static bool honda_tx_hook(const CANPacket_t *msg) {
 
   // STEER: safety check
   if ((msg->addr == 0xE4U) || (msg->addr == 0x194U)) {
-    if (!controls_allowed) {
+    if (!(aol_allowed || controls_allowed)) {
       bool steer_applied = msg->data[0] | msg->data[1];
       if (steer_applied) {
         tx = false;

opendbc_repo/opendbc/safety/modes/hyundai.h

@@ -53,6 +53,8 @@ const LongitudinalLimits HYUNDAI_LONG_LIMITS = {
   {.msg = {{0x91,  0, 8, 100U, .ignore_checksum = true, .ignore_counter = true, .ignore_quality_flag = true}, { 0 }, { 0 }}}, \
 
 // FrogPilot variables
+#define HYUNDAI_LDA_BUTTON_ADDR_CHECK \
+  {.msg = {{0x391, 0, 8, 100U, .ignore_checksum = true, .ignore_counter = true, .ignore_quality_flag = true}, { 0 }, { 0 }}}, \
 
 static const CanMsg HYUNDAI_TX_MSGS[] = {
   HYUNDAI_COMMON_TX_MSGS(0)
@@ -177,6 +179,9 @@ static void hyundai_rx_hook(const CANPacket_t *msg) {
     }
 
     // FrogPilot variables
+    if (msg->addr == 0x391U) {
+      hyundai_lkas_button_check(GET_BIT(msg, 4U));
+    }
   }
 }
 
@@ -284,11 +289,29 @@ static safety_config hyundai_init(uint16_t param) {
     };
 
     // FrogPilot variables
+    static RxCheck hyundai_long_rx_checks_lda[] = {
+      HYUNDAI_COMMON_RX_CHECKS(false)
+      HYUNDAI_LDA_BUTTON_ADDR_CHECK
+    };
+
+    static RxCheck hyundai_fcev_long_rx_checks_lda[] = {
+      HYUNDAI_COMMON_RX_CHECKS(false)
+      HYUNDAI_FCEV_GAS_ADDR_CHECK
+      HYUNDAI_LDA_BUTTON_ADDR_CHECK
+    };
 
     if (hyundai_fcev_gas_signal) {
-      SET_RX_CHECKS(hyundai_fcev_long_rx_checks, ret);
+      if (hyundai_has_lda_button) {
+        SET_RX_CHECKS(hyundai_fcev_long_rx_checks_lda, ret);
+      } else {
+        SET_RX_CHECKS(hyundai_fcev_long_rx_checks, ret);
+      }
     } else {
-      SET_RX_CHECKS(hyundai_long_rx_checks, ret);
+      if (hyundai_has_lda_button) {
+        SET_RX_CHECKS(hyundai_long_rx_checks_lda, ret);
+      } else {
+        SET_RX_CHECKS(hyundai_long_rx_checks, ret);
+      }
     }
     if (hyundai_camera_scc) {
       SET_TX_MSGS(HYUNDAI_CAMERA_SCC_LONG_TX_MSGS, ret);
@@ -303,8 +326,17 @@ static safety_config hyundai_init(uint16_t param) {
     };
 
     // FrogPilot variables
+    static RxCheck hyundai_cam_scc_rx_checks_lda[] = {
+      HYUNDAI_COMMON_RX_CHECKS(false)
+      HYUNDAI_SCC12_ADDR_CHECK(2)
+      HYUNDAI_LDA_BUTTON_ADDR_CHECK
+    };
 
-    ret = BUILD_SAFETY_CFG(hyundai_cam_scc_rx_checks, HYUNDAI_CAMERA_SCC_TX_MSGS);
+    if (hyundai_has_lda_button) {
+      ret = BUILD_SAFETY_CFG(hyundai_cam_scc_rx_checks_lda, HYUNDAI_CAMERA_SCC_TX_MSGS);
+    } else {
+      ret = BUILD_SAFETY_CFG(hyundai_cam_scc_rx_checks, HYUNDAI_CAMERA_SCC_TX_MSGS);
+    }
   } else {
     static RxCheck hyundai_rx_checks[] = {
        HYUNDAI_COMMON_RX_CHECKS(false)
@@ -318,12 +350,32 @@ static safety_config hyundai_init(uint16_t param) {
     };
 
     // FrogPilot variables
+    static RxCheck hyundai_rx_checks_lda[] = {
+       HYUNDAI_COMMON_RX_CHECKS(false)
+       HYUNDAI_SCC12_ADDR_CHECK(0)
+       HYUNDAI_LDA_BUTTON_ADDR_CHECK
+    };
+
+    static RxCheck hyundai_fcev_rx_checks_lda[] = {
+      HYUNDAI_COMMON_RX_CHECKS(false)
+      HYUNDAI_SCC12_ADDR_CHECK(0)
+      HYUNDAI_FCEV_GAS_ADDR_CHECK
+      HYUNDAI_LDA_BUTTON_ADDR_CHECK
+    };
 
     SET_TX_MSGS(HYUNDAI_TX_MSGS, ret);
     if (hyundai_fcev_gas_signal) {
-      SET_RX_CHECKS(hyundai_fcev_rx_checks, ret);
+      if (hyundai_has_lda_button) {
+        SET_RX_CHECKS(hyundai_fcev_rx_checks_lda, ret);
+      } else {
+        SET_RX_CHECKS(hyundai_fcev_rx_checks, ret);
+      }
     } else {
-      SET_RX_CHECKS(hyundai_rx_checks, ret);
+      if (hyundai_has_lda_button) {
+        SET_RX_CHECKS(hyundai_rx_checks_lda, ret);
+      } else {
+        SET_RX_CHECKS(hyundai_rx_checks, ret);
+      }
     }
   }
   return ret;

opendbc_repo/opendbc/safety/modes/hyundai_canfd.h

@@ -90,11 +90,13 @@ static void hyundai_canfd_rx_hook(const CANPacket_t *msg) {
         main_button = GET_BIT(msg, 19U);
 
         // FrogPilot variables
+        hyundai_lkas_button_check(GET_BIT(msg, 23U));
       } else {
         cruise_button = (msg->data[4] >> 4) & 0x7U;
         main_button = GET_BIT(msg, 34U);
 
         // FrogPilot variables
+        hyundai_lkas_button_check(GET_BIT(msg, 39U));
       }
       hyundai_common_cruise_buttons_check(cruise_button, main_button);
     }

opendbc_repo/opendbc/safety/modes/hyundai_common.h

@@ -43,6 +43,8 @@ extern bool hyundai_alt_limits_2;
 bool hyundai_alt_limits_2 = false;
 
 // FrogPilot variables
+extern bool hyundai_has_lda_button;
+bool hyundai_has_lda_button = false;
 
 static uint8_t hyundai_last_button_interaction;  // button messages since the user pressed an enable button
 
@@ -56,6 +58,7 @@ void hyundai_common_init(uint16_t param) {
   const uint16_t HYUNDAI_PARAM_ALT_LIMITS_2 = 512;
 
   // FrogPilot variables
+  const int HYUNDAI_PARAM_HAS_LDA_BUTTON = 1024;
 
   hyundai_ev_gas_signal = GET_FLAG(param, HYUNDAI_PARAM_EV_GAS);
   hyundai_hybrid_gas_signal = !hyundai_ev_gas_signal && GET_FLAG(param, HYUNDAI_PARAM_HYBRID_GAS);
@@ -66,6 +69,7 @@ void hyundai_common_init(uint16_t param) {
   hyundai_alt_limits_2 = GET_FLAG(param, HYUNDAI_PARAM_ALT_LIMITS_2);
 
   // FrogPilot variables
+  hyundai_has_lda_button = GET_FLAG(param, HYUNDAI_PARAM_HAS_LDA_BUTTON);
 
   hyundai_last_button_interaction = HYUNDAI_PREV_BUTTON_SAMPLES;
 
@@ -118,6 +122,10 @@ void hyundai_common_cruise_buttons_check(const int cruise_button, const bool mai
   }
 
   // FrogPilot variables
+  if (main_button && !main_button_prev) {
+    acc_main_on = !acc_main_on;
+  }
+  main_button_prev = main_button;
 }
 
 #ifdef CANFD
@@ -148,3 +156,9 @@ uint32_t hyundai_common_canfd_compute_checksum(const CANPacket_t *msg) {
 #endif
 
 // FrogPilot variables
+void hyundai_lkas_button_check(const bool lkas_button) {
+  if (lkas_button && !lkas_button_prev) {
+    lkas_on = !lkas_on;
+  }
+  lkas_button_prev = lkas_button;
+}

opendbc_repo/opendbc/safety/modes/mazda.h

@@ -36,6 +36,7 @@ static void mazda_rx_hook(const CANPacket_t *msg) {
       pcm_cruise_check(cruise_engaged);
 
       // FrogPilot variables
+      acc_main_on = GET_BIT(msg, 17U);
     }
 
     if (msg->addr == MAZDA_ENGINE_DATA) {

opendbc_repo/opendbc/safety/modes/nissan.h

@@ -52,6 +52,13 @@ static void nissan_rx_hook(const CANPacket_t *msg) {
   }
 
   // FrogPilot variables
+  if ((msg->addr == 0x1B6U) && (msg->bus == (nissan_alt_eps ? 2U : 1U))) {
+    acc_main_on = GET_BIT(msg, 36U);
+  }
+
+  if ((msg->addr == 0x239U) && (msg->bus == 0U)) {
+    acc_main_on = GET_BIT(msg, 17U);
+  }
 }
 
 

opendbc_repo/opendbc/safety/modes/psa.h

@@ -11,6 +11,7 @@
 #define PSA_LANE_KEEP_ASSIST      1010U // TX from OP,  EPS
 
 // FrogPilot variables
+#define PSA_HS2_DYN1_MDD_ETAT_2B6 694U  // RX from BSI, ACC status
 
 // CAN bus
 #define PSA_MAIN_BUS 0U
@@ -24,6 +25,8 @@ static uint8_t psa_get_counter(const CANPacket_t *msg) {
   } else if (msg->addr == PSA_HS2_DYN_ABR_38D) {
     cnt = (msg->data[5] >> 4) & 0xFU;
   // FrogPilot variables
+  } else if (msg->addr == PSA_HS2_DYN1_MDD_ETAT_2B6) {
+    cnt = (msg->data[7] >> 4) & 0xFU;
   } else {
   }
   return cnt;
@@ -36,6 +39,8 @@ static uint32_t psa_get_checksum(const CANPacket_t *msg) {
   } else if (msg->addr == PSA_HS2_DYN_ABR_38D) {
     chksum = msg->data[5] & 0xFU;
   // FrogPilot variables
+  } else if (msg->addr == PSA_HS2_DYN1_MDD_ETAT_2B6) {
+    chksum = msg->data[7] & 0xFU;
   } else {
   }
   return chksum;
@@ -64,6 +69,8 @@ static uint32_t psa_compute_checksum(const CANPacket_t *msg) {
   } else if (msg->addr == PSA_HS2_DYN_ABR_38D) {
     chk = _psa_compute_checksum(msg, 0x7, 5);
   // FrogPilot variables
+  } else if (msg->addr == PSA_HS2_DYN1_MDD_ETAT_2B6) {
+    chk = _psa_compute_checksum(msg, 0x3, 7);
   } else {
   }
   return chk;
@@ -90,6 +97,9 @@ static void psa_rx_hook(const CANPacket_t *msg) {
       pcm_cruise_check((msg->data[2U] >> 7U) & 1U); // RVV_ACC_ACTIVATION_REQ
     }
     // FrogPilot variables
+    if (msg->addr == PSA_HS2_DYN1_MDD_ETAT_2B6) {
+      acc_main_on = (msg->data[3] & 0x0FU) > 2;
+    }
   }
 
 
@@ -144,6 +154,7 @@ static safety_config psa_init(uint16_t param) {
     {.msg = {{PSA_DAT_BSI, PSA_CAM_BUS, 8, 20U, .ignore_checksum = true, .ignore_counter = true, .ignore_quality_flag = true}, { 0 }, { 0 }}},        // brake
 
     // FrogPilot variables
+    {.msg = {{PSA_HS2_DYN1_MDD_ETAT_2B6, PSA_ADAS_BUS, 8, 20U, .max_counter = 15U, .ignore_quality_flag = true}, { 0 }, { 0 }}},                      // ACC status
   };
 
   return BUILD_SAFETY_CFG(psa_rx_checks, PSA_TX_MSGS);

opendbc_repo/opendbc/safety/modes/rivian.h

@@ -99,6 +99,7 @@ static void rivian_rx_hook(const CANPacket_t *msg) {
       pcm_cruise_check(feature_status == 1);
 
       // FrogPilot variables
+      acc_main_on = (feature_status == 0) || (feature_status == 1);
     }
   }
 }

opendbc_repo/opendbc/safety/modes/subaru.h

@@ -111,6 +111,7 @@ static void subaru_rx_hook(const CANPacket_t *msg) {
     pcm_cruise_check(cruise_engaged);
 
     // FrogPilot variables
+    acc_main_on = GET_BIT(msg, 40U);
   }
 
   // update vehicle moving with any non-zero wheel speed

opendbc_repo/opendbc/safety/modes/subaru_preglobal.h

@@ -35,6 +35,7 @@ static void subaru_preglobal_rx_hook(const CANPacket_t *msg) {
       pcm_cruise_check(cruise_engaged);
 
       // FrogPilot variables
+      acc_main_on = GET_BIT(msg, 48U);
     }
 
     // update vehicle moving with any non-zero wheel speed

opendbc_repo/opendbc/safety/modes/tesla.h

@@ -161,6 +161,7 @@ static void tesla_rx_hook(const CANPacket_t *msg) {
       pcm_cruise_check(cruise_engaged);
 
       // FrogPilot variables
+      acc_main_on = ((cruise_state == 1) || cruise_engaged) && !tesla_autopark;
     }
 
     if (msg->addr == 0x155U) {

opendbc_repo/opendbc/safety/modes/toyota.h

@@ -40,6 +40,7 @@
   {.msg = {{ 0xaa, 0, 8, 83U, .ignore_checksum = true, .ignore_counter = true, .ignore_quality_flag = true}, { 0 }, { 0 }}},  \
   {.msg = {{0x260, 0, 8, 50U, .ignore_counter = true, .ignore_quality_flag=!(lta)}, { 0 }, { 0 }}},                           \
   /* FrogPilot Variables */                                                                                                   \
+  {.msg = {{0x1D3, 0, 8, 33U, .ignore_checksum = true, .ignore_counter = true, .ignore_quality_flag = true}, { 0 }, { 0 }}},  \
 
 #define TOYOTA_RX_CHECKS(lta)                                                                                                               \
   TOYOTA_COMMON_RX_CHECKS(lta)                                                                                                              \
@@ -162,6 +163,13 @@ static void toyota_rx_hook(const CANPacket_t *msg) {
     }
 
     // FrogPilot variables
+    if (msg->addr == 0x1D3U) {
+      acc_main_on = GET_BIT(msg, 15U);
+    }
+
+    if (msg->addr == 0x365U) {
+      acc_main_on = GET_BIT(msg, 0U);
+    }
   }
 }
 

opendbc_repo/opendbc/safety/safety.h

@@ -61,6 +61,10 @@ int cruise_button_prev = 0;
 bool safety_rx_checks_invalid = false;
 
 // FrogPilot variables
+bool aol_allowed = false;
+bool lkas_button_prev = false;
+bool lkas_on = false;
+bool main_button_prev = false;
 
 // for safety modes with torque steering control
 int desired_torque_last = 0;       // last desired steer torque
@@ -370,6 +374,7 @@ static void generic_rx_checks(void) {
   steering_disengage_prev = steering_disengage;
 
   // FrogPilot variables
+  aol_allowed = (acc_main_on || lkas_on) && (alternative_experience & ALT_EXP_ALWAYS_ON_LATERAL);
 }
 
 static void stock_ecu_check(bool stock_ecu_detected) {
@@ -494,6 +499,10 @@ int set_safety_hooks(uint16_t mode, uint16_t param) {
   enable_gas_interceptor = false;
 
   // FrogPilot variables
+  aol_allowed = false;
+  lkas_button_prev = false;
+  lkas_on = false;
+  main_button_prev = false;
 
   return set_status;
 }

opendbc_repo/opendbc/safety/tests/common.py

@@ -302,6 +302,40 @@ class TorqueSteeringSafetyTestBase(SafetyTestBase, abc.ABC):
       self.assertFalse(self._tx(self._torque_cmd_msg(self.MAX_TORQUE, 1)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    """Toggles "Always On Lateral" On/Off"""
+    pass
+
+  def test_always_on_lateral(self):
+    if self._toggle_aol(True) is None:
+      raise unittest.SkipTest("AOL message not implemented for this safety mode")
+
+    self.safety.set_controls_allowed(False)
+
+    torque_cmd = self.MAX_RATE_UP  # Use the max rate
+
+    # Without alt exp, make sure steering is blocked
+    self.safety.set_alternative_experience(0)
+    self._set_prev_torque(0)
+    self.assertFalse(self._tx(self._torque_cmd_msg(torque_cmd)))
+
+    # With alt exp, but without main on, steering should be blocked
+    self.safety.set_alternative_experience(ALTERNATIVE_EXPERIENCE.ALWAYS_ON_LATERAL)
+    self._rx(self._toggle_aol(False))
+    self._set_prev_torque(0)
+    self.assertFalse(self._tx(self._torque_cmd_msg(torque_cmd)))
+    self.assertFalse(self.safety.get_longitudinal_allowed())
+
+    # With alt exp and main on, steering should be allowed
+    self._rx(self._toggle_aol(True))
+    self._set_prev_torque(0)
+    self.assertTrue(self._tx(self._torque_cmd_msg(torque_cmd)))
+    self.assertFalse(self.safety.get_longitudinal_allowed())
+
+    # Turn off main, steering should be blocked again
+    self._rx(self._toggle_aol(False))
+    self.safety.set_desired_torque_last(torque_cmd)
+    self.assertFalse(self._tx(self._torque_cmd_msg(torque_cmd)))
 
 
 class SteerRequestCutSafetyTest(TorqueSteeringSafetyTestBase, abc.ABC):
@@ -809,6 +843,42 @@ class AngleSteeringSafetyTest(VehicleSpeedSafetyTest):
       self.assertTrue(self._tx(self._angle_cmd_msg(0, True, increment_timer=False)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    """Toggles "Always On Lateral" on/off"""
+    pass
+
+  def test_always_on_lateral(self):
+    if self._toggle_aol(True) is None:
+      raise unittest.SkipTest("AOL message not implemented for this safety mode")
+
+    self.safety.set_controls_allowed(False)
+
+    self._reset_angle_measurement(0)
+    self._reset_speed_measurement(1)
+    angle_cmd = self.ANGLE_RATE_UP[0] / 2.0  # Use half of the max angle rate
+
+    # Without alt exp, make sure steering is blocked
+    self.safety.set_alternative_experience(0)
+    self._set_prev_desired_angle(0)
+    self.assertFalse(self._tx(self._angle_cmd_msg(angle=angle_cmd, enabled=True)))
+
+    # With alt exp, but without main on, steering should be blocked
+    self.safety.set_alternative_experience(ALTERNATIVE_EXPERIENCE.ALWAYS_ON_LATERAL)
+    self._rx(self._toggle_aol(False))
+    self._set_prev_desired_angle(0)
+    self.assertFalse(self._tx(self._angle_cmd_msg(angle=angle_cmd, enabled=True)))
+    self.assertFalse(self.safety.get_longitudinal_allowed())
+
+    # With alt exp and main on, steering should be allowed
+    self._rx(self._toggle_aol(True))
+    self._set_prev_desired_angle(0)
+    self.assertTrue(self._tx(self._angle_cmd_msg(angle=angle_cmd, enabled=True)))
+    self.assertFalse(self.safety.get_longitudinal_allowed())
+
+    # Turn off main, steering should be blocked again
+    self._rx(self._toggle_aol(False))
+    self._set_prev_desired_angle(angle_cmd)
+    self.assertFalse(self._tx(self._angle_cmd_msg(angle=angle_cmd, enabled=True)))
 
 
 class SafetyTest(SafetyTestBase):

opendbc_repo/opendbc/safety/tests/hyundai_common.py

@@ -72,6 +72,25 @@ class HyundaiButtonBase:
       self._rx(self._button_msg(Buttons.NONE))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    """
+      Simulates toggling the main cruise button. The safety model requires a
+      press and release to change the main cruise state. This function
+      resets the safety model to a known state before each call.
+    """
+    if not hasattr(self, "_aol_state"):
+      self._aol_state = False
+
+    # Already in the requested state
+    if toggle_on == self._aol_state:
+      return None
+
+    # Toggle: press + release sequence
+    self._rx(self._button_msg(Buttons.NONE, main_button=1))
+    self._rx(self._button_msg(Buttons.NONE, main_button=0))
+
+    self._aol_state = toggle_on
+    return None  # avoid duplicate message in harness
 
 
 class HyundaiLongitudinalBase(common.LongitudinalAccelSafetyTest):

opendbc_repo/opendbc/safety/tests/test_chrysler.py

@@ -72,6 +72,10 @@ class TestChryslerSafety(common.CarSafetyTest, common.MotorTorqueSteeringSafetyT
       self.assertFalse(self._tx(self._button_msg(cancel=False, resume=False)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # DAS_3, bit 20 is ACC_AVAILABLE
+    values = {"ACC_AVAILABLE": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("DAS_3", self.DAS_BUS, values)
 
 
 class TestChryslerRamDTSafety(TestChryslerSafety):

opendbc_repo/opendbc/safety/tests/test_ford.py

@@ -379,6 +379,15 @@ class TestFordSafetyBase(common.CarSafetyTest):
         self.assertEqual(enabled, self._tx(self._acc_button_msg(Buttons.CANCEL, bus)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # EngBrakeData, CcStat_D_Actl is the cruise state
+    # 3 is standby (main on), 5 is active (engaged)
+    brake = self.safety.get_brake_pressed_prev()
+    values = {
+      "BpedDrvAppl_D_Actl": 2 if brake else 1,
+      "CcStat_D_Actl": 3 if toggle_on else 0,
+    }
+    return self.packer.make_can_msg_panda("EngBrakeData", 0, values)
 
 
 class TestFordCANFDStockSafety(TestFordSafetyBase):

opendbc_repo/opendbc/safety/tests/test_gm.py

@@ -133,6 +133,10 @@ class TestGmSafetyBase(common.CarSafetyTest, common.DriverTorqueSteeringSafetyTe
     return self.packer.make_can_msg_safety("ASCMSteeringButton", self.BUTTONS_BUS, values)
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # ECMEngineStatus, bit 29 is CruiseMainOn
+    values = {"CruiseMainOn": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("ECMEngineStatus", 0, values)
 
 
 class TestGmEVSafetyBase(TestGmSafetyBase):

opendbc_repo/opendbc/safety/tests/test_honda.py

@@ -238,6 +238,11 @@ class HondaBase(common.CarSafetyTest):
     self.assertFalse(self._tx(self._send_steer_msg(0x1000)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # SCM_FEEDBACK, bit 28 is MAIN_ON
+    values = {"MAIN_ON": 1 if toggle_on else 0, "COUNTER": self.cnt_acc_state % 4}
+    self.__class__.cnt_acc_state += 1
+    return self.packer.make_can_msg_panda("SCM_FEEDBACK", self.PT_BUS, values)
 
 
 # ********************* Honda Nidec **********************

opendbc_repo/opendbc/safety/tests/test_hyundai_canfd.py

@@ -82,6 +82,26 @@ class TestHyundaiCanfdBase(HyundaiButtonBase, common.CarSafetyTest, common.Drive
     return self.packer.make_can_msg_safety("CRUISE_BUTTONS", bus, values)
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    if not hasattr(self, "_aol_state"):
+      self._aol_state = False
+
+    # Already in the requested state
+    if toggle_on == self._aol_state:
+      return None
+
+    # Simulate button press + release
+    values = {
+      "CRUISE_BUTTONS": 0,
+      "ADAPTIVE_CRUISE_MAIN_BTN": 0,
+      "LFA_BTN": 1,
+      "COUNTER": 0,
+    }
+    self._rx(self.packer.make_can_msg_panda("CRUISE_BUTTONS", self.PT_BUS, values))
+    self._rx(self.packer.make_can_msg_panda("CRUISE_BUTTONS", self.PT_BUS, {**values, "LFA_BTN": 0}))
+
+    self._aol_state = toggle_on
+    return None  # avoid duplicate message in harness
 
 
 class TestHyundaiCanfdLFASteeringBase(TestHyundaiCanfdBase):
@@ -153,6 +173,26 @@ class TestHyundaiCanfdLFASteeringAltButtonsBase(TestHyundaiCanfdLFASteeringBase)
       self.assertFalse(self._tx(self._acc_cancel_msg(False)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    if not hasattr(self, "_aol_state"):
+      self._aol_state = False
+
+    # Already in the requested state
+    if toggle_on == self._aol_state:
+      return None
+
+    # Simulate button press + release
+    values = {
+      "CRUISE_BUTTONS_ALT": 0,
+      "ADAPTIVE_CRUISE_MAIN_BTN": 0,
+      "LFA_BTN": 1,
+      "COUNTER": 0,
+    }
+    self._rx(self.packer.make_can_msg_panda("CRUISE_BUTTONS_ALT", self.PT_BUS, values))
+    self._rx(self.packer.make_can_msg_panda("CRUISE_BUTTONS_ALT", self.PT_BUS, {**values, "LFA_BTN": 0}))
+
+    self._aol_state = toggle_on
+    return None  # avoid duplicate message in harness
 
 
 @parameterized_class(ALL_GAS_EV_HYBRID_COMBOS)

opendbc_repo/opendbc/safety/tests/test_mazda.py

@@ -81,6 +81,10 @@ class TestMazdaSafety(common.CarSafetyTest, common.DriverTorqueSteeringSafetyTes
     self.assertTrue(self._tx(self._button_msg(resume=True)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # CRZ_CTRL, CRZ_AVAILABLE is the main on button
+    values = {"CRZ_AVAILABLE": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("CRZ_CTRL", 0, values)
 
 
 if __name__ == "__main__":

opendbc_repo/opendbc/safety/tests/test_nissan.py

@@ -80,6 +80,10 @@ class TestNissanSafety(common.CarSafetyTest, common.AngleSteeringSafetyTest):
         self.assertEqual(tx, should_tx)
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # PRO_PILOT, CRUISE_ON is the main on button for X-Trail/Rogue/Altima
+    values = {"CRUISE_ON": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("PRO_PILOT", 2, values)
 
 
 class TestNissanSafetyAltEpsBus(TestNissanSafety):
@@ -116,6 +120,10 @@ class TestNissanLeafSafety(TestNissanSafety):
     pass
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # CRUISE_THROTTLE, CRUISE_AVAILABLE is the main on button for Leaf
+    values = {"CRUISE_AVAILABLE": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("CRUISE_THROTTLE", 0, values)
 
 
 if __name__ == "__main__":

opendbc_repo/opendbc/safety/tests/test_subaru.py

@@ -112,6 +112,10 @@ class TestSubaruSafetyBase(common.CarSafetyTest):
     return self.packer.make_can_msg_safety("CruiseControl", self.ALT_MAIN_BUS, values)
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # CruiseControl, Cruise_On is the main on button
+    values = {"Cruise_On": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("CruiseControl", self.ALT_MAIN_BUS, values)
 
 
 class TestSubaruStockLongitudinalSafetyBase(TestSubaruSafetyBase):

opendbc_repo/opendbc/safety/tests/test_subaru_preglobal.py

@@ -60,6 +60,10 @@ class TestSubaruPreglobalSafety(common.CarSafetyTest, common.DriverTorqueSteerin
     return self.packer.make_can_msg_safety("CruiseControl", 0, values)
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # CruiseControl, Cruise_On is the main on button
+    values = {"Cruise_On": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("CruiseControl", 0, values)
 
 
 class TestSubaruPreglobalReversedDriverTorqueSafety(TestSubaruPreglobalSafety):

opendbc_repo/opendbc/safety/tests/test_tesla.py

@@ -354,6 +354,10 @@ class TestTeslaSafetyBase(common.CarSafetyTest, common.AngleSteeringSafetyTest,
         self.assertTrue(self._tx(self._angle_cmd_msg(0, True)))
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # DI_state, DI_cruiseState is the cruise state, 1 is standby
+    values = {"DI_cruiseState": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("DI_state", 0, values)
 
 
 class TestTeslaStockSafety(TestTeslaSafetyBase):

opendbc_repo/opendbc/safety/tests/test_toyota.py

@@ -10,7 +10,7 @@ from opendbc.safety.tests.libsafety import libsafety_py
 import opendbc.safety.tests.common as common
 from opendbc.safety.tests.common import CANPackerSafety
 
-TOYOTA_COMMON_TX_MSGS = [[0x2E4, 0], [0x191, 0], [0x412, 0], [0x343, 0], [0x1D2, 0]]  # LKAS + LTA + ACC & PCM cancel cmds
+TOYOTA_COMMON_TX_MSGS = [[0x2E4, 0], [0x191, 0], [0x412, 0], [0x343, 0], [0x1D2, 0], [0x1D3, 0]]  # LKAS + LTA + ACC & PCM cancel cmds
 TOYOTA_SECOC_TX_MSGS = [[0x131, 0], [0x183, 0]] + TOYOTA_COMMON_TX_MSGS
 TOYOTA_COMMON_LONG_TX_MSGS = [[0x283, 0], [0x2E6, 0], [0x2E7, 0], [0x33E, 0], [0x344, 0], [0x365, 0], [0x366, 0], [0x4CB, 0],  # DSU bus 0
                               [0x128, 1], [0x141, 1], [0x160, 1], [0x161, 1], [0x470, 1],  # DSU bus 1
@@ -123,6 +123,10 @@ class TestToyotaSafetyBase(common.CarSafetyTest, common.LongitudinalAccelSafetyT
       self.assertFalse(self.safety.get_controls_allowed())
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # pcm_cruise_2, bit 15 is toggle_on
+    values = {"MAIN_ON": 1 if toggle_on else 0}
+    return self.packer.make_can_msg_panda("PCM_CRUISE_2", 0, values)
 
 
 class TestToyotaSafetyTorque(TestToyotaSafetyBase, common.MotorTorqueSteeringSafetyTest, common.SteerRequestCutSafetyTest):

opendbc_repo/opendbc/safety/tests/test_volkswagen_mqb.py

@@ -127,6 +127,9 @@ class TestVolkswagenMqbSafetyBase(common.CarSafetyTest, common.DriverTorqueSteer
     self.assertEqual(0, self.safety.get_torque_driver_min())
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # TSK_06, TSK_Status is the cruise state, 2 is standby
+    return self._tsk_status_msg(False, main_switch=toggle_on)
 
 
 class TestVolkswagenMqbStockSafety(TestVolkswagenMqbSafetyBase):

opendbc_repo/opendbc/safety/tests/test_volkswagen_pq.py

@@ -109,6 +109,9 @@ class TestVolkswagenPqSafetyBase(common.CarSafetyTest, common.DriverTorqueSteeri
     self.assertEqual(0, self.safety.get_torque_driver_min())
 
   # FrogPilot variables
+  def _toggle_aol(self, toggle_on):
+    # Motor_5, GRA_Hauptschalter is the main cruise switch
+    return self._motor_5_msg(main_switch=toggle_on)
 
 
 class TestVolkswagenPqStockSafety(TestVolkswagenPqSafetyBase):