From b5753daa17909259c6d47d9e2919601ed3ac734b Mon Sep 17 00:00:00 2001 From: firestar5683 <168790843+firestar5683@users.noreply.github.com> Date: Sat, 1 Aug 2026 15:36:57 -0500 Subject: [PATCH] fix --- starpilot/common/starpilot_variables.py | 4 +++- starpilot/common/tests/test_starpilot_variables.py | 10 ++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/starpilot/common/starpilot_variables.py b/starpilot/common/starpilot_variables.py index a9bb03ec4..4c5954d30 100644 --- a/starpilot/common/starpilot_variables.py +++ b/starpilot/common/starpilot_variables.py @@ -1044,7 +1044,9 @@ class StarPilotVariables: toggle.lane_detection_width = self.get_value("LaneDetectionWidth", cast=float, condition=toggle.lane_changes, conversion=distance_conversion) toggle.minimum_lane_change_speed = self.get_value("MinimumLaneChangeSpeed", cast=float, condition=toggle.lane_changes, conversion=speed_conversion) toggle.lane_change_close_gap = self.get_value("LaneChangeCloseGap", condition=toggle.lane_changes) - toggle.lane_change_close_gap_seconds = self.get_value("LaneChangeCloseGapSeconds", cast=float, condition=toggle.lane_change_close_gap, min=0.5, max=3.0) + toggle.lane_change_close_gap_seconds = self.get_value( + "LaneChangeCloseGapSeconds", cast=float, condition=toggle.lane_change_close_gap, default=1.0, min=0.5, max=3.0, + ) toggle.nudgeless = self.get_value("NudgelessLaneChange", condition=toggle.lane_changes) toggle.nudgeless_lane_change_only_when_engaged = self.get_value("NudgelessLaneChangeOnlyWhenEngaged", condition=toggle.lane_changes and toggle.nudgeless) toggle.one_lane_change = self.get_value("OneLaneChange", condition=toggle.lane_changes) diff --git a/starpilot/common/tests/test_starpilot_variables.py b/starpilot/common/tests/test_starpilot_variables.py index 694d45aa6..6a2e5aa84 100644 --- a/starpilot/common/tests/test_starpilot_variables.py +++ b/starpilot/common/tests/test_starpilot_variables.py @@ -170,6 +170,16 @@ def test_runtime_values_ignore_legacy_tuning_level_metadata(): assert variables.get_button_function("LKASButtonControl") == spv.BUTTON_FUNCTIONS["AOL_TOGGLE"] +def test_missing_bounded_value_uses_explicit_default(): + variables = object.__new__(spv.StarPilotVariables) + variables.params = _FakeParams() + variables.default_values = {} + + value = variables.get_value("LaneChangeCloseGapSeconds", cast=float, default=1.0, min=0.5, max=3.0) + + assert value == 1.0 + + def test_favorite_button_flags_map_to_three_slots(): toggle = SimpleNamespace()