From af2e153e52fea84b59d7b0e265bbff1cf9b953d1 Mon Sep 17 00:00:00 2001
From: firestar5683 <168790843+firestar5683@users.noreply.github.com>
Date: Thu, 27 Aug 2026 14:24:43 -0500
Subject: [PATCH] GUM
---
docs/CARS.md | 4 +-
opendbc_repo/docs/CARS.md | 4 +-
opendbc_repo/opendbc/car/gm/fingerprints.py | 29 ++++-----
opendbc_repo/opendbc/car/gm/gmcan.py | 10 +--
opendbc_repo/opendbc/car/gm/interface.py | 5 +-
opendbc_repo/opendbc/car/gm/tests/test_gm.py | 41 ++++++++++++
opendbc_repo/opendbc/car/gm/values.py | 3 +-
opendbc_repo/opendbc/car/interfaces.py | 4 ++
.../opendbc/car/tests/test_car_interfaces.py | 24 +++++++
opendbc_repo/opendbc/safety/modes/gm.h | 9 +++
opendbc_repo/opendbc/safety/tests/test_gm.py | 22 +++++++
.../controls/tests/test_starpilot_vcruise.py | 17 +++++
.../settings/starpilot/longitudinal.py | 4 +-
.../ui/onroad/starpilot/starpilot_border.py | 10 +--
.../common/assets/device_settings_layout.json | 24 +++++++
.../controls/lib/curve_speed_controller.py | 9 ++-
.../components/tools/device_settings.css | 7 ++
.../components/tools/device_settings.js | 64 ++++++++++++++++++-
.../tests/test_device_settings_layout.py | 11 ++++
.../tests/test_navigation_params.py | 32 ++++++++++
starpilot/system/the_galaxy/the_galaxy.py | 9 +++
21 files changed, 305 insertions(+), 37 deletions(-)
diff --git a/docs/CARS.md b/docs/CARS.md
index 0cc85940a..05f5084a7 100644
--- a/docs/CARS.md
+++ b/docs/CARS.md
@@ -76,7 +76,7 @@ A supported vehicle is one that just works when you install a comma device. All
|Chevrolet|Volt 2019|Adaptive Cruise Control (ACC) & LKAS|Stock|0 mph|7 mph|[](##)|[](##)|Parts
- 1 GM SDGM connector
- 1 OBD-C cable (2 ft)
- 1 USB-C coupler
- 1 comma four
- 1 comma power v3
- 1 harness box
- 1 long OBD-C cable (9.5 ft)
- 1 mount
Buy HereParts
- 1 GM connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 harness box
- 1 mount
Buy Here
||
|Chevrolet|Volt Camera Harness 2017-18|Flashed camera-forward integration with ACC|openpilot available[1](#footnotes)|0 mph|7 mph|[](##)|[](##)|Parts
- 1 GM connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 harness box
- 1 mount
Buy HereParts
- 1 GM connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 harness box
- 1 mount
Buy HereParts
- 1 OBD-II connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 harness box
- 1 mount
Buy HereParts
- 1 FCA connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 comma power v3
- 1 harness box
- 1 mount
Buy HereParts
- 1 FCA connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 comma power v3
- 1 harness box
- 1 mount
Buy HereParts
- 1 FCA connector
- 1 OBD-C cable (2 ft)
- 1 comma four
- 1 comma power v3
- 1 harness box
- 1 mount
Buy Here
@@ -1713,8 +1771,9 @@ function renderSettingRow(p) {
` : ""}
- ${(isNumeric || isColor) ? html`${() => {
+ ${(isNumeric || isColor || isReadout) ? html`${() => {
if (isColor) return formatColorDisplayValue(p)
+ if (isReadout) return formatReadoutValue(p)
const currentValue = state.sliderPreviewValues[p.key] ?? state.values[p.key]
const bounds = numericBounds(p)
return currentValue !== undefined ? formatSliderValue(currentValue, String(bounds.step), p.precision, p.key) : ".."
@@ -1769,6 +1828,7 @@ export function DeviceSettings({ params }) {
fetchFlmWorkspace()
ensureFavoriteValuePolling()
+ ensureCscCalibrationPolling()
if (!state.fetched) {
state.fetched = true
diff --git a/starpilot/system/the_galaxy/tests/test_device_settings_layout.py b/starpilot/system/the_galaxy/tests/test_device_settings_layout.py
index e26458b5a..c90cfaebf 100644
--- a/starpilot/system/the_galaxy/tests/test_device_settings_layout.py
+++ b/starpilot/system/the_galaxy/tests/test_device_settings_layout.py
@@ -135,6 +135,17 @@ def test_curve_speed_controller_no_lead_toggle_is_nested_under_csc():
assert _declared_default("CurveSpeedControllerNoLead") == "0"
+def test_curve_speed_controller_readouts_are_display_only_and_nested():
+ csc = _params_by_section(_layout())["Longitudinal (Speed & Following)"]
+
+ for key, unit in (("CalibratedLateralAcceleration", " m/s²"), ("CalibrationProgress", "%")):
+ readout = csc[key]
+ assert readout["ui_type"] == "readout"
+ assert readout["parent_key"] == "CurveSpeedController"
+ assert readout["unit"] == unit
+ assert readout["settings_tier"] == "simple"
+
+
def test_every_galaxy_setting_has_a_shared_settings_tier():
layout = _layout()
tiers = {
diff --git a/starpilot/system/the_galaxy/tests/test_navigation_params.py b/starpilot/system/the_galaxy/tests/test_navigation_params.py
index 072d4c5ed..519348c29 100644
--- a/starpilot/system/the_galaxy/tests/test_navigation_params.py
+++ b/starpilot/system/the_galaxy/tests/test_navigation_params.py
@@ -256,6 +256,27 @@ def test_device_settings_layout_asset_is_served_from_common_catalog(monkeypatch)
assert response.get_json() == the_galaxy.load_settings_catalog()
+def test_params_all_exposes_curve_calibration_readouts(monkeypatch):
+ client, _ = _params_client(monkeypatch, {
+ "CalibratedLateralAcceleration": 2.73,
+ "CalibrationProgress": 48.0,
+ }, "tici")
+ monkeypatch.setattr(
+ the_galaxy,
+ "_params_live_raw",
+ WritableFakeParams({
+ "CalibratedLateralAcceleration": 2.73,
+ "CalibrationProgress": 48.0,
+ }),
+ )
+
+ response = client.get("/api/params/all")
+
+ assert response.status_code == 200
+ assert response.get_json()["CalibratedLateralAcceleration"] == 2.73
+ assert response.get_json()["CalibrationProgress"] == 48.0
+
+
def test_ford_lateral_mode_is_editable_through_galaxy(monkeypatch):
client, fake_params = _params_client(monkeypatch, {
"CarMake": "Ford",
@@ -391,6 +412,12 @@ def test_curve_speed_controller_reset_clears_learned_data_offroad(monkeypatch):
"CalibrationProgress": 48.0,
"CurvatureData": {"0.01": {"average": 2.73, "count": 12}},
}, "tici")
+ fake_memory = WritableFakeParams({
+ "CalibratedLateralAcceleration": 2.73,
+ "CalibrationProgress": 48.0,
+ "CurvatureData": {"0.01": {"average": 2.73, "count": 12}},
+ })
+ monkeypatch.setattr(the_galaxy, "params_memory", fake_memory)
response = client.post("/api/curve_speed_controller/reset")
@@ -403,6 +430,11 @@ def test_curve_speed_controller_reset_clears_learned_data_offroad(monkeypatch):
assert "CalibrationProgress" not in fake_params.values
assert "CurvatureData" not in fake_params.values
assert fake_params.removals == ["CalibrationProgress", "CurvatureData"]
+ assert fake_memory.values == {
+ "CalibratedLateralAcceleration": 2.0,
+ "CalibrationProgress": 0.0,
+ }
+ assert fake_memory.removals == ["CurvatureData"]
def test_curve_speed_controller_reset_rejected_onroad(monkeypatch):
diff --git a/starpilot/system/the_galaxy/the_galaxy.py b/starpilot/system/the_galaxy/the_galaxy.py
index 276acc71d..b895a5c0a 100644
--- a/starpilot/system/the_galaxy/the_galaxy.py
+++ b/starpilot/system/the_galaxy/the_galaxy.py
@@ -5456,6 +5456,9 @@ def setup(app):
params.put("CalibratedLateralAcceleration", 2.0)
params.remove("CalibrationProgress")
params.remove("CurvatureData")
+ params_memory.put("CalibratedLateralAcceleration", 2.0)
+ params_memory.put("CalibrationProgress", 0.0)
+ params_memory.remove("CurvatureData")
return jsonify({
"message": "Curve Speed Controller data reset. Training will restart on the next drive.",
@@ -5484,6 +5487,12 @@ def setup(app):
result["AlphaLongitudinalAvailable"] = _get_alpha_longitudinal_available()
result["HasRivianAngleHarness"] = _get_has_rivian_angle_harness()
+ for key in ("CalibratedLateralAcceleration", "CalibrationProgress"):
+ try:
+ result[key] = _get_current_param_value(key, float, defaults_lookup)
+ except Exception:
+ result[key] = None
+
return jsonify(_sanitize_json_value(result)), 200
@app.route("/api/params/defaults", methods=["GET"])