Widget: add enabled property (#35944)

* add enabled

* sort

* rename

* rest

* rm that
This commit is contained in:
Shane Smiskol
2025-08-06 22:00:12 -07:00
committed by GitHub
parent 8b90c210f8
commit 6cf710d4cb
7 changed files with 46 additions and 42 deletions
+30 -22
View File
@@ -2,7 +2,7 @@ import abc
import pyray as rl
from enum import IntEnum
from collections.abc import Callable
from openpilot.system.ui.lib.application import gui_app, MousePos, MAX_TOUCH_SLOT
from openpilot.system.ui.lib.application import gui_app, MousePos, MAX_TOUCH_SLOTS
class DialogResult(IntEnum):
@@ -15,34 +15,16 @@ class Widget(abc.ABC):
def __init__(self):
self._rect: rl.Rectangle = rl.Rectangle(0, 0, 0, 0)
self._parent_rect: rl.Rectangle = rl.Rectangle(0, 0, 0, 0)
self._is_pressed = [False] * MAX_TOUCH_SLOT
self._multi_touch = False
self._is_pressed = [False] * MAX_TOUCH_SLOTS
self._enabled: bool | Callable[[], bool] = True
self._is_visible: bool | Callable[[], bool] = True
self._touch_valid_callback: Callable[[], bool] | None = None
def set_touch_valid_callback(self, touch_callback: Callable[[], bool]) -> None:
"""Set a callback to determine if the widget can be clicked."""
self._touch_valid_callback = touch_callback
def _touch_valid(self) -> bool:
"""Check if the widget can be touched."""
return self._touch_valid_callback() if self._touch_valid_callback else True
@property
def is_visible(self) -> bool:
return self._is_visible() if callable(self._is_visible) else self._is_visible
@property
def is_pressed(self) -> bool:
return any(self._is_pressed)
self._multi_touch = False
@property
def rect(self) -> rl.Rectangle:
return self._rect
def set_visible(self, visible: bool | Callable[[], bool]) -> None:
self._is_visible = visible
def set_rect(self, rect: rl.Rectangle) -> None:
changed = (self._rect.x != rect.x or self._rect.y != rect.y or
self._rect.width != rect.width or self._rect.height != rect.height)
@@ -54,6 +36,32 @@ class Widget(abc.ABC):
"""Can be used like size hint in QT"""
self._parent_rect = parent_rect
@property
def is_pressed(self) -> bool:
return any(self._is_pressed)
@property
def enabled(self) -> bool:
return self._enabled() if callable(self._enabled) else self._enabled
def set_enabled(self, enabled: bool | Callable[[], bool]) -> None:
self._enabled = enabled
@property
def is_visible(self) -> bool:
return self._is_visible() if callable(self._is_visible) else self._is_visible
def set_visible(self, visible: bool | Callable[[], bool]) -> None:
self._is_visible = visible
def set_touch_valid_callback(self, touch_callback: Callable[[], bool]) -> None:
"""Set a callback to determine if the widget can be clicked."""
self._touch_valid_callback = touch_callback
def _touch_valid(self) -> bool:
"""Check if the widget can be touched."""
return self._touch_valid_callback() if self._touch_valid_callback else True
def set_position(self, x: float, y: float) -> None:
changed = (self._rect.x != x or self._rect.y != y)
self._rect.x, self._rect.y = x, y
-2
View File
@@ -172,7 +172,6 @@ class Button(Widget):
border_radius: int = 10,
text_alignment: TextAlignment = TextAlignment.CENTER,
text_padding: int = 20,
enabled: bool = True,
icon = None,
multi_touch: bool = False,
):
@@ -187,7 +186,6 @@ class Button(Widget):
self._click_callback = click_callback
self._multi_touch = multi_touch
self.enabled = enabled
def set_text(self, text):
self._label.set_text(text)
+2 -2
View File
@@ -187,10 +187,10 @@ class Keyboard(Widget):
if key in self._key_icons:
if key == SHIFT_ACTIVE_KEY and self._caps_lock:
key = CAPS_LOCK_KEY
self._all_keys[key].enabled = is_enabled
self._all_keys[key].set_enabled(is_enabled)
self._all_keys[key].render(key_rect)
else:
self._all_keys[key].enabled = is_enabled
self._all_keys[key].set_enabled(is_enabled)
self._all_keys[key].render(key_rect)
return self._render_return_status
+3 -3
View File
@@ -150,14 +150,14 @@ class WifiManagerUI(Widget):
match self.state:
case StateConnecting(network=connecting):
if connecting.ssid == network.ssid:
self._networks_buttons[network.ssid].enabled = False
self._networks_buttons[network.ssid].set_enabled(False)
status_text = "CONNECTING..."
case StateForgetting(network=forgetting):
if forgetting.ssid == network.ssid:
self._networks_buttons[network.ssid].enabled = False
self._networks_buttons[network.ssid].set_enabled(False)
status_text = "FORGETTING..."
case _:
self._networks_buttons[network.ssid].enabled = True
self._networks_buttons[network.ssid].set_enabled(True)
self._networks_buttons[network.ssid].render(ssid_rect)
-3
View File
@@ -38,9 +38,6 @@ class Toggle(Widget):
self._state = state
self._target = 1.0 if state else 0.0
def set_enabled(self, enabled: bool):
self._enabled = enabled
def is_enabled(self):
return self._enabled