From 6ca072af445a2f17fd711d0cfd5eb9b83aed88d9 Mon Sep 17 00:00:00 2001 From: Dom <168790843+firestar5683@users.noreply.github.com> Date: Tue, 20 Oct 2026 21:56:51 -0500 Subject: [PATCH] Narrow test fixture types before mutation --- .../starpilot/ui/tests/test_jeep_brake_hold_preference.py | 4 +++- openpilot/system/manager/test/test_process_recovery.py | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/openpilot/starpilot/ui/tests/test_jeep_brake_hold_preference.py b/openpilot/starpilot/ui/tests/test_jeep_brake_hold_preference.py index 3d045c6bcd..bc49d1158b 100644 --- a/openpilot/starpilot/ui/tests/test_jeep_brake_hold_preference.py +++ b/openpilot/starpilot/ui/tests/test_jeep_brake_hold_preference.py @@ -40,7 +40,9 @@ class TestJeepBrakeHoldPreference(unittest.TestCase): row = next( row for row in owner.snapshot('vehicle', parked=True, system_long=False, lateral_context=True, metric=False).rows if row.key == 'JeepBrakeHold' ) - request = replace(row_change(row), confirmation=True) + change = row_change(row) + assert change is not None + request = replace(change, confirmation=True) for group in groups: groups[group] = False self.assertFalse(owner.apply(request)) diff --git a/openpilot/system/manager/test/test_process_recovery.py b/openpilot/system/manager/test/test_process_recovery.py index ac41e4f033..1ac69ceb05 100644 --- a/openpilot/system/manager/test/test_process_recovery.py +++ b/openpilot/system/manager/test/test_process_recovery.py @@ -128,6 +128,7 @@ class TestProcessRecovery(unittest.TestCase): self.step(p) old = p.proc self.assertIsNotNone(old) + assert isinstance(old, Child) old.exitcode = 1 self.step(p) self.assertIs(p.proc, old) @@ -135,6 +136,7 @@ class TestProcessRecovery(unittest.TestCase): self.step(p) self.assertIsNot(p.proc, old) self.assertTrue(old.joined) + assert isinstance(p.proc, Child) p.proc.exitcode = 1 self.step(p) self.step(p, started=False)