From 631d6d9ef4f8c375843c64c6b3552e32adf7b363 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Wed, 17 Dec 2025 21:26:52 -0800 Subject: [PATCH] Widget: mouse handlers don't use bool (#36921) * not used * lint --- selfdrive/ui/layouts/settings/settings.py | 8 +++----- system/ui/widgets/__init__.py | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/selfdrive/ui/layouts/settings/settings.py b/selfdrive/ui/layouts/settings/settings.py index 72d3a4baf..68f45df77 100644 --- a/selfdrive/ui/layouts/settings/settings.py +++ b/selfdrive/ui/layouts/settings/settings.py @@ -145,20 +145,18 @@ class SettingsLayout(Widget): if panel.instance: panel.instance.render(content_rect) - def _handle_mouse_release(self, mouse_pos: MousePos) -> bool: + def _handle_mouse_release(self, mouse_pos: MousePos) -> None: # Check close button if rl.check_collision_point_rec(mouse_pos, self._close_btn_rect): if self._close_callback: self._close_callback() - return True + return # Check navigation buttons for panel_type, panel_info in self._panels.items(): if rl.check_collision_point_rec(mouse_pos, panel_info.button_rect): self.set_current_panel(panel_type) - return True - - return False + return def set_current_panel(self, panel_type: PanelType): if panel_type != self._current_panel: diff --git a/system/ui/widgets/__init__.py b/system/ui/widgets/__init__.py index a3fed6d96..8a46a3e43 100644 --- a/system/ui/widgets/__init__.py +++ b/system/ui/widgets/__init__.py @@ -165,15 +165,13 @@ class Widget(abc.ABC): def _update_layout_rects(self) -> None: """Optionally update any layout rects on Widget rect change.""" - def _handle_mouse_press(self, mouse_pos: MousePos) -> bool: + def _handle_mouse_press(self, mouse_pos: MousePos) -> None: """Optionally handle mouse press events.""" - return False - def _handle_mouse_release(self, mouse_pos: MousePos) -> bool: + def _handle_mouse_release(self, mouse_pos: MousePos) -> None: """Optionally handle mouse release events.""" if self._click_callback: self._click_callback() - return False def _handle_mouse_event(self, mouse_event: MouseEvent) -> None: """Optionally handle mouse events. This is called before rendering."""