diff --git a/panda/board/obj/gitversion.h b/panda/board/obj/gitversion.h index 760068830..e53e43c34 100644 --- a/panda/board/obj/gitversion.h +++ b/panda/board/obj/gitversion.h @@ -1,2 +1,2 @@ extern const uint8_t gitversion[19]; -const uint8_t gitversion[19] = "DEV-c082d60d-DEBUG"; +const uint8_t gitversion[19] = "DEV-2712642d-DEBUG"; diff --git a/panda/board/obj/version b/panda/board/obj/version index b80cde237..405d568d3 100644 --- a/panda/board/obj/version +++ b/panda/board/obj/version @@ -1 +1 @@ -DEV-c082d60d-DEBUG \ No newline at end of file +DEV-2712642d-DEBUG \ No newline at end of file diff --git a/selfdrive/ui/qt/window.cc b/selfdrive/ui/qt/window.cc index 9a6767d34..ccc63d546 100644 --- a/selfdrive/ui/qt/window.cc +++ b/selfdrive/ui/qt/window.cc @@ -13,6 +13,17 @@ MainWindow::MainWindow(QWidget *parent) : QWidget(parent) { QObject::connect(homeWindow, &HomeWindow::openSettings, this, &MainWindow::openSettings); QObject::connect(homeWindow, &HomeWindow::closeSettings, this, &MainWindow::closeSettings); + settingsWindow = new SettingsWindow(this); + main_layout->addWidget(settingsWindow); + QObject::connect(settingsWindow, &SettingsWindow::closeSettings, this, &MainWindow::closeSettings); + QObject::connect(settingsWindow, &SettingsWindow::reviewTrainingGuide, [=]() { + onboardingWindow->showTrainingGuide(); + main_layout->setCurrentWidget(onboardingWindow); + }); + QObject::connect(settingsWindow, &SettingsWindow::showDriverView, [=] { + homeWindow->showDriverView(true); + }); + onboardingWindow = new OnboardingWindow(this); main_layout->addWidget(onboardingWindow); QObject::connect(onboardingWindow, &OnboardingWindow::onboardingDone, [=]() { @@ -28,7 +39,7 @@ MainWindow::MainWindow(QWidget *parent) : QWidget(parent) { } }); QObject::connect(device(), &Device::interactiveTimeout, [=]() { - if (settingsWindow != nullptr && main_layout->currentWidget() == settingsWindow) { + if (main_layout->currentWidget() == settingsWindow) { closeSettings(); } }); @@ -54,25 +65,7 @@ MainWindow::MainWindow(QWidget *parent) : QWidget(parent) { setAttribute(Qt::WA_NoSystemBackground); } -void MainWindow::ensureSettingsWindow() { - if (settingsWindow != nullptr) { - return; - } - - settingsWindow = new SettingsWindow(this); - main_layout->insertWidget(1, settingsWindow); - QObject::connect(settingsWindow, &SettingsWindow::closeSettings, this, &MainWindow::closeSettings); - QObject::connect(settingsWindow, &SettingsWindow::reviewTrainingGuide, [=]() { - onboardingWindow->showTrainingGuide(); - main_layout->setCurrentWidget(onboardingWindow); - }); - QObject::connect(settingsWindow, &SettingsWindow::showDriverView, [=] { - homeWindow->showDriverView(true); - }); -} - void MainWindow::openSettings(int index, const QString ¶m) { - ensureSettingsWindow(); main_layout->setCurrentWidget(settingsWindow); settingsWindow->setCurrentPanel(index, param); } diff --git a/selfdrive/ui/qt/window.h b/selfdrive/ui/qt/window.h index 762f2ca59..88f4b2410 100644 --- a/selfdrive/ui/qt/window.h +++ b/selfdrive/ui/qt/window.h @@ -15,13 +15,12 @@ public: private: bool eventFilter(QObject *obj, QEvent *event) override; - void ensureSettingsWindow(); void openSettings(int index = 0, const QString ¶m = ""); void closeSettings(); QStackedLayout *main_layout; HomeWindow *homeWindow; - SettingsWindow *settingsWindow = nullptr; + SettingsWindow *settingsWindow; OnboardingWindow *onboardingWindow; Params params; diff --git a/selfdrive/ui/ui b/selfdrive/ui/ui index 349ef058c..1270f28dd 100755 Binary files a/selfdrive/ui/ui and b/selfdrive/ui/ui differ