From 31be93b22cc19ab313cf734e856a56295c8fafc6 Mon Sep 17 00:00:00 2001 From: firestar5683 <168790843+firestar5683@users.noreply.github.com> Date: Sat, 19 Sep 2026 21:53:52 -0700 Subject: [PATCH] Accept native false Params values in live model placement check --- roadscore/prototype/live_health.py | 2 +- roadscore/prototype/test_live_health.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/roadscore/prototype/live_health.py b/roadscore/prototype/live_health.py index 177bb5d8f8..8a8d5ee39b 100644 --- a/roadscore/prototype/live_health.py +++ b/roadscore/prototype/live_health.py @@ -25,7 +25,7 @@ def identity(value): def local_model_placement(metadata, active, loading): - return metadata.get("uses_external_gpu") is False and active in (b"0", "0") and loading in (b"0", "0") + return metadata.get("uses_external_gpu") is False and (active is False or active in (b"0", "0")) and (loading is False or loading in (b"0", "0")) def evaluate(snapshot, record, now): diff --git a/roadscore/prototype/test_live_health.py b/roadscore/prototype/test_live_health.py index f706623a26..e01fbbf0d3 100644 --- a/roadscore/prototype/test_live_health.py +++ b/roadscore/prototype/test_live_health.py @@ -23,6 +23,8 @@ def authorization(): class Tests(unittest.TestCase): def test_model_placement_requires_actual_runtime_flags(self): self.assertTrue(local_model_placement({"uses_external_gpu":False},b"0",b"0")) + self.assertTrue(local_model_placement({"uses_external_gpu":False},False,False)) + self.assertFalse(local_model_placement({"uses_external_gpu":False},None,False)) for active,loading in ((None,b"0"),(b"1",b"0"),(b"0",None),(b"0",b"1")): self.assertFalse(local_model_placement({"uses_external_gpu":False},active,loading)) self.assertFalse(local_model_placement({},b"0",b"0"))