From 2300a51edf6864ebafd1f7f8f0b38f57e34c364b Mon Sep 17 00:00:00 2001 From: whoisdomi Date: Sun, 27 Sep 2026 21:14:43 -0500 Subject: [PATCH] kp slider --- selfdrive/ui/layouts/settings/starpilot/lateral.py | 2 +- starpilot/common/starpilot_variables.py | 2 +- .../the_galaxy/assets/components/tools/device_settings.js | 2 +- starpilot/system/the_galaxy/assets/mobile/js/params.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/selfdrive/ui/layouts/settings/starpilot/lateral.py b/selfdrive/ui/layouts/settings/starpilot/lateral.py index 0c861b5b34..ad3d3981dc 100644 --- a/selfdrive/ui/layouts/settings/starpilot/lateral.py +++ b/selfdrive/ui/layouts/settings/starpilot/lateral.py @@ -302,7 +302,7 @@ class StarPilotLateralLayout(_SettingsPage): "SteerKP", "value", tr_noop("Kp Factor"), subtitle=tr_noop("How strongly openpilot corrects lateral position."), get_value=lambda: f"{p.get_float('SteerKP'):.2f}", - on_click=lambda: self._show_slider("SteerKP", max(0.01, cs.steerKp) * 0.5, max(0.01, cs.steerKp) * 1.5, step=0.01, value_type="float"), + on_click=lambda: self._show_slider("SteerKP", max(0.01, cs.steerKp) * 0.5, max(0.01, cs.steerKp) * 3.0, step=0.01, value_type="float"), visible=lambda: alt_on() and cs.steerKp != 0 and cs.isTorqueCar and not cs.isAngleCar, ), SettingRow( diff --git a/starpilot/common/starpilot_variables.py b/starpilot/common/starpilot_variables.py index b9c59e699e..53b9eead84 100644 --- a/starpilot/common/starpilot_variables.py +++ b/starpilot/common/starpilot_variables.py @@ -787,7 +787,7 @@ class StarPilotVariables: toggle.use_custom_steerActuatorDelay = advanced_lateral_tuning and not toggle.use_auto_steer_delay toggle.friction = self.get_value("SteerFriction", cast=float, condition=advanced_lateral_tuning, default=friction, min=0, max=1) toggle.use_custom_friction = bool(round(toggle.friction, 2) != round(friction, 2)) and is_torque_car and not toggle.force_auto_tune or toggle.force_auto_tune_off - toggle.steerKp = [[0], [self.get_value("SteerKP", cast=float, condition=advanced_lateral_tuning and is_torque_car and not is_angle_car, default=steerKp, min=steerKp * 0.5, max=steerKp * 1.5)]] + toggle.steerKp = [[0], [self.get_value("SteerKP", cast=float, condition=advanced_lateral_tuning and is_torque_car and not is_angle_car, default=steerKp, min=steerKp * 0.5, max=steerKp * 3.0)]] toggle.latAccelFactor = self.get_value("SteerLatAccel", cast=float, condition=advanced_lateral_tuning, default=latAccelFactor, min=latAccelFactor * 0.5, max=latAccelFactor * 1.5) toggle.use_custom_latAccelFactor = bool(round(toggle.latAccelFactor, 2) != round(latAccelFactor, 2)) and is_torque_car and not toggle.force_auto_tune or toggle.force_auto_tune_off toggle.steerRatio = self.get_value("SteerRatio", cast=float, condition=advanced_lateral_tuning, default=steerRatio, min=steerRatio * 0.5, max=steerRatio * 1.5) diff --git a/starpilot/system/the_galaxy/assets/components/tools/device_settings.js b/starpilot/system/the_galaxy/assets/components/tools/device_settings.js index 380e9380e5..3f8a61c7b3 100644 --- a/starpilot/system/the_galaxy/assets/components/tools/device_settings.js +++ b/starpilot/system/the_galaxy/assets/components/tools/device_settings.js @@ -762,7 +762,7 @@ function numericBounds(param) { if (param.key === "SteerKP") { const base = toFinite(state.values.SteerKPStock) || toFinite(state.values.SteerKP) || 0.6 - return { min: +(base * 0.5).toFixed(2), max: +(base * 1.5).toFixed(2), step: 0.01 } + return { min: +(base * 0.5).toFixed(2), max: +(base * 3.0).toFixed(2), step: 0.01 } } if (param.key === "SteerLatAccel") { const base = toFinite(state.values.SteerLatAccelStock) || toFinite(state.values.SteerLatAccel) || 2.0 diff --git a/starpilot/system/the_galaxy/assets/mobile/js/params.js b/starpilot/system/the_galaxy/assets/mobile/js/params.js index 6547245f17..1f2b339ab5 100644 --- a/starpilot/system/the_galaxy/assets/mobile/js/params.js +++ b/starpilot/system/the_galaxy/assets/mobile/js/params.js @@ -154,7 +154,7 @@ export function numericBounds(param, values = {}) { } if (param.key === "SteerKP") { const base = toFinite(values?.SteerKPStock) || toFinite(values?.SteerKP) || 0.6 - return { min: +(base * 0.5).toFixed(2), max: +(base * 1.5).toFixed(2), step: 0.01 } + return { min: +(base * 0.5).toFixed(2), max: +(base * 3.0).toFixed(2), step: 0.01 } } if (param.key === "SteerLatAccel") { const base = toFinite(values?.SteerLatAccelStock) || toFinite(values?.SteerLatAccel) || 2.0