Car interface: require fingerprint and FW versions to get params (#26932)

* require fingerprint and FW versions

* add get_non_essential_params()

* comment

* all required

* classmethod, need to allow subclasses to override _get_params

* fix that

* fix

* fix

* wrong fix 🤦
old-commit-hash: b00bc4f57e2c9a3acb9e3b10528b7e30cbde43f1
This commit is contained in:
Shane Smiskol
2023-01-12 12:25:24 -08:00
committed by GitHub
parent b67646e1ab
commit 0ceb423ccc
12 changed files with 18 additions and 17 deletions
@@ -49,7 +49,7 @@ class Plant:
from selfdrive.car.honda.values import CAR
from selfdrive.car.honda.interface import CarInterface
self.planner = LongitudinalPlanner(CarInterface.get_params(CAR.CIVIC), init_v=self.speed)
self.planner = LongitudinalPlanner(CarInterface.get_non_essential_params(CAR.CIVIC), init_v=self.speed)
@property
def current_time(self):
@@ -180,7 +180,7 @@ def fingerprint(msgs, fsm, can_sock, fingerprint):
def get_car_params(msgs, fsm, can_sock, fingerprint):
if fingerprint:
CarInterface, _, _ = interfaces[fingerprint]
CP = CarInterface.get_params(fingerprint)
CP = CarInterface.get_non_essential_params(fingerprint)
else:
can = FakeSocket(wait=False)
sendcan = FakeSocket(wait=False)