From 081bb51e586a4f48ad00d5eb05b9b0616b0c3fe7 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Tue, 24 Feb 2026 00:50:32 -0800 Subject: [PATCH] mici: add missing Scroller hide events --- selfdrive/ui/mici/layouts/main.py | 2 ++ selfdrive/ui/mici/layouts/offroad_alerts.py | 5 +++++ selfdrive/ui/mici/layouts/settings/developer.py | 4 ++++ selfdrive/ui/mici/layouts/settings/device.py | 4 ++++ selfdrive/ui/mici/layouts/settings/network/__init__.py | 1 + selfdrive/ui/mici/layouts/settings/toggles.py | 4 ++++ 6 files changed, 20 insertions(+) diff --git a/selfdrive/ui/mici/layouts/main.py b/selfdrive/ui/mici/layouts/main.py index dc01aba56..3e3948eea 100644 --- a/selfdrive/ui/mici/layouts/main.py +++ b/selfdrive/ui/mici/layouts/main.py @@ -63,9 +63,11 @@ class MiciMainLayout(Widget): device.add_interactive_timeout_callback(self._on_interactive_timeout) def show_event(self): + super().show_event() self._scroller.show_event() def hide_event(self): + super().hide_event() self._scroller.hide_event() def _scroll_to(self, layout: Widget): diff --git a/selfdrive/ui/mici/layouts/offroad_alerts.py b/selfdrive/ui/mici/layouts/offroad_alerts.py index 565d27593..bc1cd02c5 100644 --- a/selfdrive/ui/mici/layouts/offroad_alerts.py +++ b/selfdrive/ui/mici/layouts/offroad_alerts.py @@ -289,10 +289,15 @@ class MiciOffroadAlerts(Widget): def show_event(self): """Reset scroll position when shown and refresh alerts.""" + super().show_event() self._scroller.show_event() self._last_refresh = time.monotonic() self.refresh() + def hide_event(self): + super().hide_event() + self._scroller.hide_event() + def _update_state(self): """Periodically refresh alerts.""" # Refresh alerts periodically, not every frame diff --git a/selfdrive/ui/mici/layouts/settings/developer.py b/selfdrive/ui/mici/layouts/settings/developer.py index f107df720..b04d69682 100644 --- a/selfdrive/ui/mici/layouts/settings/developer.py +++ b/selfdrive/ui/mici/layouts/settings/developer.py @@ -104,6 +104,10 @@ class DeveloperLayoutMici(NavWidget): self._scroller.show_event() self._update_toggles() + def hide_event(self): + super().hide_event() + self._scroller.hide_event() + def _render(self, rect: rl.Rectangle): self._scroller.render(rect) diff --git a/selfdrive/ui/mici/layouts/settings/device.py b/selfdrive/ui/mici/layouts/settings/device.py index d919df1c1..cd7172455 100644 --- a/selfdrive/ui/mici/layouts/settings/device.py +++ b/selfdrive/ui/mici/layouts/settings/device.py @@ -345,5 +345,9 @@ class DeviceLayoutMici(NavWidget): super().show_event() self._scroller.show_event() + def hide_event(self): + super().hide_event() + self._scroller.hide_event() + def _render(self, rect: rl.Rectangle): self._scroller.render(rect) diff --git a/selfdrive/ui/mici/layouts/settings/network/__init__.py b/selfdrive/ui/mici/layouts/settings/network/__init__.py index 8f9b18b9a..bdae92456 100644 --- a/selfdrive/ui/mici/layouts/settings/network/__init__.py +++ b/selfdrive/ui/mici/layouts/settings/network/__init__.py @@ -168,6 +168,7 @@ class NetworkLayoutMici(NavWidget): def hide_event(self): super().hide_event() + self._scroller.hide_event() self._wifi_manager.set_active(False) gui_app.set_nav_stack_tick(None) diff --git a/selfdrive/ui/mici/layouts/settings/toggles.py b/selfdrive/ui/mici/layouts/settings/toggles.py index b0f718923..d6a91b40f 100644 --- a/selfdrive/ui/mici/layouts/settings/toggles.py +++ b/selfdrive/ui/mici/layouts/settings/toggles.py @@ -71,6 +71,10 @@ class TogglesLayoutMici(NavWidget): self._scroller.show_event() self._update_toggles() + def hide_event(self): + super().hide_event() + self._scroller.hide_event() + def _update_toggles(self): ui_state.update_params()