Commit Graph

353 Commits

Author SHA1 Message Date
Shane Smiskol 7ef1812968 fix static analysis
old-commit-hash: 0355ceaeacff5a3d0e435fbd5e44cb94b3dea37d
2024-02-07 19:57:33 -08:00
Shane Smiskol b8952216c0 test_fw_fingerprint: remove timeout
it's fast now
old-commit-hash: 1b0a4746eb085dad56445ffeb0f4e3b020ea3afb
2024-02-07 19:47:20 -08:00
Justin Newberry abb7672b9b add cd for jenkins replacement scripts (#31355)
fix dirs
old-commit-hash: 6a463503a7a2d0c8f2d76c5633b9c9308b3c850c
2024-02-07 15:40:36 -08:00
Nelson Chen 26f7e788b3 Lexus LC 2024 (#31199)
* Initial pass

* Add physical measurements for LEXUS_LC_2024

* Add new test route for TOYOTA.LEXUS_LC_TSS2

* Add new public-OK test route for TOYOTA.LEXUS_LC_TSS2

* update docs

* | not /

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 879e2521ac59d2440455ef362bce8f8ac643f658
2024-02-07 11:45:12 -08:00
Justin Newberry 4ad5ba1864 jenkins: remove pc / car tests (#31353)
* move to scripts

* clean first

* cant have test_*?

* move
old-commit-hash: 8f67d3cab9bb7031f3350b0c320606aa843503d5
2024-02-07 11:33:52 -08:00
Shane Smiskol 6d956f9297 Hyundai: log camera manufacture date (#31345)
* log manufac date

* oof

* should be safe

* update refs
old-commit-hash: fabec9964584ace9063fc92203bf9f6912f47310
2024-02-07 00:07:01 -08:00
Shane Smiskol b0f087bb7d Hyundai: add PT queries for all ECUs (#31334)
* We never had any bus 0 logging queries for CAN!

* should be logging

* try all, and try on can fd as well

* update refs

* oof forgot about hda2 can fd where pt is bus 1

* sheesh

* fix the timing

* fix ref
old-commit-hash: bcd29a2b8af7c7364040716926d5c18ccd89ca7c
2024-02-06 20:37:26 -08:00
Shane Smiskol 07bb2e7e89 FW query timing test: fix total reference time (#31344)
* We never had any bus 0 logging queries for CAN!

* should be logging

* try all, and try on can fd as well

* update refs

* oof forgot about hda2 can fd where pt is bus 1

* sheesh

* fix the timing

* not here

* revert

* this just simply measured the total time of all the brands with aux queries (1.25s)

* clean up
old-commit-hash: 4ec0ed311c4def6106911c24d5a19e6a9b1fbfd2
2024-02-06 20:10:06 -08:00
Justin Newberry 572744128e test_models: cleanup by using new logreader (#31267)
* cleanup

* only check error

* this segment only

* fix

* fix

* keep this

* fix internal
old-commit-hash: 66dc7030de1b39bd814cc20091d22ec38976523b
2024-02-06 16:50:30 -08:00
Shane Smiskol 6171b1b6f3 Reapply "Ford: don't fingerprint on engine (#31195)" part 2 (#31320)
* Reapply "Ford: don't fingerprint on engine (#31195) part 2"

This reverts commit 0dccc2ab5776145bc3458d75c7c8b6ad51fff57d.

* add comment

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
old-commit-hash: dd6065c33b66e04b0ba79d78f967349a5cec6a67
2024-02-05 23:57:46 -08:00
Shane Smiskol 680169a4c9 Revert "Ford: don't fingerprint on engine (#31195)"
This reverts commit d104dcd9dbf3a79dbfca57dd0385ea6f2a44ab64.

old-commit-hash: 7694712cd6823a99c3f1c03270bb7167e4c1bdf9
2024-02-05 01:35:39 -08:00
Shane Smiskol 5e4a177276 Test car interfaces: init controllers (#31282)
* not pytest?

* copy what build release does

* test controls step with CI and lat/long controllers, car controller.update, etc

* clean up

* not needed

* not here

* here

* better cmt

* fix test_fuzzy

* see what's failing

* need conftest for OPENPILOT_PREFIX to work!

* up

* clean up

* test

* fix

* params put is slow

* stash

* Revert "stash"

This reverts commit 22cc9f814c0699f7046970763663205907f2890b.

* stash

bad

* just freaking merge

* sort

* rm
old-commit-hash: 011054030064dc4cf7ff6590681389fdfb66ae19
2024-02-02 23:43:30 -08:00
Shane Smiskol fee938a524 FW_QUERY_CONFIGS: type annotate (#31265)
* annotate

* fix

* clean up

* test

* clean up

* space

* fix
old-commit-hash: c9bd4e4c0df6a03daeb2968498a32f9caf248baf
2024-02-01 21:01:31 -08:00
Shane Smiskol e2059a9293 fw_versions: type annotate test_brand_ecu_matches (#31272)
* test this

* we
old-commit-hash: 341f8420dbd309c8465e1872839baacd1c1f3438
2024-02-01 15:11:10 -08:00
Shane Smiskol 55f88260d1 Mazda: use bus 0 to fingerprint (#31261)
* for testing

* switch OBD port to logging

* revert

* cmt

* cmt

* remove OBD query

* Update selfdrive/car/mazda/values.py
old-commit-hash: f0b6f489489731b4d968880d6d9e5a58dbc14035
2024-02-01 00:28:00 -08:00
Shane Smiskol 85f1aea158 HKG CAN FD: Merge Sorento Plug-in Hybrid and Hybrid (#31241)
* merge sorento plug-in hybrid and hybrid

* format

* allow fuzzy fingerprinting

* rm todo

* Revert "rm todo"

This reverts commit f2457eb58f88f780b25625942dbd9c74202acbb8.

* Revert "allow fuzzy fingerprinting"

This reverts commit 91f143f3115e31107752a5e84d3f587e6917933f.
old-commit-hash: b4f958c13f221704012578518b00ab88a4e33faf
2024-01-31 00:41:57 -08:00
Shane Smiskol db086e9cc7 Hyundai CAN FD: merge Sportage platforms (#31235)
* merge Tucson 4th gen!

* format fingerprints

* fix torque params

* fix

* detect CANFD hybrid with ACCELERATOR_ALT

* passes

* add test

* pass test

* cmt

* Revert "pass test"

This reverts commit 5f48ab1f6e6569def1cbbc92c9c0dd4ea5eebbe2.

* combine sportage hybrid

* merge sportage

* format
old-commit-hash: 2f4cadc6bfb53a6ac25040b0f2aa181ee601d106
2024-01-31 00:19:15 -08:00
Shane Smiskol 550fc4a726 Hyundai CAN FD: merge Tucson and Tucson Hybrid (#31238)
* combine tucson and tucson hybrid can fd

* format fingerprints
old-commit-hash: e92e856f7ad5f19692b6328ab0d89027c1495f2c
2024-01-30 23:06:24 -08:00
Cameron Clough a2db032930 Ford: don't fingerprint on engine (#31195)
* Ford: do not fingerprint engine

* add notebook

* Ford: add missing Explorer FW

* revert

* revert

* Revert "revert"

This reverts commit ad32feaa689f2b497c8bcc9fedc73cae6c87f697.

* TestFwFingerprintTiming: try these

* TestFwFingerprintTiming: update total ref time

* remove notebook

* fix ref

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 1d1c9936cf5711c5414b2da2ee823f7233e7882e
2024-01-30 02:42:33 -08:00
Shane Smiskol b41683d323 GM: FPv2 logging (#31221)
* bump

* from https://github.com/commaai/openpilot/pull/27929

* get VIN on bolt!

* might as well try on other gms

* remove vin

* ugh gm is going to be slow

* fix

* should really fix this

* revert

* happy?1

* fix unit test

* bump

* functional addressing must be an OBD gateway feature, this does nothing

* fix vin response

* fix addr!

* finally fix fw_versions bugs since boardd IsOnroad refactor

* for

* only bus 0

* clean up

* Update selfdrive/car/gm/values.py

* ChatGPT re-write

* filter out did

* todo

* oof

* preview: what multiple DIDs per ECU would look like in the future

* Revert "preview: what multiple DIDs per ECU would look like in the future"

This reverts commit 88f0d8611e638de644adc5feabade848c03d59e4.

* function to get all ecus

* we can remove this!

* can also do this!

* and this one too :o

* consistency

* yay

* clean up
old-commit-hash: 06f0e5096424acd643046f4bd5a3c84a4f684e8e
2024-01-30 02:19:12 -08:00
Shane Smiskol 849504bfe7 FPv2: support FwQueryConfig with no FW versions (#31227)
* bump

* from https://github.com/commaai/openpilot/pull/27929

* get VIN on bolt!

* might as well try on other gms

* remove vin

* ugh gm is going to be slow

* fix

* should really fix this

* revert

* happy?1

* fix unit test

* bump

* functional addressing must be an OBD gateway feature, this does nothing

* fix vin response

* fix addr!

* finally fix fw_versions bugs since boardd IsOnroad refactor

* for

* only bus 0

* clean up

* Update selfdrive/car/gm/values.py

* ChatGPT re-write

* filter out did

* todo

* oof

* preview: what multiple DIDs per ECU would look like in the future

* Revert "preview: what multiple DIDs per ECU would look like in the future"

This reverts commit 88f0d8611e638de644adc5feabade848c03d59e4.

* function to get all ecus

* we can remove this!

* can also do this!

* and this one too :o

* consistency

* yay

* add tests

* revert GM stuff

* another PR

* reads better

* revert rest of gm

* use that

* interesting

* these are exactly the same (with ordering differences)

* Revert "these are exactly the same (with ordering differences)"

This reverts commit a9e918dc351d24f1b7c8a05c7ec402e057a0e09a.

* flip
old-commit-hash: 2c0f7b872702e44bb8911702d027d39b01134e6f
2024-01-30 02:08:08 -08:00
Shane Smiskol b2fcda8419 GM camera ACC: get VIN from camera (#31224)
* bump

* gm vin

* that's not right

* only check relevant buses

* instead try queries for each bus first

* clean up

* use default retry in function

* all
old-commit-hash: c3fcf75737b28efe05bf78c4ec886482749844c6
2024-01-29 23:24:21 -08:00
Shane Smiskol 2e4f6b23fe Honda: add logging request for radarless Civic 2022+ camera (#31176)
* try tester present

* radar

* rm whitelist

* refs
old-commit-hash: 52d7cfa68952ab30ac7577b4cdeb20c75e2c8745
2024-01-25 23:58:27 -08:00
Shane Smiskol 7c70aef5de vin: reduce retries (#31175)
reduce retries
old-commit-hash: c99cd3251b6a283be43fd301273baf78553c9c43
2024-01-25 22:40:39 -08:00
Shane Smiskol ff6ae8f1b9 VIN: query on bus 0 to log data (#31165)
* query on bus 0

* fix

* log vin_rx_bus

* fix!
old-commit-hash: 289868297eb2646acb8c62cec27ce77027d09ac7
2024-01-25 18:01:49 -08:00
Shane Smiskol f01651d440 Nissan: log FW responses on bus 0 (#31138)
* nissan: log FW responses on bus 0

* update refs
old-commit-hash: b9ad854451ce642a05c487d96a1a9bc2181bb3ba
2024-01-23 23:12:48 -08:00
Justin Newberry f447062b66 CommaCarSegments: public database of segments for each platform (#31114)
* comma car segments

* comma car segments for test_models

* oneliner

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* better name

* not used here

* sort

* remove print

* better comment

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: caa9153974c21fd827d0e991f1789cf3e81b5c3b
2024-01-22 17:33:03 -08:00
Justin Newberry 4080bec11d pytest: add marker for sharing the download cache (#31082)
* fix cache

* with a marker
old-commit-hash: 3846130d8e15ea71e9576ae62b69918757edc7b8
2024-01-22 16:30:59 -08:00
Justin Newberry b29eea47ce sanitizer: sanitize vin number (#31090)
old-commit-hash: 2c86c023fe2d3072910ed33ff97cd6d3ddf2915d
2024-01-21 12:22:32 -05:00
Shane Smiskol 0c68412407 Toyota: combine more hybrid platforms (#31057)
* Combine

* migrate test models segs

* fix highlander engine

* no change
old-commit-hash: 29536324c1dceceb064c6b3ef6a3e0ef3dd0d578
2024-01-18 18:51:24 -08:00
Shane Smiskol 8200f32b5f FW query timing test: mock inconsistent, timing-based functions (#31048)
* Revert "Revert "FW query timing test: mock get_data function for timeout" (#30696)"

This reverts commit 799cdee1e97bd45946ffb31a03e1fcc1c5da5ac6.

* no thread

* clean up a bit

* no thread!

* combine functions

* re-enable total time check

* back to 5

* minimal diff

* minimal diff
old-commit-hash: f96aa247cc0834296a3f85ea58617ef700de596c
2024-01-17 19:05:31 -08:00
Justin Newberry eeaf219cce test_models: sanitize segment before running test (#31026)
to ensure sanetized routes will work
old-commit-hash: 5c24527683cd4a9d338fe64dd9e98179e903316e
2024-01-16 15:08:44 -08:00
Justin Newberry 4b7edec2b0 LogReader: move opci to tools/lib (#31021)
move opci
old-commit-hash: 7d400112df6692ef026245b03951345cc36dd83e
2024-01-16 10:58:51 -08:00
Shane Smiskol fc23ab6c8d Fix string indentation (#30943)
* fix bad spacing

* more

* these aren't important
old-commit-hash: d689a4e6537b6b48e0ad9948ac919065317258c1
2024-01-08 15:36:43 -08:00
Justin Newberry 1fe1523fc2 add read_seglist helper (#30908)
add helper
old-commit-hash: 1148c65d232fdfe7aa46b80c078721d78876da4a
2024-01-04 17:52:07 -08:00
Shane Smiskol dac5a594aa test_models: fallback to public route when route isn't uploaded to CI bucket (#30893)
* not sure why this is a test

* Revert "not sure why this is a test"

This reverts commit c13e16311eb882df65d216bbd59acb5702e985e6.

* no ruff for this pattern :(

* this is always caught

* should fail

* simpler

* Revert "should fail"

This reverts commit 21bd15275c46cd42fd19b058245334bae83cce77.

* fix

* cleanup this

* better comment

* better

* this can be more localized

* better names

* better names

* should fail

* Revert "should fail"

This reverts commit c58495e8b3417ce351df8048752ec60177827cb3.

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 7f398e1cf9b0fd83bb1238b9b347a21d8868ee0f
2024-01-03 11:54:22 -08:00
Shane Smiskol 52150bbb02 Revert "test_models: fallback to public route when route isn't uploaded to CI bucket (#30794)" (#30896)
* fails if no skip function

* Revert "fails if no skip function"

This reverts commit ff3d697d38dce56057c83f06033a689f2301a29d.

* Revert "test_models: fallback to public route when route isn't uploaded to CI bucket (#30794)"

This reverts commit f60e70d4729efe7db36888a0a750a0e4706cc943.
old-commit-hash: 8c4930d2d300a439aaf7dd9ca4324271cc0c7b52
2024-01-02 17:22:06 -08:00
Justin Newberry bf8e8f8338 test_models: fallback to public route when route isn't uploaded to CI bucket (#30794)
* wip

* add public comment

* fix that

* wip

* retrigger
old-commit-hash: 05dc0b51e6597fb83aed14f5a390fa4254751c98
2023-12-20 11:29:19 -08:00
Shane Smiskol f65ccca8e0 test_models: fuzz test panda and CarState (#30443)
* pre-hypothesis

* some hypothesis junk

* this kinda works but is really slow due to counter check

* choose addrs from fingerprint

* stash

* honda nidec brake pressed mismatches fixed

* bump panda

* stash

* tesla: use DI_torque2 (panda msg)

* run

* run

* ah this honda mismatch too

* no more multi can msgs

* clean up, remove old file

* add todo

* prob can remove urandom

* stash, huge examples

* fix pq standstill mismatch

* yuge

* yup there's a leak somewhere

* try to find leak

* skip dashcam (pq and tesla)

* PR comments

* bump

* draft stash

* fix alt brake hondas

* bump

* bump

* bump

* some clean up

* minor clean up

* more clean up

* stash

* fix honda bug

* more

* 100 examples

* revert tesla

* no memory leak any more?

* bring back tests with skips

* parameterize max_examples

* skip interceptor

* is jenkins on my branch?

* ooh that's fast

* 50 is not bad for GH CI

* 300 might be better with rest of test_models

* no more detection

* bump

* need CS_prev to catch bugs where openpilot changes and panda doesn't (eg. not setting interceptor safety mode)

* need to simplify all this

* need a warm up first, since some signals are 1 by default (toyota's gas_released!=1)

* changes

* set honda safety param

* set toyota safety param

* bump panda

* clean up honda

* rm interceptor

* thought interleaving addrs might help, but we can fine tune later

* Revert "thought interleaving addrs might help, but we can fine tune later"

This reverts commit 153301384b48c9f33f9e2af3c224241eaeec41c1.

* get size from dict

* what

* add nocapture marker

* clean up

* try to raise logging level

* need to run last as pytest_runtest_call, since it starts capturing

* get capman conditionally

* mark

* type fingerprint

* should use gen_empty_fingerprint

* no longer needed

* draft

* no longer need gc

* clean that up

* test everything!

* more clean up

* more

* no point

* fix that

* fix errors

* bump

* nice even 300 examples for 300 segs

* final bump :fingers_crossed:

* better import order

* remove debugging prints

* warm up kinda works

* Revert "warm up kinda works"

This reverts commit 7fc77b07d592edb13eadca77deb49540954a7d69.

* random seed

* revert

* strat

strat

* add expl comment

* cmt

* check controls allowed

* Revert "check controls allowed"

This reverts commit e82a0e5396810dd4670e6847aa555194a709e10f.

* not unittests

* run tests!

* run tests 2!

* run tests 3!

* seed unused

* revert

* add shrink phase, and remove health check suppression

* hello

* oncemore

* Update selfdrive/car/tests/test_models.py
old-commit-hash: 5052b55c440f3a778f9db9c854fa385077dd7ab9
2023-12-19 03:18:54 -06:00
Justin Newberry ff12759e80 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
old-commit-hash: 28eed156e0a62ab993de6d534bb102a6ede222f7
2023-12-18 14:04:27 -08:00
Shane Smiskol 3c7fcbb839 test_models: use gen_empty_fingerprint (#30752)
use gen_empty_fingerprint
old-commit-hash: d9a8846d58af2a3a9a598fcf9fb1acf89e4b54f6
2023-12-15 17:16:19 -08:00
Shane Smiskol 19572df478 Revert "test_models: check consitency between panda and openpilot for velocity (#30750)" (#30753)
This reverts commit 19c040150dcec8bfa4b70aa870ae5564739c278a.
old-commit-hash: 123ef46af3694afc30b4ec28ce8f995d9fa92cd1
2023-12-15 17:16:01 -08:00
Justin Newberry ffae1ce377 test_models: check consitency between panda and openpilot for velocity (#30750)
* sanity check on velocity

* import from there

* use raw

* just check last

* ignore body

* reduce tolerance and bump panda

* its not average anymore

* slightly higher tolerance
old-commit-hash: 1ca1cf39223557955cee58e18a418914faf472c3
2023-12-15 14:50:37 -08:00
Justin Newberry a625ca55e7 Subaru: enable alpha longitudinal for gen1 cars (#30714)
* enable alpha long

* update docs

* added footnote about eyesight

* only for these cars

* add alpha

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5f24078a480c9436ce99bf19358b5737aebf065f
2023-12-13 20:17:33 -08:00
Isaac d5b4ba8239 Ford: Add Mach-E (#30691)
* Update interface.py

* Update values.py

* Update routes.py

* Update override.yaml

* Update selfdrive/car/ford/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update interface.py

* order

* only have dongles for these

42f08a29af3699f4
83a4e056c7072678

from https://github.com/commaai/openpilot/pull/30444

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 26a67641d2e4a4b908239996c7a9b580c3813d4b
2023-12-13 09:05:41 -08:00
Jason Wen 82747c42a1 Hyundai: Car Port for Staria 2023 (#30672)
* Hyundai: Car Port for Staria 2023

* camera scc!

* add test route

* Update RELEASES.md

* Apply suggestions from code review

* bump down max torque

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: d6465e39bd74591d82d9a8c673052f656ed62516
2023-12-13 08:23:10 -08:00
Isaac 390e75b3bd Ford: Add F-150 Lightning (#30692)
* Update interface.py

* Update values.py

* Update routes.py

* Update override.yaml

* Update values.py

* Update interface.py

* Update selfdrive/car/ford/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2192cc170c3231186704b0929e1ee81d318e940e
2023-12-12 20:07:59 -08:00
Shane Smiskol 4596da1508 Revert "FW query timing test: mock get_data function for timeout" (#30696)
Revert "FW query timing test: mock get_data function for timeout (#29712)"

This reverts commit 3014e27e57cf3a281eac656391615299ba981958.
old-commit-hash: b1ecfd55ce73062f297a5ea7d99d0c55d57c58ab
2023-12-11 22:12:21 -08:00
Jason Wen 35c0b199a5 HKG: Car Port for Kia Niro Plug-in Hybrid 2022 (#30576)
* HKG: Car Port for Kia Niro Plug-in Hybrid 2022

* Update CARS.md and add test route

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9807bd99dbc526ba92bb68c503d5108b9f892dd1
2023-12-11 20:32:36 -08:00
Justin Newberry 05a6da6e96 FW query timing test: mock get_data function for timeout (#29712)
* use a mock function to simulate timeout

* Cleanup

* Cleanup

* clean refs

* tolerance can also go down

* fix

* better name

revert refs

* use unittest

* revert

* Revert "use unittest"

This reverts commit 7a1d6a6fc72fa129a66590e0e5998c2438ecbe55.

* order

* local

* use a context

* revert

* stress test it

* let's try

* it's consistent

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 4028cb6121ffd1f92463cfc109593b17abe3aa8c
2023-12-11 19:24:01 -08:00