Commit Graph

41 Commits

Author SHA1 Message Date
Adeeb Shihadeh 0325a33752 add pyside2 package (#25602)
old-commit-hash: c6b749fb96
2022-08-30 15:10:52 -07:00
Adeeb Shihadeh 35ff65121e pre-commit: add codespell (#25571)
old-commit-hash: 6590fb2b93
2022-08-30 11:20:55 -07:00
Adeeb Shihadeh a4effaa34a body: add fw repo as submodule (#25420)
* body: add fw repo as submodule

* bump body

* file whitelist

* revert that for now
old-commit-hash: 7e6f4e74bf
2022-08-12 16:46:33 -07:00
Willem Melching b1901c648d run pre-commit in release CI (#25158)
* run pre-commit in release

* add pylintrc and init files

* build first

* add mypy ini

* limit amount of debug scripts shipped in release

* add python version?

* add more missing __init__.py

* excluded rednose for cppcheck

* remove files before dirty check
old-commit-hash: a006cd168e
2022-07-13 17:55:05 +02:00
HaraldSchafer 0282b746f4 Refactor torque stuff (#24921)
* Refactor torque stuff

* Add to release

* Add substitute and override

* Maxlataccel is required

* Add to asserts

* add ideal car

* Need china too

* yamls already linted

* Fixed some bugs

* Fixup

* Unreliable data

* Add cehck

* Better comment

* ref commit update
old-commit-hash: 2deaf69789
2022-06-22 15:58:06 -07:00
Dylan Herman 2dfba97175 add mypy check for return-any (#24379)
* add mypy check for return-any

* remove unused import

* typing

* remove unnecessary variable typing

* cleanup

* cleanup

* bump submodules

* small fixes

* only a problem on mac

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d2eef1955c
2022-05-12 14:59:00 +02:00
Dylan Herman 11b9cb9fb5 enable numpy mypy typing (#24387)
* enable numpy mypy typing

* remove --warn-return-any

* merge conflict and syntax

* merge conflict

* merge conflict

* add type to img var
old-commit-hash: 603942ffe0
2022-05-02 16:48:04 -07:00
Adeeb Shihadeh badb143cc7 lines for mypy report
old-commit-hash: 39cf862435
2022-05-01 18:52:32 -07:00
grekiki 77d6d9a083 mypy: enable --warn-unused-ignores (#24287)
* this is the easy part to check

* Not sure what this fixes, https://github.com/commaai/openpilot/pull/24282/commits/8aaf00c6a41ac4c9c5e56f8a2dfed8591f153b67

* bump laika

* works here

* cleanup

* add types-certifi

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 049b163ea0
2022-04-27 14:26:15 -07:00
Dylan Herman a8910d9d43 Add --warn-redundant-casts to mypy checks (#24304)
* add mypy checks for redundant-casts and unused-ignores

* revert unnecessary changes

* ignore

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: ee0021b86c
2022-04-27 12:07:53 -07:00
grekiki cc943ac9a5 mypy: enable --warn-unreachable (#24282)
* Optional solves mypy assuming None is always None

* oops

* spaces

* Update registration.py

* fix local error

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: b8b15d5cf1
2022-04-21 18:27:45 +02:00
Adeeb Shihadeh 597535c014 linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
old-commit-hash: 2c94f15584
2022-01-13 14:19:38 -08:00
Adeeb Shihadeh 88f0be8372 add pre-commit hook for large files (#23505)
old-commit-hash: ee52a61c7d
2022-01-12 22:52:58 -08:00
Adeeb Shihadeh 63d9bed046 pre-commit: fix exclude patterns (#23375)
old-commit-hash: a1a9a0f342
2022-01-03 15:24:34 -08:00
Adeeb Shihadeh efa7998d5f update pre-commit hook versions (#22526)
* update pre-commit hook versions

* fix mypy
old-commit-hash: a255449539
2021-10-14 20:14:00 -07:00
Adeeb Shihadeh 782d7023d2 phonelibs -> third_party (#22477)
* git mv to third_party

* find and replace

* fix release tests

* update pre-commit

* update tici bins

* update eon bins

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 5b641379ae
2021-10-07 16:32:44 -07:00
Adeeb Shihadeh 760cdcd896 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
old-commit-hash: 9e03aa0b92
2021-08-22 00:27:48 -07:00
Adeeb Shihadeh 03405b81fd acados support (#21319)
* acados support

* add pyextra to python path

* x86 libs
old-commit-hash: 6e4c2aa4d2
2021-06-17 16:40:00 -07:00
Adeeb Shihadeh d366d2abeb pin pre-commit hook versions
old-commit-hash: 9fbac812e4
2021-01-30 16:55:07 -08:00
Adeeb Shihadeh bc9891b651 external cleanup (#19647)
* remove external

* put back ffmpeg for now
old-commit-hash: 1669e4a5d1
2021-01-04 14:17:14 -08:00
Willem Melching 9ac982ea34 fix cppcheck on ubuntu 19.10
old-commit-hash: 5f59fd4f40
2020-07-23 15:24:17 +02:00
Adeeb Shihadeh d8adab2ce5 enable flake8 F error codes
old-commit-hash: d204d87b95
2020-06-22 14:00:32 -07:00
Adeeb Shihadeh 0891b1331d Add cppcheck as a pre-commit hook (#1646)
* add cppcheck as a pre-commit hook

* fix Dockerfile

* update precommit config

* exclude panda and opendbc
old-commit-hash: 3c461ca5cc
2020-06-19 20:39:34 -07:00
Adeeb Shihadeh 35fe5fa31b remove trailing whitespace pre-commi hook for now
old-commit-hash: c454bff2f8
2020-06-05 12:52:55 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a
2020-06-03 16:13:34 -07:00
Willem Melching dbdbef72d6 vehicle model types (#1631)
old-commit-hash: 2400417084
2020-06-03 13:47:47 -07:00
Adeeb d035394ce7 Add pre-commit hooks (#1629)
old-commit-hash: ab83e48ec4
2020-06-03 12:54:49 -07:00
George Hotz 710710364d fetch image from route script
old-commit-hash: d1d2984f36
2020-06-03 11:32:51 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72f
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982a
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 8b3418b0f9 enable flake8 E251: unexpected spaces around keyword / parameter equals
old-commit-hash: ebed2d1dcc
2020-05-31 17:34:47 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c7
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e
2020-05-31 12:49:11 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8
2020-05-31 00:48:47 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a40
2020-05-30 20:14:58 -07:00
Willem Melching 8a32bd3c41 use github url instead of gitlab mirror
old-commit-hash: 266dfe5a9b
2020-05-28 17:45:32 -07:00
Willem Melching 2ac27def5a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
old-commit-hash: ba2ac1207a
2020-05-28 15:40:48 -07:00
Willem Melching 2b60ee9531 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
old-commit-hash: 3d08dcc3b2
2020-05-28 15:05:04 -07:00
Willem Melching 12a306021d flake8 in pre-commit(#1583)
old-commit-hash: 29aaa44740
2020-05-27 20:33:05 -07:00
Willem Melching c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd06434243
2020-05-27 20:00:14 -07:00