Commit Graph

252 Commits

Author SHA1 Message Date
Dean Lee 4c17c06799 Handle EINTR for all syscalls that can return it (#21948)
old-commit-hash: f02c8d0e2c
2021-08-31 16:22:56 -07:00
Dean Lee 94d1866ccd camera_qcom2: new functions device_acquire & device_config (#22077)
* new function device_acquire & device_config

* add space

* apply reviews

* use the specified struct for each command

* fix typo

* apply review

* remove static

* revert device_control
old-commit-hash: 0d3eec385c
2021-08-31 07:21:40 -07:00
Dean Lee 5f64289206 camera_qcom2: use macros for link control operations (#22088)
old-commit-hash: ee5ef4dab2
2021-08-30 22:10:18 -07:00
Dean Lee ecf3ee7603 loggerd: create encoder threads from cameras_logged (#21875)
old-commit-hash: d9baaf7eb9
2021-08-30 19:33:00 -07:00
Dean Lee 7b9555df75 camera_qcom2: refactor open_v4l_by_name_and_index (#22067)
* refactor

* small cleanup

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: cf4ad99554
2021-08-30 17:12:22 -07:00
Dean Lee 073898d8fd retry ioctls while errno == EINTR (#22054)
old-commit-hash: 31230e5b60
2021-08-30 16:07:34 -07:00
Dean Lee 6d054a0012 camera_qcom2: remove req_mgr_session_info from CameraState (#22059)
* remove req_mgr_session_info from CameraState

* handle should be int32_t
old-commit-hash: 37dda3d6bf
2021-08-30 15:32:31 -07:00
Dean Lee 92627760de camera_qcom2: fix memory leaks in camera_open (#22061)
old-commit-hash: 7a80bf7fcc
2021-08-30 14:59:04 -07:00
Dean Lee 75f686f728 camera_qcom2.cc : fix wrong LOGD order (#22072)
old-commit-hash: 862f93f7f1
2021-08-30 09:21:35 -07:00
Dean Lee 88878cc2cd qcom2/enqueue_buffer: use macro CAM_MEM_FLAG_HW_READ_WRITE (#22060)
old-commit-hash: 0f4227f42b
2021-08-28 17:43:50 -07:00
Dean Lee 2658ef5243 camera_qcom2.cc: use V4L_EVENT_CAM_REQ_MGR_EVENT (#22057)
old-commit-hash: ffb1dd019e
2021-08-28 14:49:56 -07:00
Dean Lee eb17b4403e camera_qcom2: remove unused variables from MultiCameraState (#22058)
old-commit-hash: df6432c8cd
2021-08-28 14:44:30 -07:00
Adeeb Shihadeh 277bd43b15 Revert "tici: give loggerd rt priority (#21503)"
This reverts commit 0a50cf851e79342cf3db01033bc91516c504cbea.

old-commit-hash: 54a4eeb0fc
2021-08-22 16:57:53 -07:00
Adeeb Shihadeh 5c1d1ebe76 tici: give loggerd rt priority (#21503)
* give loggerd rt priority

* assert

* little more

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7e2752c878
2021-08-20 21:27:31 -07:00
Dean Lee 5d77755f18 camerad: remove unused macros and global (#21970)
old-commit-hash: e646febaae
2021-08-19 14:49:16 -07:00
Dean Lee f32b1655e4 cameras_qcom2.cc: add a missing newline (#21956)
old-commit-hash: 74ecbbed63
2021-08-18 10:37:05 +02:00
Willem Melching ae4f3c98d5 refactor loggerd: trigger rotate in encoder thread (#21860)
* trigger rotate in eoncode thread

* rotate in time

* lgtm

* dcam trigger rotate on C3

* check trigger rotate field

* Use >=

* add rotator thread

* set cnt to 0

* test encodeIdx is increasing across segments

* test both segmentId and encodeId

* fix encodeIdx

* no thread needed

* add log for failed to encode

* stricter C3 test, dont check start encodeId on C2 dcam

* only update last_camera_seen_tms when considered for rotate

Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: a39873872d
2021-08-06 11:10:33 +02:00
arfy slowy 63b3d6024b fix: spelling typos (#21861)
* fix: typo spelling grammar

* revert

* Update selfdrive/locationd/calibrationd.py

* more revert

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: d74def61f8
2021-08-05 12:05:49 -07:00
Willem Melching 9038e1b86f C3 AE improvements (#21698)
* AE improvements

* boardd: also use gain to compute IR brightness

* use default rect for DM autoexposure

* more smooth

* whitespace

* camerad cpu usage

* hcg on is slightly better for noise

* hysteris around high conversion gain

* improve i2c timing

* use AB contexts

* HCG default off

* run at 10 hz

* stay in context A for now

* remove ae thread

* wait till next frame is started before sending i2c

* back at 20fps

* add comment and filter across 3 evs

* remove context switch code

* tuning

* recomened without HCG is 0.8x
old-commit-hash: 25de93d133
2021-08-05 16:34:36 +02:00
Dean Lee 94d534afea hw.h: move Hardware-related paths to namespace Path (#21826)
* refactor getenv and path

* apply review
old-commit-hash: fefc70b4ca
2021-08-04 13:29:03 +02:00
Adeeb Shihadeh 4d0543d92d 100 yuv buffers for all
old-commit-hash: 4c0caf7f7e
2021-07-26 14:02:49 -07:00
Willem Melching d479b9a5de Revert AE changes (#21682)
* Revert AE changes

* keep YUV buffer count
old-commit-hash: b6b0393e2d
2021-07-22 11:22:19 -07:00
Willem Melching 7a9659a9f7 AE: revert changes to min grey target (#21648)
old-commit-hash: b35f6871cb
2021-07-19 10:37:43 +02:00
Willem Melching afd96fb083 only 100 yuv buffers on C2 (#21622)
old-commit-hash: 0d9e7ad241
2021-07-16 11:59:30 +02:00
Willem Melching 6dc20d7c75 tici: AE sane default values (#21610)
* tici: AE sane default values

* set exposure time

* remove comment

* set dc gain variable

* whitespace
old-commit-hash: 3ad40963cc
2021-07-15 16:11:27 +02:00
Willem Melching 7198224cf2 tici: improve AE (#21493)
* simplify histogram calculation

* add debug prints

* faster AE

* revert that

* lower log level

* use minimum recomended gains from datasheet

* use define

* fix min gain

* dynamic grey target

* fix build

* add low pass

* more stable rounding

* increase max gain

* always enable HCG

* correctly set min ev

* fix analog gain

* remove unused variable

* fix build

* move recomended gain into cost function

* tweak cost function a bit

* small LPF on desired ev

* fix typo

* lower ts

* clean up defines

* that was used in common

* add cast

* less cost is fine

* fix tests

* whitespace

* filtering is broken

* put back

* clip gain changes instead

* cost function tweaking

* Only go below recomended gain when absolutely necessary

* small penalty on changing gains
old-commit-hash: 63c9b56063
2021-07-13 23:33:50 +02:00
Adeeb Shihadeh 92e236e7ad increase yuv buffer count to hold 5s (#21528)
* increase yuv buffer count to hold 5s

* bump cereal
old-commit-hash: 4738fe0e45
2021-07-10 14:46:20 -07:00
Willem Melching e0378d41cb Refactor camerad exposure logging (#21506)
* simplify gain logging

* clean up metadata

* log grey fractions

* those are not used

* set grey fracs in message

* fix qcom
old-commit-hash: 47be6c751e
2021-07-08 15:22:00 +02:00
Willem Melching 3c5a97251f tici: Switch to 1D dead pixel correction (#21467)
old-commit-hash: 8d075048b3
2021-07-02 14:01:43 +02:00
Dean Lee def897a2c7 fix webcam crash when failed to read video frame (#21272)
old-commit-hash: 73d741b7be
2021-06-15 12:25:05 +02:00
Dean Lee 147b355dde add space after function name and if statement (#21225)
old-commit-hash: e4e669bb0f
2021-06-11 10:17:52 +02:00
Maxime Desroches 426df0435b Convert C++ while loops from int to bool (#21214)
old-commit-hash: 03df1b08bb
2021-06-09 21:09:21 -07:00
Adeeb Shihadeh edd2f1c1a6 fix qcom and qcom2 builds
old-commit-hash: 9e94fb17cf
2021-06-08 16:44:05 -07:00
Dean Lee f70a79b838 Use C++ header files instead of C header files. (#21192)
* use cstring instead of string.h

* use cstdio instead of stdio.h

* remove inttypes.h

* use cstdlib instead of stdlib.h

* use cstdint instead of stdint.h

* #include <cstddef>

* cstdlib

* use cmath

* remove stddef.h

* use cassert

* use csignal

* use ctime

* use cerror

* rebase master
old-commit-hash: c53cb5d570
2021-06-08 13:46:22 -07:00
Dean Lee 3a698faadc Use full include path (#21194)
old-commit-hash: b06b3ecb60
2021-06-08 12:09:30 -07:00
Dean Lee 497472932a Cleanup util.h (#20849)
* cleanup util.h

* fix build error:omx_encoder.cc:408: undefined reference to do_exit

* fix build error

* rebase master

* move helper functions back to util

* ExitHandleHelper->ExitHandlerHelper

* std::clamp

* struct ExitHandlerHelper to class

* rebase master

* cleanup

* restore ExitHandler

* prefer cassert
old-commit-hash: 65e0b1e699
2021-06-01 16:53:12 +02:00
Adeeb Shihadeh c7c49e8e35 fix up model tests + tools (#21071)
* unlogger: send yuv stream

* fix up model test tools

* fix unlogger

* rename model replay

* bump cereal

* test in actions

* no ci for now
old-commit-hash: cf6d133638
2021-05-28 23:08:08 -07:00
Adeeb Shihadeh 39d83ba32c remove oneplus camera params (#21047)
* remove oneplus camera params

* align
old-commit-hash: 8fdbbdef73
2021-05-26 17:46:43 -07:00
ShaneSmiskol 75b1c7c4ba Improve focus when using snapshot (#21031)
old-commit-hash: a457144357
2021-05-26 17:17:04 -07:00
George Hotz 6922150ede Move MCLK from 24 -> 19.2 mhz + Add accuracy in sidebar (#20960)
* wip

* one day i'll flip that right

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f43671c987
2021-05-18 22:37:33 -07:00
Dean Lee 5609f32cee Cleanup includes (#20925)
* remove #include <pthread.h>

* remove #include<stdbool.h> for cc files

* remove #include<iostream>
old-commit-hash: 0495426535
2021-05-17 10:31:31 +02:00
Dean Lee e333e4f189 Cleanup selfdrive/ includes (#20822)
* cleanup include path

* continue

* format includes

* fix testraw.cc

* remove include path from SConstruct

* regroup

* rebase master

* almost done

* apply review

* rename FileReader.xx to filereader.xx

* rename Unlogger.x->unlogger.x

* rename FrameReader.xx -> framereader.xx

* apply reviews

* ui.h

* continue

* fix framebuffer.cc build error:mv util.h up

* full path to msm_media_info

* fix qcom2 camerad

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7222d0f20d
2021-05-08 22:15:17 -07:00
Willem Melching 78bf4f5867 Replace ifdef with hw abstraction layer (#20843)
* Replace ifdefs with hardware abstraction layer (#20801)

* add type to class hadwareXXX

* replace ifdefs with hardware layer

* continue

* continue

* new function get_driver_view_transform

* full path to hw.h

* fix build error setup.cc

* apply review

* fix typo

* fix deprecated error:replace deprecated fromPath with new

* fix build error

* Fixes after ifdef clenaup (#20842)

* inheritance doesnt work with static

* fix debayer

* small cleanup

* Update selfdrive/camerad/cameras/camera_common.cc

* Update selfdrive/ui/qt/offroad/settings.cc

* Update selfdrive/common/modeldata.h

* flip conditions

* fix comment

Co-authored-by: Dean Lee <deanlee3@gmail.com>
old-commit-hash: ab319d4f54
2021-05-06 14:39:05 +02:00
Willem Melching 39c18d4c5a Revert "Replace ifdefs with hardware abstraction layer (#20801)"
This reverts commit 9f2ad462f39f4c880f283b71bffbc9248a2b577d.

old-commit-hash: 3a95d3ccaa
2021-05-06 12:29:30 +02:00
Dean Lee e0282ced49 Replace ifdefs with hardware abstraction layer (#20801)
* add type to class hadwareXXX

* replace ifdefs with hardware layer

* continue

* continue

* new function get_driver_view_transform

* full path to hw.h

* fix build error setup.cc

* apply review

* fix typo

* fix deprecated error:replace deprecated fromPath with new

* fix build error
old-commit-hash: 757d2923d2
2021-05-06 11:41:46 +02:00
Adeeb Shihadeh 532d19427c bump cereal
old-commit-hash: 8a280fbb8e
2021-05-03 20:47:11 -07:00
iejMac 4abd8988e4 cereal: SubMaster refactor, update is now void (#20730)
* cereal: SubMaster refactor, update is now void

* bump cereal

* mistake

* update void

* checks

* semicolon

* Update selfdrive/camerad/cameras/camera_frame_stream.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* check sensorEvent

* update cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 4866a39244
2021-04-22 22:13:32 -07:00
Dean Lee 2db11515bd camerad: SubMaster never updated (#20651)
* fix sm has not been updated

* update submaster in processing driver cam thread

* move Subbmaster to driver camera thread

* cleanup

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f0a1a6e4d6
2021-04-13 15:26:24 -07:00
Dean Lee 3339cc01a6 camerad: refactor RGBToYUVState into a class (#20310)
* struct RGBToYUVState to class Rgb2Yuv

* clFinish

* blank line

* rebase master

* use event
old-commit-hash: 5a3c22d804
2021-04-12 22:42:53 -07:00
Dean Lee 7d5a53ccbe Use std::size for element counts (#20654)
old-commit-hash: cf80675369
2021-04-12 12:22:22 +02:00